Joe Jin
731f3ab66a
xen/fb: fix xenfb suspend/resume race. ...
When migrating guests over a long period we hit this:
<1>BUG: unable to handle kernel paging request at 0000000b819fdb98
<1>IP: [<ffffffff812a588f>] notify_remote_via_irq+0x13/0x34
<4>PGD 94b10067 PUD 0
<0>Oops: 0000 [#1 ] SMP
.. snip..
Call Trace:
[<ffffffff812712c9>] xenfb_send_event+0x5c/0x5e
[<ffffffff8100ea5f>] ? xen_restore_fl_direct_end+0x0/0x1
[<ffffffff81438d80>] ? _spin_unlock_irqrestore+0x16/0x18
[<ffffffff812714ee>] xenfb_refresh+0x1b1/0x1d7
[<ffffffff81270568>] ? sys_imageblit+0x1ac/0x458
[<ffffffff81271786>] xenfb_imageblit+0x2f/0x34
[<ffffffff8126a3e5>] soft_cursor+0x1b5/0x1c8
[<ffffffff8126a137>] bit_cursor+0x4b6/0x4d7
[<ffffffff8100ea5f>] ? xen_restore_fl_direct_end+0x0/0x1
[<ffffffff81438d80>] ? _spin_unlock_irqrestore+0x16/0x18
[<ffffffff81269c81>] ? bit_cursor+0x0/0x4d7
[<ffffffff812656b7>] fb_flashcursor+0xff/0x111
[<ffffffff812655b8>] ? fb_flashcursor+0x0/0x111
[<ffffffff81071812>] worker_thread+0x14d/0x1ed
[<ffffffff81075a8c>] ? autoremove_wake_function+0x0/0x3d
[<ffffffff81438d80>] ? _spin_unlock_irqrestore+0x16/0x18
[<ffffffff810716c5>] ? worker_thread+0x0/0x1ed
[<ffffffff810756e3>] kthread+0x6e/0x76
[<ffffffff81012dea>] child_rip+0xa/0x20
[<ffffffff81011fd1>] ? int_ret_from_sys_call+0x7/0x1b
[<ffffffff8101275d>] ? retint_restore_args+0x5/0x6
[<ffffffff81012de0>] ? child_rip+0x0/0x20
Code: 6b ff 0c 8b 87 a4 db 9f 81 66 85 c0 74 08 0f b7 f8 e8 3b ff ff ff c9
c3 55 48 89 e5 48 83 ec 10 0f 1f 44 00 00 89 ff 48 6b ff 0c <8b> 87 a4 db 9f
81 66 85 c0 74 14 48 8d 75 f0 0f b7 c0 bf 04 00
RIP [<ffffffff812a588f>] notify_remote_via_irq+0x13/0x34
RSP <ffff8800e7bf7bd0>
CR2: 0000000b819fdb98
---[ end trace 098b4b74827595d0 ]---
The root cause of the panic is the race between the resume and reconnect to the backend.
Clearing the 'update_wanted' flag of xenfb before disconnecting from the
backend fixes this issue.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tested-by: Gurudas Pai <gurudas.pai@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
2011-01-10 10:46:30 -05:00
2010-11-13 09:52:16 -08:00
2010-11-19 13:16:26 -05:00
2010-11-08 12:17:05 -08:00
2010-11-11 01:50:53 +01:00
2010-12-02 08:05:22 -08:00
2010-11-09 01:08:53 -02:00
2010-10-27 14:33:39 +09:00
2010-11-30 09:18:01 +11:00
2010-10-31 10:40:39 -04:00
2010-10-24 14:20:01 -07:00
2010-11-13 09:55:56 -08:00
2010-11-25 16:29:41 +09:00
2010-11-22 15:35:32 +01:00
2010-11-28 12:24:20 -08:00
2010-10-27 18:03:05 -07:00
2010-12-02 14:51:15 -08:00
2010-12-01 12:13:37 +10:00
2010-12-02 17:40:04 -08:00
2010-11-22 12:23:39 -08:00
2010-11-22 11:27:35 -02:00
2010-10-26 10:17:30 -07:00
2010-10-26 17:28:07 -07:00
2010-12-02 12:10:56 -08:00
2010-12-04 11:19:59 -05:00
2010-11-24 11:19:05 -08:00
2010-12-02 14:51:15 -08:00
2010-12-02 14:51:15 -08:00
2010-11-24 16:40:33 +11:00
2010-12-05 16:41:13 -08:00
2010-11-16 13:33:23 -08:00
2010-10-29 00:30:43 +02:00
2010-11-25 06:50:47 +09:00
2010-11-22 15:12:04 -05:00
2010-12-03 15:49:21 +02:00
2010-12-02 12:58:16 -08:00
2010-10-30 11:43:26 -07:00
2010-12-04 11:18:25 -05:00
2010-10-24 13:41:39 -07:00
2010-11-25 07:42:03 +09:00
2010-12-04 12:47:48 +00:00
2010-10-27 18:03:18 -07:00
2010-11-17 08:59:32 -08:00
2010-10-29 00:30:44 +02:00
2010-11-12 07:55:30 -08:00
2010-11-30 15:13:25 +00:00
2010-11-10 18:15:44 +09:00
2010-11-25 09:52:59 +01:00
2010-10-25 08:19:14 -07:00
2010-11-23 22:26:23 +00:00
2010-12-02 12:58:16 -08:00
2010-11-19 16:43:23 +09:00
2010-11-30 17:23:24 +01:00
2010-11-22 15:19:31 -05:00
2010-12-02 12:59:11 -08:00
2010-10-22 10:52:56 -07:00
2010-12-02 12:58:16 -08:00
2010-11-10 16:57:11 -08:00
2010-11-30 15:52:04 -08:00
2010-11-11 07:14:07 -08:00
2010-11-25 11:29:16 +02:00
2011-01-10 10:46:30 -05:00
2010-11-24 15:21:12 +10:30
2010-10-27 18:03:17 -07:00
2010-12-02 14:10:32 +00:00
2010-12-09 16:02:35 -05:00
2010-11-17 08:59:32 -08:00
2010-11-05 08:10:33 -07:00
731f3ab66a