Joe Jin
731f3ab66a
xen/fb: fix xenfb suspend/resume race.
...
When migrating guests over a long period we hit this:
<1>BUG: unable to handle kernel paging request at 0000000b819fdb98
<1>IP: [<ffffffff812a588f>] notify_remote_via_irq+0x13/0x34
<4>PGD 94b10067 PUD 0
<0>Oops: 0000 [#1 ] SMP
.. snip..
Call Trace:
[<ffffffff812712c9>] xenfb_send_event+0x5c/0x5e
[<ffffffff8100ea5f>] ? xen_restore_fl_direct_end+0x0/0x1
[<ffffffff81438d80>] ? _spin_unlock_irqrestore+0x16/0x18
[<ffffffff812714ee>] xenfb_refresh+0x1b1/0x1d7
[<ffffffff81270568>] ? sys_imageblit+0x1ac/0x458
[<ffffffff81271786>] xenfb_imageblit+0x2f/0x34
[<ffffffff8126a3e5>] soft_cursor+0x1b5/0x1c8
[<ffffffff8126a137>] bit_cursor+0x4b6/0x4d7
[<ffffffff8100ea5f>] ? xen_restore_fl_direct_end+0x0/0x1
[<ffffffff81438d80>] ? _spin_unlock_irqrestore+0x16/0x18
[<ffffffff81269c81>] ? bit_cursor+0x0/0x4d7
[<ffffffff812656b7>] fb_flashcursor+0xff/0x111
[<ffffffff812655b8>] ? fb_flashcursor+0x0/0x111
[<ffffffff81071812>] worker_thread+0x14d/0x1ed
[<ffffffff81075a8c>] ? autoremove_wake_function+0x0/0x3d
[<ffffffff81438d80>] ? _spin_unlock_irqrestore+0x16/0x18
[<ffffffff810716c5>] ? worker_thread+0x0/0x1ed
[<ffffffff810756e3>] kthread+0x6e/0x76
[<ffffffff81012dea>] child_rip+0xa/0x20
[<ffffffff81011fd1>] ? int_ret_from_sys_call+0x7/0x1b
[<ffffffff8101275d>] ? retint_restore_args+0x5/0x6
[<ffffffff81012de0>] ? child_rip+0x0/0x20
Code: 6b ff 0c 8b 87 a4 db 9f 81 66 85 c0 74 08 0f b7 f8 e8 3b ff ff ff c9
c3 55 48 89 e5 48 83 ec 10 0f 1f 44 00 00 89 ff 48 6b ff 0c <8b> 87 a4 db 9f
81 66 85 c0 74 14 48 8d 75 f0 0f b7 c0 bf 04 00
RIP [<ffffffff812a588f>] notify_remote_via_irq+0x13/0x34
RSP <ffff8800e7bf7bd0>
CR2: 0000000b819fdb98
---[ end trace 098b4b74827595d0 ]---
The root cause of the panic is the race between the resume and reconnect to the backend.
Clearing the 'update_wanted' flag of xenfb before disconnecting from the
backend fixes this issue.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Tested-by: Gurudas Pai <gurudas.pai@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
2011-01-10 10:46:30 -05:00
..
2010-10-25 08:19:14 -07:00
2010-11-25 06:50:47 +09:00
2010-11-17 08:59:32 -08:00
2010-03-30 22:02:32 +09:00
2010-12-01 18:18:56 +09:00
2010-10-24 18:16:58 +02:00
2010-10-24 18:16:58 +02:00
2009-06-16 19:47:57 -07:00
2010-10-27 18:03:08 -07:00
2010-08-06 09:25:50 -06:00
2010-10-15 15:53:27 +02:00
2010-10-27 13:43:21 -07:00
2010-03-30 22:02:32 +09:00
2010-10-27 18:03:08 -07:00
2010-11-10 20:51:13 +09:00
2010-03-30 22:02:32 +09:00
2010-11-15 22:40:38 +01:00
2010-10-27 18:03:08 -07:00
2010-11-24 16:03:22 +09:00
2010-03-30 22:02:32 +09:00
2010-10-28 09:35:11 -07:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-08-17 22:15:09 +01:00
2010-05-17 21:37:43 +02:00
2010-10-18 11:03:14 +02:00
2009-04-01 08:59:32 -07:00
2010-03-30 22:02:32 +09:00
2010-10-22 09:43:25 +02:00
2010-03-30 22:02:32 +09:00
2010-07-26 19:08:15 +01:00
2010-10-26 16:52:12 -07:00
2010-08-09 11:25:17 +02:00
2010-05-25 08:07:08 -07:00
2010-08-09 11:25:17 +02:00
2010-03-12 15:52:34 -08:00
2010-08-06 09:25:50 -06:00
2009-01-12 20:56:31 +01:00
2009-01-12 20:56:31 +01:00
2009-01-12 20:56:32 +01:00
2009-01-12 20:56:32 +01:00
2010-06-16 18:05:05 +02:00
2010-03-30 22:02:32 +09:00
2009-05-06 16:36:10 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-05-17 21:37:41 +02:00
2009-12-16 07:20:04 -08:00
2010-05-03 15:42:58 +02:00
2010-08-01 01:42:42 -06:00
2010-07-30 23:29:33 +01:00
2010-12-01 18:18:52 +09:00
2010-03-30 22:02:32 +09:00
2010-09-22 17:22:39 -07:00
2010-03-30 22:02:32 +09:00
2010-10-18 11:03:14 +02:00
2010-03-30 22:02:32 +09:00
2010-06-04 15:21:45 -07:00
2009-05-06 16:36:10 -07:00
2010-11-26 15:05:08 +09:00
2010-10-18 11:03:14 +02:00
2010-10-27 18:03:08 -07:00
2010-03-30 22:02:32 +09:00
2010-05-18 16:19:27 +10:00
2010-08-06 09:25:50 -06:00
2010-05-17 21:37:41 +02:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-10-27 18:03:08 -07:00
2010-03-30 22:02:32 +09:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:09 -07:00
2010-03-30 22:02:32 +09:00
2010-08-11 08:59:12 -07:00
2010-03-30 22:02:32 +09:00
2010-08-10 22:10:51 +01:00
2010-08-05 13:26:17 +01:00
2010-10-26 18:57:59 -07:00
2010-08-06 09:25:50 -06:00
2010-02-27 18:31:16 +01:00
2010-02-27 18:31:14 +01:00
2010-08-06 18:13:19 +01:00
2010-03-30 22:02:32 +09:00
2010-10-18 11:03:14 +02:00
2010-03-30 22:02:32 +09:00
2010-11-15 09:25:01 +01:00
2010-06-29 15:29:32 -07:00
2010-03-12 15:52:34 -08:00
2010-08-01 01:42:42 -06:00
2010-03-30 22:02:32 +09:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-02-05 12:22:42 +01:00
2010-03-30 22:02:32 +09:00
2010-07-26 19:08:14 +01:00
2010-07-26 19:08:15 +01:00
2009-08-20 10:29:26 +10:00
2010-02-17 13:23:00 +09:00
2010-10-09 17:07:23 +08:00
2009-06-13 00:09:09 +08:00
2009-12-29 14:11:27 +08:00
2010-10-22 09:43:25 +02:00
2010-03-30 22:02:32 +09:00
2010-05-25 08:07:09 -07:00
2009-06-16 19:47:59 -07:00
2010-08-11 08:59:12 -07:00
2010-05-27 09:12:42 -07:00
2010-03-07 17:04:50 -08:00
2009-04-13 15:04:29 -07:00
2010-05-25 08:07:09 -07:00
2010-03-30 22:02:32 +09:00
2010-09-14 17:22:38 +09:00
2010-11-10 16:53:12 +09:00
2010-11-16 10:11:28 +09:00
2010-09-16 16:36:17 +09:00
2009-04-13 15:04:29 -07:00
2010-02-09 11:13:56 +01:00
2010-03-30 22:02:32 +09:00
2009-12-04 15:39:55 +01:00
2010-04-05 11:37:28 +09:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2009-05-06 16:36:10 -07:00
2010-08-06 09:25:50 -06:00
2010-08-05 13:25:38 +01:00
2010-06-16 18:05:05 +02:00
2009-09-23 07:39:57 -07:00
2010-03-30 22:02:32 +09:00
2010-08-11 23:04:13 +09:30
2010-02-27 18:31:13 +01:00
2010-02-27 18:31:13 +01:00
2010-08-16 15:14:03 +02:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:08 -07:00
2010-08-11 23:04:31 +09:30
2010-08-09 20:44:53 -07:00
2011-01-10 10:46:30 -05:00
2010-10-21 16:04:51 +10:00