Jack Morgenstein 8511a653e9 net/mlx4_core: Fix qp mtt size calculation
Calculation of qp mtt size (in function mlx4_RST2INIT_wrapper)
ultimately depends on function roundup_pow_of_two.

If the amount of memory required by the QP is less than one page,
roundup_pow_of_two is called with argument zero.  In this case, the
roundup_pow_of_two result is undefined.

Calling roundup_pow_of_two with a zero argument resulted in the
following stack trace:

UBSAN: Undefined behaviour in ./include/linux/log2.h:61:13
shift exponent 64 is too large for 64-bit type 'long unsigned int'
CPU: 4 PID: 26939 Comm: rping Tainted: G OE 4.19.0-rc1
Hardware name: Supermicro X9DR3-F/X9DR3-F, BIOS 3.2a 07/09/2015
Call Trace:
dump_stack+0x9a/0xeb
ubsan_epilogue+0x9/0x7c
__ubsan_handle_shift_out_of_bounds+0x254/0x29d
? __ubsan_handle_load_invalid_value+0x180/0x180
? debug_show_all_locks+0x310/0x310
? sched_clock+0x5/0x10
? sched_clock+0x5/0x10
? sched_clock_cpu+0x18/0x260
? find_held_lock+0x35/0x1e0
? mlx4_RST2INIT_QP_wrapper+0xfb1/0x1440 [mlx4_core]
mlx4_RST2INIT_QP_wrapper+0xfb1/0x1440 [mlx4_core]

Fix this by explicitly testing for zero, and returning one if the
argument is zero (assuming that the next higher power of 2 in this case
should be one).

Fixes: c82e9aa0a8bc ("mlx4_core: resource tracking for HCA resources used by guests")
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-12 15:00:15 -07:00
..
2019-03-04 19:16:09 -08:00
2019-01-10 13:39:19 +02:00
2018-12-29 08:20:44 -07:00
2019-02-20 11:40:21 -08:00
2019-02-10 10:39:37 -08:00
2018-12-10 10:17:45 +01:00
2019-03-04 15:32:51 +00:00
2019-02-28 14:05:33 +10:00
2019-01-09 19:20:31 -05:00
2019-03-01 09:13:04 -08:00
2019-03-04 19:33:04 -08:00
2019-02-15 09:12:28 -08:00
2019-01-05 11:30:37 -08:00
2018-12-28 16:52:18 -08:00
2019-02-01 15:53:54 +01:00
2019-03-01 09:50:10 +01:00
2019-03-04 19:23:56 -08:00
2018-12-06 15:45:46 +01:00
2019-02-08 15:32:10 -08:00
2019-01-05 11:23:17 -08:00
2018-12-29 13:03:29 -08:00
2018-12-24 12:06:56 +01:00
2019-01-01 13:24:31 -08:00
2019-03-02 11:39:54 -08:00
2019-03-04 15:32:51 +00:00
2019-02-08 10:49:55 -08:00
2018-12-28 20:54:57 -08:00
2019-01-25 12:58:40 -10:00
2018-12-29 13:40:29 -08:00