iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel
History
Peter Zijlstra 85d68222dd rcu: Break rcu_node_0 --> &rq->__lock order 
Commit 851a723e45d1 ("sched: Always clear user_cpus_ptr in
do_set_cpus_allowed()") added a kfree() call to free any user
provided affinity mask, if present. It was changed later to use
kfree_rcu() in commit 9a5418bc48ba ("sched/core: Use kfree_rcu()
in do_set_cpus_allowed()") to avoid a circular locking dependency
problem.

It turns out that even kfree_rcu() isn't safe for avoiding
circular locking problem. As reported by kernel test robot,
the following circular locking dependency now exists:

  &rdp->nocb_lock --> rcu_node_0 --> &rq->__lock

Solve this by breaking the rcu_node_0 --> &rq->__lock chain by moving
the resched_cpu() out from under rcu_node lock.

[peterz: heavily borrowed from Waiman's Changelog]
[paulmck: applied Z qiang feedback]

Fixes: 851a723e45d1 ("sched: Always clear user_cpus_ptr in do_set_cpus_allowed()")
Reported-by: kernel test robot <oliver.sang@intel.com>
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/oe-lkp/202310302207.a25f1a30-oliver.sang@intel.com
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
2023-11-01 21:39:58 +01:00
..
bpf
vfs-6.7.ctime
2023-10-30 09:47:13 -10:00
cgroup
cgroup: Remove duplicates in cgroup v1 tasks file
2023-10-09 06:42:05 -10:00
configs
Kbuild updates for v6.6
2023-09-05 11:01:47 -07:00
debug
printk changes for 6.6
2023-09-04 13:20:19 -07:00
dma
swiotlb: do not try to allocate a TLB bigger than MAX_ORDER pages
2023-10-25 16:26:20 +02:00
entry
entry: Remove empty addr_limit_user_check()
2023-08-23 10:32:39 +02:00
events
Performance events changes for v6.7 are:
2023-10-30 13:44:35 -10:00
futex
futex: Don't include process MM in futex key on no-MMU
2023-10-27 11:53:42 +02:00
gcov
gcov: shut up missing prototype warnings for internal stubs
2023-08-18 10:18:58 -07:00
irq
Updates for the X86 APIC:
2023-10-30 17:27:56 -10:00
kcsan
kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures
2023-06-09 23:29:50 +10:00
livepatch
livepatch: Make 'klp_stack_entries' static
2023-06-05 13:56:52 +02:00
locking
RCU pull request for v6.7
2023-10-30 18:01:41 -10:00
module
module/decompress: use vmalloc() for zstd decompression workspace
2023-08-29 09:39:08 -07:00
power
PM: hibernate: Drop unused snapshot_test argument
2023-10-28 13:29:19 +02:00
printk
Merge branch 'rework/misc-cleanups' into for-linus
2023-10-11 12:58:14 +02:00
rcu
rcu: Break rcu_node_0 --> &rq->__lock order
2023-11-01 21:39:58 +01:00
sched
Scheduler changes for v6.7 are:
2023-10-30 13:12:15 -10:00
time
alarmtimer: Use maximum alarm time for suspend
2023-10-09 15:03:28 +02:00
trace
vfs-6.7.misc
2023-10-30 09:14:19 -10:00
.gitignore
…
acct.c
fs: rename __mnt_{want,drop}_write*() helpers
2023-09-11 15:05:50 +02:00
async.c
…
audit_fsnotify.c
audit: fix potential double free on error path from fsnotify_add_inode_mark
2022-08-22 18:50:06 -04:00
audit_tree.c
…
audit_watch.c
audit_init_parent(): constify path
2022-09-01 17:39:30 -04:00
audit.c
audit: move trailing statements to next line
2023-08-15 18:16:14 -04:00
audit.h
audit: correct audit_filter_inodes() definition
2023-07-21 12:17:25 -04:00
auditfilter.c
audit: move trailing statements to next line
2023-08-15 18:16:14 -04:00
auditsc.c
audit,io_uring: io_uring openat triggers audit reference count underflow
2023-10-13 18:34:46 +02:00
backtracetest.c
…
bounds.c
mm: multi-gen LRU: minimal implementation
2022-09-26 19:46:09 -07:00
capability.c
lsm: constify the 'target' parameter in security_capget()
2023-08-08 16:48:47 -04:00
cfi.c
cfi: Switch to -fsanitize=kcfi
2022-09-26 10:13:13 -07:00
compat.c
sched_getaffinity: don't assume 'cpumask_size()' is fully initialized
2023-03-14 19:32:38 -07:00
configs.c
…
context_tracking.c
locking/atomic: treewide: use raw_atomic*_<op>()
2023-06-05 09:57:20 +02:00
cpu_pm.c
cpuidle, cpu_pm: Remove RCU fiddling from cpu_pm_{enter,exit}()
2023-01-13 11:48:15 +01:00
cpu.c
RCU pull request for v6.7
2023-10-30 18:01:41 -10:00
crash_core.c
Crash: add lock to serialize crash hotplug handling
2023-09-29 17:20:48 -07:00
crash_dump.c
…
cred.c
cred: convert printks to pr_<level>
2023-08-18 10:18:49 -07:00
delayacct.c
delayacct: track delays from IRQ/SOFTIRQ
2023-04-18 16:39:34 -07:00
dma.c
…
exec_domain.c
…
exit.c
fork, vhost: Use CLONE_THREAD to fix freezer/ps regression
2023-06-01 17:15:33 -04:00
extable.c
context_tracking: Take NMI eqs entrypoints over RCU
2022-07-05 13:32:59 -07:00
fail_function.c
kernel/fail_function: fix memory leak with using debugfs_lookup()
2023-02-08 13:36:22 +01:00
fork.c
file: convert to SLAB_TYPESAFE_BY_RCU
2023-10-19 11:02:48 +02:00
freezer.c
freezer,sched: Use saved_state to reduce some spurious wakeups
2023-09-18 08:14:36 +02:00
gen_kheaders.sh
Revert "kheaders: substituting --sort in archive creation"
2023-05-28 16:20:21 +09:00
groups.c
security: Add LSM hook to setgroups() syscall
2022-07-15 18:21:49 +00:00
hung_task.c
kernel/hung_task.c: set some hung_task.c variables storage-class-specifier to static
2023-04-08 13:45:37 -07:00
iomem.c
kernel/iomem.c: remove __weak ioremap_cache helper
2023-08-21 13:37:28 -07:00
irq_work.c
trace: Add trace_ipi_send_cpu()
2023-03-24 11:01:29 +01:00
jump_label.c
jump_label: Prevent key->enabled int overflow
2022-12-01 15:53:05 -08:00
kallsyms_internal.h
kallsyms: Reduce the memory occupied by kallsyms_seqs_of_names[]
2022-11-12 18:47:36 -08:00
kallsyms_selftest.c
Modules changes for v6.6-rc1
2023-08-29 17:32:32 -07:00
kallsyms_selftest.h
kallsyms: Add self-test facility
2022-11-15 00:42:02 -08:00
kallsyms.c
kallsyms: Change func signature for cleanup_symbol_name()
2023-08-25 15:00:36 -07:00
kcmp.c
file: convert to SLAB_TYPESAFE_BY_RCU
2023-10-19 11:02:48 +02:00
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.kexec
crash: hotplug support for kexec_load()
2023-08-24 16:25:14 -07:00
Kconfig.locks
…
Kconfig.preempt
…
kcov.c
kcov: add prototypes for helper functions
2023-06-09 17:44:17 -07:00
kexec_core.c
crash: add generic infrastructure for crash hotplug support
2023-08-24 16:25:13 -07:00
kexec_elf.c
…
kexec_file.c
integrity-v6.6
2023-08-30 09:16:56 -07:00
kexec_internal.h
panic, kexec: make __crash_kexec() NMI safe
2022-09-11 21:55:06 -07:00
kexec.c
crash: hotplug support for kexec_load()
2023-08-24 16:25:14 -07:00
kheaders.c
kheaders: Use array declaration instead of char
2023-03-24 20:10:59 -07:00
kprobes.c
kernel: kprobes: Use struct_size()
2023-08-23 09:38:17 +09:00
ksyms_common.c
kallsyms: make kallsyms_show_value() as generic function
2023-06-08 12:27:20 -07:00
ksysfs.c
crash: hotplug support for kexec_load()
2023-08-24 16:25:14 -07:00
kthread.c
kthread: unexport __kthread_should_park()
2023-08-18 10:18:59 -07:00
latencytop.c
latencytop: use the last element of latency_record of system
2022-09-11 21:55:12 -07:00
Makefile
v6.5-rc1-modules-next
2023-06-28 15:51:08 -07:00
module_signature.c
…
notifier.c
notifiers: add tracepoints to the notifiers infrastructure
2023-04-08 13:45:38 -07:00
nsproxy.c
nsproxy: Convert nsproxy.count to refcount_t
2023-08-21 11:29:12 -07:00
padata.c
padata: use alignment when calculating the number of worker threads
2023-03-14 17:06:44 +08:00
panic.c
panic: Reenable preemption in WARN slowpath
2023-09-15 11:28:08 +02:00
params.c
kernel: params: Remove unnecessary ‘0’ values from err
2023-07-10 12:47:01 -07:00
pid_namespace.c
memfd: replace ratcheting feature from vm.memfd_noexec with hierarchy
2023-08-21 13:37:59 -07:00
pid_sysctl.h
memfd: replace ratcheting feature from vm.memfd_noexec with hierarchy
2023-08-21 13:37:59 -07:00
pid.c
pidfd: prevent a kernel-doc warning
2023-09-19 13:21:33 -07:00
profile.c
kernel/profile.c: simplify duplicated code in profile_setup()
2022-09-11 21:55:12 -07:00
ptrace.c
ptrace: Provide set/get interface for syscall user dispatch
2023-04-16 14:23:07 +02:00
range.c
…
reboot.c
kernel/reboot: Add SYS_OFF_MODE_RESTART_PREPARE mode
2022-10-04 15:59:36 +02:00
regset.c
…
relay.c
kernel: relay: remove unnecessary NULL values from relay_open_buf
2023-08-18 10:18:55 -07:00
resource_kunit.c
…
resource.c
dax/kmem: Fix leak of memory-hotplug resources
2023-02-17 14:58:01 -08:00
rseq.c
rseq: Extend struct rseq with per-memory-map concurrency ID
2022-12-27 12:52:12 +01:00
scftorture.c
scftorture: Pause testing after memory-allocation failure
2023-07-14 15:02:57 -07:00
scs.c
scs: add support for dynamic shadow call stacks
2022-11-09 18:06:35 +00:00
seccomp.c
seccomp: Add missing kerndoc notations
2023-08-17 12:32:15 -07:00
signal.c
signal: Don't disable preemption in ptrace_stop() on PREEMPT_RT
2023-09-19 22:08:29 +02:00
smp.c
CSD lock commits for v6.7
2023-10-30 17:56:53 -10:00
smpboot.c
cpu/hotplug: Remove unused state functions
2023-05-15 13:45:00 +02:00
smpboot.h
…
softirq.c
sched/core: introduce sched_core_idle_cpu()
2023-07-13 15:21:50 +02:00
stackleak.c
stackleak: allow to specify arch specific stackleak poison function
2023-04-20 11:36:35 +02:00
stacktrace.c
stacktrace: Export stack_trace_save_tsk
2023-09-11 23:59:47 -04:00
static_call_inline.c
static_call: Add call depth tracking support
2022-10-17 16:41:16 +02:00
static_call.c
…
stop_machine.c
Scheduler changes in this cycle were:
2022-05-24 11:11:13 -07:00
sys_ni.c
futex: Add sys_futex_requeue()
2023-09-21 19:22:10 +02:00
sys.c
prctl: move PR_GET_AUXV out of PR_MCE_KILL
2023-07-17 12:53:21 -07:00
sysctl-test.c
kernel/sysctl-test: use SYSCTL_{ZERO/ONE_HUNDRED} instead of i_{zero/one_hundred}
2022-09-08 16:56:45 -07:00
sysctl.c
perf/core: Rename perf_proc_update_handler() -> perf_event_max_sample_rate_handler(), for readability
2023-10-05 10:26:50 +02:00
task_work.c
task_work: add kerneldoc annotation for 'data' argument
2023-09-19 13:21:32 -07:00
taskstats.c
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
torture.c
torture: Print out torture module parameters
2023-09-24 17:24:01 +02:00
tracepoint.c
tracepoint: Allow livepatch module add trace event
2023-02-18 14:34:36 -05:00
tsacct.c
…
ucount.c
sysctl: Add size to register_sysctl
2023-08-15 15:26:17 -07:00
uid16.c
…
uid16.h
…
umh.c
sysctl: fix unused proc_cap_handler() function warning
2023-06-29 15:19:43 -07:00
up.c
smp: Change function signatures to use call_single_data_t
2023-09-13 14:59:24 +02:00
user_namespace.c
userns: fix a struct's kernel-doc notation
2023-02-02 22:50:04 -08:00
user-return-notifier.c
…
user.c
kernel/user: Allow user_struct::locked_vm to be usable for iommufd
2022-11-30 20:16:49 -04:00
usermode_driver.c
…
utsname_sysctl.c
utsname: simplify one-level sysctl registration for uts_kern_table
2023-04-13 11:49:35 -07:00
utsname.c
…
vhost_task.c
vhost: Fix worker hangs due to missed wake up calls
2023-06-08 15:43:09 -04:00
watch_queue.c
watch_queue: prevent dangling pipe pointer
2023-06-06 10:47:04 +02:00
watchdog_buddy.c
watchdog/hardlockup: move SMP barriers from common code to buddy code
2023-06-19 16:25:28 -07:00
watchdog_perf.c
watchdog/perf: add a weak function for an arch to detect if perf can use NMIs
2023-06-09 17:44:21 -07:00
watchdog.c
watchdog/hardlockup: avoid large stack frames in watchdog_hardlockup_check()
2023-08-18 10:19:00 -07:00
workqueue_internal.h
workqueue: Drop the special locking rule for worker->flags and worker_pool->flags
2023-08-07 15:57:22 -10:00
workqueue.c
workqueue: fix -Wformat-truncation in create_worker
2023-10-12 09:53:40 -10:00