Jason A. Donenfeld 99de0356b3 siphash: use one source of truth for siphash permutations
commit e73aaae2fa9024832e1f42e30c787c7baf61d014 upstream.

The SipHash family of permutations is currently used in three places:

- siphash.c itself, used in the ordinary way it was intended.
- random32.c, in a construction from an anonymous contributor.
- random.c, as part of its fast_mix function.

Each one of these places reinvents the wheel with the same C code, same
rotation constants, and same symmetry-breaking constants.

This commit tidies things up a bit by placing macros for the
permutations and constants into siphash.h, where each of the three .c
users can access them. It also leaves a note dissuading more users of
them from emerging.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-06-25 11:45:14 +02:00
..
2017-09-02 07:07:54 +02:00
2015-11-23 09:44:58 +01:00
2016-03-17 15:09:34 -07:00
2019-04-20 09:07:54 +02:00
2014-04-30 19:49:37 +01:00
2014-08-06 18:01:25 -07:00
2016-05-23 17:04:14 -07:00
2016-03-09 15:43:42 -08:00
2015-02-12 18:54:15 -08:00
2014-06-25 17:45:43 -07:00
2015-09-08 14:35:59 -07:00
2015-02-12 18:54:16 -08:00
2018-10-18 09:13:24 +02:00
2016-09-19 08:19:40 -06:00
2015-06-25 17:00:40 -07:00
2016-05-30 15:26:57 -07:00