Daniel Borkmann
b2a5212fb6
bpf: Restrict bpf_trace_printk()'s %s usage and add %pks, %pus specifier
...
Usage of plain %s conversion specifier in bpf_trace_printk() suffers from the
very same issue as bpf_probe_read{,str}() helpers, that is, it is broken on
archs with overlapping address ranges.
While the helpers have been addressed through work in 6ae08ae3dea2 ("bpf: Add
probe_read_{user, kernel} and probe_read_{user, kernel}_str helpers"), we need
an option for bpf_trace_printk() as well to fix it.
Similarly as with the helpers, force users to make an explicit choice by adding
%pks and %pus specifier to bpf_trace_printk() which will then pick the corresponding
strncpy_from_unsafe*() variant to perform the access under KERNEL_DS or USER_DS.
The %pk* (kernel specifier) and %pu* (user specifier) can later also be extended
for other objects aside strings that are probed and printed under tracing, and
reused out of other facilities like bpf_seq_printf() or BTF based type printing.
Existing behavior of %s for current users is still kept working for archs where it
is not broken and therefore gated through CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE.
For archs not having this property we fall-back to pick probing under KERNEL_DS as
a sensible default.
Fixes: 8d3b7dce8622 ("bpf: add support for %s specifier to bpf_trace_printk()")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Link: https://lore.kernel.org/bpf/20200515101118.6508-4-daniel@iogearbox.net
2020-05-15 08:10:36 -07:00
..
2019-07-03 16:57:17 +02:00
2020-03-20 14:35:27 +11:00
2019-07-25 11:34:39 -07:00
2019-06-20 10:11:24 +02:00
2020-04-23 15:42:00 -06:00
2020-01-17 11:12:06 +01:00
2019-09-20 09:06:26 -07:00
2019-09-25 17:51:41 -07:00
2019-12-04 19:44:13 -08:00
2020-04-24 13:14:59 +10:00
2020-04-09 00:12:48 +09:00
2019-07-02 08:41:37 +02:00
2020-03-21 15:24:03 +01:00
2019-11-15 18:34:00 -08:00
2020-01-31 10:30:40 -08:00
2020-01-31 10:30:40 -08:00
2020-01-31 10:30:40 -08:00
2019-09-15 19:42:16 +02:00
2020-03-25 11:50:48 +01:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:27:11 +02:00
2019-05-24 17:27:11 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-04-07 10:43:42 -07:00
2020-02-04 03:05:26 +00:00
2019-05-21 10:50:45 +02:00
2020-03-03 17:38:42 -05:00
2019-11-14 13:15:11 -05:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2019-09-25 17:51:41 -07:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:06 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-10-18 15:01:57 +02:00
2020-03-20 13:06:18 +01:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2019-02-15 19:50:07 +01:00
2018-07-27 19:04:33 +08:00
2017-02-24 17:46:57 -08:00
2020-01-23 11:40:01 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2020-01-17 15:45:01 +01:00
2018-06-12 23:33:24 +02:00
2018-07-27 19:16:38 +08:00
2020-01-31 10:30:40 -08:00
2019-06-19 17:09:55 +02:00
2019-05-24 17:37:53 +02:00
2017-11-02 11:10:55 +01:00
2020-01-06 09:45:59 +01:00
2019-07-10 18:43:43 -07:00
2019-11-06 08:47:50 -08:00
2020-04-07 10:43:43 -07:00
2017-11-15 11:56:19 -08:00
2019-06-05 17:36:37 +02:00
2019-10-17 16:23:25 +02:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2019-06-18 13:47:24 +02:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2020-01-31 10:30:41 -08:00
2017-11-02 11:10:55 +01:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2019-12-04 19:44:13 -08:00
2019-10-14 15:04:00 -07:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2019-09-25 17:51:39 -07:00
2019-05-13 11:07:33 +02:00
2019-11-01 22:26:34 -04:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2019-01-22 13:39:59 +01:00
2018-05-09 06:55:44 +02:00
2019-11-11 21:18:20 +01:00
2019-12-16 12:48:10 -05:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2020-02-20 16:58:55 -08:00
2020-04-09 17:39:22 -07:00
2019-12-01 12:59:05 -08:00
2019-12-07 11:00:19 -08:00
2020-04-07 10:43:44 -07:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2019-04-01 07:37:12 +02:00
2019-06-19 19:27:39 +02:00
2018-10-31 08:54:13 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2018-04-11 10:28:35 -07:00
2019-06-20 14:07:34 -06:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-10-09 12:46:10 +02:00
2019-06-07 13:15:06 -07:00
2019-11-05 08:45:25 +08:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2020-04-07 10:43:44 -07:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2019-11-07 15:44:29 +01:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-04 01:27:11 -04:00
2018-07-09 14:10:40 +02:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2017-11-04 09:26:51 +09:00
2019-05-03 10:49:17 -04:00
2017-02-03 16:35:42 -05:00
2019-06-19 17:09:06 +02:00
2018-01-26 11:45:16 -06:00
2018-08-30 12:56:40 +02:00
2019-05-21 10:50:45 +02:00
2020-03-05 13:10:26 -08:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2020-01-31 15:09:49 -05:00
2019-05-17 11:32:47 -07:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-04-07 10:43:43 -07:00
2019-11-25 09:15:32 +01:00
2019-06-19 17:09:55 +02:00
2019-12-20 16:51:54 -07:00
2020-04-07 10:43:43 -07:00
2019-11-14 13:15:12 -05:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2017-11-02 11:10:55 +01:00
2019-09-24 15:54:09 -07:00
2019-04-25 19:47:24 +02:00
2019-10-09 12:46:10 +02:00
2019-11-14 13:15:11 -05:00
2020-04-07 10:43:43 -07:00
2019-05-30 11:26:32 -07:00
2019-07-16 19:23:22 -07:00
2020-02-21 11:22:15 -08:00
2020-01-24 09:27:34 -08:00
2020-01-24 09:27:34 -08:00
2019-04-05 09:26:43 -04:00
2018-06-27 18:58:49 +03:00
2020-04-07 10:43:43 -07:00
2019-07-01 19:34:46 -07:00
2020-02-24 16:20:09 -08:00
2019-05-21 10:50:45 +02:00
2020-03-20 14:54:04 +01:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2018-10-15 16:31:29 -04:00
2020-04-02 09:35:30 -07:00
2020-04-07 10:43:43 -07:00
2019-05-21 10:50:45 +02:00
2020-04-07 10:43:42 -07:00
2018-10-16 13:45:44 +02:00
2019-12-04 19:44:13 -08:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2019-02-13 22:13:29 -08:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2019-11-26 19:45:12 -08:00
2019-06-19 17:09:55 +02:00
2017-01-09 13:58:57 -05:00
2019-05-21 10:50:45 +02:00
2020-04-07 10:43:43 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2019-05-14 19:52:51 -07:00
2019-03-07 18:32:00 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2019-05-14 19:52:49 -07:00
2020-01-31 15:09:49 -05:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2020-04-07 10:43:42 -07:00
2020-04-07 10:43:43 -07:00
2020-04-07 10:43:43 -07:00
2020-04-07 10:43:44 -07:00
2019-11-17 09:02:42 +08:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2019-10-01 15:45:03 +02:00
2020-03-23 17:01:47 +01:00
2020-05-15 08:10:36 -07:00
2017-11-02 11:10:55 +01:00
2020-03-12 17:42:08 -04:00
2017-08-15 09:02:07 -07:00