Kuninori Morimoto
ec4e5ccd4b
fbdev: sh_mobile_hdmi: add new label for sound error path ...
This patch solve below report from Guennadi
> /* External video parameter settings */
> static void hdmi_external_video_param(struct sh_hdmi *hdmi)
> {
> @@ -804,6 +862,11 @@ static int __init sh_hdmi_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + ret = snd_soc_register_codec(&pdev->dev,
> + &soc_codec_dev_sh_hdmi, &sh_hdmi_dai, 1);
> + if (ret < 0)
> + goto egetclk;
> +
> hdmi->dev = &pdev->dev;
>
> hdmi->hdmi_clk = clk_get(&pdev->dev, "ick");
NAK. This breaks the error path and has to be fixed. Firstly, please, use
a new label like "esndreg," secondly, you have to add
clk_disable(hdmi->hdmi_clk);
erate:
clk_put(hdmi->hdmi_clk);
egetclk:
+ snd_soc_unregister_codec(&pdev->dev);
+esndreg:
mutex_destroy(&hdmi->mutex);
kfree(hdmi);
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2010-09-10 16:07:41 +01:00
2010-08-15 17:37:07 -07:00
2010-07-31 13:07:27 +01:00
2010-08-15 01:06:31 -04:00
2010-08-12 09:11:31 -07:00
2010-08-09 20:45:02 -07:00
2010-08-12 09:11:31 -07:00
2010-08-06 12:25:06 -07:00
2010-08-07 18:25:34 +02:00
2010-08-12 10:01:59 -07:00
2010-08-03 13:47:05 -04:00
2010-08-09 20:45:04 -07:00
2010-08-13 10:06:54 +02:00
2010-08-12 09:11:31 -07:00
2010-08-12 09:11:31 -07:00
2010-08-02 10:09:04 +02:00
2010-08-14 12:34:34 -07:00
2010-08-12 11:27:57 +02:00
2010-08-13 18:04:52 -07:00
2010-08-10 15:08:02 -07:00
2010-08-14 21:09:02 +02:00
2010-08-14 11:57:54 -07:00
2010-08-11 23:04:39 +09:30
2010-08-15 11:17:52 -07:00
2010-08-02 10:09:04 +02:00
2010-08-12 09:11:31 -07:00
2010-08-16 18:42:58 +01:00
2010-08-13 10:38:12 -07:00
2010-08-12 09:11:31 -07:00
2010-08-12 10:06:29 -07:00
2010-08-12 04:14:32 +01:00
2010-08-14 00:24:24 +02:00
2010-08-12 08:43:31 -07:00
2010-08-14 16:21:00 -07:00
2010-08-16 18:42:58 +01:00
2010-08-12 10:01:59 -07:00
2010-08-14 11:54:09 -07:00
2010-08-15 17:32:47 -07:00
2010-08-13 16:55:26 -07:00
2010-08-06 09:25:50 -06:00
2010-08-04 15:31:02 -07:00
2010-08-12 09:11:31 -07:00
2010-08-15 17:34:20 -07:00
2010-08-12 09:11:31 -07:00
2010-08-11 18:00:52 +01:00
2010-08-12 09:58:33 -07:00
2010-08-11 11:38:03 +01:00
2010-08-12 09:11:31 -07:00
2010-08-13 10:54:04 -07:00
2010-08-06 09:25:50 -06:00
2010-08-14 12:34:34 -07:00
2010-08-12 09:11:31 -07:00
2010-08-04 16:12:01 +09:00
2010-08-14 11:54:09 -07:00
2010-08-06 12:25:06 -07:00
2010-08-11 23:04:27 +09:30
2010-08-03 09:04:11 +02:00
2010-08-05 13:53:33 -07:00
2010-08-12 10:06:29 -07:00
2010-08-04 11:47:58 -07:00
2010-09-10 16:07:41 +01:00
2010-08-13 20:54:53 +00:00
2010-08-12 09:09:41 -07:00
2010-08-09 21:14:08 +02:00
ec4e5ccd4b