Kuninori Morimoto ec4e5ccd4b fbdev: sh_mobile_hdmi: add new label for sound error path
This patch solve below report from Guennadi

>  /* External video parameter settings */
>  static void hdmi_external_video_param(struct sh_hdmi *hdmi)
>  {
> @@ -804,6 +862,11 @@ static int __init sh_hdmi_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	}
>
> +	ret =  snd_soc_register_codec(&pdev->dev,
> +			&soc_codec_dev_sh_hdmi, &sh_hdmi_dai, 1);
> +	if (ret < 0)
> +		goto egetclk;
> +
>  	hdmi->dev = &pdev->dev;
>
>  	hdmi->hdmi_clk = clk_get(&pdev->dev, "ick");

NAK. This breaks the error path and has to be fixed. Firstly, please, use
a new label like "esndreg," secondly, you have to add

 	clk_disable(hdmi->hdmi_clk);
 erate:
 	clk_put(hdmi->hdmi_clk);
 egetclk:
+	snd_soc_unregister_codec(&pdev->dev);
+esndreg:
 	mutex_destroy(&hdmi->mutex);
 	kfree(hdmi);

Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2010-09-10 16:07:41 +01:00
..
2010-07-19 10:56:54 +02:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:08 -07:00
2009-04-01 08:59:32 -07:00
2009-01-12 20:56:32 +01:00
2009-12-16 07:20:04 -08:00
2010-05-03 15:42:58 +02:00
2010-08-11 08:59:09 -07:00
2009-05-06 16:36:10 -07:00
2010-08-11 08:59:12 -07:00
2010-07-26 19:08:13 +01:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:09 -07:00
2010-02-27 18:31:16 +01:00
2010-02-27 18:31:14 +01:00
2009-01-06 15:59:27 -08:00
2010-03-12 15:52:34 -08:00
2009-01-06 15:59:27 -08:00
2010-05-25 08:07:09 -07:00
2010-05-27 09:12:42 -07:00
2010-05-25 08:07:09 -07:00
2010-02-09 11:13:56 +01:00
2010-06-16 18:05:05 +02:00
2010-02-27 18:31:13 +01:00
2010-02-27 18:31:13 +01:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:08 -07:00