Kuninori Morimoto
ec4e5ccd4b
fbdev: sh_mobile_hdmi: add new label for sound error path
...
This patch solve below report from Guennadi
> /* External video parameter settings */
> static void hdmi_external_video_param(struct sh_hdmi *hdmi)
> {
> @@ -804,6 +862,11 @@ static int __init sh_hdmi_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + ret = snd_soc_register_codec(&pdev->dev,
> + &soc_codec_dev_sh_hdmi, &sh_hdmi_dai, 1);
> + if (ret < 0)
> + goto egetclk;
> +
> hdmi->dev = &pdev->dev;
>
> hdmi->hdmi_clk = clk_get(&pdev->dev, "ick");
NAK. This breaks the error path and has to be fixed. Firstly, please, use
a new label like "esndreg," secondly, you have to add
clk_disable(hdmi->hdmi_clk);
erate:
clk_put(hdmi->hdmi_clk);
egetclk:
+ snd_soc_unregister_codec(&pdev->dev);
+esndreg:
mutex_destroy(&hdmi->mutex);
kfree(hdmi);
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2010-09-10 16:07:41 +01:00
..
2010-07-21 09:25:42 -07:00
2010-07-19 10:56:54 +02:00
2010-08-11 08:59:09 -07:00
2010-03-30 22:02:32 +09:00
2010-06-29 15:29:31 -07:00
2010-03-30 22:02:32 +09:00
2010-05-25 08:07:09 -07:00
2009-06-16 19:47:57 -07:00
2010-08-11 18:20:56 +02:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-07-29 13:54:53 -07:00
2010-03-30 22:02:32 +09:00
2010-07-05 16:31:39 +03:00
2010-08-08 10:02:59 -07:00
2010-03-30 22:02:32 +09:00
2010-03-16 19:47:54 +00:00
2010-03-30 22:02:32 +09:00
2010-05-25 08:07:08 -07:00
2010-03-30 22:02:32 +09:00
2010-08-05 22:36:27 +00:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-03-14 19:42:44 +00:00
2010-05-17 21:37:43 +02:00
2010-05-25 08:07:08 -07:00
2009-04-01 08:59:32 -07:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-07-26 19:08:15 +01:00
2010-03-30 22:02:32 +09:00
2010-05-27 09:12:42 -07:00
2010-05-25 08:07:08 -07:00
2010-05-27 09:12:42 -07:00
2010-03-12 15:52:34 -08:00
2010-08-06 09:25:50 -06:00
2009-01-12 20:56:31 +01:00
2009-01-12 20:56:31 +01:00
2009-01-12 20:56:32 +01:00
2009-01-12 20:56:32 +01:00
2010-06-16 18:05:05 +02:00
2010-03-30 22:02:32 +09:00
2009-05-06 16:36:10 -07:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-05-17 21:37:41 +02:00
2009-12-16 07:20:04 -08:00
2010-05-03 15:42:58 +02:00
2010-08-01 01:42:42 -06:00
2010-07-30 23:29:33 +01:00
2010-05-25 08:07:09 -07:00
2010-03-30 22:02:32 +09:00
2010-08-11 08:59:09 -07:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-06-04 15:21:45 -07:00
2009-05-06 16:36:10 -07:00
2009-02-05 12:56:46 -08:00
2010-03-30 22:02:32 +09:00
2010-08-11 08:59:12 -07:00
2010-03-30 22:02:32 +09:00
2010-05-18 16:19:27 +10:00
2010-08-06 09:25:50 -06:00
2010-05-17 21:37:41 +02:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-07-26 19:08:13 +01:00
2009-01-06 15:59:26 -08:00
2010-03-30 22:02:32 +09:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:09 -07:00
2010-03-30 22:02:32 +09:00
2010-08-11 08:59:12 -07:00
2010-03-30 22:02:32 +09:00
2010-08-10 22:10:51 +01:00
2010-08-05 13:26:17 +01:00
2010-08-11 09:13:19 -07:00
2010-08-06 09:25:50 -06:00
2010-02-27 18:31:16 +01:00
2010-02-27 18:31:14 +01:00
2010-08-06 18:13:19 +01:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-05-17 16:30:42 -07:00
2009-01-06 15:59:27 -08:00
2010-06-29 15:29:32 -07:00
2010-03-12 15:52:34 -08:00
2010-08-01 01:42:42 -06:00
2010-03-30 22:02:32 +09:00
2010-08-06 09:25:50 -06:00
2010-08-06 09:25:50 -06:00
2010-02-05 12:22:42 +01:00
2009-01-06 15:59:27 -08:00
2010-03-30 22:02:32 +09:00
2010-07-26 19:08:14 +01:00
2010-07-26 19:08:15 +01:00
2009-08-20 10:29:26 +10:00
2010-02-17 13:23:00 +09:00
2010-03-22 20:30:17 +08:00
2009-06-13 00:09:09 +08:00
2009-12-29 14:11:27 +08:00
2008-12-29 18:00:04 +08:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-05-25 08:07:09 -07:00
2009-06-16 19:47:59 -07:00
2010-08-11 08:59:12 -07:00
2010-05-27 09:12:42 -07:00
2010-03-07 17:04:50 -08:00
2009-04-13 15:04:29 -07:00
2010-05-25 08:07:09 -07:00
2010-03-30 22:02:32 +09:00
2010-08-04 16:12:11 +09:00
2010-09-10 16:07:41 +01:00
2010-08-04 16:12:15 +09:00
2009-04-13 15:04:29 -07:00
2010-02-09 11:13:56 +01:00
2010-03-30 22:02:32 +09:00
2009-12-04 15:39:55 +01:00
2010-04-05 11:37:28 +09:00
2010-08-06 09:25:50 -06:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2009-05-06 16:36:10 -07:00
2010-08-06 09:25:50 -06:00
2010-08-05 13:25:38 +01:00
2010-06-16 18:05:05 +02:00
2009-09-23 07:39:57 -07:00
2010-03-30 22:02:32 +09:00
2010-08-11 23:04:13 +09:30
2010-02-27 18:31:13 +01:00
2010-02-27 18:31:13 +01:00
2010-05-18 16:19:27 +10:00
2010-05-25 08:07:08 -07:00
2010-05-25 08:07:08 -07:00
2010-08-11 23:04:31 +09:30
2010-08-09 20:44:53 -07:00
2010-07-22 16:45:35 -07:00
2010-08-06 09:25:50 -06:00