Peter Xu b76b46902c mm/hugetlb: fix missing hugetlb_lock for resv uncharge
There is a recent report on UFFDIO_COPY over hugetlb:

https://lore.kernel.org/all/000000000000ee06de0616177560@google.com/

350:	lockdep_assert_held(&hugetlb_lock);

Should be an issue in hugetlb but triggered in an userfault context, where
it goes into the unlikely path where two threads modifying the resv map
together.  Mike has a fix in that path for resv uncharge but it looks like
the locking criteria was overlooked: hugetlb_cgroup_uncharge_folio_rsvd()
will update the cgroup pointer, so it requires to be called with the lock
held.

Link: https://lkml.kernel.org/r/20240417211836.2742593-3-peterx@redhat.com
Fixes: 79aa925bf239 ("hugetlb_cgroup: fix reservation accounting")
Signed-off-by: Peter Xu <peterx@redhat.com>
Reported-by: syzbot+4b8077a5fccc61c385a1@syzkaller.appspotmail.com
Reviewed-by: Mina Almasry <almasrymina@google.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-04-24 19:34:25 -07:00
..
2024-03-11 09:38:17 -07:00
2024-03-26 11:07:20 -07:00
2023-12-12 10:11:32 +01:00
2024-03-21 14:41:00 -07:00
2023-04-12 17:36:23 -07:00
2024-02-24 15:53:40 -08:00
2024-03-13 18:38:13 -04:00
2022-10-03 14:02:43 -07:00
2024-03-22 10:41:13 -07:00
2024-02-21 16:00:03 -08:00
2024-02-23 17:48:19 -08:00
2023-04-12 17:36:23 -07:00
2024-04-05 11:21:30 -07:00