Eric Dumazet
72b49dd116
netfilter: nftables: avoid overflows in nft_hash_buckets() ...
[ Upstream commit a54754ec9891830ba548e2010c889e3c8146e449 ]
Number of buckets being stored in 32bit variables, we have to
ensure that no overflows occur in nft_hash_buckets()
syzbot injected a size == 0x40000000 and reported:
UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:13
shift exponent 64 is too large for 64-bit type 'long unsigned int'
CPU: 1 PID: 29539 Comm: syz-executor.4 Not tainted 5.12.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:79 [inline]
dump_stack+0x141/0x1d7 lib/dump_stack.c:120
ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
__ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:327
__roundup_pow_of_two include/linux/log2.h:57 [inline]
nft_hash_buckets net/netfilter/nft_set_hash.c:411 [inline]
nft_hash_estimate.cold+0x19/0x1e net/netfilter/nft_set_hash.c:652
nft_select_set_ops net/netfilter/nf_tables_api.c:3586 [inline]
nf_tables_newset+0xe62/0x3110 net/netfilter/nf_tables_api.c:4322
nfnetlink_rcv_batch+0xa09/0x24b0 net/netfilter/nfnetlink.c:488
nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:612 [inline]
nfnetlink_rcv+0x3af/0x420 net/netfilter/nfnetlink.c:630
netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline]
netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1338
netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1927
sock_sendmsg_nosec net/socket.c:654 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:674
____sys_sendmsg+0x6e8/0x810 net/socket.c:2350
___sys_sendmsg+0xf3/0x170 net/socket.c:2404
__sys_sendmsg+0xe5/0x1b0 net/socket.c:2433
do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
Fixes: 0ed6389c483d ("netfilter: nf_tables: rename set implementations")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-05-19 10:13:09 +02:00
2021-04-07 15:00:08 +02:00
2021-01-17 14:16:55 +01:00
2021-04-07 15:00:08 +02:00
2020-10-31 12:26:30 -07:00
2021-04-14 08:41:59 +02:00
2021-05-19 10:12:53 +02:00
2021-01-27 11:55:07 +01:00
2020-10-15 12:33:24 -07:00
2021-05-19 10:12:53 +02:00
2020-09-05 15:57:05 -07:00
2021-04-14 08:42:07 +02:00
2020-10-12 15:29:27 +02:00
2021-05-19 10:12:57 +02:00
2021-01-23 16:04:01 +01:00
2021-03-30 14:32:01 +02:00
2020-08-23 17:36:59 -05:00
2021-04-14 08:42:07 +02:00
2021-05-19 10:13:08 +02:00
2021-04-14 08:42:02 +02:00
2021-04-21 13:00:53 +02:00
2021-05-14 09:50:46 +02:00
2021-05-19 10:12:54 +02:00
2021-03-07 12:34:05 +01:00
2021-02-13 13:55:02 +01:00
2021-03-17 17:06:11 +01:00
2020-08-27 07:55:59 -07:00
2021-02-10 09:29:14 +01:00
2021-05-19 10:12:55 +02:00
2021-04-14 08:42:13 +02:00
2021-03-17 17:06:11 +01:00
2021-04-14 08:42:09 +02:00
2021-04-14 08:42:08 +02:00
2021-05-19 10:13:09 +02:00
2021-03-17 17:06:15 +01:00
2020-10-09 20:22:32 -07:00
2020-08-23 17:36:59 -05:00
2021-05-14 09:50:44 +02:00
2021-05-11 14:47:34 +02:00
2021-05-14 09:50:38 +02:00
2020-08-23 17:36:59 -05:00
2021-03-07 12:34:07 +01:00
2021-05-07 11:04:31 +02:00
2021-04-14 08:42:09 +02:00
2020-11-12 09:18:06 +01:00
2020-11-20 10:04:58 -08:00
2021-02-17 11:02:28 +01:00
2021-05-19 10:12:57 +02:00
2021-05-19 10:13:06 +02:00
2021-05-19 10:13:08 +02:00
2021-05-19 10:13:06 +02:00
2021-02-07 15:37:12 +01:00
2021-05-19 10:12:52 +02:00
2021-02-23 15:53:23 +01:00
2020-10-15 18:42:13 -07:00
2021-05-14 09:50:41 +02:00
2020-10-02 19:11:11 -07:00
2021-05-14 09:50:00 +02:00
2020-12-02 17:26:36 -08:00
2021-05-19 10:13:06 +02:00
2021-04-21 13:00:51 +02:00
2020-10-03 00:02:13 -04:00
2020-09-30 18:01:26 -07:00
2020-10-05 18:40:01 -07:00
72b49dd116