Lin Ma 2def44d3ae
ASoC: rt5645: Fix errorenous cleanup order
There is a logic error when removing rt5645 device as the function
rt5645_i2c_remove() first cancel the &rt5645->jack_detect_work and
delete the &rt5645->btn_check_timer latter. However, since the timer
handler rt5645_btn_check_callback() will re-queue the jack_detect_work,
this cleanup order is buggy.

That is, once the del_timer_sync in rt5645_i2c_remove is concurrently
run with the rt5645_btn_check_callback, the canceled jack_detect_work
will be rescheduled again, leading to possible use-after-free.

This patch fix the issue by placing the del_timer_sync function before
the cancel_delayed_work_sync.

Signed-off-by: Lin Ma <linma@zju.edu.cn>
Link: https://lore.kernel.org/r/20220516092035.28283-1-linma@zju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
2022-05-16 12:58:42 +01:00
..
2021-04-20 17:25:51 +01:00
2022-04-05 10:29:12 +01:00
2022-05-04 15:31:20 +01:00
2021-03-31 18:00:38 +01:00
2022-05-04 15:30:32 +01:00
2022-05-09 19:04:36 +01:00
2022-04-26 15:13:40 +01:00
2022-05-04 15:30:32 +01:00
2018-04-26 12:44:15 +01:00
2021-10-02 01:31:58 +01:00
2019-06-12 13:52:26 +01:00
2020-05-07 13:18:04 +01:00
2019-07-26 13:10:09 +01:00
2022-05-04 15:30:32 +01:00
2022-01-28 15:59:20 +00:00
2021-12-06 10:04:05 +01:00
2021-12-06 10:04:05 +01:00
2018-06-01 12:05:30 +01:00
2020-07-20 15:34:29 +01:00
2020-10-02 21:05:29 +01:00
2022-05-09 19:04:36 +01:00
2022-05-04 15:30:32 +01:00
2022-03-21 16:19:21 +01:00