iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/hwtracing/coresight
History
Linu Cherian bd2767ec3d coresight: Fix run time warnings while reusing ETR buffer 
Fix the below warning by avoding calls to tmc_etr_enable_hw,
if we are reusing the ETR buffer for multiple sources in sysfs mode.

echo 1 > /sys/bus/coresight/devices/tmc_etr0/enable_sink
echo 1 > /sys/bus/coresight/devices/ete1/enable_source
echo 1 > /sys/bus/coresight/devices/ete2/enable_source
[  166.918290] ------------[ cut here ]------------
[  166.922905] WARNING: CPU: 4 PID: 2288 at
drivers/hwtracing/coresight/coresight-tmc-etr.c:1037
tmc_etr_enable_hw+0xb0/0xc8
[  166.933862] Modules linked in:
[  166.936911] CPU: 4 PID: 2288 Comm: bash Not tainted 6.5.0-rc7 #132
[  166.943084] Hardware name: Marvell CN106XX board (DT)
[  166.948127] pstate: 834000c9 (Nzcv daIF +PAN -UAO +TCO +DIT -SSBS
BTYPE=--)
[  166.955083] pc : tmc_etr_enable_hw+0xb0/0xc8
[  166.959345] lr : tmc_enable_etr_sink+0x134/0x210
snip..
  167.038545] Call trace:
[  167.040982]  tmc_etr_enable_hw+0xb0/0xc8
[  167.044897]  tmc_enable_etr_sink+0x134/0x210
[  167.049160]  coresight_enable_path+0x160/0x278
[  167.053596]  coresight_enable+0xd4/0x298
[  167.057510]  enable_source_store+0x54/0xa0
[  167.061598]  dev_attr_store+0x20/0x40
[  167.065254]  sysfs_kf_write+0x4c/0x68
[  167.068909]  kernfs_fop_write_iter+0x128/0x200
[  167.073345]  vfs_write+0x1ac/0x2f8
[  167.076739]  ksys_write+0x74/0x110
[  167.080132]  __arm64_sys_write+0x24/0x38
[  167.084045]  invoke_syscall.constprop.0+0x58/0xf8
[  167.088744]  do_el0_svc+0x60/0x160
[  167.092137]  el0_svc+0x40/0x170
[  167.095273]  el0t_64_sync_handler+0x100/0x130
[  167.099621]  el0t_64_sync+0x190/0x198
[  167.103277] ---[ end trace 0000000000000000 ]---
-bash: echo: write error: Device or resource busy

Fixes: 296b01fd106e ("coresight: Refactor out buffer allocation function for ETR")
Signed-off-by: Linu Cherian <lcherian@marvell.com>
Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230823042948.12879-1-lcherian@marvell.com
2023-09-15 16:09:18 +01:00
..
coresight-catu.c
coresight: Enable and disable helper devices adjacent to the path
2023-06-05 15:46:47 +01:00
coresight-catu.h
coresight: Make new csdev_access offsets unsigned
2022-08-31 10:56:36 -06:00
coresight-cfg-afdo.c
coresight: config: Add preloaded configurations
2021-08-18 22:33:28 +02:00
coresight-cfg-preload.c
coresight: configuration: Update API to introduce load owner concept
2021-11-26 11:27:21 -07:00
coresight-cfg-preload.h
coresight: config: Add preloaded configurations
2021-08-18 22:33:28 +02:00
coresight-config.c
coresight: config: Add configuration and feature generic functions
2021-08-18 22:33:27 +02:00
coresight-config.h
coresight: syscfg: Update load and unload operations
2022-06-29 09:35:58 -06:00
coresight-core.c
hwtracing: coresight: Explicitly include correct DT includes
2023-07-26 16:46:24 +01:00
coresight-cpu-debug.c
coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier
2022-05-09 16:03:24 +01:00
coresight-cti-core.c
coresight: Fix all W=1 build warnings
2023-07-26 18:01:52 +01:00
coresight-cti-platform.c
coresight: cti: Reduce scope for the variable 'cs_fwnode' in cti_plat_create_connection()
2021-02-04 17:00:32 +01:00
coresight-cti-sysfs.c
coresight: Fix CTI module refcount leak by making it a helper device
2023-06-05 15:46:47 +01:00
coresight-cti.h
coresight: Fix CTI module refcount leak by making it a helper device
2023-06-05 15:46:47 +01:00
coresight-dummy.c
coresight: dummy: simplify the code with module_platform_driver
2023-08-04 14:17:30 +01:00
coresight-etb10.c
coresight: Make refcount a property of the connection
2023-06-05 15:46:46 +01:00
coresight-etm3x-core.c
coresight: Use enum type for cs_mode wherever possible
2023-06-05 15:46:45 +01:00
coresight-etm3x-sysfs.c
coresight: etm3x: Update ETM3 driver to use Trace ID API
2023-01-19 10:16:47 +00:00
coresight-etm4x-cfg.c
coresight: Fix all W=1 build warnings
2023-07-26 18:01:52 +01:00
coresight-etm4x-cfg.h
coresight: config: Add preloaded configurations
2021-08-18 22:33:28 +02:00
coresight-etm4x-core.c
coresight: etm4x: Ensure valid drvdata and clock before clk_put()
2023-08-17 11:49:21 +01:00
coresight-etm4x-sysfs.c
coresight: etm4x: Fix missing trctraceidr file in sysfs
2023-06-06 10:39:15 +01:00
coresight-etm4x.h
coresight: etm4x: Change etm4_platform_driver driver for MMIO devices
2023-07-26 16:46:25 +01:00
coresight-etm-cp14.c
coresight: Moving framework and drivers to SPDX identifier
2018-05-14 16:19:59 +02:00
coresight-etm-perf.c
coresight: Enable and disable helper devices adjacent to the path
2023-06-05 15:46:47 +01:00
coresight-etm-perf.h
coresight: perf: Output trace id only once
2023-01-24 10:41:46 +00:00
coresight-etm.h
coresight: etmX.X: stm: Remove trace_id() callback
2023-01-19 10:16:47 +00:00
coresight-funnel.c
coresight: Make refcount a property of the connection
2023-06-05 15:46:46 +01:00
coresight-platform.c
coresight: Fix memory leak in acpi_buffer->pointer
2023-08-18 11:23:47 +01:00
coresight-priv.h
coresight: etm4x: Match all ETM4 instances based on DEVARCH and DEVTYPE
2023-06-07 12:07:10 +01:00
coresight-replicator.c
coresight: Make refcount a property of the connection
2023-06-05 15:46:46 +01:00
coresight-self-hosted-trace.h
coresight: trbe: Prohibit trace before disabling TRBE
2021-10-27 11:45:33 -06:00
coresight-stm.c
coresight: Use enum type for cs_mode wherever possible
2023-06-05 15:46:45 +01:00
coresight-syscfg-configfs.c
coresight: configfs: Allow configfs to activate configuration
2021-11-26 11:34:27 -07:00
coresight-syscfg-configfs.h
coresight: configfs: Allow configfs to activate configuration
2021-11-26 11:34:27 -07:00
coresight-syscfg.c
coresight: syscfg: Update load and unload operations
2022-06-29 09:35:58 -06:00
coresight-syscfg.h
coresight: syscfg: Update load and unload operations
2022-06-29 09:35:58 -06:00
coresight-sysfs.c
coresight: Fix CTI module refcount leak by making it a helper device
2023-06-05 15:46:47 +01:00
coresight-tmc-core.c
coresight: tmc: Don't enable TMC when it's not ready.
2023-01-30 11:45:32 +00:00
coresight-tmc-etf.c
coresight: tmc: Explicit type conversions to prevent integer overflow
2023-08-04 10:52:32 +01:00
coresight-tmc-etr.c
coresight: Fix run time warnings while reusing ETR buffer
2023-09-15 16:09:18 +01:00
coresight-tmc.h
coresight: tmc: Explicit type conversions to prevent integer overflow
2023-08-04 10:52:32 +01:00
coresight-tpda.c
coresight: Make refcount a property of the connection
2023-06-05 15:46:46 +01:00
coresight-tpda.h
Coresight: Add TPDA link driver
2023-01-20 11:39:03 +00:00
coresight-tpdm.c
coresight: Use enum type for cs_mode wherever possible
2023-06-05 15:46:45 +01:00
coresight-tpdm.h
coresight-tpdm: Add integration test support
2023-01-20 11:39:03 +00:00
coresight-tpiu.c
coresight: Make refcount a property of the connection
2023-06-05 15:46:46 +01:00
coresight-trace-id.c
coresight: trace-id: Add debug & test macros to Trace ID allocation
2023-01-19 10:16:47 +00:00
coresight-trace-id.h
coresight: trace-id: Add API to dynamically assign Trace ID values
2023-01-19 10:16:46 +00:00
coresight-trbe.c
coresight: trbe: Fix TRBE potential sleep in atomic context
2023-08-18 16:42:26 +01:00
coresight-trbe.h
coresight: trbe: Directly use ID_AA64DFR0_EL1_TraceBuffer_IMP
2023-08-02 12:53:28 +01:00
Kconfig
Coresight: Add coresight dummy driver
2023-06-15 08:50:23 +01:00
Makefile
Coresight: Add coresight dummy driver
2023-06-15 08:50:23 +01:00
ultrasoc-smb.c
coresight: Make refcount a property of the connection
2023-06-05 15:46:46 +01:00
ultrasoc-smb.h
coresight: Use enum type for cs_mode wherever possible
2023-06-05 15:46:45 +01:00