Eric Sandeen 2be2f98b96 ext4: make grpinfo slab cache names static
commit 2892c15ddda6a76dc10b7499e56c0f3b892e5a69 upstream.

In 2.6.37 I was running into oopses with repeated module
loads & unloads.  I tracked this down to:

fb1813f4 ext4: use dedicated slab caches for group_info structures

(this was in addition to the features advert unload problem)

The kstrdup & subsequent kfree of the cache name was causing
a double free.  In slub, at least, if I read it right it allocates
& frees the name itself, slab seems to do something different...
so in slub I think we were leaking -our- cachep->name, and double
freeing the one allocated by slub.

After getting lost in slab/slub/slob a bit, I just looked at other
sized-caches that get allocated.  jbd2, biovec, sgpool all do it
more or less the way jbd2 does.  Below patch follows the jbd2
method of dynamically allocating a cache at mount time from
a list of static names.

(This might also possibly fix a race creating the caches with
parallel mounts running).

[Folded in a fix from Dan Carpenter which fixed an off-by-one error in
the original patch]

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-17 15:14:21 -08:00
..
2010-10-29 04:16:38 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:17:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-12-20 09:09:57 -08:00
2010-10-29 04:16:31 -04:00
2010-10-29 04:16:28 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:28 -04:00
2010-10-29 04:16:28 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:31 -04:00
2010-10-25 21:26:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-11-30 16:39:27 +01:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:31 -04:00
2010-10-29 04:16:31 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-11-08 14:29:39 -08:00
2011-02-17 15:14:16 -08:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:31 -04:00
2010-10-29 04:17:08 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:36 -04:00
2010-10-29 04:16:13 -04:00
2010-10-29 04:16:13 -04:00
2010-10-25 21:26:11 -04:00
2010-10-29 04:16:33 -04:00
2010-10-29 04:16:28 -04:00
2010-10-15 15:53:27 +02:00
2010-08-18 08:35:46 -04:00
2010-10-29 05:49:13 -04:00
2010-10-28 09:44:56 -07:00
2010-10-29 04:16:33 -04:00
2010-10-28 09:44:56 -07:00
2010-10-29 04:14:56 -04:00
2010-08-18 08:35:48 -04:00
2010-08-09 16:48:44 -04:00
2010-10-29 04:17:03 -04:00
2010-08-09 16:47:43 -04:00