Andrey Ryabinin
ec8d0ee880
stackdepot: respect __GFP_NOLOCKDEP allocation flag
...
commit 6fe60465e1d53ea321ee909be26d97529e8f746c upstream.
If stack_depot_save_flags() allocates memory it always drops
__GFP_NOLOCKDEP flag. So when KASAN tries to track __GFP_NOLOCKDEP
allocation we may end up with lockdep splat like bellow:
======================================================
WARNING: possible circular locking dependency detected
6.9.0-rc3+ #49 Not tainted
------------------------------------------------------
kswapd0/149 is trying to acquire lock:
ffff88811346a920
(&xfs_nondir_ilock_class){++++}-{4:4}, at: xfs_reclaim_inode+0x3ac/0x590
[xfs]
but task is already holding lock:
ffffffff8bb33100 (fs_reclaim){+.+.}-{0:0}, at:
balance_pgdat+0x5d9/0xad0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (fs_reclaim){+.+.}-{0:0}:
__lock_acquire+0x7da/0x1030
lock_acquire+0x15d/0x400
fs_reclaim_acquire+0xb5/0x100
prepare_alloc_pages.constprop.0+0xc5/0x230
__alloc_pages+0x12a/0x3f0
alloc_pages_mpol+0x175/0x340
stack_depot_save_flags+0x4c5/0x510
kasan_save_stack+0x30/0x40
kasan_save_track+0x10/0x30
__kasan_slab_alloc+0x83/0x90
kmem_cache_alloc+0x15e/0x4a0
__alloc_object+0x35/0x370
__create_object+0x22/0x90
__kmalloc_node_track_caller+0x477/0x5b0
krealloc+0x5f/0x110
xfs_iext_insert_raw+0x4b2/0x6e0 [xfs]
xfs_iext_insert+0x2e/0x130 [xfs]
xfs_iread_bmbt_block+0x1a9/0x4d0 [xfs]
xfs_btree_visit_block+0xfb/0x290 [xfs]
xfs_btree_visit_blocks+0x215/0x2c0 [xfs]
xfs_iread_extents+0x1a2/0x2e0 [xfs]
xfs_buffered_write_iomap_begin+0x376/0x10a0 [xfs]
iomap_iter+0x1d1/0x2d0
iomap_file_buffered_write+0x120/0x1a0
xfs_file_buffered_write+0x128/0x4b0 [xfs]
vfs_write+0x675/0x890
ksys_write+0xc3/0x160
do_syscall_64+0x94/0x170
entry_SYSCALL_64_after_hwframe+0x71/0x79
Always preserve __GFP_NOLOCKDEP to fix this.
Link: https://lkml.kernel.org/r/20240418141133.22950-1-ryabinin.a.a@gmail.com
Fixes: cd11016e5f52 ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB")
Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Reported-by: Xiubo Li <xiubli@redhat.com>
Closes: https://lore.kernel.org/all/a0caa289-ca02-48eb-9bf2-d86fd47b71f4@redhat.com/
Reported-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Closes: https://lore.kernel.org/all/f9ff999a-e170-b66b-7caf-293f2b147ac2@opensource.wdc.com/
Suggested-by: Dave Chinner <david@fromorbit.com>
Tested-by: Xiubo Li <xiubli@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-05-02 16:24:49 +02:00
..
2020-08-10 01:32:59 +09:00
2022-09-05 10:30:03 +02:00
2023-05-24 17:36:41 +01:00
2022-12-31 13:14:02 +01:00
2024-01-25 14:52:34 -08:00
2022-08-17 14:24:03 +02:00
2022-04-13 20:59:21 +02:00
2020-12-15 22:46:19 -08:00
2021-09-08 11:50:26 -07:00
2024-02-23 08:55:11 +01:00
2021-07-08 11:48:20 -07:00
2022-04-08 14:23:56 +02:00
2021-07-08 11:48:20 -07:00
2022-12-02 17:41:08 +01:00
2021-11-18 19:16:17 +01:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2021-09-24 16:13:35 -07:00
2021-07-01 11:06:05 -07:00
2021-05-02 00:43:35 +09:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2021-07-08 11:48:20 -07:00
2022-06-06 08:43:37 +02:00
2019-05-30 11:26:32 -07:00
2021-05-26 13:20:50 +02:00
2021-05-06 19:24:12 -07:00
2020-10-16 13:25:14 -06:00
2021-08-13 10:27:50 +02:00
2019-05-21 10:50:45 +02:00
2021-09-14 13:23:22 -07:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-04-01 09:54:37 +01:00
2019-05-24 17:27:11 +02:00
2021-07-08 11:48:22 -07:00
2018-11-30 07:22:05 +01:00
2020-08-20 15:45:14 -04:00
2023-08-30 16:18:18 +02:00
2024-03-26 18:21:15 -04:00
2021-05-05 16:07:40 +02:00
2019-05-24 17:39:02 +02:00
2023-06-14 11:13:04 +02:00
2021-02-05 23:28:29 +01:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:12 -07:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2020-11-02 12:14:19 -08:00
2021-06-05 08:58:12 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2021-08-19 09:02:55 +09:00
2021-06-22 13:56:43 +02:00
2024-03-01 13:21:54 +01:00
2021-07-01 11:06:05 -07:00
2020-01-31 10:30:40 -08:00
2021-07-01 11:06:06 -07:00
2021-05-06 19:24:12 -07:00
2021-07-01 11:06:06 -07:00
2021-11-18 19:16:17 +01:00
2021-07-01 11:06:05 -07:00
2020-07-31 11:49:08 +02:00
2021-08-13 14:09:32 -10:00
2021-07-08 11:48:20 -07:00
2020-11-20 14:45:33 +11:00
2021-09-08 11:50:26 -07:00
2022-10-26 12:35:08 +02:00
2020-10-16 11:11:20 -07:00
2021-04-16 16:10:37 -07:00
2023-12-08 08:48:02 +01:00
2020-12-15 22:46:19 -08:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2021-05-06 19:24:12 -07:00
2020-06-04 19:06:25 -07:00
2018-12-29 11:36:44 -08:00
2021-05-06 19:24:12 -07:00
2019-10-14 15:04:00 -07:00
2020-11-18 14:15:17 -06:00
2022-05-09 09:14:30 +02:00
2019-05-13 11:07:33 +02:00
2024-01-25 14:52:30 -08:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2022-08-17 14:22:51 +02:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2021-08-19 09:02:55 +09:00
2022-06-22 14:22:03 +02:00
2024-04-10 16:18:49 +02:00
2021-09-24 16:13:34 -07:00
2021-07-20 13:49:44 -07:00
2021-11-12 15:05:49 +01:00
2020-09-28 12:14:08 +01:00
2022-04-13 20:59:27 +02:00
2021-07-08 11:48:20 -07:00
2019-06-19 17:09:08 +02:00
2021-04-10 11:09:41 +02:00
2023-09-23 11:09:59 +02:00
2021-07-02 12:08:10 -07:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2021-08-13 18:37:38 +02:00
2022-08-25 11:40:40 +02:00
2021-07-08 11:48:20 -07:00
2022-06-09 10:23:31 +02:00
2019-06-05 17:37:06 +02:00
2021-06-22 16:42:08 +02:00
2023-02-01 08:27:19 +01:00
2022-04-13 20:58:59 +02:00
2021-02-17 17:31:06 -06:00
2021-04-16 16:10:37 -07:00
2019-05-24 17:39:02 +02:00
2022-06-22 14:22:03 +02:00
2018-10-16 13:45:44 +02:00
2022-06-22 14:22:03 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2019-05-24 17:39:02 +02:00
2019-05-21 10:50:45 +02:00
2023-02-01 08:27:26 +01:00
2021-11-25 09:48:45 +01:00
2022-06-14 18:36:24 +02:00
2022-12-31 13:14:03 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2022-10-26 12:34:49 +02:00
2021-09-17 13:52:17 +01:00
2021-04-16 16:10:37 -07:00
2021-07-01 11:06:05 -07:00
2024-04-10 16:18:34 +02:00
2021-05-06 19:24:12 -07:00
2019-05-21 10:50:45 +02:00
2022-06-06 08:43:36 +02:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2023-08-30 16:18:18 +02:00
2022-05-30 09:29:10 +02:00
2022-08-31 17:16:43 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2021-09-03 10:08:28 -07:00
2021-07-08 11:48:20 -07:00
2021-08-24 19:52:40 -03:00
2019-08-08 07:45:01 -06:00
2022-05-30 09:28:59 +02:00
2019-09-24 15:54:09 -07:00
2022-05-30 09:29:15 +02:00
2021-06-29 10:53:46 -07:00
2022-08-17 14:24:08 +02:00
2021-07-08 11:48:20 -07:00
2024-05-02 16:24:49 +02:00
2019-05-30 11:26:32 -07:00
2021-11-21 13:44:12 +01:00
2021-08-30 07:50:56 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2021-06-18 11:43:09 +02:00
2021-08-13 10:27:49 +02:00
2021-07-08 11:48:20 -07:00
2020-08-12 10:58:00 -07:00
2024-03-26 18:21:18 -04:00
2022-08-17 14:23:23 +02:00
2019-05-21 10:50:45 +02:00
2023-07-23 13:47:25 +02:00
2021-01-18 11:03:26 +01:00
2020-12-15 22:46:16 -08:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2021-07-01 11:06:03 -07:00
2022-08-17 14:23:43 +02:00
2024-01-25 14:52:30 -08:00
2021-09-03 09:58:15 -07:00
2024-04-10 16:18:35 +02:00
2022-04-08 14:23:54 +02:00
2020-05-08 18:18:12 +01:00
2021-06-25 11:31:03 -06:00
2022-04-08 14:24:01 +02:00
2018-10-16 13:45:44 +02:00
2023-10-19 23:05:33 +02:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2022-12-31 13:14:33 +01:00
2021-09-08 12:55:35 -07:00
2021-03-24 15:16:09 -07:00
2023-09-19 12:23:01 +02:00
2021-09-08 11:50:26 -07:00
2021-08-22 00:21:36 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2021-07-01 11:06:05 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2022-04-13 20:59:27 +02:00
2019-10-16 14:56:21 +02:00
2021-09-03 09:58:14 -07:00
2022-04-08 14:24:09 +02:00
2021-07-19 11:39:28 +02:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2023-07-23 13:46:56 +02:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2023-02-01 08:27:22 +01:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2023-02-25 12:06:44 +01:00
2020-03-23 17:01:47 +01:00
2024-01-05 15:13:35 +01:00
2022-04-08 14:24:09 +02:00
2020-08-12 10:58:00 -07:00