Xiyu Yang f35d12971b net/x25: Fix x25_neigh refcnt leak when receiving frame
x25_lapb_receive_frame() invokes x25_get_neigh(), which returns a
reference of the specified x25_neigh object to "nb" with increased
refcnt.

When x25_lapb_receive_frame() returns, local variable "nb" becomes
invalid, so the refcount should be decreased to keep refcount balanced.

The reference counting issue happens in one path of
x25_lapb_receive_frame(). When pskb_may_pull() returns false, the
function forgets to decrease the refcnt increased by x25_get_neigh(),
causing a refcnt leak.

Fix this issue by calling x25_neigh_put() when pskb_may_pull() returns
false.

Fixes: cb101ed2c3c7 ("x25: Handle undersized/fragmented skbs")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-04-23 15:39:39 -07:00
..
2020-04-03 13:12:26 -07:00
2020-03-23 21:57:44 -07:00
2020-01-27 11:09:31 +01:00
2019-09-26 08:56:17 +02:00
2019-12-09 10:36:44 -08:00
2019-11-26 14:40:13 -08:00
2020-04-07 13:51:39 -07:00
2020-04-08 14:34:02 -07:00
2020-01-24 13:44:07 +01:00
2020-03-30 12:18:49 -07:00