Eric Dumazet
de5e2ddf9b
ipmi: proper spinlock initialization ...
Unloading ipmi module can trigger following error. (if
CONFIG_DEBUG_SPINLOCK=y)
[ 9633.779590] BUG: spinlock bad magic on CPU#1, rmmod/7170
[ 9633.779606] lock: f41f5414, .magic: 00000000, .owner:
<none>/-1, .owner_cpu: 0
[ 9633.779626] Pid: 7170, comm: rmmod Not tainted
2.6.36-rc7-11474-gb71eb1e-dirty #328
[ 9633.779644] Call Trace:
[ 9633.779657] [<c13921cc>] ? printk+0x18/0x1c
[ 9633.779672] [<c11a1f33>] spin_bug+0xa3/0xf0
[ 9633.779685] [<c11a1ffd>] do_raw_spin_lock+0x7d/0x160
[ 9633.779702] [<c1131537>] ? release_sysfs_dirent+0x47/0xb0
[ 9633.779718] [<c1131b78>] ? sysfs_addrm_finish+0xa8/0xd0
[ 9633.779734] [<c1394bac>] _raw_spin_lock_irqsave+0xc/0x20
[ 9633.779752] [<f99d93da>] cleanup_one_si+0x6a/0x200 [ipmi_si]
[ 9633.779768] [<c11305b2>] ? sysfs_hash_and_remove+0x72/0x80
[ 9633.779786] [<f99dcf26>] ipmi_pnp_remove+0xd/0xf [ipmi_si]
[ 9633.779802] [<c11f622b>] pnp_device_remove+0x1b/0x40
Fix this by initializing spinlocks in a smi_info_alloc() helper function,
right after memory allocation and clearing.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David Miller <davem@davemloft.net>
Cc: Yinghai Lu <yinghai@kernel.org>
Acked-by: Corey Minyard <cminyard@mvista.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-10-26 16:52:04 -07:00
2010-10-22 10:52:56 -07:00
2010-10-08 10:02:27 +01:00
2010-10-24 13:41:39 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 08:19:14 -07:00
2010-10-25 08:19:14 -07:00
2010-10-23 11:47:02 -07:00
2010-10-05 15:01:10 +02:00
2010-10-26 16:52:04 -07:00
2010-10-22 11:44:47 -04:00
2010-09-28 23:30:38 -04:00
2010-10-24 12:44:34 -07:00
2010-09-17 20:08:21 -07:00
2010-10-22 10:52:56 -07:00
2010-10-26 10:13:48 -07:00
2010-10-25 08:05:29 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 08:19:14 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 07:59:01 -07:00
2010-10-25 14:44:59 -07:00
2010-10-25 07:51:49 -07:00
2010-10-24 13:41:39 -07:00
2010-10-22 10:52:56 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 10:59:31 -07:00
2010-10-24 13:41:39 -07:00
2010-10-07 14:02:12 -04:00
2010-10-15 15:53:27 +02:00
2010-10-24 13:41:39 -07:00
2010-10-22 17:07:18 -07:00
2010-10-25 07:59:01 -07:00
2010-10-05 15:01:10 +02:00
2010-10-22 17:34:15 -07:00
2010-10-25 08:32:05 -07:00
2010-10-26 16:52:04 -07:00
2010-10-26 11:32:49 +02:00
2010-10-25 10:59:31 -07:00
2010-10-25 18:41:32 -07:00
2010-10-21 11:10:11 -06:00
2010-10-22 10:52:56 -07:00
2010-10-18 11:03:14 +02:00
2010-10-24 13:41:39 -07:00
2010-10-24 13:41:39 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 08:28:13 -07:00
2010-10-24 13:41:39 -07:00
2010-10-26 10:14:23 -07:00
2010-10-07 13:44:30 -07:00
2010-10-26 11:32:49 +02:00
2010-10-25 16:10:21 +02:00
2010-10-25 08:19:14 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 13:46:56 -07:00
2010-10-18 21:32:58 +09:00
2010-10-25 18:42:06 -07:00
2010-09-29 17:20:23 +02:00
2010-10-25 08:32:05 -07:00
2010-10-22 10:52:56 -07:00
2010-10-24 13:41:39 -07:00
2010-10-25 13:46:56 -07:00
2010-10-25 14:03:45 +01:00
2010-10-23 11:47:02 -07:00
2010-10-26 10:02:39 -07:00
2010-10-07 14:08:54 +01:00
2010-10-25 13:46:56 -07:00
2010-10-22 10:52:56 -07:00
2010-10-22 09:43:25 +02:00
2010-10-25 08:05:29 -07:00
de5e2ddf9b