Bob Peterson c279706918 gfs2: assign rgrp glock before compute_bitstructs
commit 428f651cb80b227af47fc302e4931791f2fb4741 upstream.

Before this patch, function read_rindex_entry called compute_bitstructs
before it allocated a glock for the rgrp. But if compute_bitstructs found
a problem with the rgrp, it called gfs2_consist_rgrpd, and that called
gfs2_dump_glock for rgd->rd_gl which had not yet been assigned.

read_rindex_entry
   compute_bitstructs
      gfs2_consist_rgrpd
         gfs2_dump_glock <---------rgd->rd_gl was not set.

This patch changes read_rindex_entry so it assigns an rgrp glock before
calling compute_bitstructs so gfs2_dump_glock does not reference an
unassigned pointer. If an error is discovered, the glock must also be
put, so a new goto and label were added.

Reported-by: syzbot+c6fd14145e2f62ca0784@syzkaller.appspotmail.com
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-27 13:14:10 +02:00
..
2020-11-10 10:23:59 +01:00
2020-01-29 10:24:34 +01:00
2019-08-06 18:29:38 +02:00
2022-01-27 08:47:40 +01:00
2022-04-20 09:06:43 +02:00
2019-03-13 14:04:52 -07:00
2018-12-21 14:11:31 +01:00
2020-04-02 17:20:27 +02:00
2018-02-17 13:21:15 +01:00
2021-12-14 10:04:48 +01:00
2017-06-14 15:06:01 +02:00