iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Eric Dumazet f8bc4b708b xfrm: fix a data-race in xfrm_gen_index() 
commit 3e4bc23926b83c3c67e5f61ae8571602754131a6 upstream.

xfrm_gen_index() mutual exclusion uses net->xfrm.xfrm_policy_lock.

This means we must use a per-netns idx_generator variable,
instead of a static one.
Alternative would be to use an atomic variable.

syzbot reported:

BUG: KCSAN: data-race in xfrm_sk_policy_insert / xfrm_sk_policy_insert

write to 0xffffffff87005938 of 4 bytes by task 29466 on cpu 0:
xfrm_gen_index net/xfrm/xfrm_policy.c:1385 [inline]
xfrm_sk_policy_insert+0x262/0x640 net/xfrm/xfrm_policy.c:2347
xfrm_user_policy+0x413/0x540 net/xfrm/xfrm_state.c:2639
do_ipv6_setsockopt+0x1317/0x2ce0 net/ipv6/ipv6_sockglue.c:943
ipv6_setsockopt+0x57/0x130 net/ipv6/ipv6_sockglue.c:1012
rawv6_setsockopt+0x21e/0x410 net/ipv6/raw.c:1054
sock_common_setsockopt+0x61/0x70 net/core/sock.c:3697
__sys_setsockopt+0x1c9/0x230 net/socket.c:2263
__do_sys_setsockopt net/socket.c:2274 [inline]
__se_sys_setsockopt net/socket.c:2271 [inline]
__x64_sys_setsockopt+0x66/0x80 net/socket.c:2271
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

read to 0xffffffff87005938 of 4 bytes by task 29460 on cpu 1:
xfrm_sk_policy_insert+0x13e/0x640
xfrm_user_policy+0x413/0x540 net/xfrm/xfrm_state.c:2639
do_ipv6_setsockopt+0x1317/0x2ce0 net/ipv6/ipv6_sockglue.c:943
ipv6_setsockopt+0x57/0x130 net/ipv6/ipv6_sockglue.c:1012
rawv6_setsockopt+0x21e/0x410 net/ipv6/raw.c:1054
sock_common_setsockopt+0x61/0x70 net/core/sock.c:3697
__sys_setsockopt+0x1c9/0x230 net/socket.c:2263
__do_sys_setsockopt net/socket.c:2274 [inline]
__se_sys_setsockopt net/socket.c:2271 [inline]
__x64_sys_setsockopt+0x66/0x80 net/socket.c:2271
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

value changed: 0x00006ad8 -> 0x00006b18

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 29460 Comm: syz-executor.1 Not tainted 6.5.0-rc5-syzkaller-00243-g9106536c1aa3 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023

Fixes: 1121994c803f ("netns xfrm: policy insertion in netns")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-25 11:58:56 +02:00
..
6lowpan
…
9p
9p: virtio: make sure 'offs' is initialized in zc_request
2023-09-19 12:22:27 +02:00
802
mrp: introduce active flags to prevent UAF when applicant uninit
2022-12-31 13:14:42 +01:00
8021q
vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()
2023-05-24 17:36:52 +01:00
appletalk
…
atm
atm: hide unused procfs functions
2023-06-09 10:32:26 +02:00
ax25
net: ax25: Fix deadlock caused by skb_recv_datagram in ax25_recvmsg
2022-06-22 14:22:01 +02:00
batman-adv
batman-adv: Hold rtnl lock during MTU update via netlink
2023-08-30 16:18:18 +02:00
bluetooth
Bluetooth: avoid memcmp() out of bounds warning
2023-10-25 11:58:55 +02:00
bpf
bpf: Move skb->len == 0 checks into __bpf_redirect
2022-12-31 13:14:11 +01:00
bpfilter
…
bridge
net: bridge: use DEV_STATS_INC()
2023-10-06 13:18:07 +02:00
caif
net: caif: Fix use-after-free in cfusbl_device_notify()
2023-03-17 08:48:54 +01:00
can
can: raw: add missing refcount for memory leak fix
2023-08-30 16:18:20 +02:00
ceph
libceph: use kernel_connect()
2023-10-19 23:05:36 +02:00
core
net: fix possible store tearing in neigh_periodic_work()
2023-10-10 21:59:07 +02:00
dcb
net: dcb: choose correct policy to parse DCB_ATTR_BCN
2023-08-11 15:13:53 +02:00
dccp
dccp: fix dccp_v4_err()/dccp_v6_err() again
2023-10-06 13:18:06 +02:00
dns_resolver
…
dsa
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
2023-07-23 13:47:30 +02:00
ethernet
…
ethtool
ethtool: Fix uninitialized number of lanes
2023-05-17 11:50:18 +02:00
hsr
hsr: Fix uninit-value access in fill_frame_info()
2023-09-19 12:23:03 +02:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-11-03 23:59:14 +09:00
ife
…
ipv4
tcp: check mptcp-level constraints for backlog coalescing
2023-10-25 11:58:55 +02:00
ipv6
net: release reference to inet6_dev pointer
2023-10-19 23:05:35 +02:00
iucv
net/iucv: Fix size of interrupt data
2023-03-22 13:31:28 +01:00
kcm
kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().
2023-09-19 12:23:04 +02:00
key
net: af_key: fix sadb_x_filter validation
2023-08-26 14:23:32 +02:00
l2tp
ipv4, ipv6: Fix handling of transhdrlen in __ip{,6}_append_data()
2023-10-10 21:59:07 +02:00
l3mdev
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-27 14:38:53 +02:00
lapb
…
llc
llc: Don't drop packet from non-root netns.
2023-07-27 08:47:02 +02:00
mac80211
wifi: mac80211: check S1G action frame size
2023-09-23 11:09:56 +02:00
mac802154
mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()
2022-12-14 11:37:25 +01:00
mctp
net: mctp: purge receive queues on sk destruction
2023-02-06 07:59:02 +01:00
mpls
net: mpls: fix stale pointer if allocation fails during device rename
2023-02-22 12:57:09 +01:00
mptcp
mptcp: consolidate fallback and non fallback state machine
2023-07-05 18:25:04 +01:00
ncsi
ncsi: Propagate carrier gain/loss events to the NCSI controller
2023-10-06 13:18:18 +02:00
netfilter
netfilter: nft_payload: fix wrong mac header matching
2023-10-25 11:58:56 +02:00
netlabel
netlabel: fix shift wrapping bug in netlbl_catmap_setlong()
2023-09-19 12:22:29 +02:00
netlink
netlink: Add __sock_i_ino() for __netlink_diag_dump().
2023-07-23 13:46:56 +02:00
netrom
netrom: Deny concurrent connect().
2023-09-19 12:22:35 +02:00
nfc
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
2023-10-25 11:58:55 +02:00
nsh
net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()
2023-05-24 17:36:51 +01:00
openvswitch
net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()
2023-02-22 12:57:09 +01:00
packet
net/packet: annotate data-races around tp->status
2023-08-16 18:22:01 +02:00
phonet
phonet: refcount leak in pep_sock_accep
2022-01-11 15:35:16 +01:00
psample
…
qrtr
net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume()
2023-04-20 12:13:53 +02:00
rds
net: prevent address rewrite in kernel_bind()
2023-10-19 23:05:33 +02:00
rfkill
rfkill: make new event layout opt-in
2022-04-08 14:23:00 +02:00
rose
net/rose: Fix to not accept on connected socket
2023-02-22 12:57:02 +01:00
rxrpc
rxrpc: Fix hard call timeout units
2023-05-17 11:50:17 +02:00
sched
net/sched: Retire rsvp classifier
2023-09-23 11:10:03 +02:00
sctp
sctp: update hb timer immediately after users change hb_interval
2023-10-10 21:59:08 +02:00
smc
net/smc: Fix pos miscalculation in statistics
2023-10-19 23:05:34 +02:00
strparser
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-18 19:17:11 +01:00
sunrpc
Revert "SUNRPC dont update timeout value on connection reset"
2023-10-06 13:18:22 +02:00
switchdev
…
tipc
tipc: fix a potential deadlock on &tx->lock
2023-10-10 21:59:08 +02:00
tls
net/tls: do not free tls_rec on async operation in bpf_exec_tx_verdict()
2023-09-19 12:23:04 +02:00
unix
af_unix: Fix data-race around unix_tot_inflight.
2023-09-19 12:22:59 +02:00
vmw_vsock
vsock: avoid to close connected socket after the timeout
2023-05-24 17:36:49 +01:00
wireless
wifi: nl80211/cfg80211: add forgotten nla_policy for BSS color attribute
2023-09-19 12:22:34 +02:00
x25
net/x25: Fix to not accept on connected socket
2023-02-09 11:26:40 +01:00
xdp
xsk: Fix xsk_diag use-after-free error during socket cleanup
2023-09-19 12:22:58 +02:00
xfrm
xfrm: fix a data-race in xfrm_gen_index()
2023-10-25 11:58:56 +02:00
compat.c
…
devres.c
…
Kconfig
Remove DECnet support from kernel
2023-06-21 15:59:15 +02:00
Makefile
Remove DECnet support from kernel
2023-06-21 15:59:15 +02:00
socket.c
net: prevent address rewrite in kernel_bind()
2023-10-19 23:05:33 +02:00
sysctl_net.c
…