Josef Bacik 7a7ccd02dc btrfs: fixup error handling in fixup_inode_link_counts
commit 011b28acf940eb61c000059dd9e2cfcbf52ed96b upstream.

This function has the following pattern

	while (1) {
		ret = whatever();
		if (ret)
			goto out;
	}
	ret = 0
out:
	return ret;

However several places in this while loop we simply break; when there's
a problem, thus clearing the return value, and in one case we do a
return -EIO, and leak the memory for the path.

Fix this by re-arranging the loop to deal with ret == 1 coming from
btrfs_search_slot, and then simply delete the

	ret = 0;
out:

bit so everybody can break if there is an error, which will allow for
proper error handling to occur.

CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-10 12:42:37 +02:00
..
2020-11-10 10:23:59 +01:00
2020-01-29 10:24:34 +01:00
2016-10-15 12:09:13 -07:00
2021-05-22 10:40:34 +02:00
2019-08-06 18:29:38 +02:00
2021-05-22 10:40:29 +02:00
2020-08-21 11:02:08 +02:00
2021-05-22 10:40:29 +02:00
2019-03-13 14:04:52 -07:00
2018-12-21 14:11:31 +01:00
2021-02-03 23:19:49 +01:00
2020-04-02 17:20:27 +02:00
2018-02-17 13:21:15 +01:00
2017-06-14 15:06:01 +02:00