Marc Zyngier
4185b788d3
gpio: tegra186: Fix chip_data type confusion ...
commit d1e972ace42390de739cde87d96043dcbe502286 upstream.
The tegra186 GPIO driver makes the assumption that the pointer
returned by irq_data_get_irq_chip_data() is a pointer to a
tegra_gpio structure. Unfortunately, it is actually a pointer
to the inner gpio_chip structure, as mandated by the gpiolib
infrastructure. Nice try.
The saving grace is that the gpio_chip is the first member of
tegra_gpio, so the bug has gone undetected since... forever.
Fix it by performing a container_of() on the pointer. This results
in no additional code, and makes it possible to understand how
the whole thing works.
Fixes: 5b2b135a87fc ("gpio: Add Tegra186 support")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20220211093904.1112679-1-maz@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-03-02 11:42:57 +01:00
2019-12-04 19:44:12 -08:00
2019-11-07 09:27:48 +01:00
2020-07-23 15:09:26 +02:00
2020-07-23 15:09:54 +02:00
2020-07-23 15:10:25 +02:00
2020-07-20 15:34:59 +02:00
2019-05-30 11:25:18 -07:00
2020-07-20 15:47:50 +02:00
2022-02-16 12:54:23 +01:00
2019-05-30 11:29:52 -07:00
2020-07-08 09:24:07 +02:00
2020-09-28 12:22:04 +02:00
2019-07-09 09:07:00 -07:00
2020-12-02 10:40:54 +01:00
2020-10-02 09:51:42 -07:00
2022-01-27 10:54:15 +01:00
2020-08-23 17:36:59 -05:00
2020-08-28 20:13:51 +02:00
2019-11-07 09:27:48 +01:00
2019-12-01 17:56:50 -08:00
2020-02-10 10:55:18 +01:00
2020-03-26 00:02:03 +01:00
2019-05-24 17:36:45 +02:00
2021-06-03 09:00:39 +02:00
2019-05-30 11:26:32 -07:00
2020-01-23 16:16:05 +01:00
2020-08-04 01:25:02 +02:00
2019-07-15 11:03:02 -03:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-08-28 20:15:06 +02:00
2021-12-29 12:26:03 +01:00
2020-12-02 10:40:54 +01:00
2020-12-09 09:41:49 +01:00
2019-11-13 13:47:48 +01:00
2021-02-17 11:02:20 +01:00
2020-05-05 18:24:56 +02:00
2020-05-05 18:22:26 +02:00
2020-04-28 15:50:28 +02:00
2019-12-04 19:44:12 -08:00
2020-01-15 11:24:19 +01:00
2019-02-09 11:33:37 +01:00
2019-08-15 09:57:29 +02:00
2019-11-07 09:27:48 +01:00
2020-07-22 16:00:27 +03:00
2019-10-15 01:18:51 +02:00
2019-07-15 21:10:39 -07:00
2020-07-08 09:24:08 +02:00
2019-09-03 16:04:19 +02:00
2019-07-09 09:07:00 -07:00
2019-11-07 09:27:48 +01:00
2019-12-13 09:50:29 +01:00
2019-04-05 00:04:26 +07:00
2019-10-31 15:03:10 -07:00
2019-11-07 09:27:48 +01:00
2019-06-05 17:37:10 +02:00
2019-11-07 09:27:48 +01:00
2019-04-05 00:04:26 +07:00
2019-08-15 21:33:07 +02:00
2019-11-07 09:27:48 +01:00
2020-05-22 17:01:25 +02:00
2020-08-04 01:12:43 +02:00
2019-12-04 19:44:13 -08:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-07-17 14:03:38 +02:00
2019-07-29 00:03:52 +02:00
2020-05-18 09:15:16 +02:00
2019-05-30 11:26:37 -07:00
2019-05-30 11:29:19 -07:00
2019-11-03 19:54:53 +01:00
2020-04-16 20:41:06 +03:00
2020-06-30 17:00:11 +03:00
2021-11-18 14:03:42 +01:00
2020-07-08 09:24:08 +02:00
2020-04-28 22:41:25 +02:00
2020-07-16 15:07:18 +02:00
2020-09-30 10:52:21 +02:00
2019-11-07 09:27:48 +01:00
2021-09-22 12:28:04 +02:00
2019-06-05 17:37:06 +02:00
2019-02-08 15:55:41 +02:00
2020-03-25 09:50:45 +01:00
2021-01-30 13:55:16 +01:00
2021-07-07 08:22:46 -04:00
2019-11-07 09:27:48 +01:00
2019-04-05 00:04:27 +07:00
2021-04-28 13:39:59 +02:00
2019-05-30 11:29:52 -07:00
2021-10-20 11:45:03 +02:00
2020-07-16 14:35:12 +02:00
2021-03-04 11:38:40 +01:00
2020-07-21 19:12:57 +03:00
2020-07-23 15:11:26 +02:00
2020-11-06 15:19:44 +01:00
2020-08-28 20:15:51 +02:00
2020-04-14 16:23:46 +02:00
2020-07-08 09:24:07 +02:00
2020-05-25 11:14:36 +02:00
2019-11-07 09:27:48 +01:00
2019-05-30 11:29:52 -07:00
2020-07-30 00:13:10 +02:00
2019-10-29 15:12:52 +01:00
2019-05-24 17:36:45 +02:00
2019-11-07 09:27:48 +01:00
2020-06-03 10:48:37 +02:00
2019-11-07 09:27:48 +01:00
2020-07-08 09:24:07 +02:00
2019-11-07 09:27:48 +01:00
2020-07-22 16:00:27 +03:00
2022-02-16 12:54:24 +01:00
2020-09-09 12:59:15 +02:00
2020-09-17 16:00:20 +01:00
2018-12-07 17:34:08 +02:00
2019-04-05 00:04:27 +07:00
2020-08-31 18:06:28 +02:00
2019-06-05 17:37:06 +02:00
2020-08-23 17:36:59 -05:00
2020-08-18 21:32:28 +02:00
2020-07-08 09:24:08 +02:00
2019-12-12 17:09:50 +01:00
2020-10-13 10:09:33 -07:00
2022-03-02 11:42:57 +01:00
2020-04-28 16:22:33 +02:00
2020-01-15 11:18:29 +01:00
2019-05-30 11:29:19 -07:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2019-05-24 17:39:01 +02:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2021-08-12 13:22:06 +02:00
2019-04-05 00:04:28 +07:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2019-11-07 09:27:48 +01:00
2019-06-19 17:09:55 +02:00
2021-09-30 10:11:03 +02:00
2019-08-23 09:41:18 +02:00
2019-08-05 11:26:58 +02:00
2019-06-27 15:56:51 +01:00
2020-01-15 13:45:01 +01:00
2021-06-16 12:01:45 +02:00
2020-08-04 01:25:02 +02:00
2020-07-23 15:08:55 +02:00
2020-05-18 09:16:31 +02:00
2019-11-07 09:27:48 +01:00
2021-11-02 19:48:23 +01:00
2020-02-10 12:52:34 +01:00
2019-08-15 09:55:07 +02:00
2020-06-20 23:13:27 +02:00
2019-12-09 10:40:18 +01:00
2019-06-19 17:09:55 +02:00
2020-04-02 09:16:06 +02:00
2021-07-20 16:05:43 +02:00
2022-01-27 10:54:12 +01:00
2019-09-10 11:34:20 +01:00
2021-06-30 08:47:24 -04:00
2020-11-05 15:35:40 +01:00
2020-08-04 01:22:02 +02:00
2018-09-25 09:08:48 +02:00
2020-09-14 10:54:01 +02:00
2020-02-21 17:10:33 +01:00
2021-04-21 13:00:50 +02:00
2020-07-12 10:22:00 +02:00
2021-04-14 08:42:13 +02:00
2020-09-30 10:57:04 +02:00
2021-07-07 08:22:46 -04:00
2020-10-14 15:56:58 -07:00
2020-06-15 10:15:29 +02:00
4185b788d3