Rasmus Villemoes 9851ad2f71 Revert "gpio: mpc8xxx: change the gpio interrupt flags."
commit ec7099fdea8025988710ee6fecfd4e4210c29ab5 upstream.

This reverts commit 3d5bfbd9716318b1ca5c38488aa69f64d38a9aa5.

When booting with threadirqs, it causes a splat

  WARNING: CPU: 0 PID: 29 at kernel/irq/handle.c:159 __handle_irq_event_percpu+0x1ec/0x27c
  irq 66 handler irq_default_primary_handler+0x0/0x1c enabled interrupts

That splat later went away with commit 81e2073c175b ("genirq: Disable
interrupts for force threaded handlers"), which got backported to
-stable. However, when running an -rt kernel, the splat still
exists. Moreover, quoting Thomas Gleixner [1]

  But 3d5bfbd97163 ("gpio: mpc8xxx: change the gpio interrupt flags.")
  has nothing to do with that:

      "Delete the interrupt IRQF_NO_THREAD flags in order to gpio interrupts
       can be threaded to allow high-priority processes to preempt."

  This changelog is blatantly wrong. In mainline forced irq threads
  have always been invoked with softirqs disabled, which obviously
  makes them non-preemptible.

So the patch didn't even do what its commit log said.

[1] https://lore.kernel.org/lkml/871r8zey88.ffs@nanos.tec.linutronix.de/

Cc: stable@vger.kernel.org # v5.9+
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-08-12 13:22:16 +02:00
..
2020-07-20 15:34:59 +02:00
2020-07-23 15:03:25 +02:00
2020-01-15 11:24:19 +01:00
2019-09-03 16:04:19 +02:00
2019-11-07 09:27:48 +01:00
2020-07-30 00:13:10 +02:00
2019-11-07 09:27:48 +01:00
2020-01-15 13:45:01 +01:00
2019-11-07 09:27:48 +01:00
2019-12-09 10:40:18 +01:00
2021-04-21 13:00:50 +02:00
2020-10-14 15:56:58 -07:00
2020-06-15 10:15:29 +02:00