Alexander Potapenko
2acb2779b1
ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network ...
[ Upstream commit c23fb2c82267638f9d206cb96bb93e1f93ad7828 ]
When copying a `struct ifaddrlblmsg` to the network, __ifal_reserved
remained uninitialized, resulting in a 1-byte infoleak:
BUG: KMSAN: kernel-network-infoleak in __netdev_start_xmit ./include/linux/netdevice.h:4841
__netdev_start_xmit ./include/linux/netdevice.h:4841
netdev_start_xmit ./include/linux/netdevice.h:4857
xmit_one net/core/dev.c:3590
dev_hard_start_xmit+0x1dc/0x800 net/core/dev.c:3606
__dev_queue_xmit+0x17e8/0x4350 net/core/dev.c:4256
dev_queue_xmit ./include/linux/netdevice.h:3009
__netlink_deliver_tap_skb net/netlink/af_netlink.c:307
__netlink_deliver_tap+0x728/0xad0 net/netlink/af_netlink.c:325
netlink_deliver_tap net/netlink/af_netlink.c:338
__netlink_sendskb net/netlink/af_netlink.c:1263
netlink_sendskb+0x1d9/0x200 net/netlink/af_netlink.c:1272
netlink_unicast+0x56d/0xf50 net/netlink/af_netlink.c:1360
nlmsg_unicast ./include/net/netlink.h:1061
rtnl_unicast+0x5a/0x80 net/core/rtnetlink.c:758
ip6addrlbl_get+0xfad/0x10f0 net/ipv6/addrlabel.c:628
rtnetlink_rcv_msg+0xb33/0x1570 net/core/rtnetlink.c:6082
...
Uninit was created at:
slab_post_alloc_hook+0x118/0xb00 mm/slab.h:742
slab_alloc_node mm/slub.c:3398
__kmem_cache_alloc_node+0x4f2/0x930 mm/slub.c:3437
__do_kmalloc_node mm/slab_common.c:954
__kmalloc_node_track_caller+0x117/0x3d0 mm/slab_common.c:975
kmalloc_reserve net/core/skbuff.c:437
__alloc_skb+0x27a/0xab0 net/core/skbuff.c:509
alloc_skb ./include/linux/skbuff.h:1267
nlmsg_new ./include/net/netlink.h:964
ip6addrlbl_get+0x490/0x10f0 net/ipv6/addrlabel.c:608
rtnetlink_rcv_msg+0xb33/0x1570 net/core/rtnetlink.c:6082
netlink_rcv_skb+0x299/0x550 net/netlink/af_netlink.c:2540
rtnetlink_rcv+0x26/0x30 net/core/rtnetlink.c:6109
netlink_unicast_kernel net/netlink/af_netlink.c:1319
netlink_unicast+0x9ab/0xf50 net/netlink/af_netlink.c:1345
netlink_sendmsg+0xebc/0x10f0 net/netlink/af_netlink.c:1921
...
This patch ensures that the reserved field is always initialized.
Reported-by: syzbot+3553517af6020c4f2813f1003fe76ef3cbffe98d@syzkaller.appspotmail.com
Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
Signed-off-by: Alexander Potapenko <glider@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-11-16 09:58:18 +01:00
2022-10-26 12:34:47 +02:00
2021-03-30 13:29:39 -07:00
2022-08-31 17:16:44 +02:00
2022-11-16 09:58:18 +01:00
2022-07-29 17:25:13 +02:00
2021-06-11 14:48:50 +02:00
2021-03-04 15:26:57 -08:00
2022-10-29 10:12:56 +02:00
2022-03-16 14:23:36 +01:00
2022-04-27 14:38:52 +02:00
2021-08-04 10:34:40 +01:00
2021-12-08 09:04:43 +01:00
2022-07-21 21:24:26 +02:00
2020-11-23 18:36:21 -05:00
2022-08-17 14:23:36 +02:00
2021-10-12 11:49:49 +01:00
2021-10-12 11:49:49 +01:00
2022-02-01 17:27:09 +01:00
2022-02-23 12:03:10 +01:00
2022-11-03 23:59:18 +09:00
2021-02-23 11:29:52 -08:00
2022-11-10 18:15:38 +01:00
2022-03-02 11:47:56 +01:00
2022-08-25 11:40:10 +02:00
2022-11-03 23:59:18 +09:00
2022-01-11 15:35:17 +01:00
2022-04-13 20:59:03 +02:00
2021-06-11 14:48:50 +02:00
2022-11-03 23:59:20 +09:00
2021-07-21 08:14:33 -07:00
2021-07-21 08:14:33 -07:00
2021-04-27 14:02:06 -07:00
2022-08-03 12:03:51 +02:00
2021-06-11 14:48:50 +02:00
2022-08-25 11:40:24 +02:00
2022-05-09 09:14:41 +02:00
2021-05-31 22:12:08 -07:00
2022-08-03 12:03:47 +02:00
2020-11-09 15:34:44 -08:00
2022-01-11 15:35:18 +01:00
2021-05-21 15:02:25 -07:00
2022-11-10 18:15:31 +01:00
2020-12-08 16:22:54 -08:00
2022-07-07 17:53:26 +02:00
2022-07-21 21:24:30 +02:00
2022-07-21 21:24:30 +02:00
2022-09-15 11:30:06 +02:00
2022-11-03 23:59:18 +09:00
2022-07-29 17:25:18 +02:00
2021-07-21 08:14:33 -07:00
2022-11-10 18:15:38 +01:00
2021-03-30 17:06:49 -07:00
2022-11-10 18:15:38 +01:00
2022-04-08 14:22:46 +02:00
2021-06-09 09:38:52 +02:00
2acb2779b1