Alexander Wetzel 2704f48335 scsi: sg: Avoid race in error handling & drop bogus warn
commit d4e655c49f474deffaf5ed7e65034b8167ee39c8 upstream.

Commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") introduced
an incorrect WARN_ON_ONCE() and missed a sequence where sg_device_destroy()
was used after scsi_device_put().

sg_device_destroy() is accessing the parent scsi_device request_queue which
will already be set to NULL when the preceding call to scsi_device_put()
removed the last reference to the parent scsi_device.

Drop the incorrect WARN_ON_ONCE() - allowing more than one concurrent
access to the sg device - and make sure sg_device_destroy() is not used
after scsi_device_put() in the error handling.

Link: https://lore.kernel.org/all/5375B275-D137-4D5F-BE25-6AF8ACAE41EF@linux.ibm.com
Fixes: 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
Cc: stable@vger.kernel.org
Signed-off-by: Alexander Wetzel <Alexander@wetzel-home.de>
Link: https://lore.kernel.org/r/20240401191038.18359-1-Alexander@wetzel-home.de
Tested-by: Sachin Sant <sachinp@linux.ibm.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-04-17 11:19:34 +02:00
..
2023-04-26 16:07:23 -07:00
2023-04-27 11:53:57 -07:00
2023-04-27 16:36:55 -07:00
2023-05-31 19:59:26 -04:00
2023-09-13 20:08:40 -04:00
2023-05-26 13:52:19 -07:00
2023-04-18 23:01:23 -04:00
2022-06-27 22:56:21 -04:00
2024-04-10 16:36:00 +02:00
2024-04-10 16:36:00 +02:00
2022-02-22 21:11:02 -05:00
2022-05-08 14:28:18 -04:00
2023-04-27 11:53:57 -07:00
2021-12-22 23:41:13 -05:00
2023-06-30 11:57:07 -07:00
2023-05-31 11:36:40 -04:00