keremet/rpm-ostree
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

app/compose: Minor comment tweak

Browse Source 
This is slight bikeshed, though this comment took me a second to parse
because it says "not do it" right before we do it. Let's just move it up
to right outside where the condition is actually tested.

Closes: #1658
Approved by: cgwalters
This commit is contained in:
Jonathan Lebon 2018-11-02 13:26:23 -04:00 committed by Atomic Bot
parent 868bdf167a
commit 38c2ab3397
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/app/rpmostree-compose-builtin-tree.c
View File

@ -604,13 +604,12 @@ impl_install_tree (RpmOstreeTreeComposeContext *self,
g_printerr ("NOTICE: Proceeding anyways.\n"); g_printerr ("NOTICE: Proceeding anyways.\n");
} }
/* This fchdir() call is...old, dates back to when rpm-ostree wrapped
* running yum as a subprocess. It shouldn't be necessary any more,
* but let's be conservative and not do it in unified core mode.
*/
if (!opt_unified_core) if (!opt_unified_core)
{ {
/* This call is...old, dates back to when rpm-ostree wrapped
* running yum as a subprocess. It shouldn't be necessary
* any more, but let's be conservative and not do it in
* unified core mode.
*/
if (fchdir (self->workdir_dfd) != 0) if (fchdir (self->workdir_dfd) != 0)
return glnx_throw_errno_prefix (error, "fchdir"); return glnx_throw_errno_prefix (error, "fchdir");
} }