Commit Graph

153 Commits

Author SHA1 Message Date
Dietmar Maurer
bebf81f0ce bump version to 1.0-15 2018-04-06 13:48:36 +02:00
Dominik Csapak
9307eda498 allow pressing enter in ObjectGrids to edit a field
for this we need to overwrite the 'run_editor' function
of the ObjectGrid if we use a custom one

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 13:46:36 +02:00
Dominik Csapak
5d3089cd94 better default focus selection
we do not want to focus on hidden/disabled fields,
because that focus gets lost and prevents some things
e.g. cancelling with ESC

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 13:44:27 +02:00
Dominik Csapak
880df5d504 add a checkbox to edit windows for advanced options
if the inputpanel has advanced options, show a checkbox to
show/hide them

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 10:08:31 +02:00
Dominik Csapak
33a4fc355c add advanced options to the input panel
with this, you can now put items in the
advancedColumn1/2/B and show/hide it with
setAdvancedVisible

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 10:05:33 +02:00
Dietmar Maurer
ba70732c22 bump version to 1.0-14 2018-04-05 12:19:12 +02:00
Dominik Csapak
aea77b2c69 (partially) fix #1223: add touchscreen override for extjs
the combination of firefox, touchscreen, mouse input and extjs
prevents normal click/touch input for buttons, lists, etc.

the workaround on firefox was to set
dom.w3c_touch_events.enabled
to 0 (in about:config)

or to upgrade to extjs >= 6.5.1 (of which there is no gpl release as of now)

so we introduce that workaround as it seems to not disrupt 'normal'
browsers and non-touchscreen devices

we then still have an issue with scrolling though, since extjs
now expects the user to drag the content instead of using the wheel

but it is still better than a completely non working interface

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-30 10:10:46 +02:00
Thomas Lamprecht
fde8e8bbb9 task view, progress: add taskDone callback
and integrate it into the edit window

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-03-27 14:03:14 +02:00
Thomas Lamprecht
8d8dbfc5b9 window/Edit: allow showing TaskViewer instead of TaskProgress
let our users decide if the want to show a TaskProgress window or a
TaskViewer window, so that they do not always must create the Viewer
their self

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-03-27 11:53:30 +02:00
Dominik Csapak
37d8d60201 add labelWidth to the fieldDefaults in add_*_row
this resizes the editwindow to the correct size

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-16 16:01:57 +01:00
Dominik Csapak
0d5c5e14c8 add an optional renderer for integer rows in ObjectGrid
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-16 11:35:35 +01:00
Dietmar Maurer
36ee012f37 bump version to 1.0-13 2018-03-08 11:38:18 +01:00
Dominik Csapak
ea7fb2205f remove gettext definition in Utils.js
this should not be here, rather where we include the language files
(like in pve), because this is not ecma conform and behaves very
different in different browsers (e.g. safari ignores the if check
completely and simply uses that function definition)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-03-08 11:37:32 +01:00
Thomas Lamprecht
2e6df526fa bump version to 1.0-12 2018-02-23 11:14:02 +01:00
Dominik Csapak
c33f087874 skip config property for cbind mixin
if we use a component with cbind in a static declaration,
we do not want to traverse the 'config' property, as this can lead
to properties of base classes which produce errors on copying

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-22 10:14:58 +01:00
Fabian Grünbichler
eb1f0d2a37 bump version to 1.0-11 2018-02-16 13:06:57 +01:00
Dominik Csapak
4b23ab8806 rename pve(Show|Hide)Help events
we renamed them in the helpButton, we also have to rename them here
this prevented the help button to show up in the vm/ct creation wizard

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-13 16:12:50 +01:00
Thomas Lamprecht
c6f1ab1bd7 mixin/CBind: allow binding sub elements
allow to access sub elements of configuration items for binding.

E.g., if the following configuration is present:

foo: {
    bar: true
}

one could do:

xtype: 'displayfield',
cbind {
    value: '{foo.bar}'
}
[...]

This mirrors the abillity of ExtJS's 'bind', which can do this also.
Simple implementation mirroring the surrounding code.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-02-09 10:13:34 +01:00
Wolfgang Bumiller
f3cf5c9bd8 buildsys: prevent parallel deb builds
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2018-02-09 10:13:34 +01:00
Wolfgang Link
9b575917b9 change the hard coded text against the translated text 2018-01-25 11:03:44 +01:00
Wolfgang Link
8947a4fc13 show VLAN aware setting in NetworkView. 2018-01-25 11:03:44 +01:00
Dominik Csapak
102716a69a bump version to 1.0-10 2018-01-25 10:23:20 +01:00
Thomas Lamprecht
bf49d2da0f TimeEdit: use schematic declaration
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-17 12:21:04 +01:00
Thomas Lamprecht
5106364829 toolkit: remove PVE specific VType
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-17 12:21:04 +01:00
Thomas Lamprecht
8f449655ad toolkit: add MacPrefix vtype
useful for our PVE dc/options panel

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-17 12:20:50 +01:00
Dominik Csapak
5812914ce5 reintroduce api2request checks for toolkit 2018-01-15 14:51:24 +01:00
Dominik Csapak
42a6e12072 add proxmoxlib to the clean target 2018-01-15 14:13:11 +01:00
Dominik Csapak
ab7fac0b2f add task_desc_table and format_task_description from pve
since the Task is in the widget-toolkit, passing
a renderer/list a few levels of components down is not nice
and there are not *that* many strings in the task_desc_table,
we put it here, so that either pve and pmg can use them
2018-01-15 14:11:02 +01:00
Dominik Csapak
590d00bf20 remove unnecessary formatter 2018-01-15 14:09:53 +01:00
Dominik Csapak
f97a2a34ee add all languages from pve 2018-01-15 14:09:41 +01:00
Dominik Csapak
39d9914990 ComboGrid: open picker also when focusing an editable field
port commit
851c032d69ad5ae23725dd1add9e4084ebc12650
from pve-manager

commit message:

    ComboBoxes provided by UI frameworks normally show their selection
    possibilities once focused, ExtJS does this too but not on editable
    (and thus filterable) input fields. Add a logic which allows this too
    and streamlines the behavior of ComboGrid/Box like components.

    To avoid a glitch, where clicking the "picker trigger" (the down
    arrow which normally toggles the selection picker) would first focus
    the element - thus expanding it - and only then causing a toggle
    which collapses it again, we overwrite the 'Ext.form.trigger.Trigger'
    onMouseDown so that we can skip a expansion on this event.

    Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:48:13 +01:00
Dominik Csapak
3ab80554c6 ComboGrid: improve setting 'editable' default value
port commit
bff876ecb5f3388b7d65c491680b9a40574e4744
from pve-manager

commit message:

    This allows child classes to use another default, the initialConfig
    didn't allowed that.
    This is also the ExtJS like way to set defaults.

    Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:48:13 +01:00
Dominik Csapak
4c2b424203 fix var assignments
only declare 'grid' once
2018-01-11 14:48:13 +01:00
Dominik Csapak
a147a8cbb7 explicit set button focus respecting the 'dangerous' option
port commit
4dc6bd326a829d5bf708c4a33722d5a8c6304f9c
from pve-manager
2018-01-11 14:48:13 +01:00
Dominik Csapak
c47f5f46f4 place space on correct side of colon 2018-01-11 14:48:13 +01:00
Dominik Csapak
ec0296eb11 change invalid class
so that we can safely create a css style for it
(in our namespace)
2018-01-11 14:48:13 +01:00
Dominik Csapak
31a5025184 pass given defaults in Edit window
this is a port of the change for the Edit window from
pve-manager commit:
ff740ccbeed1e7e2131b14c9ce50f300f24201f6

which passes the given defaults to the items
2018-01-11 14:48:13 +01:00
Dominik Csapak
42a9df8b1f add the missing explanation of onlineHelp 2018-01-11 14:48:13 +01:00
Dominik Csapak
cf4ecb2bfe check earlier if the logview is destroyed
this is a port from pve-manager commit:
bde1efbf66cf8794d99708b41d92b2106c44f192

which fixes a problem with destroying the logview in extjs 6.2
2018-01-11 14:48:13 +01:00
Dominik Csapak
f2bf80bd41 add version as comment to js file
this can be used in the proxy to read the installed version
of the widget toolkit (without needing to read the info from
apt/dpkg/etc.)
2018-01-11 14:48:13 +01:00
Thomas Lamprecht
1fb41f2e36 toolkit: fix #1516: mouse-scrolling of overflowhandlers in firefox
this is a workaround for scrolling in toolbars, etc. in firefox with
the mouse.
while the result is not very "pretty", it maintains the old behaviour
for all other browsers and makes it work in firefox

we may drop this when we update to a new extjs release

commit 484bf3f29e58d0f96c65e6dca6b5dd95eaea180c from pve-manager

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:45:48 +01:00
Thomas Lamprecht
47d1c80c37 toolkit: fix #1510: don't scroll back to focus when view refreshes
adds a workaround, so that we restore the scroll position when we
restore the focus. Fixies an annoying issue where, if a user had an
ellemtn selected, scrolled down and then a store refresh re-rendered
the view it was scrolled back to the selected item and the user lost
his scrolling position.

Add also the 'jumpToFocus' flag to allow enabling the old behaviour

commit e6f2a94f4fff3c125e8406a21d8d6159aca1421e from pve-manager

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:45:48 +01:00
Thomas Lamprecht
3c15824972 toolkit: fix #1307: don\'t use language dependent separator
by default, extjs submits the language dependent decimal separator,
e.g., ',' (comma) for german and '.' (dot) for english.

We always want the dot.

commit 5c660b6d1302a5fbb3dcf477cf8b5adc9f798530 from pve-manager

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:45:48 +01:00
Thomas Lamprecht
9503d4570e toolkit: remove unneeded applyEmptyText
The parent method does this already in ExtJS 6

commit d19ffc1bb078e42a042c5c73797d713aa9cf9bcc from pve-manager

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-11 14:45:48 +01:00
Thomas Lamprecht
0e029e08ef HelpButton: be backward compatible with PVE help mapping
pve-doc-generator used pveOnlineHelp as variable name while the
widget toolkit expects proxmoxOnlineHelp, allow both for now.

As its not quite clear when the switch to the widget toolkit happens
this is more flexible than changing the generator and adding a
versioned build dependency in pve-manager for it.
We normally do not bump pve-docs during releases either.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
CC: Dominik Csapak <d.csapak@proxmox.com>
2017-12-14 15:38:50 +01:00
Dietmar Maurer
6689e1cedd bump version to 1.0-9 2017-12-11 14:43:35 +01:00
Dominik Csapak
881c9c0c12 add Xtermjs popup helper
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-12-11 14:42:16 +01:00
Thomas Lamprecht
e94c076748 Utils: fix some lint errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2017-12-07 12:00:27 +01:00
Thomas Lamprecht
641df09e9e taskviewer: port over extraTite config parameter
commit acc9bf4752972ffd79af1c78510fcce24c2db959 (Close #1268: Show
migration start server and migration end server) introduced the
possibility to display additional information in the TaskViewer
window title. This change happened after the widget toolkit formed
and seems reasonable to have here, thus port it over.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2017-12-07 12:00:27 +01:00
Thomas Lamprecht
85d85d151c ObjectGrid: add_text_row: allow setting vtype for editor
Allow setting a validation type for the editors text field

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2017-12-07 12:00:27 +01:00