Ryan Petrello
1ac5bc5e2b
remove angular-md5 license
2018-11-28 10:43:53 -05:00
kialam
362a3753d0
Remove 'angular-md5' from our dependencies.
2018-11-28 10:43:53 -05:00
kialam
71ee9d28b9
Add link to original gist and rename file.
2018-11-28 10:43:53 -05:00
kialam
d8d89d253d
Remove instances of "md5" from the UI.
2018-11-28 10:43:53 -05:00
Ryan Petrello
a72f3d2f2f
generate host_config_key using random UUIDs, not a time-based md5 hash
2018-11-28 10:43:45 -05:00
softwarefactory-project-zuul[bot]
d9866c35b4
Merge pull request #2819 from ryanpetrello/fix-busted-tests
...
mock an HTTP call to fix busted unit tests
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2018-11-28 14:50:38 +00:00
Ryan Petrello
4e45c3a66c
mock an HTTP call to fix busted unit tests
2018-11-28 09:17:50 -05:00
softwarefactory-project-zuul[bot]
87b55dc413
Merge pull request #2816 from ansible/jakemcdermott-smoke-break
...
update expected color vals of active tab in smoke test
Reviewed-by: Jake McDermott <yo@jakemcdermott.me>
https://github.com/jakemcdermott
2018-11-28 04:02:31 +00:00
Jake McDermott
2e3949d612
update expected color vals of active tab in smoke test
2018-11-27 22:46:16 -05:00
softwarefactory-project-zuul[bot]
d928ccd922
Merge pull request #2799 from ansible/jakemcdermott-readonly-viz
...
don't conditionally hide workflow viz templates list button
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2018-11-28 03:39:51 +00:00
softwarefactory-project-zuul[bot]
a9c51b737c
Merge pull request #2389 from ansible/workflow-convergence
...
Workflow convergence
Reviewed-by: https://github.com/softwarefactory-project-zuul[bot]
2018-11-27 22:04:50 +00:00
mabashian
51669c9765
Fixes hint/lint errors in workflow viz test
2018-11-27 16:12:42 -05:00
mabashian
17cc82d946
Ensure that selected row is cleared when adding new node after editing existing node
2018-11-27 16:12:42 -05:00
mabashian
10de5b6866
Fixes clicking on a wf in wf node. Also fixes editing wf in wf node with inv prompt
2018-11-27 16:12:42 -05:00
mabashian
55dc27f243
Set active tab to jobs when initially clicking a workflow_job_template type node
2018-11-27 16:12:42 -05:00
mabashian
6fc2ba3495
Fixes delete node shifting e2e test
2018-11-27 16:12:42 -05:00
mabashian
7bad01e193
Fixes e2e workflow visualizer tests
2018-11-27 16:12:42 -05:00
mabashian
62a1f10c42
Fix node pagination for project/inv
2018-11-27 16:12:42 -05:00
mabashian
3975a2ecdb
fix linkpath class
2018-11-27 16:12:42 -05:00
Jake McDermott
bfa361c87f
hide prompt button when not on jobs tab
2018-11-27 16:12:42 -05:00
Jake McDermott
d5f07a9652
hide inventory help message when not on jobs tab
2018-11-27 16:12:42 -05:00
Jake McDermott
65ec1d18ad
skip missing inventory prompt value check when selecting workflow node
2018-11-27 16:12:42 -05:00
Jake McDermott
7b4521f980
workflow node prompt fixup
...
* use workflow model and endpoint when node is workflow
* always include template type in prompt data
* skip missing inventory checks when node is workflow
* skip checks for required credential fields when node is workflow
2018-11-27 16:12:42 -05:00
John Mitchell
3762ba7b24
add back in workflow_nodes in order to be able to use it for count of nodes
2018-11-27 16:12:42 -05:00
John Mitchell
762c882cd7
consume workflow maker total nodes label change
2018-11-27 16:12:42 -05:00
John Mitchell
343639d4b7
fix workflow maker total templates header to total nodes
2018-11-27 16:12:42 -05:00
John Mitchell
38dc0b8e90
fix workflow total jobs header to total nodes
2018-11-27 16:12:42 -05:00
mabashian
ed40ba6267
Fix searching on related fields
2018-11-27 16:12:42 -05:00
mabashian
54d56f2284
Fix node jobs column sorting. Adds arrows to potential workflow node links
2018-11-27 16:12:42 -05:00
mabashian
1477bbae30
Fixed error Cannot read property 'type' of undefined in console when selecting a project or inventory node
2018-11-27 16:12:42 -05:00
mabashian
625c6c30fc
Fixed edge dropdown id
2018-11-27 16:12:42 -05:00
chris meyers
228e412478
simplify workflow job failure reason
...
* Log the more detailed reason for a workflow job failing but expose a
simplified reason to users via job_explanation
2018-11-27 16:12:42 -05:00
chris meyers
f8f2e005ba
better comment for deciding parent's status
2018-11-27 16:12:42 -05:00
chris meyers
d8bf82a8cb
add help_text to do_not_run workflow field
2018-11-27 16:12:41 -05:00
chris meyers
2eeca3cfd7
add example workflow run to docs
2018-11-27 16:12:41 -05:00
mabashian
28a4bbbe8a
Fixed jshint errors that fell out of merge conflict
2018-11-27 16:12:41 -05:00
mabashian
1cfcaa72ad
Fixed editNodeHelpMessage logic that was broken during merge conflict
2018-11-27 16:12:41 -05:00
AlanCoding
4c14727762
bump migration number
2018-11-27 16:12:41 -05:00
chris meyers
0c8dde9718
fix dfs_run_nodes()
...
* Tried to re-use the topological sort order to crawl the graph to find
the next node(s) to run. This is incorrect, we need to take into account
the fail/success of jobs and directionally crawl the graph.
2018-11-27 16:12:41 -05:00
chris meyers
febf051748
do not mark ujt None nodes dnr
...
* Leave workflow nodes with no related unified job template nodes
do_not_run = False. If we mark it True, we can't differentiate between
the actual want to not take that path vs. do not run this because I do
not have a valid related unified job template.
2018-11-27 16:12:41 -05:00
mabashian
56885a5da1
Remove reference to isStartNode and just check the id of the node to determine if it's our start node or not
2018-11-27 16:12:41 -05:00
mabashian
623cf54766
Added dagre and graphlib licenses
2018-11-27 16:12:41 -05:00
mabashian
a804c854bf
Fix test failures and jshint errors
2018-11-27 16:12:41 -05:00
chris meyers
7b087d4a6c
loop over dnr nodes by topological sort
...
* Perform topological sort on graph nodes before looping over them to
mark do not run. This guarantees that parent nodes will be processed
before calling dependent child nodes. The complexity of the sorting is
N. The complexity of marking the the nodes is N*V
2018-11-27 16:12:41 -05:00
chris meyers
cfa098479e
Revert "optimize mark dnr nodes algorithm"
...
This reverts commit 6372c52772
2018-11-27 16:12:41 -05:00
mabashian
3c510e6344
Fixed bug where root link became clickable. Fix workflow key on results page.
2018-11-27 16:12:41 -05:00
chris meyers
4c9a1d6b90
optimize mark dnr nodes algorithm
...
* Compute largest depth of each node and traverse graph by depth. This
allows us to check a node once, and only once, to determine if it needs
to be marked for do not run.
2018-11-27 16:12:41 -05:00
chris meyers
d1aa52a2a6
fix up mark dnr logic
2018-11-27 16:12:41 -05:00
chris meyers
f30f52a0a8
handle missing unified job template in workflow
...
* Workflow Node without unified_job_template is treated as a job marked
as failure; when deciding what path to execute.
* Remove optimization of marking dnr nodes due to it making the
algorithm incorrect.
2018-11-27 16:12:41 -05:00
mabashian
5b459e3c5d
Code cleanup. Fixed bugs with workflow results page including details links
2018-11-27 16:12:41 -05:00
