Ahmed RAHAL
2ec5dda1d8
Add quotes to shell variables with user input
...
The last update of this file added default values for passwords
but removed the 'quote' filter.
This is extremely problematic for database passwords that should always
be complex and contain special characters that the shell may interpret
wrongly.
As a sanity measure, adding the quote filter to all fields.
2019-10-25 16:44:59 -04:00
softwarefactory-project-zuul[bot]
ee5199f77a
Merge pull request #5090 from lopf/5089-fix-psql-user-specification
...
Fix psql: local user with ID 1001 does not exist
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 19:32:13 +00:00
softwarefactory-project-zuul[bot]
491e4c709e
Merge pull request #5116 from jakemcdermott/remove-jdetails-close
...
Remove close button from job details
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 16:43:21 +00:00
softwarefactory-project-zuul[bot]
480c8516ab
Merge pull request #5086 from keithjgrant/4614-fix-template-edit-border
...
Fix border/padding while loading jt edit form
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 16:31:53 +00:00
softwarefactory-project-zuul[bot]
9eda4efb74
Merge pull request #5114 from jakemcdermott/hide-revision-copy-button-sometimes
...
Hide revision copy button when there's no revision
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 16:21:14 +00:00
Jake McDermott
a517b15c26
Remove close button from job details
2019-10-25 11:59:40 -04:00
Jake McDermott
e17ee4b58f
Hide revision copy button when there's no revision
2019-10-25 11:40:06 -04:00
softwarefactory-project-zuul[bot]
3dc8a10e85
Merge pull request #5104 from mabashian/4985-close-button-details
...
Remove close button from Project and Job Template details views
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 14:43:07 +00:00
softwarefactory-project-zuul[bot]
e893017e00
Merge pull request #5105 from mabashian/4956-template-details-links
...
Link to project and inventory from job template details
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 14:21:14 +00:00
softwarefactory-project-zuul[bot]
4a1c121792
Merge pull request #5084 from fosterseth/fix-4147-schedule500error
...
Fix 500 error when creating a job schedule
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 13:35:57 +00:00
softwarefactory-project-zuul[bot]
d39ad9d9ce
Merge pull request #5085 from mabashian/5054-revision-column
...
Adds revision to project list row items
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-25 13:05:17 +00:00
mabashian
07a5e17284
Link to project and inventory from job template details
2019-10-24 16:36:19 -04:00
mabashian
583d1390d2
Remove close button from Project and Job Template details views
2019-10-24 16:17:37 -04:00
Keith Grant
1d7bd835e6
remove unused imports
2019-10-24 10:29:04 -07:00
Keith Grant
4f90406e91
fix border/padding while loading jt edit form
2019-10-24 10:29:03 -07:00
softwarefactory-project-zuul[bot]
f57cf03f4b
Merge pull request #5017 from kimausloos/update-docs-openshift-scc
...
[docs] Update OpenShift doc section to clarify #3116
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-24 15:47:21 +00:00
mabashian
b319f47048
Adds revision to project list row items. Adds ClipboardCopyButton component to allow the user to copy the full revision to the clipboard.
2019-10-24 09:11:05 -04:00
lopf
432daa6139
fix 5089
2019-10-24 14:44:36 +02:00
Kim Ausloos
835c26f6cb
[docs] Update OpenShift doc section to clarify #3116
...
Signed-off-by: Kim Ausloos <kim.ausloos@cegeka.be>
2019-10-24 08:55:40 +02:00
softwarefactory-project-zuul[bot]
f1c2a95f0d
Merge pull request #5053 from fosterseth/fix-4797-copycredential
...
Fix secret lookup links when credentials are copied
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-23 23:46:52 +00:00
Seth Foster
58e84a40e5
Fix 500 error when creating a job schedule
...
- 500 error occurs when a non-admin user attempts to add an invalid
credential during schedule creation
- This change checks that the user can add the object to
serializer.validated_data, instead of serializer.initial_data
- The invalid credential field is purged in .validated_data, so the
request passes through cleanly
- Fix for awx issue #4147
2019-10-23 14:22:07 -04:00
Seth Foster
9c04e08b4d
Fix secret lookup links when credentials are copied
...
- When a credential that contains secret lookups (e.g. HashiCorp Vault
Secret Lookup) is copied, the lookup fields are not properly copied
- This change adds the necessary fields to FIELDS_TO_PRESERVE_AT_COPY
for both Credential and CredentialInputSource classes to ensure a
proper copy
2019-10-22 17:49:10 -04:00
softwarefactory-project-zuul[bot]
bda1abab8d
Merge pull request #5074 from shanemcd/devel
...
Downstream k8s installer changes
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-22 20:34:20 +00:00
Shane McDonald
8356327c2b
Downstream k8s installer changes
2019-10-22 15:57:40 -04:00
softwarefactory-project-zuul[bot]
cafac2338d
Merge pull request #5063 from HunterNyan/devel
...
Fixed bug with python check
Reviewed-by: Shane McDonald <me@shanemcd.com>
https://github.com/shanemcd
2019-10-22 13:37:37 +00:00
Alice Hunter
e5dfc62dce
Fixed bug with python check
2019-10-22 23:06:06 +11:00
softwarefactory-project-zuul[bot]
11edd43af3
Merge pull request #5058 from MrMEEE/patch-1
...
Only create /var/log/tower/external.log when LOG_AGGREGATOR_AUDIT is enabled
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-22 11:16:15 +00:00
Martin Juhl
27d0111a27
Update handlers.py
2019-10-22 01:25:27 +02:00
Martin Juhl
58367811a0
Update handlers.py
...
The setFormatter tries to create the external.log file.. So we should check if LOG_AGGREGATOR_AUDIT is active here as well
2019-10-22 01:02:31 +02:00
softwarefactory-project-zuul[bot]
3277d3afe0
Merge pull request #5050 from ryanpetrello/release-8.0.0
...
Bump VERSION to 8.0.0
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-21 17:26:33 +00:00
Ryan Petrello
45136b6503
Bump VERSION to 8.0.0
2019-10-21 12:29:24 -04:00
Ryan Petrello
e9af6af97c
Merge pull request #5047 from ryanpetrello/devel
...
merge a variety of downstream bug fixes
2019-10-21 12:27:54 -04:00
Ryan Petrello
f86d647571
Merge branch 'hardening' into devel
2019-10-21 12:09:27 -04:00
Ryan Petrello
f02357ca16
Merge pull request #3871 from mabashian/3865-add-buttons
...
Revert 6282b5bacb
2019-10-21 12:08:52 -04:00
mabashian
e64b087e9f
Revert 6282b5bacb
2019-10-21 11:55:12 -04:00
Ryan Petrello
5bb7e69a4d
Merge pull request #3864 from ansible/container-launch-error
...
when isolated or container jobs fail to launch, set job status to error
2019-10-21 11:18:04 -04:00
Ryan Petrello
a8aed53c10
when isolated or container jobs fail to launch, set job status to error
...
a status of error makes more sense, because failed generally points to
an issue with the playbook itself, while error is more generally used
for reporting issues internal to Tower
see: https://github.com/ansible/awx/issues/4909
2019-10-21 11:02:31 -04:00
Jake McDermott
b19539069c
Merge pull request #3863 from jakemcdermott/fix-3578-part-3
...
Set omitted runner_on_start event line lengths to 0
2019-10-21 10:37:09 -04:00
Jake McDermott
312cf13777
Set omitted runner event line lengths to 0
...
runner_on_start events have zero-length strings for their stdout
fields. We don't want to display these in the ui so we omit them.
Although the stdout field is an empty string, it still has a recorded
line length of 1 that we must account for. Since we're not rendering
the blank line, we must also go back and set the event record's line
length to 0 in order to avoid deleting too many lines when we pop or
shift events off of the view while scrolling.
2019-10-19 19:18:45 -04:00
Jake McDermott
c6033399d0
Fix off-by-one errors
2019-10-19 18:58:42 -04:00
Ryan Petrello
85f118c17d
Merge pull request #3852 from ansible/pod-reaper
...
implement a simple periodic pod reaper for container groups
2019-10-18 16:50:30 -04:00
softwarefactory-project-zuul[bot]
0de805ac67
Merge pull request #5035 from keithjgrant/4617-inventory-lookup-error-message
...
Add error messages for InventorySelect
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-18 19:46:29 +00:00
Ryan Petrello
c7426fbff4
Merge pull request #3861 from wenottingham/where-did-you-come-from
...
Log the remote IP for logged in users
2019-10-18 15:16:34 -04:00
softwarefactory-project-zuul[bot]
3cbd52a56e
Merge pull request #5040 from keithjgrant/4976-job-list-status-icons
...
Add status icon to job list
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-18 19:12:14 +00:00
Jake McDermott
97a635ef49
Merge pull request #3844 from jakemcdermott/fix-3578-part-1
...
Always disable search when processing events
2019-10-18 15:07:41 -04:00
Keith Grant
155ed75f15
update jt Inventory field error message
2019-10-18 11:38:01 -07:00
Bill Nottingham
a664c5eabe
Log the remote IP for logged in users
2019-10-18 14:28:10 -04:00
Keith Grant
8b23c6e19a
add job id to jobs list
2019-10-18 10:44:39 -07:00
Keith Grant
a5d9bbb1e6
add status icon to job list
2019-10-18 10:08:59 -07:00
softwarefactory-project-zuul[bot]
c262df0dfe
Merge pull request #5009 from wanderboessenkool/rabbit-healthcheck-cpu-usage
...
Change 'rabbitmqctl status' to a wget | grep to save CPU
Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
2019-10-18 16:48:39 +00:00