Ryan Petrello
f8211b0588
add more edge case handling for yaml unsafe marking
2018-04-19 09:16:22 -04:00
Ryan Petrello
31ea55acb9
Merge pull request #1397 from ryanpetrello/unsafe-extra-vars-324
...
mark launch-time extra vars as !unsafe and sanitize Jinja from certain CLI flags
2018-04-19 07:55:53 -04:00
Ryan Petrello
835f2eebc3
make extra var YAML serialization more robust to non-dict extra vars
2018-04-17 15:39:37 -04:00
Ryan Petrello
fe47b75aad
use a three-prong setting for Jinja extra vars policy
2018-04-17 12:08:07 -04:00
Ryan Petrello
7304301948
don't bother building a safe extra vars namespace; it's a file path now
2018-04-17 10:24:14 -04:00
Ryan Petrello
7074dcd677
don't allow usage of jinja templates in certain ansible CLI flags
...
see: https://github.com/ansible/tower/issues/1338
2018-04-17 09:20:05 -04:00
Ryan Petrello
88c243c92a
mark all unsafe launch-time extra vars as !unsafe
...
see: https://github.com/ansible/tower/issues/1338
see: https://bugzilla.redhat.com/show_bug.cgi?id=1565865
2018-04-16 16:47:44 -04:00
Bill Nottingham
bba7f45972
Pass extra vars via file rather than via commandline, including custom creds.
...
The extra vars file created lives in the playbook private runtime
directory, and will be reaped along with the rest of the directory.
Adjust assorted unit tests as necessary.
2018-04-16 16:31:50 -04:00
Alan Rominger
88e2741836
Merge pull request #1370 from AlanCoding/backport_with_items
...
[3.2.4] with_items no_log fix
2018-04-16 09:57:25 -04:00
AlanCoding
77aab65f57
fix no_log leaking with_items values
2018-04-13 15:41:57 -04:00
Alan Rominger
89f770c9ca
Merge pull request #1270 from AlanCoding/user_editability
...
User editing permission changes (3.2.4 backport)
2018-04-06 14:19:50 -04:00
AlanCoding
1195385492
User editing permission changes
...
Only allow administrative action for a user
who is a system admin or auditor if the
the requesting-user is a system admin.
Previously a user could be edited if the
requesting-user was an admin of ANY of the
orgs the user was member of.
This is changed to require admin permission
to ALL orgs the user is member of.
As a special-case, allow org admins to add
a user as a member to their organization if
the following conditions are met:
- the user is not member of any other orgs
- the org admin has permissions to all of
the roles the user has
2018-04-06 14:05:29 -04:00
Wayne Witzel III
f64587cd1c
Merge pull request #1207 from wwitzel3/fix-32-1189
...
Back port of 3.3.0 fix
2018-04-03 09:29:38 -04:00
Wayne Witzel III
c4635fa683
Merge pull request #1199 from wwitzel3/fix-1189
...
Fixes RBAC issue, ensures can admin of sub_obj when needed
2018-04-02 16:06:11 -04:00
Ryan Petrello
61d58b83a4
Merge pull request #1162 from ryanpetrello/release_3.2.4
...
properly filter disabled hosts on smart inventory composition
2018-03-29 08:51:20 -04:00
Ryan Petrello
c1cc92afa0
properly filter disabled hosts on smart inventory composition
...
see: #1053
related: https://github.com/ansible/tower/pull/1155
2018-03-28 17:02:32 -04:00
Ryan Petrello
7842b67bea
Merge pull request #1104 from ryanpetrello/fix-1101
...
properly sanitize module arguments with no_log (like uri:password)
2018-03-26 11:57:28 -04:00
Jared Tabor
7979bc93fb
Merge pull request #1105 from jaredevantabor/background-tabs
...
Fixes issue with sockets and XHR requests for backgrounded tabs
2018-03-23 16:18:25 -07:00
Jared Tabor
df60876bf3
Adds a debug function to turn on $log.debug
2018-03-23 16:17:24 -07:00
Jared Tabor
8643972064
Fixes issue with sockets and XHR requests for backgrounded tabs
...
adjusts toggling based on API setting and doesn't toggle for job stdout page
2018-03-23 12:40:34 -07:00
AlanCoding
f6e507ad12
add API setting for UI live updates
...
include context data
update help text
2018-03-23 12:40:31 -07:00
Ryan Petrello
35e38760aa
properly sanitize module arguments with no_log (like uri:password)
...
this will _not_ sanitize playbooks that have secrets hard-coded *in* the
playbook - for that, people will need to use Vault or a variable/lookup
see: https://github.com/ansible/tower/issues/1101
see: https://github.com/ansible/awx/issues/1633
2018-03-23 11:15:37 -04:00
Ryan Petrello
61aafe15d6
fix busted shippable builds
2018-03-22 16:56:04 -04:00
Shane McDonald
0d86e646ec
Merge pull request #1100 from rooftopcellist/fix_upgrade_python_saml24
...
fix_python_saml24_update
2018-03-22 11:48:24 -04:00
adamscmRH
ad37f71af4
fix_python_saml24_update
2018-03-22 11:26:17 -04:00
Shane McDonald
f8b5318206
Merge pull request #1093 from rooftopcellist/upgrade_python_saml
...
upgrade python-saml for CVE fix
2018-03-21 12:27:35 -04:00
adamscmRH
c3842b6bf9
upgrade python-saml for CVE fix
2018-03-21 12:07:18 -04:00
Alan Rominger
1a6819cdea
Merge pull request #630 from AlanCoding/text_type
...
Fix unicode bugs with log statements
2018-02-15 15:52:29 -05:00
AlanCoding
465e605464
fix unicode bugs with log statements
2018-02-15 15:26:58 -05:00
Alan Rominger
5935c410e4
Merge pull request #629 from AlanCoding/export
...
Use --export option for ansible-inventory
2018-02-14 15:56:05 -05:00
AlanCoding
b01deb393e
use --export option for ansible-inventory
2018-02-14 14:48:13 -05:00
Ryan Petrello
3a0f2ce2fe
Merge pull request #628 from ryanpetrello/sudo-become-adhoc
...
add support for new "BECOME" prompt in Ansible 2.5+ for adhoc commands
2018-02-13 14:38:30 -05:00
Ryan Petrello
613d48cdbc
add support for new "BECOME" prompt in Ansible 2.5+ for adhoc commands
...
see: https://github.com/ansible/ansible-tower/issues/7850
2018-02-13 14:26:27 -05:00
Ryan Petrello
eda53eb548
Merge pull request #627 from ryanpetrello/fix-7898
...
enforce strings for secret password inputs on Credentials
2018-02-12 17:11:02 -05:00
Ryan Petrello
82e41b40bb
enforce strings for secret password inputs on Credentials
...
see: https://github.com/ansible/ansible-tower/issues/7898
2018-02-12 17:03:32 -05:00
Ryan Petrello
bd2f1568fb
Merge pull request #626 from ryanpetrello/release_3.2.3
...
fix a bug for "users should be able to change type of unused credential"
2018-02-08 15:59:22 -05:00
Ryan Petrello
72715df751
fix a bug for "users should be able to change type of unused credential"
...
see: https://github.com/ansible/ansible-tower/issues/7516
related: https://github.com/ansible/tower/pull/441
2018-02-08 15:44:14 -05:00
John Mitchell
7e400413db
Merge pull request #625 from jlmitch5/fixXSS
...
fix xss vulnerabilities
2018-02-01 11:49:35 -05:00
John Mitchell
28596b7d5e
fix xss vulnerabilities
...
- on host recent jobs popover
- on schedule name tooltip
2018-01-30 16:30:00 -05:00
Jake McDermott
a2e274d1f9
Merge pull request #623 from jakemcdermott/fix-ansible-tower-7871
...
bump templates form credential_types page limit
2018-01-30 14:48:36 -05:00
Ryan Petrello
d96cc51431
Merge pull request #624 from ryanpetrello/release_3.2.3
...
fix a bug when testing UDP-based logging configuration
2018-01-30 10:27:39 -05:00
Ryan Petrello
982539f444
fix a bug when testing UDP-based logging configuration
...
see: https://github.com/ansible/ansible-tower/issues/7868
2018-01-29 12:05:51 -05:00
Jake McDermott
4c79e6912e
bump templates form credential_types page limit
2018-01-28 21:50:30 -05:00
Matthew Jones
42098bfa6d
Merge pull request #621 from ryanpetrello/set_stat_workflow_race_condition
...
don't process artifacts from custom `set_stat` calls asynchronously
2018-01-24 10:27:19 -05:00
Wayne Witzel III
b205630490
Merge pull request #622 from wwitzel3/release_3.2.3
...
Wait for Slack RTM API websocket connection to be established
2018-01-24 08:59:45 -05:00
Wayne Witzel III
aa469d730e
Wait for Slack RTM API websocket connection to be established
2018-01-24 13:48:42 +00:00
Ryan Petrello
d57470ce49
don't process artifacts from custom set_stat
calls asynchronously
...
previously, we persisted custom artifacts to the database on
`Job.artifacts` via the callback receiver. when the callback receiver
is backed up processing events, this can result in race conditions for
workflows where a playbook calls `set_stat()`, but the artifact data is
not persisted in the database before the next job in the workflow starts
see: https://github.com/ansible/ansible-tower/issues/7831
2018-01-23 17:09:23 -05:00
Ryan Petrello
fa9c6287f7
Merge pull request #620 from ryanpetrello/fix-815
...
don't overwrite env['ANSIBLE_LIBRARY'] when fact caching is enabled
2018-01-15 13:55:42 -05:00
Ryan Petrello
2955842c44
don't overwrite env['ANSIBLE_LIBRARY'] when fact caching is enabled
...
see: https://github.com/ansible/awx/issues/815
see: https://github.com/ansible/ansible-tower/issues/7830
2018-01-15 13:39:46 -05:00
Ryan Petrello
64028dba66
Merge pull request #619 from ryanpetrello/file_based_tower_fact_cache
...
replace our memcached-based fact cache implementation with local files
2018-01-15 11:57:18 -05:00