2006-05-09 19:35:46 +04:00
## Process this file with automake to produce Makefile.in
2013-02-09 03:44:21 +04:00
## Copyright (C) 2005-2013 Red Hat, Inc.
2011-07-28 22:56:24 +04:00
## See COPYING.LIB for the License of this software
2008-03-24 13:19:36 +03:00
SHELL = $( PREFERABLY_POSIX_SHELL)
2006-05-09 19:35:46 +04:00
INCLUDES = \
2012-04-10 16:03:46 +04:00
-I$( top_builddir) -I$( top_srcdir) \
2012-02-03 00:20:09 +04:00
-I$( top_builddir) /gnulib/lib -I$( top_srcdir) /gnulib/lib \
-I$( top_builddir) /include -I$( top_srcdir) /include \
-I$( top_builddir) /src -I$( top_srcdir) /src \
Move all shared utility files to src/util/
* src/bridge.c, src/bridge.h, src/buf.c, src/buf.h, src/cgroup.c,
src/cgroup.h, src/conf.c, src/conf.h, src/event.c, src/event.h,
src/hash.c, src/hash.h, src/hostusb.c, src/hostusb.h,
src/iptables.c, src/iptables.h, src/logging.c, src/logging.h,
src/memory.c, src/memory.h, src/pci.c, src/pci.h, src/qparams.c,
src/qparams.h, src/stats_linux.c, src/stats_linux.h,
src/threads-pthread.c, src/threads-pthread.h, src/threads-win32.c,
src/threads-win32.h, src/threads.c, src/threads.h, src/util.c,
src/util.h, src/uuid.c, src/uuid.h, src/virterror.c,
src/virterror_internal.h, src/xml.c, src/xml.h: Move all files
into src/util/
* daemon/Makefile.am: Add -Isrc/util/ to build flags
* src/Makefile.am: Add -Isrc/util/ to build flags and update for
moved files
* src/libvirt_private.syms: Export cgroup APIs since they're now
in util rather than linking directly to drivers
* src/xen/xs_internal.c: Disable bogus virEventRemoveHandle call
when built under PROXY
* proxy/Makefile.am: Update for changed file locations. Remove
bogus build of event.c
* tools/Makefile.am, tests/Makefile.am: Add -Isrc/util/ to build flags
2009-09-16 19:28:46 +04:00
-I$( top_srcdir) /src/util \
2011-07-28 16:55:21 +04:00
-I$( top_srcdir) /src/conf \
$( GETTEXT_CPPFLAGS)
build: consistently use CFLAGS
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like -Wall belong in CFLAGS since they affect more
phases of the build process. Therefore, we should be sticking CFLAGS
additions into a CFLAGS container, not a CPPFLAGS container.
* src/Makefile.am (libvirt_driver_vmware_la_CFLAGS): Use AM_CFLAGS.
(INCLUDES): Move CFLAGS items...
(AM_CFLAGS): ...to their proper location.
* python/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
* tests/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
(commandtest_CFLAGS, commandhelper_CFLAGS)
(virnetmessagetest_CFLAGS, virnetsockettest_CFLAGS): Use AM_CFLAGS.
2011-06-01 02:15:28 +04:00
AM_CFLAGS = \
2013-02-26 20:40:38 +04:00
-Dabs_builddir= "\"`pwd`\"" \
2007-09-19 21:42:40 +04:00
$( LIBXML_CFLAGS) \
$( GNUTLS_CFLAGS) \
2007-12-05 18:24:15 +03:00
$( SASL_CFLAGS) \
2008-02-20 18:38:29 +03:00
$( SELINUX_CFLAGS) \
2009-10-08 18:34:22 +04:00
$( APPARMOR_CFLAGS) \
2011-06-30 18:08:29 +04:00
$( YAJL_CFLAGS) \
build: consistently use CFLAGS
According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
in automake 1.9.6) should only include -I, -D, and -U directives; more
generic directives like -Wall belong in CFLAGS since they affect more
phases of the build process. Therefore, we should be sticking CFLAGS
additions into a CFLAGS container, not a CPPFLAGS container.
* src/Makefile.am (libvirt_driver_vmware_la_CFLAGS): Use AM_CFLAGS.
(INCLUDES): Move CFLAGS items...
(AM_CFLAGS): ...to their proper location.
* python/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
* tests/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
(commandtest_CFLAGS, commandhelper_CFLAGS)
(virnetmessagetest_CFLAGS, virnetsockettest_CFLAGS): Use AM_CFLAGS.
2011-06-01 02:15:28 +04:00
$( COVERAGE_CFLAGS) \
$( WARN_CFLAGS)
2007-02-14 05:12:41 +03:00
2008-11-21 15:16:08 +03:00
i f W I T H _ D R I V E R _ M O D U L E S
INCLUDES += \
-DTEST_DRIVER_DIR= \" $( top_builddir) /src/.libs\"
e n d i f
build: fix 'make check' linkage with dtrace
Building on Linux with dtrace enabled was failing 'make check':
CCLD nodeinfotest
../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In function `virNetClientNew':
/home/remote/eblake/libvirt/src/rpc/virnetclient.c:162: undefined reference to `libvirt_rpc_client_new_semaphore'
On looking further, I see some earlier warnings emitted from libtool:
*** Warning: Linking the shared library libvirt.la against the non-libtool
*** objects probes.o is not portable!
Since src/probes.o is only built on Linux, and even then, only when
dtrace is enabled, this failure does not affect other platforms, and
despite libtool warning that it is not generally portable, it is not
a problem for our use-case in libvirt.la. But it turns out that while
libtool is willing to jam raw .o files into an installed shared
library (libvirt.la becomes libvirt.so), it is NOT willing to jam
the same .o file into the convenience library libvirt_test.la.
Perhaps this is a bug in libtool, but even if we get libtool fixed,
libvirt must continue to build on platforms with older libtool. So,
the fix is the same as we are already using for the libvirt_lxc
executable - don't rely on the .o file being in the convenience
library, but instead use LDADD to pull it in directly.
* tests/Makefile.am (PROBES_O): New macro.
(LDADDS): Use it to fix link errors.
2011-10-11 23:18:37 +04:00
PROBES_O =
2012-02-24 19:10:53 +04:00
i f W I T H _ D T R A C E _ P R O B E S
2012-05-25 19:57:56 +04:00
PROBES_O += ../src/libvirt_probes.lo
build: fix 'make check' linkage with dtrace
Building on Linux with dtrace enabled was failing 'make check':
CCLD nodeinfotest
../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In function `virNetClientNew':
/home/remote/eblake/libvirt/src/rpc/virnetclient.c:162: undefined reference to `libvirt_rpc_client_new_semaphore'
On looking further, I see some earlier warnings emitted from libtool:
*** Warning: Linking the shared library libvirt.la against the non-libtool
*** objects probes.o is not portable!
Since src/probes.o is only built on Linux, and even then, only when
dtrace is enabled, this failure does not affect other platforms, and
despite libtool warning that it is not generally portable, it is not
a problem for our use-case in libvirt.la. But it turns out that while
libtool is willing to jam raw .o files into an installed shared
library (libvirt.la becomes libvirt.so), it is NOT willing to jam
the same .o file into the convenience library libvirt_test.la.
Perhaps this is a bug in libtool, but even if we get libtool fixed,
libvirt must continue to build on platforms with older libtool. So,
the fix is the same as we are already using for the libvirt_lxc
executable - don't rely on the .o file being in the convenience
library, but instead use LDADD to pull it in directly.
* tests/Makefile.am (PROBES_O): New macro.
(LDADDS): Use it to fix link errors.
2011-10-11 23:18:37 +04:00
e n d i f
2006-05-09 19:35:46 +04:00
LDADDS = \
2007-05-29 18:44:15 +04:00
$( WARN_CFLAGS) \
build: fix 'make check' linkage with dtrace
Building on Linux with dtrace enabled was failing 'make check':
CCLD nodeinfotest
../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In function `virNetClientNew':
/home/remote/eblake/libvirt/src/rpc/virnetclient.c:162: undefined reference to `libvirt_rpc_client_new_semaphore'
On looking further, I see some earlier warnings emitted from libtool:
*** Warning: Linking the shared library libvirt.la against the non-libtool
*** objects probes.o is not portable!
Since src/probes.o is only built on Linux, and even then, only when
dtrace is enabled, this failure does not affect other platforms, and
despite libtool warning that it is not generally portable, it is not
a problem for our use-case in libvirt.la. But it turns out that while
libtool is willing to jam raw .o files into an installed shared
library (libvirt.la becomes libvirt.so), it is NOT willing to jam
the same .o file into the convenience library libvirt_test.la.
Perhaps this is a bug in libtool, but even if we get libtool fixed,
libvirt must continue to build on platforms with older libtool. So,
the fix is the same as we are already using for the libvirt_lxc
executable - don't rely on the .o file being in the convenience
library, but instead use LDADD to pull it in directly.
* tests/Makefile.am (PROBES_O): New macro.
(LDADDS): Use it to fix link errors.
2011-10-11 23:18:37 +04:00
$( PROBES_O) \
2012-04-02 19:45:01 +04:00
../src/libvirt.la \
../gnulib/lib/libgnu.la
2006-05-09 19:35:46 +04:00
2007-11-14 13:35:58 +03:00
EXTRA_DIST = \
2009-01-27 18:29:53 +03:00
capabilityschemadata \
2010-12-16 21:24:00 +03:00
capabilityschematest \
commanddata \
confdata \
cputestdata \
2009-01-27 18:29:53 +03:00
domainschemadata \
2010-12-16 21:24:00 +03:00
domainschematest \
domainsnapshotschematest \
domainsnapshotxml2xmlin \
domainsnapshotxml2xmlout \
2009-07-22 13:07:07 +04:00
interfaceschemadata \
2012-03-26 21:09:31 +04:00
lxcxml2xmldata \
2010-12-16 21:24:00 +03:00
networkschematest \
networkxml2xmlin \
networkxml2xmlout \
2012-12-06 21:20:39 +04:00
networkxml2confdata \
2010-12-16 21:24:00 +03:00
nodedevschemadata \
nodedevschematest \
nodeinfodata \
nwfilterschematest \
nwfilterxml2xmlin \
nwfilterxml2xmlout \
oomtrace.pl \
qemuhelpdata \
qemuxml2argvdata \
qemuxml2xmloutdata \
2011-10-18 23:16:01 +04:00
qemuxmlnsdata \
2012-09-19 17:00:34 +04:00
securityselinuxlabeldata \
2010-12-16 21:24:00 +03:00
schematestutils.sh \
sexpr2xmldata \
2009-01-27 18:29:53 +03:00
storagepoolschematest \
2009-10-09 01:26:30 +04:00
storagepoolxml2xmlin \
2010-12-16 21:24:00 +03:00
storagepoolxml2xmlout \
2013-02-18 16:43:28 +04:00
storagevolxml2argvdata \
2009-01-27 18:29:53 +03:00
storagevolschematest \
2009-10-09 22:17:21 +04:00
storagevolxml2xmlin \
2010-12-16 21:24:00 +03:00
storagevolxml2xmlout \
2012-12-14 19:08:25 +04:00
sysinfodata \
2010-12-16 21:24:00 +03:00
test-lib.sh \
2009-12-24 01:02:44 +03:00
vmx2xmldata \
2010-12-16 21:24:00 +03:00
xencapsdata \
xmconfigdata \
xml2sexprdata \
2011-06-30 19:23:23 +04:00
xml2vmxdata \
.valgrind.supp
2006-05-09 19:35:46 +04:00
2013-03-19 22:36:28 +04:00
test_helpers = commandhelper ssh test_conf
2012-03-27 19:35:01 +04:00
test_programs = virshtest sockettest \
2012-03-24 02:04:18 +04:00
nodeinfotest virbuftest \
2012-03-27 19:35:01 +04:00
commandtest seclabeltest \
virhashtest virnetmessagetest virnetsockettest \
2012-07-11 17:35:43 +04:00
viratomictest \
2013-01-07 18:54:18 +04:00
utiltest shunloadtest \
2012-03-20 19:40:05 +04:00
virtimetest viruritest virkeyfiletest \
2012-09-14 11:46:57 +04:00
virauthconfigtest \
2013-02-09 03:44:21 +04:00
virbitmaptest virendiantest \
2012-01-20 21:49:32 +04:00
viridentitytest \
2013-04-05 20:49:27 +04:00
virkeycodetest \
Introduce an internal API for handling file based lockspaces
The previously introduced virFile{Lock,Unlock} APIs provide a
way to acquire/release fcntl() locks on individual files. For
unknown reason though, the POSIX spec says that fcntl() locks
are released when *any* file handle referring to the same path
is closed. In the following sequence
threadA: fd1 = open("foo")
threadB: fd2 = open("foo")
threadA: virFileLock(fd1)
threadB: virFileLock(fd2)
threadB: close(fd2)
you'd expect threadA to come out holding a lock on 'foo', and
indeed it does hold a lock for a very short time. Unfortunately
when threadB does close(fd2) this releases the lock associated
with fd1. For the current libvirt use case for virFileLock -
pidfiles - this doesn't matter since the lock is acquired
at startup while single threaded an never released until
exit.
To provide a more generally useful API though, it is necessary
to introduce a slightly higher level abstraction, which is to
be referred to as a "lockspace". This is to be provided by
a virLockSpacePtr object in src/util/virlockspace.{c,h}. The
core idea is that the lockspace keeps track of what files are
already open+locked. This means that when a 2nd thread comes
along and tries to acquire a lock, it doesn't end up opening
and closing a new FD. The lockspace just checks the current
list of held locks and immediately returns VIR_ERR_RESOURCE_BUSY.
NB, the API as it stands is designed on the basis that the
files being locked are not being otherwise opened and used
by the application code. One approach to using this API is to
acquire locks based on a hash of the filepath.
eg to lock /var/lib/libvirt/images/foo.img the application
might do
virLockSpacePtr lockspace = virLockSpaceNew("/var/lib/libvirt/imagelocks");
lockname = md5sum("/var/lib/libvirt/images/foo.img");
virLockSpaceAcquireLock(lockspace, lockname);
NB, in this example, the caller should ensure that the path
is canonicalized before calculating the checksum.
It is also possible to do locks directly on resources by
using a NULL lockspace directory and then using the file
path as the lock name eg
virLockSpacePtr lockspace = virLockSpaceNew(NULL);
virLockSpaceAcquireLock(lockspace, "/var/lib/libvirt/images/foo.img");
This is only safe to do though if no other part of the process
will be opening the files. This will be the case when this
code is used inside the soon-to-be-reposted virlockd daemon
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-08-02 20:02:40 +04:00
virlockspacetest \
2012-11-30 19:21:02 +04:00
virstringtest \
2013-01-09 19:11:50 +04:00
virportallocatortest \
2012-12-14 19:08:25 +04:00
sysinfotest \
2013-02-13 22:04:05 +04:00
virstoragetest \
Introduce an internal API for handling file based lockspaces
The previously introduced virFile{Lock,Unlock} APIs provide a
way to acquire/release fcntl() locks on individual files. For
unknown reason though, the POSIX spec says that fcntl() locks
are released when *any* file handle referring to the same path
is closed. In the following sequence
threadA: fd1 = open("foo")
threadB: fd2 = open("foo")
threadA: virFileLock(fd1)
threadB: virFileLock(fd2)
threadB: close(fd2)
you'd expect threadA to come out holding a lock on 'foo', and
indeed it does hold a lock for a very short time. Unfortunately
when threadB does close(fd2) this releases the lock associated
with fd1. For the current libvirt use case for virFileLock -
pidfiles - this doesn't matter since the lock is acquired
at startup while single threaded an never released until
exit.
To provide a more generally useful API though, it is necessary
to introduce a slightly higher level abstraction, which is to
be referred to as a "lockspace". This is to be provided by
a virLockSpacePtr object in src/util/virlockspace.{c,h}. The
core idea is that the lockspace keeps track of what files are
already open+locked. This means that when a 2nd thread comes
along and tries to acquire a lock, it doesn't end up opening
and closing a new FD. The lockspace just checks the current
list of held locks and immediately returns VIR_ERR_RESOURCE_BUSY.
NB, the API as it stands is designed on the basis that the
files being locked are not being otherwise opened and used
by the application code. One approach to using this API is to
acquire locks based on a hash of the filepath.
eg to lock /var/lib/libvirt/images/foo.img the application
might do
virLockSpacePtr lockspace = virLockSpaceNew("/var/lib/libvirt/imagelocks");
lockname = md5sum("/var/lib/libvirt/images/foo.img");
virLockSpaceAcquireLock(lockspace, lockname);
NB, in this example, the caller should ensure that the path
is canonicalized before calculating the checksum.
It is also possible to do locks directly on resources by
using a NULL lockspace directory and then using the file
path as the lock name eg
virLockSpacePtr lockspace = virLockSpaceNew(NULL);
virLockSpaceAcquireLock(lockspace, "/var/lib/libvirt/images/foo.img");
This is only safe to do though if no other part of the process
will be opening the files. This will be the case when this
code is used inside the soon-to-be-reposted virlockd daemon
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-08-02 20:02:40 +04:00
$( NULL)
Prevent crash from dlclose() of libvirt.so
When libvirt calls virInitialize it creates a thread local
for the virErrorPtr storage, and registers a callback to
cleanup memory when a thread exits. When libvirt is dlclose()d
or otherwise made non-resident, the callback function is
removed from memory, but the thread local may still exist
and if a thread later exists, it will invoke the callback
and SEGV. There may also be other thread locals with callbacks
pointing to libvirt code, so it is in general never safe to
unload libvirt.so from memory once initialized.
To allow dlclose() to succeed, but keep libvirt.so resident
in memory, link with '-z nodelete'. This issue was first
found with the libvirt CIM provider, but can potentially
hit many of the dynamic language bindings which all ultimately
involve dlopen() in some way, either on libvirt.so itself,
or on the glue code for the binding which in turns links
to libvirt
* configure.ac, src/Makefile.am: Ensure libvirt.so is linked
with -z nodelete
* cfg.mk, .gitignore, tests/Makefile.am, tests/shunloadhelper.c,
tests/shunloadtest.c: A test case to unload libvirt while
a thread is still running.
2011-09-01 20:57:06 +04:00
2013-01-09 01:02:05 +04:00
i f W I T H _ G N U T L S
2013-01-07 18:54:18 +04:00
test_programs += virnettlscontexttest
e n d i f
2012-08-10 17:31:14 +04:00
i f W I T H _ S E C D R I V E R _ S E L I N U X
test_programs += securityselinuxtest
2013-01-30 19:44:06 +04:00
i f W I T H _ Q E M U
2012-09-19 17:00:34 +04:00
i f W I T H _ A T T R
test_programs += securityselinuxlabeltest
e n d i f
2012-08-10 17:31:14 +04:00
e n d i f
2013-01-30 19:44:06 +04:00
e n d i f
2012-08-10 17:31:14 +04:00
2012-04-02 20:25:30 +04:00
i f W I T H _ D R I V E R _ M O D U L E S
test_programs += virdrivermoduletest
e n d i f
2010-12-06 20:03:35 +03:00
# This is a fake SSH we use from virnetsockettest
ssh_SOURCES = ssh.c
ssh_LDADD = $( COVERAGE_LDFLAGS)
2006-08-24 19:05:19 +04:00
2008-11-24 22:23:39 +03:00
i f W I T H _ X E N
2012-03-27 19:35:01 +04:00
test_programs += xml2sexprtest sexpr2xmltest \
2011-07-08 01:53:41 +04:00
xmconfigtest xencapstest statstest reconnect
2008-11-24 22:23:39 +03:00
e n d i f
2008-11-18 15:46:13 +03:00
i f W I T H _ Q E M U
2012-03-27 19:35:01 +04:00
test_programs += qemuxml2argvtest qemuxml2xmltest qemuxmlnstest \
2012-02-26 04:48:02 +04:00
qemuargv2xmltest qemuhelptest domainsnapshotxml2xmltest \
2012-08-20 16:31:29 +04:00
qemumonitortest qemumonitorjsontest
2008-11-18 15:46:13 +03:00
e n d i f
2012-03-26 21:09:31 +04:00
i f W I T H _ L X C
2012-03-27 19:35:01 +04:00
test_programs += lxcxml2xmltest
2012-03-26 21:09:31 +04:00
e n d i f
2011-05-26 21:45:41 +04:00
i f W I T H _ O P E N V Z
2012-03-27 19:35:01 +04:00
test_programs += openvzutilstest
2011-05-26 21:45:41 +04:00
e n d i f
2009-09-23 16:25:52 +04:00
i f W I T H _ E S X
2012-03-27 19:35:01 +04:00
test_programs += esxutilstest
2010-12-22 00:39:55 +03:00
e n d i f
i f W I T H _ V M X
2012-03-27 19:35:01 +04:00
test_programs += vmx2xmltest xml2vmxtest
2009-09-23 16:25:52 +04:00
e n d i f
2009-05-19 14:17:17 +04:00
i f W I T H _ C I L
2012-03-27 19:35:01 +04:00
test_programs += object-locking
2009-05-19 14:17:17 +04:00
e n d i f
2012-09-20 15:57:13 +04:00
i f W I T H _ Y A J L
2012-03-27 19:35:01 +04:00
test_programs += jsontest
2011-06-30 18:08:29 +04:00
e n d i f
2012-03-27 19:35:01 +04:00
test_programs += networkxml2xmltest
2009-10-09 16:47:43 +04:00
2011-07-05 17:26:18 +04:00
i f W I T H _ N E T W O R K
2012-12-06 21:20:39 +04:00
test_programs += networkxml2conftest
2011-07-05 17:26:18 +04:00
e n d i f
2011-06-24 14:04:37 +04:00
2012-07-18 23:06:58 +04:00
i f W I T H _ S T O R A G E _ S H E E P D O G
test_programs += storagebackendsheepdogtest
e n d i f
2012-03-27 19:35:01 +04:00
test_programs += nwfilterxml2xmltest
2010-04-02 21:28:28 +04:00
2013-04-15 20:01:02 +04:00
i f W I T H _ S T O R A G E
2013-02-18 16:43:28 +04:00
test_programs += storagevolxml2argvtest
2013-04-15 20:01:02 +04:00
e n d i f
2013-02-18 16:43:28 +04:00
2012-03-27 19:35:01 +04:00
test_programs += storagevolxml2xmltest storagepoolxml2xmltest
2009-10-09 01:26:30 +04:00
2012-03-27 19:35:01 +04:00
test_programs += nodedevxml2xmltest
2009-02-24 17:58:32 +03:00
2012-03-27 19:35:01 +04:00
test_programs += interfacexml2xmltest
2009-07-15 21:50:34 +04:00
2012-03-27 19:35:01 +04:00
test_programs += cputest
2010-10-07 18:35:17 +04:00
2009-01-27 18:29:53 +03:00
test_scripts = \
capabilityschematest \
2009-07-15 21:50:34 +04:00
interfaceschematest \
2009-01-27 18:29:53 +03:00
networkschematest \
storagepoolschematest \
storagevolschematest \
domainschematest \
2010-04-06 19:09:46 +04:00
nodedevschematest \
2010-05-04 01:15:18 +04:00
nwfilterschematest \
domainsnapshotschematest
2009-01-27 18:29:53 +03:00
2008-06-26 13:37:51 +04:00
i f W I T H _ L I B V I R T D
2009-01-16 21:07:24 +03:00
test_scripts += \
test_conf.sh \
cpuset \
define-dev-segfault \
int-overflow \
2009-03-02 23:01:05 +03:00
libvirtd-fail \
libvirtd-pool \
2009-01-16 21:07:24 +03:00
read-bufsiz \
read-non-seekable \
start \
vcpupin \
virsh-all \
2011-04-13 01:59:19 +04:00
virsh-optparse \
2010-05-11 17:38:21 +04:00
virsh-schedinfo \
2012-09-12 21:25:51 +04:00
virsh-synopsis \
virsh-undefine \
$( NULL)
2012-03-27 19:35:01 +04:00
2012-04-04 18:01:46 +04:00
test_programs += \
eventtest \
libvirtdconftest
2011-05-13 12:03:20 +04:00
e l s e
EXTRA_DIST += \
test_conf.sh \
cpuset \
define-dev-segfault \
int-overflow \
libvirtd-fail \
libvirtd-pool \
read-bufsiz \
read-non-seekable \
start \
vcpupin \
virsh-all \
virsh-optparse \
virsh-schedinfo \
2012-09-12 21:25:51 +04:00
virsh-synopsis \
virsh-undefine \
$( NULL)
2008-06-26 13:37:51 +04:00
e n d i f
2007-12-12 00:20:13 +03:00
2009-10-08 18:34:22 +04:00
i f W I T H _ S E C D R I V E R _ A P P A R M O R
test_scripts += virt-aa-helper-test
2009-12-14 15:40:42 +03:00
e l s e
EXTRA_DIST += virt-aa-helper-test
2009-10-08 18:34:22 +04:00
e n d i f
2009-12-14 15:40:42 +03:00
2007-11-14 13:35:58 +03:00
EXTRA_DIST += $( test_scripts)
2013-01-09 19:11:50 +04:00
test_libraries = libshunload.la \
libvirportallocatormock.la \
$( NULL)
2012-08-20 17:06:21 +04:00
i f W I T H _ Q E M U
test_libraries += libqemumonitortestutils.la
e n d i f
2012-03-27 19:35:01 +04:00
i f W I T H _ T E S T S
noinst_PROGRAMS = $( test_programs) $( test_helpers)
2012-08-20 17:06:21 +04:00
noinst_LTLIBRARIES = $( test_libraries)
2012-03-27 19:35:01 +04:00
e l s e
check_PROGRAMS = $( test_programs) $( test_helpers)
2012-08-20 17:06:21 +04:00
check_LTLIBRARIES = $( test_libraries)
2011-07-05 17:26:18 +04:00
e n d i f
2011-06-24 14:04:37 +04:00
2012-03-27 19:35:01 +04:00
TESTS = $( test_programs) \
$( test_scripts)
2010-10-07 18:35:17 +04:00
2007-11-17 16:16:47 +03:00
# NB, automake < 1.10 does not provide the real
2010-12-15 03:23:22 +03:00
# abs_top_{src/build}dir or builddir variables, so don't rely
2007-11-17 16:16:47 +03:00
# on them here. Fake them with 'pwd'
2011-07-29 18:52:27 +04:00
# Also, BSD sh doesn't like 'a=b b=$$a', so we can't use an
# intermediate shell variable, but must do all the expansion in make
lv_abs_top_builddir = ` cd '$(top_builddir)' ; pwd `
path_add = $( lv_abs_top_builddir) /daemon$( PATH_SEPARATOR) $( lv_abs_top_builddir) /tools$( PATH_SEPARATOR) $( lv_abs_top_builddir) /tests
2007-11-12 17:00:32 +03:00
TESTS_ENVIRONMENT = \
2011-07-29 18:52:27 +04:00
abs_top_builddir = $( lv_abs_top_builddir) \
2008-03-24 13:18:36 +03:00
abs_top_srcdir = ` cd '$(top_srcdir)' ; pwd ` \
2010-12-15 03:23:22 +03:00
abs_builddir = ` pwd ` \
2008-04-18 19:28:33 +04:00
abs_srcdir = ` cd '$(srcdir)' ; pwd ` \
2009-03-04 16:04:06 +03:00
CONFIG_HEADER = " `cd ' $( top_builddir) '; pwd`/config.h " \
2008-03-24 13:18:36 +03:00
PATH = " $( path_add) $( PATH_SEPARATOR) $$ PATH " \
2008-03-24 13:19:36 +03:00
SHELL = " $( SHELL) " \
2008-11-21 15:16:08 +03:00
LIBVIRT_DRIVER_DIR = " $( abs_top_builddir) /src/.libs " \
2012-08-07 15:02:06 +04:00
LIBVIRT_AUTOSTART = 0 \
2008-12-21 02:23:50 +03:00
LC_ALL = C \
2007-11-12 17:00:32 +03:00
$( VG)
2012-03-27 19:35:01 +04:00
2006-08-24 20:00:19 +04:00
valgrind :
2010-11-24 23:41:50 +03:00
$( MAKE) check VG = " libtool --mode=execute valgrind --quiet --leak-check=full --suppressions= $( srcdir) /.valgrind.supp "
2006-08-24 20:00:19 +04:00
2010-10-21 22:11:50 +04:00
sockettest_SOURCES = \
sockettest.c \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
sockettest_LDADD = $( LDADDS)
2010-10-21 22:11:50 +04:00
2008-11-24 22:23:39 +03:00
i f W I T H _ X E N
2012-05-25 23:18:10 +04:00
xen_LDADDS = ../src/libvirt_driver_xen_impl.la
2012-04-02 19:45:01 +04:00
xen_LDADDS += $( LDADDS)
2006-08-24 19:05:19 +04:00
xml2sexprtest_SOURCES = \
2008-07-25 17:17:27 +04:00
xml2sexprtest.c testutilsxen.c testutilsxen.h \
2006-08-24 19:05:19 +04:00
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
xml2sexprtest_LDADD = $( xen_LDADDS)
2006-08-24 19:05:19 +04:00
sexpr2xmltest_SOURCES = \
2009-01-22 21:19:20 +03:00
sexpr2xmltest.c testutilsxen.c testutilsxen.h \
2006-08-24 19:05:19 +04:00
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
sexpr2xmltest_LDADD = $( xen_LDADDS)
2006-08-24 19:05:19 +04:00
2007-01-19 23:30:05 +03:00
xmconfigtest_SOURCES = \
2008-07-25 17:39:02 +04:00
xmconfigtest.c testutilsxen.c testutilsxen.h \
2007-01-19 23:30:05 +03:00
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
xmconfigtest_LDADD = $( xen_LDADDS)
2007-01-19 23:30:05 +03:00
2008-11-24 22:23:39 +03:00
xencapstest_SOURCES = \
xencapstest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
xencapstest_LDADD = $( xen_LDADDS)
2008-11-24 22:23:39 +03:00
reconnect_SOURCES = \
2011-07-09 13:50:38 +04:00
reconnect.c testutils.h testutils.c
2008-11-24 22:23:39 +03:00
reconnect_LDADD = $( LDADDS)
2010-10-14 16:22:18 +04:00
statstest_SOURCES = \
statstest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
statstest_LDADD = $( xen_LDADDS)
2010-10-14 16:22:18 +04:00
2008-11-24 22:23:39 +03:00
e l s e
EXTRA_DIST += xml2sexprtest.c sexpr2xmltest.c xmconfigtest.c \
xencapstest.c reconnect.c \
testutilsxen.c testutilsxen.h
e n d i f
2012-08-20 17:06:21 +04:00
QEMUMONITORTESTUTILS_SOURCES = \
qemumonitortestutils.c \
qemumonitortestutils.h \
$( NULL)
2008-11-18 15:46:13 +03:00
i f W I T H _ Q E M U
2011-07-04 10:27:12 +04:00
2012-08-20 17:06:21 +04:00
libqemumonitortestutils_la_SOURCES = $( QEMUMONITORTESTUTILS_SOURCES)
2012-08-02 16:10:31 +04:00
qemu_LDADDS = ../src/libvirt_driver_qemu_impl.la
2011-07-04 10:27:12 +04:00
i f W I T H _ N E T W O R K
2012-05-25 23:18:10 +04:00
qemu_LDADDS += ../src/libvirt_driver_network_impl.la
2011-07-04 10:27:12 +04:00
e n d i f
2012-04-02 21:24:29 +04:00
i f W I T H _ D T R A C E _ P R O B E S
2012-05-25 19:57:56 +04:00
qemu_LDADDS += ../src/libvirt_qemu_probes.lo
2012-04-02 21:24:29 +04:00
e n d i f
2012-04-02 19:45:01 +04:00
qemu_LDADDS += $( LDADDS)
2011-07-04 10:27:12 +04:00
2007-07-19 01:34:22 +04:00
qemuxml2argvtest_SOURCES = \
2008-05-16 20:51:30 +04:00
qemuxml2argvtest.c testutilsqemu.c testutilsqemu.h \
2007-07-19 01:34:22 +04:00
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
qemuxml2argvtest_LDADD = $( qemu_LDADDS)
2007-07-19 01:34:22 +04:00
qemuxml2xmltest_SOURCES = \
2008-05-16 20:51:30 +04:00
qemuxml2xmltest.c testutilsqemu.c testutilsqemu.h \
2007-07-19 01:34:22 +04:00
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
qemuxml2xmltest_LDADD = $( qemu_LDADDS)
2009-05-21 18:22:51 +04:00
2011-10-18 23:16:01 +04:00
qemuxmlnstest_SOURCES = \
qemuxmlnstest.c testutilsqemu.c testutilsqemu.h \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
qemuxmlnstest_LDADD = $( qemu_LDADDS)
2011-10-18 23:16:01 +04:00
2009-05-21 18:22:51 +04:00
qemuargv2xmltest_SOURCES = \
qemuargv2xmltest.c testutilsqemu.c testutilsqemu.h \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
qemuargv2xmltest_LDADD = $( qemu_LDADDS)
2009-06-11 18:17:42 +04:00
qemuhelptest_SOURCES = qemuhelptest.c testutils.c testutils.h
2012-04-02 19:45:01 +04:00
qemuhelptest_LDADD = $( qemu_LDADDS)
2011-09-23 00:29:00 +04:00
2012-02-26 04:48:02 +04:00
qemumonitortest_SOURCES = qemumonitortest.c testutils.c testutils.h
2012-04-02 19:45:01 +04:00
qemumonitortest_LDADD = $( qemu_LDADDS)
2012-02-26 04:48:02 +04:00
2012-08-20 16:31:29 +04:00
qemumonitorjsontest_SOURCES = \
qemumonitorjsontest.c \
testutils.c testutils.h \
testutilsqemu.c testutilsqemu.h \
$( NULL)
qemumonitorjsontest_LDADD = $( qemu_LDADDS) libqemumonitortestutils.la
2011-09-23 00:29:00 +04:00
domainsnapshotxml2xmltest_SOURCES = \
domainsnapshotxml2xmltest.c testutilsqemu.c testutilsqemu.h \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
domainsnapshotxml2xmltest_LDADD = $( qemu_LDADDS)
2008-11-18 15:46:13 +03:00
e l s e
2011-09-23 00:29:00 +04:00
EXTRA_DIST += qemuxml2argvtest.c qemuxml2xmltest.c qemuargv2xmltest.c \
qemuxmlnstest.c qemuhelptest.c domainsnapshotxml2xmltest.c \
2012-08-20 17:06:21 +04:00
qemumonitortest.c testutilsqemu.c testutilsqemu.h \
2012-08-20 16:31:29 +04:00
qemumonitorjsontest.c \
2012-08-20 17:06:21 +04:00
$( QEMUMONITORTESTUTILS_SOURCES)
2008-11-18 15:46:13 +03:00
e n d i f
2007-07-19 01:34:22 +04:00
2012-03-26 21:09:31 +04:00
i f W I T H _ L X C
2012-05-25 23:18:10 +04:00
lxc_LDADDS = ../src/libvirt_driver_lxc_impl.la
2012-04-02 19:45:01 +04:00
i f W I T H _ N E T W O R K
2012-05-25 23:18:10 +04:00
lxc_LDADDS += ../src/libvirt_driver_network_impl.la
2012-04-02 19:45:01 +04:00
e n d i f
lxc_LDADDS += $( LDADDS)
2012-03-26 21:09:31 +04:00
lxcxml2xmltest_SOURCES = \
lxcxml2xmltest.c testutilslxc.c testutilslxc.h \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
lxcxml2xmltest_LDADD = $( lxc_LDADDS)
2012-03-26 21:09:31 +04:00
e l s e
EXTRA_DIST += lxcxml2xmltest.c testutilslxc.c testutilslxc.h
e n d i f
2011-05-26 21:45:41 +04:00
i f W I T H _ O P E N V Z
openvzutilstest_SOURCES = \
openvzutilstest.c \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
openvzutilstest_LDADD = $( LDADDS)
2011-05-26 21:45:41 +04:00
e l s e
EXTRA_DIST += openvzutilstest.c
e n d i f
EXTRA_DIST += openvzutilstest.conf
2009-09-23 16:25:52 +04:00
i f W I T H _ E S X
esxutilstest_SOURCES = \
esxutilstest.c \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
esxutilstest_LDADD = $( LDADDS)
2010-12-22 00:39:55 +03:00
e l s e
EXTRA_DIST += esxutilstest.c
e n d i f
2009-09-23 16:25:52 +04:00
2010-12-22 00:39:55 +03:00
i f W I T H _ V M X
2009-09-23 16:25:52 +04:00
vmx2xmltest_SOURCES = \
vmx2xmltest.c \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
vmx2xmltest_LDADD = $( LDADDS)
2009-09-23 16:25:52 +04:00
xml2vmxtest_SOURCES = \
xml2vmxtest.c \
testutils.c testutils.h
2012-04-02 19:45:01 +04:00
xml2vmxtest_LDADD = $( LDADDS)
2009-09-23 16:25:52 +04:00
e l s e
2010-12-22 00:39:55 +03:00
EXTRA_DIST += vmx2xmltest.c xml2vmxtest.c
2009-09-23 16:25:52 +04:00
e n d i f
2009-10-09 16:47:43 +04:00
networkxml2xmltest_SOURCES = \
networkxml2xmltest.c \
testutils.c testutils.h
networkxml2xmltest_LDADD = $( LDADDS)
2011-07-05 17:26:18 +04:00
i f W I T H _ N E T W O R K
2012-12-06 21:20:39 +04:00
networkxml2conftest_SOURCES = \
networkxml2conftest.c \
2011-06-24 14:04:37 +04:00
testutils.c testutils.h
2012-12-06 21:20:39 +04:00
networkxml2conftest_LDADD = ../src/libvirt_driver_network_impl.la $( LDADDS)
2011-07-05 17:26:18 +04:00
e l s e
2012-12-06 21:20:39 +04:00
EXTRA_DIST += networkxml2conftest.c
2011-07-05 17:26:18 +04:00
e n d i f
2011-06-24 14:04:37 +04:00
2012-07-18 23:06:58 +04:00
i f W I T H _ S T O R A G E _ S H E E P D O G
storagebackendsheepdogtest_SOURCES = \
storagebackendsheepdogtest.c \
testutils.c testutils.h
2012-08-21 16:50:28 +04:00
storagebackendsheepdogtest_LDADD = \
../src/libvirt_driver_storage_impl.la $( LDADDS)
2012-07-18 23:06:58 +04:00
e l s e
EXTRA_DIST += storagebackendsheepdogtest.c
e n d i f
2010-04-02 21:28:28 +04:00
nwfilterxml2xmltest_SOURCES = \
nwfilterxml2xmltest.c \
testutils.c testutils.h
nwfilterxml2xmltest_LDADD = $( LDADDS)
2013-02-18 16:43:28 +04:00
2013-04-15 20:01:02 +04:00
i f W I T H _ S T O R A G E
2013-02-18 16:43:28 +04:00
storagevolxml2argvtest_SOURCES = \
storagevolxml2argvtest.c \
testutils.c testutils.h
storagevolxml2argvtest_LDADD = \
../src/libvirt_driver_storage_impl.la $( LDADDS)
2013-04-15 20:01:02 +04:00
e l s e
EXTRA_DIST += storagevolxml2argvtest.c
e n d i f
2010-04-02 21:28:28 +04:00
2009-10-09 22:17:21 +04:00
storagevolxml2xmltest_SOURCES = \
storagevolxml2xmltest.c \
testutils.c testutils.h
storagevolxml2xmltest_LDADD = $( LDADDS)
2009-10-09 01:26:30 +04:00
storagepoolxml2xmltest_SOURCES = \
storagepoolxml2xmltest.c \
testutils.c testutils.h
storagepoolxml2xmltest_LDADD = $( LDADDS)
2009-02-24 17:58:32 +03:00
nodedevxml2xmltest_SOURCES = \
nodedevxml2xmltest.c \
testutils.c testutils.h
2009-03-03 20:00:18 +03:00
nodedevxml2xmltest_LDADD = $( LDADDS)
2009-02-24 17:58:32 +03:00
2009-07-15 21:50:34 +04:00
interfacexml2xmltest_SOURCES = \
interfacexml2xmltest.c \
testutils.c testutils.h
interfacexml2xmltest_LDADD = $( LDADDS)
2010-10-07 18:35:17 +04:00
cputest_SOURCES = \
cputest.c \
testutils.c testutils.h
cputest_LDADD = $( LDADDS)
2006-08-25 01:46:28 +04:00
virshtest_SOURCES = \
virshtest.c \
testutils.c testutils.h
virshtest_LDADD = $( LDADDS)
2013-03-19 22:36:28 +04:00
test_conf_SOURCES = \
test_conf.c
test_conf_LDADD = $( LDADDS)
2006-08-30 02:27:07 +04:00
2007-07-26 03:16:30 +04:00
nodeinfotest_SOURCES = \
nodeinfotest.c testutils.h testutils.c
nodeinfotest_LDADD = $( LDADDS)
2010-05-25 15:14:06 +04:00
commandtest_SOURCES = \
commandtest.c testutils.h testutils.c
commandtest_LDADD = $( LDADDS)
commandhelper_SOURCES = \
commandhelper.c
commandhelper_LDADD = $( LDADDS)
2012-04-02 19:45:01 +04:00
commandhelper_LDFLAGS = -static
2010-05-25 15:14:06 +04:00
2012-04-04 18:01:46 +04:00
i f W I T H _ L I B V I R T D
libvirtdconftest_SOURCES = \
libvirtdconftest.c testutils.h testutils.c \
../daemon/libvirtd-config.c
libvirtdconftest_LDADD = $( LDADDS)
e l s e
EXTRA_DIST += libvirtdconftest.c
e n d i f
2010-12-06 20:03:22 +03:00
virnetmessagetest_SOURCES = \
virnetmessagetest.c testutils.h testutils.c
2013-02-26 20:40:38 +04:00
virnetmessagetest_CFLAGS = $( XDR_CFLAGS) $( AM_CFLAGS)
2012-04-02 19:45:01 +04:00
virnetmessagetest_LDADD = $( LDADDS)
2010-12-06 20:03:22 +03:00
2010-12-06 20:03:35 +03:00
virnetsockettest_SOURCES = \
virnetsockettest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
virnetsockettest_LDADD = $( LDADDS)
2010-12-06 20:03:35 +03:00
2013-01-09 01:02:05 +04:00
i f W I T H _ G N U T L S
2011-07-20 22:04:18 +04:00
virnettlscontexttest_SOURCES = \
2011-07-22 21:59:37 +04:00
virnettlscontexttest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
virnettlscontexttest_LDADD = $( LDADDS)
2011-07-22 21:59:37 +04:00
i f H A V E _ L I B T A S N 1
virnettlscontexttest_SOURCES += pkix_asn1_tab.c
virnettlscontexttest_LDADD += -ltasn1
e l s e
EXTRA_DIST += pkix_asn1_tab.c
e n d i f
2013-01-07 18:54:18 +04:00
e l s e
EXTRA_DIST += \
virnettlscontexttest.c testutils.h testutils.c pkix_asn1_tab.c
e n d i f
2011-07-20 22:04:18 +04:00
2011-11-29 16:11:01 +04:00
virtimetest_SOURCES = \
virtimetest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
virtimetest_LDADD = $( LDADDS)
2011-11-29 16:11:01 +04:00
2012-11-30 19:21:02 +04:00
virstringtest_SOURCES = \
virstringtest.c testutils.h testutils.c
virstringtest_LDADD = $( LDADDS)
2013-02-13 22:04:05 +04:00
virstoragetest_SOURCES = \
virstoragetest.c testutils.h testutils.c
virstoragetest_LDADD = $( LDADDS)
2012-01-20 21:49:32 +04:00
viridentitytest_SOURCES = \
viridentitytest.c testutils.h testutils.c
viridentitytest_LDADD = $( LDADDS)
2013-04-05 20:49:27 +04:00
virkeycodetest_SOURCES = \
virkeycodetest.c testutils.h testutils.c
virkeycodetest_LDADD = $( LDADDS)
Introduce an internal API for handling file based lockspaces
The previously introduced virFile{Lock,Unlock} APIs provide a
way to acquire/release fcntl() locks on individual files. For
unknown reason though, the POSIX spec says that fcntl() locks
are released when *any* file handle referring to the same path
is closed. In the following sequence
threadA: fd1 = open("foo")
threadB: fd2 = open("foo")
threadA: virFileLock(fd1)
threadB: virFileLock(fd2)
threadB: close(fd2)
you'd expect threadA to come out holding a lock on 'foo', and
indeed it does hold a lock for a very short time. Unfortunately
when threadB does close(fd2) this releases the lock associated
with fd1. For the current libvirt use case for virFileLock -
pidfiles - this doesn't matter since the lock is acquired
at startup while single threaded an never released until
exit.
To provide a more generally useful API though, it is necessary
to introduce a slightly higher level abstraction, which is to
be referred to as a "lockspace". This is to be provided by
a virLockSpacePtr object in src/util/virlockspace.{c,h}. The
core idea is that the lockspace keeps track of what files are
already open+locked. This means that when a 2nd thread comes
along and tries to acquire a lock, it doesn't end up opening
and closing a new FD. The lockspace just checks the current
list of held locks and immediately returns VIR_ERR_RESOURCE_BUSY.
NB, the API as it stands is designed on the basis that the
files being locked are not being otherwise opened and used
by the application code. One approach to using this API is to
acquire locks based on a hash of the filepath.
eg to lock /var/lib/libvirt/images/foo.img the application
might do
virLockSpacePtr lockspace = virLockSpaceNew("/var/lib/libvirt/imagelocks");
lockname = md5sum("/var/lib/libvirt/images/foo.img");
virLockSpaceAcquireLock(lockspace, lockname);
NB, in this example, the caller should ensure that the path
is canonicalized before calculating the checksum.
It is also possible to do locks directly on resources by
using a NULL lockspace directory and then using the file
path as the lock name eg
virLockSpacePtr lockspace = virLockSpaceNew(NULL);
virLockSpaceAcquireLock(lockspace, "/var/lib/libvirt/images/foo.img");
This is only safe to do though if no other part of the process
will be opening the files. This will be the case when this
code is used inside the soon-to-be-reposted virlockd daemon
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-08-02 20:02:40 +04:00
virlockspacetest_SOURCES = \
virlockspacetest.c testutils.h testutils.c
virlockspacetest_LDADD = $( LDADDS)
2013-01-09 19:11:50 +04:00
virportallocatortest_SOURCES = \
virportallocatortest.c testutils.h testutils.c
virportallocatortest_LDADD = $( LDADDS)
libvirportallocatormock_la_SOURCES = \
virportallocatortest.c
libvirportallocatormock_la_CFLAGS = $( AM_CFLAGS) -DMOCK_HELPER= 1
libvirportallocatormock_la_LDFLAGS = -module -avoid-version \
-rpath /evil/libtool/hack/to/force/shared/lib/creation
2012-03-20 15:55:11 +04:00
viruritest_SOURCES = \
viruritest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
viruritest_LDADD = $( LDADDS)
2010-12-06 20:03:22 +03:00
2012-03-16 20:29:49 +04:00
virkeyfiletest_SOURCES = \
virkeyfiletest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
virkeyfiletest_LDADD = $( LDADDS)
2012-03-16 20:29:49 +04:00
2012-03-20 19:40:05 +04:00
virauthconfigtest_SOURCES = \
virauthconfigtest.c testutils.h testutils.c
2012-04-02 19:45:01 +04:00
virauthconfigtest_LDADD = $( LDADDS)
2012-03-20 19:40:05 +04:00
2009-04-03 14:55:51 +04:00
seclabeltest_SOURCES = \
seclabeltest.c
2012-08-02 16:10:31 +04:00
seclabeltest_LDADD = $( LDADDS)
2009-10-08 18:34:22 +04:00
2012-08-10 17:31:14 +04:00
i f W I T H _ S E C D R I V E R _ S E L I N U X
i f W I T H _ T E S T S
noinst_LTLIBRARIES += libsecurityselinuxhelper.la
e l s e
check_LTLIBRARIES += libsecurityselinuxhelper.la
e n d i f
libsecurityselinuxhelper_la_SOURCES = \
securityselinuxhelper.c
libsecurityselinuxhelper_la_LDFLAGS = -module -avoid-version \
-rpath /evil/libtool/hack/to/force/shared/lib/creation
securityselinuxtest_SOURCES = \
securityselinuxtest.c testutils.h testutils.c
securityselinuxtest_LDADD = $( LDADDS)
2012-09-19 17:00:34 +04:00
securityselinuxtest_DEPENDENCIES = libsecurityselinuxhelper.la ../src/libvirt.la
i f W I T H _ Q E M U
i f W I T H _ A T T R
securityselinuxlabeltest_SOURCES = \
securityselinuxlabeltest.c testutils.h testutils.c \
testutilsqemu.h testutilsqemu.c
securityselinuxlabeltest_LDADD = $( qemu_LDADDS)
securityselinuxlabeltest_DEPENDENCIES = libsecurityselinuxhelper.la ../src/libvirt.la
e n d i f
e n d i f
2012-08-10 17:31:14 +04:00
e n d i f
2012-09-19 17:00:34 +04:00
EXTRA_DIST += securityselinuxtest.c securityselinuxlabeltest.c securityselinuxhelper.c
2012-08-10 17:31:14 +04:00
buf: Fix possible infinite loop in EscapeString, VSnprintf
The current code will go into an infinite loop if the printf generated
string is >= 1000, AND exactly 1 character smaller than the amount of free
space in the buffer. When this happens, we are dropped into the loop body,
but nothing will actually change, because count == (buf->size - buf->use - 1),
and virBufferGrow returns unchanged if count < (buf->size - buf->use)
Fix this by removing the '- 1' bit from 'size'. The *nprintf functions handle
the NULL byte for us anyways, so we shouldn't need to manually accommodate
for it.
Here's a bug where we are actually hitting this issue:
https://bugzilla.redhat.com/show_bug.cgi?id=602772
v2: Eric's improvements: while -> if (), remove extra va_list variable,
make sure we report buffer error if snprintf fails
v3: Add tests/virbuftest which reproduces the infinite loop before this
patch, works correctly after
2010-09-01 21:51:35 +04:00
virbuftest_SOURCES = \
virbuftest.c testutils.h testutils.c
virbuftest_LDADD = $( LDADDS)
2012-01-25 20:13:59 +04:00
virhashtest_SOURCES = \
virhashtest.c virhashdata.h testutils.h testutils.c
virhashtest_LDADD = $( LDADDS)
2011-04-15 15:15:37 +04:00
2012-07-11 17:35:43 +04:00
viratomictest_SOURCES = \
2012-08-03 08:47:38 +04:00
viratomictest.c testutils.h testutils.c
2012-07-11 17:35:43 +04:00
viratomictest_LDADD = $( LDADDS)
2012-09-14 11:46:57 +04:00
virbitmaptest_SOURCES = \
virbitmaptest.c testutils.h testutils.c
virbitmaptest_LDADD = $( LDADDS)
2013-02-09 03:44:21 +04:00
virendiantest_SOURCES = \
virendiantest.c testutils.h testutils.c
virendiantest_LDADD = $( LDADDS)
2011-06-30 18:08:29 +04:00
jsontest_SOURCES = \
2011-07-01 13:16:33 +04:00
jsontest.c testutils.h testutils.c
2011-06-30 18:08:29 +04:00
jsontest_LDADD = $( LDADDS)
2011-07-01 21:58:15 +04:00
utiltest_SOURCES = \
utiltest.c testutils.h testutils.c
utiltest_LDADD = $( LDADDS)
2012-04-02 20:25:30 +04:00
i f W I T H _ D R I V E R _ M O D U L E S
virdrivermoduletest_SOURCES = \
virdrivermoduletest.c testutils.h testutils.c
virdrivermoduletest_LDADD = $( LDADDS)
e n d i f
2009-05-12 20:45:14 +04:00
i f W I T H _ L I B V I R T D
eventtest_SOURCES = \
2011-02-24 20:58:04 +03:00
eventtest.c testutils.h testutils.c
2009-05-12 20:45:14 +04:00
eventtest_LDADD = -lrt $( LDADDS)
e n d i f
Prevent crash from dlclose() of libvirt.so
When libvirt calls virInitialize it creates a thread local
for the virErrorPtr storage, and registers a callback to
cleanup memory when a thread exits. When libvirt is dlclose()d
or otherwise made non-resident, the callback function is
removed from memory, but the thread local may still exist
and if a thread later exists, it will invoke the callback
and SEGV. There may also be other thread locals with callbacks
pointing to libvirt code, so it is in general never safe to
unload libvirt.so from memory once initialized.
To allow dlclose() to succeed, but keep libvirt.so resident
in memory, link with '-z nodelete'. This issue was first
found with the libvirt CIM provider, but can potentially
hit many of the dynamic language bindings which all ultimately
involve dlopen() in some way, either on libvirt.so itself,
or on the glue code for the binding which in turns links
to libvirt
* configure.ac, src/Makefile.am: Ensure libvirt.so is linked
with -z nodelete
* cfg.mk, .gitignore, tests/Makefile.am, tests/shunloadhelper.c,
tests/shunloadtest.c: A test case to unload libvirt while
a thread is still running.
2011-09-01 20:57:06 +04:00
libshunload_la_SOURCES = shunloadhelper.c
libshunload_la_LIBADD = ../src/libvirt.la
libshunload_la_LDFLAGS = -module -avoid-version -rpath /evil/libtool/hack/to/force/shared/lib/creation
shunloadtest_SOURCES = \
shunloadtest.c
2012-05-02 22:53:04 +04:00
shunloadtest_LDADD = $( LIB_PTHREAD)
Prevent crash from dlclose() of libvirt.so
When libvirt calls virInitialize it creates a thread local
for the virErrorPtr storage, and registers a callback to
cleanup memory when a thread exits. When libvirt is dlclose()d
or otherwise made non-resident, the callback function is
removed from memory, but the thread local may still exist
and if a thread later exists, it will invoke the callback
and SEGV. There may also be other thread locals with callbacks
pointing to libvirt code, so it is in general never safe to
unload libvirt.so from memory once initialized.
To allow dlclose() to succeed, but keep libvirt.so resident
in memory, link with '-z nodelete'. This issue was first
found with the libvirt CIM provider, but can potentially
hit many of the dynamic language bindings which all ultimately
involve dlopen() in some way, either on libvirt.so itself,
or on the glue code for the binding which in turns links
to libvirt
* configure.ac, src/Makefile.am: Ensure libvirt.so is linked
with -z nodelete
* cfg.mk, .gitignore, tests/Makefile.am, tests/shunloadhelper.c,
tests/shunloadtest.c: A test case to unload libvirt while
a thread is still running.
2011-09-01 20:57:06 +04:00
shunloadtest_DEPENDENCIES = libshunload.la
2012-12-14 19:08:25 +04:00
sysinfotest_SOURCES = \
sysinfotest.c testutils.h testutils.c
sysinfotest_LDADD = $( LDADDS)
2009-05-19 14:17:17 +04:00
i f W I T H _ C I L
CILOPTFLAGS =
CILOPTINCS =
CILOPTPACKAGES = -package unix,str,cil
CILOPTLIBS = -linkpkg
object_locking_SOURCES = object-locking.ml
%.cmx : %.ml
ocamlfind ocamlopt $( CILOPTFLAGS) $( CILOPTINCS) $( CILOPTPACKAGES) -c $<
object-locking : object -locking .cmx object -locking -files .txt
ocamlfind ocamlopt $( CILOPTFLAGS) $( CILOPTINCS) $( CILOPTPACKAGES) $( CILOPTLIBS) $< -o $@
object-locking-files.txt :
find $( top_builddir) /src/ -name '*.i' > $@
e l s e
EXTRA_DIST += object-locking.ml
e n d i f
2009-05-27 16:07:43 +04:00
CLEANFILES = *.cov *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda *.cmi *.cmx object-locking-files.txt
