2006-05-09 19:35:46 +04:00
/*
2007-01-19 23:30:05 +03:00
* testutils . c : basic test utils
2006-05-09 19:35:46 +04:00
*
2015-04-27 20:43:06 +03:00
* Copyright ( C ) 2005 - 2015 Red Hat , Inc .
2006-05-09 19:35:46 +04:00
*
2012-07-27 13:39:53 +04:00
* This library is free software ; you can redistribute it and / or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation ; either
* version 2.1 of the License , or ( at your option ) any later version .
*
* This library is distributed in the hope that it will be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the GNU
* Lesser General Public License for more details .
*
* You should have received a copy of the GNU Lesser General Public
2012-09-21 02:30:55 +04:00
* License along with this library . If not , see
2012-07-27 13:39:53 +04:00
* < http : //www.gnu.org/licenses/>.
2006-05-09 19:35:46 +04:00
*/
2008-01-29 21:15:54 +03:00
# include <config.h>
2007-12-07 13:08:06 +03:00
2016-05-20 17:27:00 +03:00
# include <stdarg.h>
2006-05-09 19:35:46 +04:00
# include <sys/time.h>
2006-08-24 19:05:19 +04:00
# include <sys/types.h>
# include <sys/stat.h>
# include <unistd.h>
2006-08-25 01:46:28 +04:00
# include <fcntl.h>
2006-05-09 19:35:46 +04:00
# include "testutils.h"
2008-04-30 16:30:55 +04:00
# include "internal.h"
2012-12-12 22:06:53 +04:00
# include "viralloc.h"
2012-12-13 22:21:53 +04:00
# include "virerror.h"
2012-12-04 16:04:07 +04:00
# include "virbuffer.h"
2012-12-12 21:59:27 +04:00
# include "virlog.h"
2013-04-03 14:36:23 +04:00
# include "virstring.h"
2008-05-29 19:21:45 +04:00
2012-05-09 18:18:56 +04:00
# define VIR_FROM_THIS VIR_FROM_NONE
2014-02-28 16:16:17 +04:00
VIR_LOG_INIT ( " tests.testutils " ) ;
2016-06-17 15:09:30 +03:00
# include "virbitmap.h"
2011-07-19 22:32:58 +04:00
# include "virfile.h"
2010-11-09 23:48:48 +03:00
2009-10-16 19:37:36 +04:00
static unsigned int testDebug = - 1 ;
2009-11-30 22:01:31 +03:00
static unsigned int testVerbose = - 1 ;
2013-08-03 01:43:07 +04:00
static unsigned int testExpensive = - 1 ;
2015-12-10 15:30:37 +03:00
static unsigned int testRegenerate = - 1 ;
2009-09-10 14:07:20 +04:00
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
2014-10-28 21:38:04 +03:00
static size_t testCounter ;
2021-03-11 10:16:13 +03:00
static virBitmap * testBitmap ;
static virBitmap * failedTests ;
2008-05-29 19:21:45 +04:00
2022-05-05 16:27:14 +03:00
static virArch virTestHostArch = VIR_ARCH_X86_64 ;
2019-11-26 20:51:22 +03:00
virArch
virArchFromHost ( void )
{
return virTestHostArch ;
}
2022-05-05 16:27:14 +03:00
void
virTestSetHostArch ( virArch arch )
{
virTestHostArch = arch ;
}
2019-11-26 20:51:22 +03:00
2016-05-26 18:01:59 +03:00
static int virTestUseTerminalColors ( void )
2015-09-29 18:28:15 +03:00
{
2017-11-09 15:31:03 +03:00
return isatty ( STDOUT_FILENO ) ;
2015-09-29 18:28:15 +03:00
}
2015-04-23 21:02:57 +03:00
static unsigned int
virTestGetFlag ( const char * name )
{
char * flagStr ;
unsigned int flag ;
if ( ( flagStr = getenv ( name ) ) = = NULL )
return 0 ;
if ( virStrToLong_ui ( flagStr , NULL , 10 , & flag ) < 0 )
return 0 ;
return flag ;
}
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
2019-11-19 13:52:40 +03:00
/**
* virTestPropagateLibvirtError :
*
* In cases when a libvirt utility function which reports libvirt errors is
* used in the test suite outside of the virTestRun call and the failure of such
* a function would cause an test failure the error message reported by that
* function will not be propagated to the user as the error callback is not
* invoked .
*
* In cases when the error message may be beneficial in debugging this helper
* provides means to dispatch the errors including invocation of the error
* callback .
*/
void
virTestPropagateLibvirtError ( void )
{
if ( virGetLastErrorCode ( ) = = VIR_ERR_OK )
return ;
if ( virTestGetVerbose ( ) | | virTestGetDebug ( ) )
virDispatchError ( NULL ) ;
}
2007-01-19 23:30:05 +03:00
/*
2013-09-20 22:13:35 +04:00
* Runs test
2007-01-19 23:30:05 +03:00
*
* returns : - 1 = error , 0 = success
2006-05-09 19:35:46 +04:00
*/
int
2016-05-26 18:01:50 +03:00
virTestRun ( const char * title ,
int ( * body ) ( const void * data ) , const void * data )
2006-05-09 19:35:46 +04:00
{
Convert 'int i' to 'size_t i' in tests/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
int ret = 0 ;
2008-04-18 19:05:29 +04:00
2016-04-18 15:10:33 +03:00
/* Some test are fragile about environ settings. If that's
* the case , don ' t poison it . */
if ( getenv ( " VIR_TEST_MOCK_PROGNAME " ) )
2019-12-18 20:16:19 +03:00
g_setenv ( " VIR_TEST_MOCK_TESTNAME " , title , TRUE ) ;
2016-04-18 15:10:33 +03:00
2011-07-09 13:50:38 +04:00
if ( testCounter = = 0 & & ! virTestGetVerbose ( ) )
fprintf ( stderr , " " ) ;
2008-05-29 19:21:45 +04:00
testCounter + + ;
2008-04-18 19:05:29 +04:00
2013-07-18 18:02:19 +04:00
/* Skip tests if out of range */
2016-06-17 15:09:30 +03:00
if ( testBitmap & & ! virBitmapIsBitSet ( testBitmap , testCounter ) )
2013-07-18 18:02:19 +04:00
return 0 ;
2013-09-20 22:11:02 +04:00
if ( virTestGetVerbose ( ) )
fprintf ( stderr , " %2zu) %-65s ... " , testCounter , title ) ;
2007-01-19 23:30:05 +03:00
2013-09-20 22:13:35 +04:00
virResetLastError ( ) ;
ret = body ( data ) ;
2019-11-19 13:52:40 +03:00
virTestPropagateLibvirtError ( ) ;
2013-09-20 22:13:35 +04:00
2013-09-20 22:11:02 +04:00
if ( virTestGetVerbose ( ) ) {
2013-09-20 22:13:35 +04:00
if ( ret = = 0 )
2016-05-26 18:01:59 +03:00
if ( virTestUseTerminalColors ( ) )
2015-09-29 18:28:15 +03:00
fprintf ( stderr , " \ e[32mOK \ e[0m \n " ) ; /* green */
else
fprintf ( stderr , " OK \n " ) ;
2013-09-20 22:11:02 +04:00
else if ( ret = = EXIT_AM_SKIP )
2016-05-26 18:01:59 +03:00
if ( virTestUseTerminalColors ( ) )
2015-09-29 18:28:15 +03:00
fprintf ( stderr , " \ e[34m \ e[1mSKIP \ e[0m \n " ) ; /* bold blue */
else
fprintf ( stderr , " SKIP \n " ) ;
2013-09-20 22:11:02 +04:00
else
2016-05-26 18:01:59 +03:00
if ( virTestUseTerminalColors ( ) )
2015-09-29 18:28:15 +03:00
fprintf ( stderr , " \ e[31m \ e[1mFAILED \ e[0m \n " ) ; /* bold red */
else
fprintf ( stderr , " FAILED \n " ) ;
2013-09-20 22:11:02 +04:00
} else {
if ( testCounter ! = 1 & &
! ( ( testCounter - 1 ) % 40 ) ) {
fprintf ( stderr , " %-3zu \n " , ( testCounter - 1 ) ) ;
fprintf ( stderr , " " ) ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
}
2013-09-20 22:11:02 +04:00
if ( ret = = 0 )
2009-11-30 22:01:31 +03:00
fprintf ( stderr , " . " ) ;
2013-09-20 22:11:02 +04:00
else if ( ret = = EXIT_AM_SKIP )
fprintf ( stderr , " _ " ) ;
else
fprintf ( stderr , " ! " ) ;
2008-05-29 19:21:45 +04:00
}
2007-01-19 23:30:05 +03:00
2020-03-04 18:48:27 +03:00
if ( ret ! = 0 & & ret ! = EXIT_AM_SKIP )
2021-12-06 17:55:46 +03:00
virBitmapSetBitExpand ( failedTests , testCounter ) ;
2020-02-06 19:31:04 +03:00
2019-12-18 20:16:19 +03:00
g_unsetenv ( " VIR_TEST_MOCK_TESTNAME " ) ;
2007-01-19 23:30:05 +03:00
return ret ;
2006-05-09 19:35:46 +04:00
}
2006-08-24 19:05:19 +04:00
2017-07-25 15:28:48 +03:00
2021-08-20 17:29:45 +03:00
/*
* A wrapper for virTestRun that resets the log content before each run
* and sets ret to - 1 on failure . On success , ret is untouched .
*/
void
virTestRunLog ( int * ret ,
const char * title ,
int ( * body ) ( const void * data ) ,
const void * data )
{
int rc ;
g_free ( virTestLogContentAndReset ( ) ) ;
rc = virTestRun ( title , body , data ) ;
if ( rc > = 0 )
return ;
* ret = - 1 ;
if ( virTestGetDebug ( ) ) {
g_autofree char * log = virTestLogContentAndReset ( ) ;
if ( strlen ( log ) > 0 )
VIR_TEST_DEBUG ( " \n %s " , log ) ;
}
}
2017-07-25 15:28:48 +03:00
/**
* virTestLoadFile :
* @ file : name of the file to load
* @ buf : buffer to load the file into
*
* Allocates @ buf to the size of FILE . Reads FILE into buffer BUF .
* Upon any failure , error is printed to stderr and - 1 is returned . ' errno ' is
* not preserved . On success 0 is returned . Caller is responsible for freeing
* @ buf .
*/
2011-04-25 02:25:10 +04:00
int
2016-05-26 18:01:52 +03:00
virTestLoadFile ( const char * file , char * * buf )
2011-04-25 02:25:10 +04:00
{
2021-09-04 21:15:29 +03:00
g_autoptr ( FILE ) fp = fopen ( file , " r " ) ;
2006-08-24 19:05:19 +04:00
struct stat st ;
2011-04-25 02:25:10 +04:00
char * tmp ;
int len , tmplen , buflen ;
2007-01-19 23:30:05 +03:00
2009-02-02 23:35:14 +03:00
if ( ! fp ) {
2019-10-02 18:30:36 +03:00
fprintf ( stderr , " %s: failed to open: %s \n " , file , g_strerror ( errno ) ) ;
2006-08-24 19:05:19 +04:00
return - 1 ;
2009-02-02 23:35:14 +03:00
}
2006-08-24 19:05:19 +04:00
if ( fstat ( fileno ( fp ) , & st ) < 0 ) {
2019-10-02 18:30:36 +03:00
fprintf ( stderr , " %s: failed to fstat: %s \n " , file , g_strerror ( errno ) ) ;
2006-08-24 19:05:19 +04:00
return - 1 ;
}
2011-04-25 02:25:10 +04:00
tmplen = buflen = st . st_size + 1 ;
2020-09-23 02:04:17 +03:00
* buf = g_new0 ( char , buflen ) ;
2006-08-24 19:05:19 +04:00
2011-04-25 02:25:10 +04:00
tmp = * buf ;
2011-01-31 14:42:57 +03:00
( * buf ) [ 0 ] = ' \0 ' ;
2007-01-19 23:30:05 +03:00
if ( st . st_size ) {
2011-01-31 14:42:57 +03:00
/* read the file line by line */
while ( fgets ( tmp , tmplen , fp ) ! = NULL ) {
len = strlen ( tmp ) ;
2011-04-25 02:25:10 +04:00
/* stop on an empty line */
if ( len = = 0 )
break ;
2011-01-31 14:42:57 +03:00
/* remove trailing backslash-newline pair */
if ( len > = 2 & & tmp [ len - 2 ] = = ' \\ ' & & tmp [ len - 1 ] = = ' \n ' ) {
len - = 2 ;
tmp [ len ] = ' \0 ' ;
}
/* advance the temporary buffer pointer */
tmp + = len ;
tmplen - = len ;
}
if ( ferror ( fp ) ) {
2019-10-02 18:30:36 +03:00
fprintf ( stderr , " %s: read failed: %s \n " , file , g_strerror ( errno ) ) ;
2012-02-03 03:16:43 +04:00
VIR_FREE ( * buf ) ;
2007-01-19 23:30:05 +03:00
return - 1 ;
}
2006-08-24 19:05:19 +04:00
}
2017-07-25 15:28:48 +03:00
return 0 ;
2006-08-24 19:05:19 +04:00
}
2017-07-25 16:11:31 +03:00
static char *
virTestLoadFileGetPath ( const char * p ,
va_list ap )
{
2020-07-03 02:35:41 +03:00
g_auto ( virBuffer ) buf = VIR_BUFFER_INITIALIZER ;
2017-07-25 16:11:31 +03:00
char * path = NULL ;
virBufferAddLit ( & buf , abs_srcdir " / " ) ;
if ( p ) {
virBufferAdd ( & buf , p , - 1 ) ;
virBufferStrcatVArgs ( & buf , ap ) ;
}
if ( ! ( path = virBufferContentAndReset ( & buf ) ) )
VIR_TEST_VERBOSE ( " failed to format file path " ) ;
return path ;
}
/**
* virTestLoadFilePath :
* @ . . . : file name components terminated with a NULL
*
* Constructs the test file path from variable arguments and loads the file .
* ' abs_srcdir ' is automatically prepended .
*/
char *
virTestLoadFilePath ( const char * p , . . . )
{
2020-02-09 03:47:22 +03:00
g_autofree char * path = NULL ;
2017-07-25 16:11:31 +03:00
char * ret = NULL ;
va_list ap ;
va_start ( ap , p ) ;
if ( ! ( path = virTestLoadFileGetPath ( p , ap ) ) )
goto cleanup ;
ignore_value ( virTestLoadFile ( path , & ret ) ) ;
cleanup :
va_end ( ap ) ;
return ret ;
}
2017-07-25 19:40:50 +03:00
/**
* virTestLoadFileJSON :
* @ . . . : name components terminated with a NULL
*
* Constructs the test file path from variable arguments and loads and parses
* the JSON file . ' abs_srcdir ' is automatically prepended to the path .
*/
2021-03-11 10:16:13 +03:00
virJSONValue *
2017-07-25 19:40:50 +03:00
virTestLoadFileJSON ( const char * p , . . . )
{
2021-03-11 10:16:13 +03:00
virJSONValue * ret = NULL ;
2020-02-09 03:47:22 +03:00
g_autofree char * jsonstr = NULL ;
g_autofree char * path = NULL ;
2017-07-25 19:40:50 +03:00
va_list ap ;
va_start ( ap , p ) ;
if ( ! ( path = virTestLoadFileGetPath ( p , ap ) ) )
goto cleanup ;
2021-03-31 10:29:22 +03:00
if ( virFileReadAll ( path , INT_MAX , & jsonstr ) < 0 )
2017-07-25 19:40:50 +03:00
goto cleanup ;
if ( ! ( ret = virJSONValueFromString ( jsonstr ) ) )
VIR_TEST_VERBOSE ( " failed to parse json from file '%s' " , path ) ;
cleanup :
va_end ( ap ) ;
return ret ;
}
2008-04-18 19:05:29 +04:00
/**
2015-04-28 18:43:12 +03:00
* @ param stream : output stream to write differences to
2008-04-18 19:05:29 +04:00
* @ param expect : expected output text
2014-10-29 17:53:36 +03:00
* @ param expectName : name designator of the expected text
2008-04-18 19:05:29 +04:00
* @ param actual : actual output text
2014-10-29 17:53:36 +03:00
* @ param actualName : name designator of the actual text
2015-12-10 15:40:54 +03:00
* @ param regenerate : enable or disable regenerate functionality
2021-03-31 10:18:57 +03:00
* @ param rewrap : enable or disable rewrapping when regenerating
2008-04-18 19:05:29 +04:00
*
2014-10-29 17:53:36 +03:00
* Display expected and actual output text , trimmed to first and last
* characters at which differences occur . Displays names of the text strings if
* non - NULL .
2008-04-18 19:05:29 +04:00
*/
2015-12-10 15:40:54 +03:00
static int
2016-05-26 18:02:02 +03:00
virTestDifferenceFullInternal ( FILE * stream ,
const char * expect ,
const char * expectName ,
const char * actual ,
const char * actualName ,
2021-04-06 17:49:47 +03:00
bool regenerate )
2008-04-18 19:05:29 +04:00
{
2013-03-04 20:30:40 +04:00
const char * expectStart ;
const char * expectEnd ;
const char * actualStart ;
const char * actualEnd ;
if ( ! expect )
expect = " " ;
if ( ! actual )
actual = " " ;
expectStart = expect ;
expectEnd = expect + ( strlen ( expect ) - 1 ) ;
actualStart = actual ;
actualEnd = actual + ( strlen ( actual ) - 1 ) ;
2008-04-18 19:05:29 +04:00
2016-01-12 18:55:08 +03:00
if ( expectName & & regenerate & & ( virTestGetRegenerate ( ) > 0 ) ) {
2016-01-13 04:26:00 +03:00
if ( virFileWriteStr ( expectName , actual , 0666 ) < 0 ) {
virDispatchError ( NULL ) ;
2016-01-04 22:31:58 +03:00
return - 1 ;
2016-01-13 04:26:00 +03:00
}
2015-12-10 15:40:54 +03:00
}
2009-11-30 22:01:31 +03:00
if ( ! virTestGetDebug ( ) )
2008-05-29 19:21:45 +04:00
return 0 ;
2009-11-30 22:01:31 +03:00
if ( virTestGetDebug ( ) < 2 ) {
2008-04-30 16:30:55 +04:00
/* Skip to first character where they differ */
while ( * expectStart & & * actualStart & &
* actualStart = = * expectStart ) {
actualStart + + ;
expectStart + + ;
}
2008-04-18 19:05:29 +04:00
2008-04-30 16:30:55 +04:00
/* Work backwards to last character where they differ */
while ( actualEnd > actualStart & &
expectEnd > expectStart & &
* actualEnd = = * expectEnd ) {
actualEnd - - ;
expectEnd - - ;
}
2008-04-18 19:05:29 +04:00
}
/* Show the trimmed differences */
2014-10-29 17:53:36 +03:00
if ( expectName )
fprintf ( stream , " \n In '%s': " , expectName ) ;
2011-09-17 17:57:26 +04:00
fprintf ( stream , " \n Offset %d \n Expect [ " , ( int ) ( expectStart - expect ) ) ;
2008-04-18 19:05:29 +04:00
if ( ( expectEnd - expectStart + 1 ) & &
fwrite ( expectStart , ( expectEnd - expectStart + 1 ) , 1 , stream ) ! = 1 )
return - 1 ;
fprintf ( stream , " ] \n " ) ;
2014-10-29 17:53:36 +03:00
if ( actualName )
fprintf ( stream , " In '%s': \n " , actualName ) ;
2008-04-18 19:05:29 +04:00
fprintf ( stream , " Actual [ " ) ;
if ( ( actualEnd - actualStart + 1 ) & &
fwrite ( actualStart , ( actualEnd - actualStart + 1 ) , 1 , stream ) ! = 1 )
return - 1 ;
fprintf ( stream , " ] \n " ) ;
/* Pad to line up with test name ... in virTestRun */
fprintf ( stream , " ... " ) ;
return 0 ;
}
2008-05-29 19:21:45 +04:00
2015-12-10 15:40:54 +03:00
/**
* @ param stream : output stream to write differences to
* @ param expect : expected output text
* @ param expectName : name designator of the expected text
* @ param actual : actual output text
* @ param actualName : name designator of the actual text
*
* Display expected and actual output text , trimmed to first and last
* characters at which differences occur . Displays names of the text strings if
* non - NULL . If VIR_TEST_REGENERATE_OUTPUT is used , this function will
* regenerate the expected file .
*/
int
2016-05-26 18:01:54 +03:00
virTestDifferenceFull ( FILE * stream ,
const char * expect ,
const char * expectName ,
const char * actual ,
const char * actualName )
2015-12-10 15:40:54 +03:00
{
2016-05-26 18:02:02 +03:00
return virTestDifferenceFullInternal ( stream , expect , expectName ,
2021-04-06 17:49:47 +03:00
actual , actualName , true ) ;
2015-12-10 15:40:54 +03:00
}
/**
* @ param stream : output stream to write differences to
* @ param expect : expected output text
* @ param expectName : name designator of the expected text
* @ param actual : actual output text
* @ param actualName : name designator of the actual text
*
* Display expected and actual output text , trimmed to first and last
* characters at which differences occur . Displays names of the text strings if
* non - NULL . If VIR_TEST_REGENERATE_OUTPUT is used , this function will not
* regenerate the expected file .
*/
int
2016-05-26 18:02:01 +03:00
virTestDifferenceFullNoRegenerate ( FILE * stream ,
const char * expect ,
const char * expectName ,
const char * actual ,
const char * actualName )
2015-12-10 15:40:54 +03:00
{
2016-05-26 18:02:02 +03:00
return virTestDifferenceFullInternal ( stream , expect , expectName ,
2021-04-06 17:49:47 +03:00
actual , actualName , false ) ;
2015-12-10 15:40:54 +03:00
}
2014-10-29 17:53:36 +03:00
/**
2015-04-28 18:43:12 +03:00
* @ param stream : output stream to write differences to
2014-10-29 17:53:36 +03:00
* @ param expect : expected output text
* @ param actual : actual output text
*
* Display expected and actual output text , trimmed to
* first and last characters at which differences occur
*/
2015-12-10 15:40:54 +03:00
int
2016-05-26 18:01:51 +03:00
virTestDifference ( FILE * stream ,
const char * expect ,
const char * actual )
2014-10-29 17:53:36 +03:00
{
2016-05-26 18:02:01 +03:00
return virTestDifferenceFullNoRegenerate ( stream ,
expect , NULL ,
actual , NULL ) ;
2014-10-29 17:53:36 +03:00
}
2010-12-06 20:03:22 +03:00
/**
2015-04-28 18:43:12 +03:00
* @ param stream : output stream to write differences to
2010-12-06 20:03:22 +03:00
* @ param expect : expected output text
* @ param actual : actual output text
*
* Display expected and actual output text , trimmed to
* first and last characters at which differences occur
*/
2016-05-26 18:02:04 +03:00
int virTestDifferenceBin ( FILE * stream ,
const char * expect ,
const char * actual ,
size_t length )
2010-12-06 20:03:22 +03:00
{
size_t start = 0 , end = length ;
ssize_t i ;
if ( ! virTestGetDebug ( ) )
return 0 ;
if ( virTestGetDebug ( ) < 2 ) {
/* Skip to first character where they differ */
2013-05-21 11:53:48 +04:00
for ( i = 0 ; i < length ; i + + ) {
2010-12-06 20:03:22 +03:00
if ( expect [ i ] ! = actual [ i ] ) {
start = i ;
break ;
}
}
/* Work backwards to last character where they differ */
2013-05-21 11:53:48 +04:00
for ( i = ( length - 1 ) ; i > = 0 ; i - - ) {
2010-12-06 20:03:22 +03:00
if ( expect [ i ] ! = actual [ i ] ) {
end = i ;
break ;
}
}
}
2011-06-24 18:01:10 +04:00
/* Round to nearest boundary of 4, except that last word can be short */
2010-12-06 20:03:22 +03:00
start - = ( start % 4 ) ;
end + = 4 - ( end % 4 ) ;
if ( end > = length )
end = length - 1 ;
/* Show the trimmed differences */
fprintf ( stream , " \n Expect [ Region %d-%d " , ( int ) start , ( int ) end ) ;
2013-05-21 11:53:48 +04:00
for ( i = start ; i < end ; i + + ) {
2010-12-06 20:03:22 +03:00
if ( ( i % 4 ) = = 0 )
fprintf ( stream , " \n " ) ;
fprintf ( stream , " 0x%02x, " , ( ( int ) expect [ i ] ) & 0xff ) ;
}
fprintf ( stream , " ] \n " ) ;
fprintf ( stream , " Actual [ Region %d-%d " , ( int ) start , ( int ) end ) ;
2013-05-21 11:53:48 +04:00
for ( i = start ; i < end ; i + + ) {
2010-12-06 20:03:22 +03:00
if ( ( i % 4 ) = = 0 )
fprintf ( stream , " \n " ) ;
fprintf ( stream , " 0x%02x, " , ( ( int ) actual [ i ] ) & 0xff ) ;
}
fprintf ( stream , " ] \n " ) ;
/* Pad to line up with test name ... in virTestRun */
fprintf ( stream , " ... " ) ;
return 0 ;
}
2015-04-23 18:14:26 +03:00
/*
2019-02-19 20:15:23 +03:00
* @ param actual : String input content
* @ param filename : File to compare @ actual against
2021-03-31 10:18:57 +03:00
* @ param unwrap : Remove ' \ \ \ n ' sequences from file content before comparison
2017-07-28 13:37:48 +03:00
*
2019-02-19 20:15:23 +03:00
* If @ actual is NULL , it ' s treated as an empty string .
2015-04-23 18:14:26 +03:00
*/
int
2021-03-31 10:18:57 +03:00
virTestCompareToFileFull ( const char * actual ,
const char * filename ,
bool unwrap )
2015-04-23 18:14:26 +03:00
{
2020-02-09 03:47:22 +03:00
g_autofree char * filecontent = NULL ;
g_autofree char * fixedcontent = NULL ;
2019-02-19 20:15:23 +03:00
const char * cmpcontent = actual ;
2015-04-23 18:14:26 +03:00
2017-07-28 13:37:48 +03:00
if ( ! cmpcontent )
cmpcontent = " " ;
2021-03-31 10:18:57 +03:00
if ( unwrap ) {
if ( virTestLoadFile ( filename , & filecontent ) < 0 & & ! virTestGetRegenerate ( ) )
return - 1 ;
} else {
if ( virFileReadAll ( filename , INT_MAX , & filecontent ) < 0 & & ! virTestGetRegenerate ( ) )
return - 1 ;
}
2015-04-23 18:14:26 +03:00
2017-08-04 16:22:53 +03:00
if ( filecontent ) {
size_t filecontentLen = strlen ( filecontent ) ;
2018-04-03 17:16:52 +03:00
size_t cmpcontentLen = strlen ( cmpcontent ) ;
2017-08-04 16:22:53 +03:00
if ( filecontentLen > 0 & &
filecontent [ filecontentLen - 1 ] = = ' \n ' & &
2018-04-03 17:16:52 +03:00
( cmpcontentLen = = 0 | | cmpcontent [ cmpcontentLen - 1 ] ! = ' \n ' ) ) {
2019-10-22 16:26:14 +03:00
fixedcontent = g_strdup_printf ( " %s \n " , cmpcontent ) ;
2017-08-04 16:22:53 +03:00
cmpcontent = fixedcontent ;
}
2015-04-23 18:14:26 +03:00
}
2016-09-19 20:44:21 +03:00
if ( STRNEQ_NULLABLE ( cmpcontent , filecontent ) ) {
2021-03-31 10:18:57 +03:00
virTestDifferenceFullInternal ( stderr , filecontent , filename ,
2021-04-06 17:49:47 +03:00
cmpcontent , NULL , true ) ;
2020-02-09 03:57:06 +03:00
return - 1 ;
2015-04-23 18:14:26 +03:00
}
2020-02-09 03:57:06 +03:00
return 0 ;
2015-04-23 18:14:26 +03:00
}
2021-03-31 10:18:57 +03:00
/*
* @ param actual : String input content
* @ param filename : File to compare @ actual against
*
* If @ actual is NULL , it ' s treated as an empty string .
*/
int
virTestCompareToFile ( const char * actual ,
const char * filename )
{
return virTestCompareToFileFull ( actual , filename , true ) ;
}
2017-03-23 16:29:43 +03:00
int
2019-02-19 20:15:23 +03:00
virTestCompareToULL ( unsigned long long expect ,
unsigned long long actual )
2017-03-23 16:29:43 +03:00
{
2019-10-15 16:16:31 +03:00
g_autofree char * expectStr = NULL ;
g_autofree char * actualStr = NULL ;
2017-03-23 16:29:43 +03:00
2019-10-22 16:26:14 +03:00
expectStr = g_strdup_printf ( " %llu " , expect ) ;
2017-03-23 16:29:43 +03:00
2019-10-22 16:26:14 +03:00
actualStr = g_strdup_printf ( " %llu " , actual ) ;
2017-03-23 16:29:43 +03:00
2019-02-20 16:14:31 +03:00
return virTestCompareToString ( expectStr , actualStr ) ;
2017-03-23 16:29:43 +03:00
}
2016-04-21 00:14:34 +03:00
int
2019-02-19 20:15:23 +03:00
virTestCompareToString ( const char * expect ,
const char * actual )
2016-04-21 00:14:34 +03:00
{
2019-02-19 20:15:23 +03:00
if ( STRNEQ_NULLABLE ( expect , actual ) ) {
virTestDifference ( stderr , expect , actual ) ;
2016-04-21 00:14:34 +03:00
return - 1 ;
}
return 0 ;
}
2008-05-29 19:21:45 +04:00
static void
2019-10-14 15:45:03 +03:00
virTestErrorFuncQuiet ( void * data G_GNUC_UNUSED ,
virErrorPtr err G_GNUC_UNUSED )
2008-05-29 19:21:45 +04:00
{ }
2013-09-17 17:20:24 +04:00
/* register an error handler in tests when using connections */
void
2016-05-26 18:02:00 +03:00
virTestQuiesceLibvirtErrors ( bool always )
2013-09-17 17:20:24 +04:00
{
if ( always | | ! virTestGetVerbose ( ) )
2016-05-26 18:02:07 +03:00
virSetErrorFunc ( NULL , virTestErrorFuncQuiet ) ;
2013-09-17 17:20:24 +04:00
}
2008-05-29 19:21:45 +04:00
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
struct virtTestLogData {
virBuffer buf ;
} ;
static struct virtTestLogData testLog = { VIR_BUFFER_INITIALIZER } ;
2012-09-20 22:24:00 +04:00
static void
2021-03-11 10:16:13 +03:00
virtTestLogOutput ( virLogSource * source G_GNUC_UNUSED ,
2019-10-14 15:45:03 +03:00
virLogPriority priority G_GNUC_UNUSED ,
const char * filename G_GNUC_UNUSED ,
int lineno G_GNUC_UNUSED ,
const char * funcname G_GNUC_UNUSED ,
2011-09-28 17:20:07 +04:00
const char * timestamp ,
2021-03-11 10:16:13 +03:00
struct _virLogMetadata * metadata G_GNUC_UNUSED ,
2019-10-14 15:45:03 +03:00
const char * rawstr G_GNUC_UNUSED ,
2011-09-28 17:20:07 +04:00
const char * str ,
void * data )
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
{
struct virtTestLogData * log = data ;
2019-08-29 15:04:07 +03:00
virBufferAsprintf ( & log - > buf , " %s: %s " , timestamp , str ) ;
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
}
static void
virtTestLogClose ( void * data )
{
struct virtTestLogData * log = data ;
virBufferFreeAndReset ( & log - > buf ) ;
}
/* Return a malloc'd string (possibly with strlen of 0) of all data
* logged since the last call to this function , or NULL on failure . */
char *
2016-05-26 18:01:58 +03:00
virTestLogContentAndReset ( void )
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
{
char * ret ;
ret = virBufferContentAndReset ( & testLog . buf ) ;
2013-05-03 16:52:21 +04:00
if ( ! ret )
2019-10-18 14:27:03 +03:00
ret = g_strdup ( " " ) ;
2013-05-03 16:52:21 +04:00
return ret ;
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
}
2008-05-29 19:21:45 +04:00
2009-11-30 22:01:31 +03:00
unsigned int
2014-03-18 12:13:43 +04:00
virTestGetDebug ( void )
{
2009-11-30 22:01:31 +03:00
if ( testDebug = = - 1 )
testDebug = virTestGetFlag ( " VIR_TEST_DEBUG " ) ;
2009-10-16 19:37:36 +04:00
return testDebug ;
}
2008-05-29 19:21:45 +04:00
2009-11-30 22:01:31 +03:00
unsigned int
2014-03-18 12:13:43 +04:00
virTestGetVerbose ( void )
{
2009-11-30 22:01:31 +03:00
if ( testVerbose = = - 1 )
testVerbose = virTestGetFlag ( " VIR_TEST_VERBOSE " ) ;
return testVerbose | | virTestGetDebug ( ) ;
}
2013-08-03 01:43:07 +04:00
unsigned int
2014-03-18 12:13:43 +04:00
virTestGetExpensive ( void )
{
2013-08-03 01:43:07 +04:00
if ( testExpensive = = - 1 )
testExpensive = virTestGetFlag ( " VIR_TEST_EXPENSIVE " ) ;
return testExpensive ;
}
2015-12-10 15:30:37 +03:00
unsigned int
virTestGetRegenerate ( void )
{
if ( testRegenerate = = - 1 )
testRegenerate = virTestGetFlag ( " VIR_TEST_REGENERATE_OUTPUT " ) ;
return testRegenerate ;
}
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
static int
virTestSetEnvPath ( void )
{
const char * path = getenv ( " PATH " ) ;
2020-02-09 03:47:22 +03:00
g_autofree char * new_path = NULL ;
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
2016-03-24 16:57:42 +03:00
if ( path ) {
2019-10-22 16:26:14 +03:00
if ( strstr ( path , abs_builddir ) ! = path )
new_path = g_strdup_printf ( " %s:%s " , abs_builddir , path ) ;
2016-03-24 16:57:42 +03:00
} else {
2019-10-20 14:49:46 +03:00
new_path = g_strdup ( abs_builddir ) ;
2016-03-24 16:57:42 +03:00
}
2016-03-25 12:20:28 +03:00
if ( new_path & &
2020-02-09 03:26:08 +03:00
g_setenv ( " PATH " , new_path , TRUE ) = = FALSE )
2020-02-09 03:57:06 +03:00
return - 1 ;
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
2020-02-09 03:57:06 +03:00
return 0 ;
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
}
2023-03-01 12:39:44 +03:00
# define FAKEROOTDIRTEMPLATE abs_builddir " / fakerootdir-XXXXXX"
char *
virTestFakeRootDirInit ( void )
{
g_autofree char * fakerootdir = g_strdup ( FAKEROOTDIRTEMPLATE ) ;
if ( ! g_mkdtemp ( fakerootdir ) ) {
fprintf ( stderr , " Cannot create fakerootdir " ) ;
return NULL ;
}
g_setenv ( " LIBVIRT_FAKE_ROOT_DIR " , fakerootdir , TRUE ) ;
return g_steal_pointer ( & fakerootdir ) ;
}
void
virTestFakeRootDirCleanup ( char * fakerootdir )
{
g_unsetenv ( " LIBVIRT_FAKE_ROOT_DIR " ) ;
if ( ! g_getenv ( " LIBVIRT_SKIP_CLEANUP " ) )
virFileDeleteTree ( fakerootdir ) ;
2023-03-01 13:11:23 +03:00
else
fprintf ( stderr , " Test data ready for inspection: %s \n " , fakerootdir ) ;
2023-03-01 12:39:44 +03:00
}
2016-05-26 18:02:08 +03:00
int virTestMain ( int argc ,
char * * argv ,
int ( * func ) ( void ) ,
. . . )
2008-05-29 19:21:45 +04:00
{
2016-05-20 17:27:00 +03:00
const char * lib ;
va_list ap ;
2008-05-29 19:21:45 +04:00
int ret ;
2013-07-18 18:02:19 +04:00
char * testRange = NULL ;
2016-03-17 17:26:40 +03:00
size_t noutputs = 0 ;
2021-03-11 10:16:13 +03:00
virLogOutput * output = NULL ;
virLogOutput * * outputs = NULL ;
2021-05-16 19:21:10 +03:00
g_autofree char * progname = NULL ;
2020-01-09 21:01:44 +03:00
g_autofree const char * * preloads = NULL ;
size_t npreloads = 0 ;
g_autofree char * mock = NULL ;
2023-03-01 13:06:14 +03:00
g_autofree char * fakerootdir = NULL ;
2020-01-09 21:01:44 +03:00
if ( getenv ( " VIR_TEST_FILE_ACCESS " ) ) {
preloads = g_renew ( const char * , preloads , npreloads + 2 ) ;
preloads [ npreloads + + ] = VIR_TEST_MOCK ( " virtest " ) ;
preloads [ npreloads ] = NULL ;
}
2016-04-18 15:10:33 +03:00
2020-05-04 15:09:45 +03:00
g_setenv ( " HOME " , " /bad-test-used-env-home " , TRUE ) ;
g_setenv ( " XDG_RUNTIME_DIR " , " /bad-test-used-env-xdg-runtime-dir " , TRUE ) ;
2023-03-02 19:59:06 +03:00
g_setenv ( " XDG_DATA_HOME " , " /bad-test-used-env-xdg-data-home " , TRUE ) ;
g_setenv ( " XDG_CACHE_HOME " , " /bad-test-used-env-xdg-cache-home " , TRUE ) ;
g_setenv ( " XDG_CONFIG_HOME " , " /bad-test-used-env-xdg-config-home " , TRUE ) ;
2020-05-04 15:09:45 +03:00
2016-05-20 17:27:00 +03:00
va_start ( ap , func ) ;
2020-01-09 21:01:44 +03:00
while ( ( lib = va_arg ( ap , const char * ) ) ) {
if ( ! virFileIsExecutable ( lib ) ) {
perror ( lib ) ;
2020-11-16 18:12:09 +03:00
va_end ( ap ) ;
2020-01-09 21:01:44 +03:00
return EXIT_FAILURE ;
}
preloads = g_renew ( const char * , preloads , npreloads + 2 ) ;
preloads [ npreloads + + ] = lib ;
preloads [ npreloads ] = NULL ;
}
2016-05-20 17:27:00 +03:00
va_end ( ap ) ;
2016-04-18 15:10:33 +03:00
2020-01-09 21:01:44 +03:00
if ( preloads ) {
mock = g_strjoinv ( " : " , ( char * * ) preloads ) ;
VIR_TEST_PRELOAD ( mock ) ;
}
2021-05-16 19:21:10 +03:00
progname = g_path_get_basename ( argv [ 0 ] ) ;
2016-04-18 15:10:33 +03:00
2019-12-18 20:16:19 +03:00
g_setenv ( " VIR_TEST_MOCK_PROGNAME " , progname , TRUE ) ;
2016-04-18 15:10:33 +03:00
2019-08-29 13:52:08 +03:00
virFileActivateDirOverrideForProg ( argv [ 0 ] ) ;
2014-04-24 18:57:36 +04:00
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
if ( virTestSetEnvPath ( ) < 0 )
return EXIT_AM_HARDFAIL ;
2013-11-28 01:31:53 +04:00
if ( ! virFileExists ( abs_srcdir ) )
2013-02-23 02:42:39 +04:00
return EXIT_AM_HARDFAIL ;
2011-04-29 20:21:20 +04:00
if ( argc > 1 ) {
fprintf ( stderr , " Usage: %s \n " , argv [ 0 ] ) ;
2012-05-08 21:46:45 +04:00
fputs ( " effective environment variables: \n "
" VIR_TEST_VERBOSE set to show names of individual tests \n "
2022-01-17 18:46:46 +03:00
" VIR_TEST_DEBUG set to show information for debugging failures \n " ,
2012-05-08 21:46:45 +04:00
stderr ) ;
2011-04-29 20:21:20 +04:00
return EXIT_FAILURE ;
}
fprintf ( stderr , " TEST: %s \n " , progname ) ;
2009-11-30 22:01:31 +03:00
2019-09-16 19:44:23 +03:00
if ( virErrorInitialize ( ) < 0 )
2013-02-23 02:42:39 +04:00
return EXIT_FAILURE ;
2009-01-29 00:53:48 +03:00
2021-12-15 18:34:16 +03:00
if ( virLogSetFromEnv ( ) < 0 )
return EXIT_FAILURE ;
2010-12-06 20:03:35 +03:00
if ( ! getenv ( " LIBVIRT_DEBUG " ) & & ! virLogGetNbOutputs ( ) ) {
2016-03-17 17:26:40 +03:00
if ( ! ( output = virLogOutputNew ( virtTestLogOutput , virtTestLogClose ,
& testLog , VIR_LOG_DEBUG ,
2021-08-03 15:14:20 +03:00
VIR_LOG_TO_STDERR , NULL ) ) )
return EXIT_FAILURE ;
VIR_APPEND_ELEMENT ( outputs , noutputs , output ) ;
if ( virLogDefineOutputs ( outputs , noutputs ) < 0 ) {
2016-03-17 17:26:40 +03:00
virLogOutputListFree ( outputs , noutputs ) ;
2013-02-23 02:42:39 +04:00
return EXIT_FAILURE ;
2016-03-17 17:26:40 +03:00
}
2010-12-06 20:03:35 +03:00
}
2008-05-29 19:21:45 +04:00
2013-07-18 18:02:19 +04:00
if ( ( testRange = getenv ( " VIR_TEST_RANGE " ) ) ! = NULL ) {
2017-03-22 16:39:53 +03:00
if ( ! ( testBitmap = virBitmapParseUnlimited ( testRange ) ) ) {
2013-07-18 18:02:19 +04:00
fprintf ( stderr , " Cannot parse range %s \n " , testRange ) ;
return EXIT_FAILURE ;
}
}
2020-10-01 18:42:11 +03:00
failedTests = virBitmapNew ( 1 ) ;
2020-02-06 19:31:04 +03:00
2023-03-01 13:06:14 +03:00
if ( ! ( fakerootdir = virTestFakeRootDirInit ( ) ) )
return EXIT_FAILURE ;
2011-04-29 20:21:20 +04:00
ret = ( func ) ( ) ;
2009-01-29 00:53:48 +03:00
virResetLastError ( ) ;
2011-07-09 13:50:38 +04:00
if ( ! virTestGetVerbose ( ) & & ret ! = EXIT_AM_SKIP ) {
2011-07-11 19:19:11 +04:00
if ( testCounter = = 0 | | testCounter % 40 )
2013-07-18 18:02:19 +04:00
fprintf ( stderr , " %*s " , 40 - ( int ) ( testCounter % 40 ) , " " ) ;
fprintf ( stderr , " %-3zu %s \n " , testCounter , ret = = 0 ? " OK " : " FAIL " ) ;
2009-11-30 22:01:31 +03:00
}
2021-05-16 19:20:56 +03:00
2023-03-01 13:06:14 +03:00
virTestFakeRootDirCleanup ( fakerootdir ) ;
2021-05-16 19:20:56 +03:00
switch ( ret ) {
case EXIT_FAILURE :
case EXIT_SUCCESS :
case EXIT_AM_SKIP :
case EXIT_AM_HARDFAIL :
break ;
default :
fprintf ( stderr , " Test callback returned invalid value: %d \n " , ret ) ;
ret = EXIT_AM_HARDFAIL ;
break ;
}
2020-02-06 19:31:04 +03:00
if ( ret = = EXIT_FAILURE & & ! virBitmapIsAllClear ( failedTests ) ) {
g_autofree char * failed = virBitmapFormat ( failedTests ) ;
2023-04-03 14:33:52 +03:00
fprintf ( stderr , " %zu tests failed. Run them using: \n " , virBitmapCountBits ( failedTests ) ) ;
2020-02-06 19:31:04 +03:00
fprintf ( stderr , " VIR_TEST_DEBUG=1 VIR_TEST_RANGE=%s %s \n " , failed , argv [ 0 ] ) ;
}
2021-07-29 16:53:16 +03:00
virBitmapFree ( testBitmap ) ;
virBitmapFree ( failedTests ) ;
2016-03-17 17:26:40 +03:00
virLogReset ( ) ;
2009-01-29 00:53:48 +03:00
return ret ;
2008-05-29 19:21:45 +04:00
}
2009-05-21 18:22:51 +04:00
2021-03-11 10:16:13 +03:00
virCaps *
virTestGenericCapsInit ( void )
2013-11-12 15:57:56 +04:00
{
2020-02-09 03:51:37 +03:00
g_autoptr ( virCaps ) caps = NULL ;
2021-03-11 10:16:13 +03:00
virCapsGuest * guest ;
2013-11-12 15:57:56 +04:00
if ( ( caps = virCapabilitiesNew ( VIR_ARCH_X86_64 ,
2014-07-14 16:56:13 +04:00
false , false ) ) = = NULL )
2013-11-12 15:57:56 +04:00
return NULL ;
2021-10-07 11:47:27 +03:00
guest = virCapabilitiesAddGuest ( caps , VIR_DOMAIN_OSTYPE_HVM , VIR_ARCH_I686 ,
" /usr/bin/acme-virt " , NULL , 0 , NULL ) ;
2013-11-12 15:57:56 +04:00
2021-10-07 11:47:28 +03:00
virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_TEST ,
NULL , NULL , 0 , NULL ) ;
virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_QEMU ,
NULL , NULL , 0 , NULL ) ;
virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_KVM ,
NULL , NULL , 0 , NULL ) ;
2013-11-12 15:57:56 +04:00
2021-10-07 11:47:27 +03:00
guest = virCapabilitiesAddGuest ( caps , VIR_DOMAIN_OSTYPE_HVM , VIR_ARCH_X86_64 ,
" /usr/bin/acme-virt " , NULL , 0 , NULL ) ;
2013-11-12 15:57:56 +04:00
2021-10-07 11:47:28 +03:00
virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_TEST ,
NULL , NULL , 0 , NULL ) ;
virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_QEMU ,
NULL , NULL , 0 , NULL ) ;
virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_KVM ,
NULL , NULL , 0 , NULL ) ;
2013-11-12 15:57:56 +04:00
2017-11-03 19:28:10 +03:00
if ( virTestGetDebug ( ) > 1 ) {
2020-02-09 03:47:22 +03:00
g_autofree char * caps_str = NULL ;
2013-11-12 15:57:56 +04:00
caps_str = virCapabilitiesFormatXML ( caps ) ;
if ( ! caps_str )
2020-02-09 03:57:06 +03:00
return NULL ;
2013-11-12 15:57:56 +04:00
2015-04-23 20:38:00 +03:00
VIR_TEST_DEBUG ( " Generic driver capabilities: \n %s " , caps_str ) ;
2013-11-12 15:57:56 +04:00
}
2020-02-09 03:51:37 +03:00
return g_steal_pointer ( & caps ) ;
2013-11-12 15:57:56 +04:00
}
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
# define MAX_CELLS 4
# define MAX_CPUS_IN_CELL 2
# define MAX_MEM_IN_CELL 2097152
/*
* Build NUMA topology with cell id starting from ( 0 + seq )
* for testing
*/
2021-03-11 10:16:13 +03:00
virCapsHostNUMA *
2019-11-29 12:55:59 +03:00
virTestCapsBuildNUMATopology ( int seq )
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
{
2020-02-09 03:51:37 +03:00
g_autoptr ( virCapsHostNUMA ) caps = virCapabilitiesHostNUMANew ( ) ;
2021-03-11 10:16:13 +03:00
virCapsHostNUMACellCPU * cell_cpus = NULL ;
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
int core_id , cell_id ;
int id ;
id = 0 ;
for ( cell_id = 0 ; cell_id < MAX_CELLS ; cell_id + + ) {
2020-09-23 02:04:17 +03:00
cell_cpus = g_new0 ( virCapsHostNUMACellCPU , MAX_CPUS_IN_CELL ) ;
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
for ( core_id = 0 ; core_id < MAX_CPUS_IN_CELL ; core_id + + ) {
cell_cpus [ core_id ] . id = id + core_id ;
cell_cpus [ core_id ] . socket_id = cell_id + seq ;
cell_cpus [ core_id ] . core_id = id + core_id ;
2020-10-01 18:42:11 +03:00
cell_cpus [ core_id ] . siblings = virBitmapNew ( MAX_CPUS_IN_CELL ) ;
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
ignore_value ( virBitmapSetBit ( cell_cpus [ core_id ] . siblings , id ) ) ;
}
id + + ;
2019-11-29 12:55:59 +03:00
virCapabilitiesHostNUMAAddCell ( caps , cell_id + seq ,
MAX_MEM_IN_CELL ,
2021-04-29 19:58:40 +03:00
MAX_CPUS_IN_CELL , & cell_cpus ,
0 , NULL ,
2021-04-29 19:58:43 +03:00
0 , NULL ,
NULL ) ;
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
cell_cpus = NULL ;
}
2020-02-09 03:51:37 +03:00
return g_steal_pointer ( & caps ) ;
tests: Create full host NUMA topology in more cases
vircapstest has code to add a full host NUMA topology, that
is, one that includes all information about nodes and CPUs
including IDs; testQemuCapsInit(), which is used to create a
mock virCapsPtr for QEMU tests, however, just fakes it by
setting nnumaCell_max to some number.
While the latter approach has served us well so far, we're
going to need all the information to be filled in soon. In
order to do that, we can just move the existing code from
vircapstest to testutils and, with some renaming and
trivial tweaking, use it as-is.
Interestingly, the NUMA topology generated by the function
is rigged up so that the NUMA nodes aren't (necessarily)
numbered starting from 0, which is a nice way to spot
mistaken assumptions in our codebase.
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2018-04-10 18:42:14 +03:00
}
2016-08-02 18:58:43 +03:00
static virDomainDefParserConfig virTestGenericDomainDefParserConfig = {
. features = VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS ,
} ;
2013-11-12 15:57:56 +04:00
2021-03-11 10:16:13 +03:00
virDomainXMLOption * virTestGenericDomainXMLConfInit ( void )
2013-11-12 15:57:56 +04:00
{
return virDomainXMLOptionNew ( & virTestGenericDomainDefParserConfig ,
2022-09-05 16:57:03 +03:00
NULL , NULL , NULL , NULL , NULL ) ;
2013-11-12 15:57:56 +04:00
}
2015-01-15 13:44:58 +03:00
2016-01-08 23:55:44 +03:00
int
2021-03-11 10:16:13 +03:00
testCompareDomXML2XMLFiles ( virCaps * caps G_GNUC_UNUSED ,
virDomainXMLOption * xmlopt ,
2016-01-27 23:55:01 +03:00
const char * infile , const char * outfile , bool live ,
2018-03-02 18:58:50 +03:00
unsigned int parseFlags ,
2016-04-08 19:04:10 +03:00
testCompareDomXML2XMLResult expectResult )
2016-01-08 23:55:44 +03:00
{
2020-02-09 03:47:22 +03:00
g_autofree char * actual = NULL ;
2016-01-08 23:55:44 +03:00
int ret = - 1 ;
2016-04-08 19:04:10 +03:00
testCompareDomXML2XMLResult result ;
2021-09-04 22:50:02 +03:00
g_autoptr ( virDomainDef ) def = NULL ;
2016-01-08 23:55:44 +03:00
unsigned int parse_flags = live ? 0 : VIR_DOMAIN_DEF_PARSE_INACTIVE ;
unsigned int format_flags = VIR_DOMAIN_DEF_FORMAT_SECURE ;
2016-02-25 17:17:14 +03:00
parse_flags | = parseFlags ;
2016-06-23 16:22:06 +03:00
if ( ! virFileExists ( infile ) ) {
VIR_TEST_DEBUG ( " Test input file '%s' is missing " , infile ) ;
return - 1 ;
}
2016-01-08 23:55:44 +03:00
if ( ! live )
format_flags | = VIR_DOMAIN_DEF_FORMAT_INACTIVE ;
2019-11-27 15:29:21 +03:00
if ( ! ( def = virDomainDefParseFile ( infile , xmlopt , NULL , parse_flags ) ) ) {
2016-04-08 19:04:10 +03:00
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE ;
goto out ;
}
2016-01-08 23:55:44 +03:00
2017-05-19 16:07:15 +03:00
if ( ! virDomainDefCheckABIStability ( def , def , xmlopt ) ) {
2016-01-08 23:55:44 +03:00
VIR_TEST_DEBUG ( " ABI stability check failed on %s " , infile ) ;
2016-04-08 19:04:10 +03:00
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_STABILITY ;
goto out ;
2016-01-08 23:55:44 +03:00
}
2019-11-27 14:57:34 +03:00
if ( ! ( actual = virDomainDefFormat ( def , xmlopt , format_flags ) ) ) {
2016-04-08 19:04:10 +03:00
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_FORMAT ;
goto out ;
}
2016-01-08 23:55:44 +03:00
2016-05-26 18:01:53 +03:00
if ( virTestCompareToFile ( actual , outfile ) < 0 ) {
2016-04-08 19:04:10 +03:00
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_COMPARE ;
goto out ;
}
result = TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS ;
out :
if ( result = = expectResult ) {
ret = 0 ;
if ( expectResult ! = TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS ) {
VIR_TEST_DEBUG ( " Got expected failure code=%d msg=%s " ,
result , virGetLastErrorMessage ( ) ) ;
}
} else {
ret = - 1 ;
VIR_TEST_DEBUG ( " Expected result code=%d but received code=%d " ,
expectResult , result ) ;
}
2016-01-08 23:55:44 +03:00
return ret ;
}
2015-01-15 13:44:58 +03:00
static int virtTestCounter ;
static char virtTestCounterStr [ 128 ] ;
static char * virtTestCounterPrefixEndOffset ;
/**
2016-05-26 18:01:57 +03:00
* virTestCounterReset :
2015-01-15 13:44:58 +03:00
* @ prefix : name of the test group
*
* Resets the counter and sets up the test group name to use with
2016-05-26 18:02:06 +03:00
* virTestCounterNext ( ) . This function is not thread safe .
2015-01-15 13:44:58 +03:00
*
* Note : The buffer for the assembled message is 128 bytes long . Longer test
* case names ( including the number index ) will be silently truncated .
*/
void
2016-05-26 18:01:57 +03:00
virTestCounterReset ( const char * prefix )
2015-01-15 13:44:58 +03:00
{
virtTestCounter = 0 ;
ignore_value ( virStrcpyStatic ( virtTestCounterStr , prefix ) ) ;
2020-01-14 13:43:37 +03:00
virtTestCounterPrefixEndOffset = virtTestCounterStr + strlen ( virtTestCounterStr ) ;
2015-01-15 13:44:58 +03:00
}
/**
2016-05-26 18:02:06 +03:00
* virTestCounterNext :
2015-01-15 13:44:58 +03:00
*
* This function is designed to ease test creation and reordering by adding
* a way to do automagic test case numbering .
*
* Returns string consisting of test name prefix configured via
2016-05-26 18:01:57 +03:00
* virTestCounterReset ( ) and a number that increments in every call of this
2015-01-15 13:44:58 +03:00
* function . This function is not thread safe .
*
* Note : The buffer for the assembled message is 128 bytes long . Longer test
* case names ( including the number index ) will be silently truncated .
*/
const char
2016-05-26 18:02:06 +03:00
* virTestCounterNext ( void )
2015-01-15 13:44:58 +03:00
{
2019-10-15 14:55:26 +03:00
size_t len = G_N_ELEMENTS ( virtTestCounterStr ) ;
2015-01-15 13:44:58 +03:00
/* calculate length of the rest of the string */
len - = ( virtTestCounterPrefixEndOffset - virtTestCounterStr ) ;
2019-11-13 16:53:42 +03:00
g_snprintf ( virtTestCounterPrefixEndOffset , len , " %d " , + + virtTestCounter ) ;
2015-01-15 13:44:58 +03:00
return virtTestCounterStr ;
}
2021-09-07 16:31:42 +03:00
/**
* virTestStablePath :
* @ path : path to make stable
*
* If @ path starts with the absolute source directory path , the prefix
* is replaced with the string " ABS_SRCDIR " and similarly the build directory
* is replaced by " ABS_BUILDDIR " . This is useful when paths e . g . in output
* test files need to be made stable .
*
* If @ path is NULL the equivalent to NULLSTR ( path ) is returned .
*
* The caller is responsible for freeing the returned buffer .
*/
char *
virTestStablePath ( const char * path )
{
const char * tmp ;
path = NULLSTR ( path ) ;
if ( ( tmp = STRSKIP ( path , abs_srcdir ) ) )
return g_strdup_printf ( " ABS_SRCDIR%s " , tmp ) ;
if ( ( tmp = STRSKIP ( path , abs_builddir ) ) )
return g_strdup_printf ( " ABS_BUILDDIR%s " , tmp ) ;
return g_strdup ( path ) ;
}
2021-10-20 11:30:31 +03:00
# ifdef __linux__
/**
* virCreateAnonymousFile :
* @ data : a pointer to data to be written into a new file .
* @ len : the length of data to be written ( in bytes ) .
*
* Create a fake fd , write initial data to it .
*
*/
int
virCreateAnonymousFile ( const uint8_t * data , size_t len )
{
int fd = - 1 ;
char path [ ] = abs_builddir " testutils-memfd-XXXXXX " ;
/* A temp file is used since not all supported distributions support memfd. */
if ( ( fd = g_mkstemp_full ( path , O_RDWR | O_CLOEXEC , S_IRUSR | S_IWUSR ) ) < 0 ) {
return fd ;
}
g_unlink ( path ) ;
if ( safewrite ( fd , data , len ) ! = len ) {
VIR_TEST_DEBUG ( " %s: %s " , " failed to write to an anonymous file " ,
g_strerror ( errno ) ) ;
goto cleanup ;
}
return fd ;
cleanup :
if ( VIR_CLOSE ( fd ) < 0 ) {
VIR_TEST_DEBUG ( " %s: %s " , " failed to close an anonymous file " ,
g_strerror ( errno ) ) ;
}
return - 1 ;
}
# endif