2001-09-25 16:49:28 +04:00
/*
2008-01-30 17:00:02 +03:00
* Copyright ( C ) 2001 - 2004 Sistina Software , Inc . All rights reserved .
2017-03-03 22:46:13 +03:00
* Copyright ( C ) 2004 - 2017 Red Hat , Inc . All rights reserved .
2001-09-25 16:49:28 +04:00
*
2004-03-30 23:35:44 +04:00
* This file is part of LVM2 .
*
* This copyrighted material is made available to anyone wishing to use ,
* modify , copy , or redistribute it subject to the terms and conditions
2007-08-21 00:55:30 +04:00
* of the GNU Lesser General Public License v .2 .1 .
2004-03-30 23:35:44 +04:00
*
2007-08-21 00:55:30 +04:00
* You should have received a copy of the GNU Lesser General Public License
2004-03-30 23:35:44 +04:00
* along with this program ; if not , write to the Free Software Foundation ,
2016-01-21 13:49:46 +03:00
* Inc . , 51 Franklin Street , Fifth Floor , Boston , MA 02110 - 1301 USA
2001-09-25 16:49:28 +04:00
*/
2001-10-06 01:39:30 +04:00
# include "tools.h"
2016-02-16 23:15:24 +03:00
# include "format1.h"
# include "format-text.h"
2015-07-06 19:30:18 +03:00
2002-01-01 00:27:39 +03:00
# include <sys/stat.h>
2013-09-03 18:06:16 +04:00
# include <signal.h>
# include <sys/wait.h>
2014-10-24 21:29:04 +04:00
# include <sys/utsname.h>
2002-01-01 00:27:39 +03:00
2016-05-23 16:27:09 +03:00
# define report_log_ret_code(ret_code) report_current_object_cmdlog(REPORT_OBJECT_CMDLOG_NAME, \
2017-07-19 17:17:30 +03:00
( ( ret_code ) = = ECMD_PROCESSED ) ? REPORT_OBJECT_CMDLOG_SUCCESS \
: REPORT_OBJECT_CMDLOG_FAILURE , ( ret_code ) )
2016-05-23 16:27:09 +03:00
2015-01-09 23:55:16 +03:00
struct device_id_list {
struct dm_list list ;
struct device * dev ;
char pvid [ ID_LEN + 1 ] ;
} ;
2006-04-19 19:33:07 +04:00
const char * command_name ( struct cmd_context * cmd )
{
return cmd - > command - > name ;
}
2013-09-03 18:06:16 +04:00
static void _sigchld_handler ( int sig __attribute__ ( ( unused ) ) )
{
while ( wait4 ( - 1 , NULL , WNOHANG | WUNTRACED , NULL ) > 0 ) ;
}
/*
* returns :
* - 1 if the fork failed
* 0 if the parent
* 1 if the child
*/
int become_daemon ( struct cmd_context * cmd , int skip_lvm )
{
static const char devnull [ ] = " /dev/null " ;
int null_fd ;
pid_t pid ;
struct sigaction act = {
{ _sigchld_handler } ,
. sa_flags = SA_NOCLDSTOP ,
} ;
2016-04-14 19:21:02 +03:00
log_verbose ( " Forking background process from command: %s " , cmd - > cmd_line ) ;
2013-09-03 18:06:16 +04:00
sigaction ( SIGCHLD , & act , NULL ) ;
if ( ! skip_lvm )
2015-06-30 20:54:38 +03:00
if ( ! sync_local_dev_names ( cmd ) ) { /* Flush ops and reset dm cookie */
log_error ( " Failed to sync local devices before forking. " ) ;
return - 1 ;
}
2013-09-03 18:06:16 +04:00
if ( ( pid = fork ( ) ) = = - 1 ) {
log_error ( " fork failed: %s " , strerror ( errno ) ) ;
return - 1 ;
}
/* Parent */
if ( pid > 0 )
return 0 ;
/* Child */
if ( setsid ( ) = = - 1 )
log_error ( " Background process failed to setsid: %s " ,
strerror ( errno ) ) ;
2013-09-06 04:49:43 +04:00
/* Set this to avoid discarding output from background process */
2013-09-16 23:20:26 +04:00
// #define DEBUG_CHILD
2013-09-06 04:49:43 +04:00
# ifndef DEBUG_CHILD
2013-09-03 18:06:16 +04:00
if ( ( null_fd = open ( devnull , O_RDWR ) ) = = - 1 ) {
log_sys_error ( " open " , devnull ) ;
_exit ( ECMD_FAILED ) ;
}
if ( ( dup2 ( null_fd , STDIN_FILENO ) < 0 ) | | /* reopen stdin */
( dup2 ( null_fd , STDOUT_FILENO ) < 0 ) | | /* reopen stdout */
( dup2 ( null_fd , STDERR_FILENO ) < 0 ) ) { /* reopen stderr */
log_sys_error ( " dup2 " , " redirect " ) ;
( void ) close ( null_fd ) ;
_exit ( ECMD_FAILED ) ;
}
if ( null_fd > STDERR_FILENO )
( void ) close ( null_fd ) ;
init_verbose ( VERBOSE_BASE_LEVEL ) ;
2013-09-06 04:49:43 +04:00
# endif /* DEBUG_CHILD */
2013-09-03 18:06:16 +04:00
strncpy ( * cmd - > argv , " (lvm2) " , strlen ( * cmd - > argv ) ) ;
2015-04-13 17:29:15 +03:00
lvmetad_disconnect ( ) ;
2013-09-03 18:06:16 +04:00
if ( ! skip_lvm ) {
reset_locking ( ) ;
2014-03-22 01:26:39 +04:00
lvmcache_destroy ( cmd , 1 , 1 ) ;
2013-09-03 18:06:16 +04:00
if ( ! lvmcache_init ( ) )
/* FIXME Clean up properly here */
_exit ( ECMD_FAILED ) ;
}
dev_close_all ( ) ;
return 1 ;
}
2006-08-26 03:02:33 +04:00
/*
* Strip dev_dir if present
*/
2011-02-18 17:47:28 +03:00
const char * skip_dev_dir ( struct cmd_context * cmd , const char * vg_name ,
2014-07-11 14:25:18 +04:00
unsigned * dev_dir_found )
2006-08-26 03:02:33 +04:00
{
2014-09-28 14:54:20 +04:00
size_t devdir_len = strlen ( cmd - > dev_dir ) ;
const char * dmdir = dm_dir ( ) + devdir_len ;
2007-03-09 23:47:41 +03:00
size_t dmdir_len = strlen ( dmdir ) , vglv_sz ;
char * vgname , * lvname , * layer , * vglv ;
2006-08-26 03:02:33 +04:00
2007-03-09 23:47:41 +03:00
/* FIXME Do this properly */
2014-09-28 14:54:20 +04:00
if ( * vg_name = = ' / ' )
while ( vg_name [ 1 ] = = ' / ' )
2006-08-26 03:02:33 +04:00
vg_name + + ;
2014-09-28 14:54:20 +04:00
if ( strncmp ( vg_name , cmd - > dev_dir , devdir_len ) ) {
if ( dev_dir_found )
* dev_dir_found = 0 ;
} else {
2007-03-09 23:47:41 +03:00
if ( dev_dir_found )
* dev_dir_found = 1 ;
2014-09-28 14:54:20 +04:00
vg_name + = devdir_len ;
2007-03-09 23:47:41 +03:00
while ( * vg_name = = ' / ' )
vg_name + + ;
2014-09-28 14:54:20 +04:00
/* Reformat string if /dev/mapper found */
2014-11-26 19:09:47 +03:00
if ( ! strncmp ( vg_name , dmdir , dmdir_len ) & & vg_name [ dmdir_len ] = = ' / ' ) {
vg_name + = dmdir_len + 1 ;
2014-09-28 14:54:20 +04:00
while ( * vg_name = = ' / ' )
vg_name + + ;
if ( ! dm_split_lvm_name ( cmd - > mem , vg_name , & vgname , & lvname , & layer ) | |
* layer ) {
2014-11-14 18:08:27 +03:00
log_error ( " skip_dev_dir: Couldn't split up device name %s. " ,
2014-09-28 14:54:20 +04:00
vg_name ) ;
return vg_name ;
}
vglv_sz = strlen ( vgname ) + strlen ( lvname ) + 2 ;
if ( ! ( vglv = dm_pool_alloc ( cmd - > mem , vglv_sz ) ) | |
dm_snprintf ( vglv , vglv_sz , " %s%s%s " , vgname ,
* lvname ? " / " : " " ,
lvname ) < 0 ) {
2014-11-14 18:08:27 +03:00
log_error ( " vg/lv string alloc failed. " ) ;
2014-09-28 14:54:20 +04:00
return vg_name ;
}
return vglv ;
2007-03-09 23:47:41 +03:00
}
}
2011-02-18 17:47:28 +03:00
return vg_name ;
2006-08-26 03:02:33 +04:00
}
2013-10-02 00:20:10 +04:00
/*
2014-11-15 00:00:35 +03:00
* Three possible results :
* a ) return 0 , skip 0 : take the VG , and cmd will end in success
* b ) return 0 , skip 1 : skip the VG , and cmd will end in success
* c ) return 1 , skip * : skip the VG , and cmd will end in failure
*
* Case b is the special case , and includes the following :
* . The VG is inconsistent , and the command allows for inconsistent VGs .
* . The VG is clustered , the host cannot access clustered VG ' s ,
* and the command option has been used to ignore clustered vgs .
*
* Case c covers the other errors returned when reading the VG .
2015-03-19 02:31:46 +03:00
* If * skip is 1 , it ' s OK for the caller to read the list of PVs in the VG .
2013-10-02 00:20:10 +04:00
*/
2015-02-13 20:01:55 +03:00
static int _ignore_vg ( struct volume_group * vg , const char * vg_name ,
2015-10-23 23:09:20 +03:00
struct dm_list * arg_vgnames , uint32_t read_flags ,
int * skip , int * notfound )
2013-10-02 00:20:10 +04:00
{
uint32_t read_error = vg_read_error ( vg ) ;
2015-10-23 23:09:20 +03:00
2014-11-14 12:50:31 +03:00
* skip = 0 ;
2015-10-23 23:09:20 +03:00
* notfound = 0 ;
2013-10-02 00:20:10 +04:00
2015-10-22 22:56:22 +03:00
if ( ( read_error & FAILED_NOTFOUND ) & & ( read_flags & READ_OK_NOTFOUND ) ) {
2015-10-23 23:09:20 +03:00
* notfound = 1 ;
2015-10-22 22:56:22 +03:00
return 0 ;
}
if ( ( read_error & FAILED_INCONSISTENT ) & & ( read_flags & READ_ALLOW_INCONSISTENT ) )
2014-11-14 12:50:31 +03:00
read_error & = ~ FAILED_INCONSISTENT ; /* Check for other errors */
2013-10-02 00:20:10 +04:00
2014-11-14 12:50:31 +03:00
if ( ( read_error & FAILED_CLUSTERED ) & & vg - > cmd - > ignore_clustered_vgs ) {
read_error & = ~ FAILED_CLUSTERED ; /* Check for other errors */
2013-10-02 00:20:10 +04:00
log_verbose ( " Skipping volume group %s " , vg_name ) ;
2014-11-14 12:50:31 +03:00
* skip = 1 ;
2013-10-02 00:20:10 +04:00
}
2014-10-24 21:29:04 +04:00
/*
* Commands that operate on " all vgs " shouldn ' t be bothered by
* skipping a foreign VG , and the command shouldn ' t fail when
* one is skipped . But , if the command explicitly asked to
* operate on a foreign VG and it ' s skipped , then the command
* would expect to fail .
*/
if ( read_error & FAILED_SYSTEMID ) {
if ( arg_vgnames & & str_list_match_item ( arg_vgnames , vg - > name ) ) {
2015-03-04 04:00:51 +03:00
log_error ( " Cannot access VG %s with system ID %s with %slocal system ID%s%s. " ,
vg - > name , vg - > system_id , vg - > cmd - > system_id ? " " : " unknown " ,
vg - > cmd - > system_id ? " " : " " , vg - > cmd - > system_id ? vg - > cmd - > system_id : " " ) ;
2014-10-24 21:29:04 +04:00
return 1 ;
} else {
read_error & = ~ FAILED_SYSTEMID ; /* Check for other errors */
2015-02-24 02:19:36 +03:00
log_verbose ( " Skipping foreign volume group %s " , vg_name ) ;
2014-10-24 21:29:04 +04:00
* skip = 1 ;
}
}
2015-03-05 23:00:44 +03:00
/*
* Accessing a lockd VG when lvmlockd is not used is similar
* to accessing a foreign VG .
2015-07-14 19:36:04 +03:00
* This is also the point where a command fails if it failed
* to acquire the necessary lock from lvmlockd .
* The two cases are distinguished by FAILED_LOCK_TYPE ( the
* VG lock_type requires lvmlockd ) , and FAILED_LOCK_MODE ( the
* command failed to acquire the necessary lock . )
2015-03-05 23:00:44 +03:00
*/
2015-07-14 19:36:04 +03:00
if ( read_error & ( FAILED_LOCK_TYPE | FAILED_LOCK_MODE ) ) {
2015-03-05 23:00:44 +03:00
if ( arg_vgnames & & str_list_match_item ( arg_vgnames , vg - > name ) ) {
2015-07-14 19:36:04 +03:00
if ( read_error & FAILED_LOCK_TYPE )
log_error ( " Cannot access VG %s with lock type %s that requires lvmlockd. " ,
vg - > name , vg - > lock_type ) ;
/* For FAILED_LOCK_MODE, the error is printed in vg_read. */
2015-03-05 23:00:44 +03:00
return 1 ;
} else {
read_error & = ~ FAILED_LOCK_TYPE ; /* Check for other errors */
2015-07-14 19:36:04 +03:00
read_error & = ~ FAILED_LOCK_MODE ;
2015-03-05 23:00:44 +03:00
log_verbose ( " Skipping volume group %s " , vg_name ) ;
* skip = 1 ;
}
}
2015-05-08 23:58:00 +03:00
if ( read_error = = FAILED_CLUSTERED ) {
2015-03-19 02:31:46 +03:00
* skip = 1 ;
stack ; /* Error already logged */
return 1 ;
}
2014-11-14 12:50:31 +03:00
if ( read_error ! = SUCCESS ) {
2015-03-19 02:31:46 +03:00
* skip = 0 ;
2015-03-11 18:18:42 +03:00
if ( is_orphan_vg ( vg_name ) )
log_error ( " Cannot process standalone physical volumes " ) ;
else
log_error ( " Cannot process volume group %s " , vg_name ) ;
2014-11-14 12:50:31 +03:00
return 1 ;
}
return 0 ;
2013-10-02 00:20:10 +04:00
}
2014-12-03 16:20:00 +03:00
/*
* This functiona updates the " selected " arg only if last item processed
* is selected so this implements the " whole structure is selected if
* at least one of its items is selected " .
*/
static void _update_selection_result ( struct processing_handle * handle , int * selected )
{
if ( ! handle | | ! handle - > selection_handle )
return ;
if ( handle - > selection_handle - > selected )
* selected = 1 ;
}
static void _set_final_selection_result ( struct processing_handle * handle , int selected )
{
if ( ! handle | | ! handle - > selection_handle )
return ;
handle - > selection_handle - > selected = selected ;
}
2005-01-19 20:31:51 +03:00
/*
* Metadata iteration functions
*/
2005-04-20 00:58:25 +04:00
int process_each_segment_in_pv ( struct cmd_context * cmd ,
struct volume_group * vg ,
struct physical_volume * pv ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2010-04-14 03:57:41 +04:00
process_single_pvseg_fn_t process_single_pvseg )
2005-04-20 00:58:25 +04:00
{
struct pv_segment * pvseg ;
2014-12-03 16:20:00 +03:00
int whole_selected = 0 ;
2008-06-11 00:07:04 +04:00
int ret_max = ECMD_PROCESSED ;
2005-04-20 00:58:25 +04:00
int ret ;
2009-04-21 16:59:18 +04:00
struct pv_segment _free_pv_segment = { . pv = pv } ;
2007-11-14 21:41:05 +03:00
2014-11-15 00:00:35 +03:00
if ( dm_list_empty ( & pv - > segments ) ) {
ret = process_single_pvseg ( cmd , NULL , & _free_pv_segment , handle ) ;
if ( ret ! = ECMD_PROCESSED )
stack ;
if ( ret > ret_max )
ret_max = ret ;
} else {
2009-04-21 16:59:18 +04:00
dm_list_iterate_items ( pvseg , & pv - > segments ) {
2014-11-14 12:50:31 +03:00
if ( sigint_caught ( ) )
return_ECMD_FAILED ;
2014-11-15 00:00:35 +03:00
ret = process_single_pvseg ( cmd , vg , pvseg , handle ) ;
2014-12-03 16:20:00 +03:00
_update_selection_result ( handle , & whole_selected ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
2013-07-01 18:30:12 +04:00
stack ;
2009-04-21 16:59:18 +04:00
if ( ret > ret_max )
ret_max = ret ;
}
2014-11-15 00:00:35 +03:00
}
2007-11-14 21:41:05 +03:00
2014-12-03 16:20:00 +03:00
/* the PV is selected if at least one PV segment is selected */
_set_final_selection_result ( handle , whole_selected ) ;
2005-04-20 00:58:25 +04:00
return ret_max ;
}
2002-12-12 23:55:49 +03:00
int process_each_segment_in_lv ( struct cmd_context * cmd ,
struct logical_volume * lv ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2010-04-14 03:57:41 +04:00
process_single_seg_fn_t process_single_seg )
2002-12-12 23:55:49 +03:00
{
struct lv_segment * seg ;
2014-12-03 16:20:00 +03:00
int whole_selected = 0 ;
2008-06-11 00:07:04 +04:00
int ret_max = ECMD_PROCESSED ;
2002-12-12 23:55:49 +03:00
int ret ;
2008-11-04 01:14:30 +03:00
dm_list_iterate_items ( seg , & lv - > segments ) {
2014-11-15 00:00:35 +03:00
if ( sigint_caught ( ) )
return_ECMD_FAILED ;
ret = process_single_seg ( cmd , seg , handle ) ;
2014-12-03 16:20:00 +03:00
_update_selection_result ( handle , & whole_selected ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
2014-11-14 12:50:31 +03:00
stack ;
2002-12-12 23:55:49 +03:00
if ( ret > ret_max )
ret_max = ret ;
}
2014-12-03 16:20:00 +03:00
/* the LV is selected if at least one LV segment is selected */
_set_final_selection_result ( handle , whole_selected ) ;
2002-12-12 23:55:49 +03:00
return ret_max ;
}
2014-09-27 18:29:43 +04:00
static const char * _extract_vgname ( struct cmd_context * cmd , const char * lv_name ,
const char * * after )
{
const char * vg_name = lv_name ;
char * st , * pos ;
/* Strip dev_dir (optional) */
if ( ! ( vg_name = skip_dev_dir ( cmd , vg_name , NULL ) ) )
return_0 ;
/* Require exactly one set of consecutive slashes */
if ( ( st = pos = strchr ( vg_name , ' / ' ) ) )
while ( * st = = ' / ' )
st + + ;
if ( ! st | | strchr ( st , ' / ' ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " \" %s \" : Invalid path for Logical Volume. " ,
2014-09-27 18:29:43 +04:00
lv_name ) ;
return 0 ;
}
if ( ! ( vg_name = dm_pool_strndup ( cmd - > mem , vg_name , pos - vg_name ) ) ) {
log_error ( " Allocation of vg_name failed. " ) ;
return 0 ;
}
if ( after )
* after = st ;
return vg_name ;
}
2014-10-07 01:02:00 +04:00
2014-10-06 18:22:01 +04:00
/*
* Extract default volume group name from environment
*/
static const char * _default_vgname ( struct cmd_context * cmd )
{
const char * vg_path ;
/* Take default VG from environment? */
vg_path = getenv ( " LVM_VG_NAME " ) ;
if ( ! vg_path )
return 0 ;
vg_path = skip_dev_dir ( cmd , vg_path , NULL ) ;
if ( strchr ( vg_path , ' / ' ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " \" %s \" : Invalid environment var LVM_VG_NAME set for Volume Group. " ,
vg_path ) ;
2014-10-06 18:22:01 +04:00
return 0 ;
}
return dm_pool_strdup ( cmd - > mem , vg_path ) ;
}
2005-01-19 20:31:51 +03:00
/*
* Determine volume group name from a logical volume name
*/
2002-12-20 02:25:55 +03:00
const char * extract_vgname ( struct cmd_context * cmd , const char * lv_name )
2001-11-14 21:38:07 +03:00
{
2002-12-20 02:25:55 +03:00
const char * vg_name = lv_name ;
2001-10-29 16:52:23 +03:00
/* Path supplied? */
2001-11-06 22:02:26 +03:00
if ( vg_name & & strchr ( vg_name , ' / ' ) ) {
2014-09-27 18:29:43 +04:00
if ( ! ( vg_name = _extract_vgname ( cmd , lv_name , NULL ) ) )
return_NULL ;
2004-03-08 20:19:15 +03:00
2001-10-29 16:52:23 +03:00
return vg_name ;
}
2001-11-06 22:02:26 +03:00
2014-10-06 18:22:01 +04:00
if ( ! ( vg_name = _default_vgname ( cmd ) ) ) {
2001-11-06 22:02:26 +03:00
if ( lv_name )
2014-11-14 18:08:27 +03:00
log_error ( " Path required for Logical Volume \" %s \" . " ,
2001-11-14 21:38:07 +03:00
lv_name ) ;
2014-09-27 18:29:43 +04:00
return NULL ;
2001-11-06 22:02:26 +03:00
}
2001-11-14 21:38:07 +03:00
2001-11-06 22:02:26 +03:00
return vg_name ;
}
2005-01-19 20:31:51 +03:00
/*
* Process physical extent range specifiers
*/
2006-10-22 03:18:43 +04:00
static int _add_pe_range ( struct dm_pool * mem , const char * pvname ,
2008-11-04 01:14:30 +03:00
struct dm_list * pe_ranges , uint32_t start , uint32_t count )
2003-04-25 02:23:24 +04:00
{
2004-08-18 01:55:23 +04:00
struct pe_range * per ;
2003-04-25 02:23:24 +04:00
2016-11-25 16:08:39 +03:00
log_debug ( " Adding PE range: start PE " FMTu32 " length " FMTu32 " on %s. " ,
start , count , pvname ) ;
2003-04-25 02:23:24 +04:00
/* Ensure no overlap with existing areas */
2008-11-04 01:14:30 +03:00
dm_list_iterate_items ( per , pe_ranges ) {
2014-10-07 03:34:04 +04:00
if ( ( ( start < per - > start ) & & ( start + count - 1 > = per - > start ) ) | |
( ( start > = per - > start ) & &
2004-08-18 01:55:23 +04:00
( per - > start + per - > count - 1 ) > = start ) ) {
2016-11-25 16:08:39 +03:00
log_error ( " Overlapping PE ranges specified ( " FMTu32
" - " FMTu32 " , " FMTu32 " - " FMTu32 " ) on %s. " ,
2004-08-18 01:55:23 +04:00
start , start + count - 1 , per - > start ,
2006-10-22 03:18:43 +04:00
per - > start + per - > count - 1 , pvname ) ;
2003-04-25 02:23:24 +04:00
return 0 ;
}
}
2005-10-17 03:03:59 +04:00
if ( ! ( per = dm_pool_alloc ( mem , sizeof ( * per ) ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Allocation of list failed. " ) ;
2003-04-25 02:23:24 +04:00
return 0 ;
}
2004-08-18 01:55:23 +04:00
per - > start = start ;
per - > count = count ;
2008-11-04 01:14:30 +03:00
dm_list_add ( pe_ranges , & per - > list ) ;
2003-04-25 02:23:24 +04:00
return 1 ;
}
2014-10-07 03:34:04 +04:00
static int _xstrtouint32 ( const char * s , char * * p , int base , uint32_t * result )
2007-09-12 00:12:54 +04:00
{
unsigned long ul ;
errno = 0 ;
ul = strtoul ( s , p , base ) ;
2014-10-07 03:34:04 +04:00
2012-01-20 01:28:06 +04:00
if ( errno | | * p = = s | | ul > UINT32_MAX )
return 0 ;
2014-10-07 03:34:04 +04:00
2007-09-12 00:12:54 +04:00
* result = ul ;
2012-01-20 01:28:06 +04:00
return 1 ;
2007-09-12 00:12:54 +04:00
}
2008-11-04 01:14:30 +03:00
static int _parse_pes ( struct dm_pool * mem , char * c , struct dm_list * pe_ranges ,
2006-10-22 03:18:43 +04:00
const char * pvname , uint32_t size )
2003-04-25 02:23:24 +04:00
{
char * endptr ;
2013-09-23 22:50:34 +04:00
uint32_t start , end , len ;
2003-04-25 02:23:24 +04:00
/* Default to whole PV */
if ( ! c ) {
2008-01-30 16:19:47 +03:00
if ( ! _add_pe_range ( mem , pvname , pe_ranges , UINT32_C ( 0 ) , size ) )
return_0 ;
2003-04-25 02:23:24 +04:00
return 1 ;
}
while ( * c ) {
if ( * c ! = ' : ' )
goto error ;
c + + ;
/* Disallow :: and :\0 */
if ( * c = = ' : ' | | ! * c )
goto error ;
/* Default to whole range */
start = UINT32_C ( 0 ) ;
end = size - 1 ;
/* Start extent given? */
if ( isdigit ( * c ) ) {
2014-10-07 03:34:04 +04:00
if ( ! _xstrtouint32 ( c , & endptr , 10 , & start ) )
2003-04-25 02:23:24 +04:00
goto error ;
c = endptr ;
/* Just one number given? */
if ( ! * c | | * c = = ' : ' )
end = start ;
}
/* Range? */
if ( * c = = ' - ' ) {
c + + ;
if ( isdigit ( * c ) ) {
2014-10-07 03:34:04 +04:00
if ( ! _xstrtouint32 ( c , & endptr , 10 , & end ) )
2003-04-25 02:23:24 +04:00
goto error ;
c = endptr ;
}
2013-09-23 22:50:34 +04:00
} else if ( * c = = ' + ' ) { /* Length? */
c + + ;
if ( isdigit ( * c ) ) {
2014-10-07 03:34:04 +04:00
if ( ! _xstrtouint32 ( c , & endptr , 10 , & len ) )
2013-09-23 22:50:34 +04:00
goto error ;
c = endptr ;
end = start + ( len ? ( len - 1 ) : 0 ) ;
}
2003-04-25 02:23:24 +04:00
}
2013-09-23 22:50:34 +04:00
2003-04-25 02:23:24 +04:00
if ( * c & & * c ! = ' : ' )
goto error ;
if ( ( start > end ) | | ( end > size - 1 ) ) {
log_error ( " PE range error: start extent % " PRIu32 " to "
2014-11-14 18:08:27 +03:00
" end extent % " PRIu32 " . " , start , end ) ;
2003-04-25 02:23:24 +04:00
return 0 ;
}
2008-01-30 16:19:47 +03:00
if ( ! _add_pe_range ( mem , pvname , pe_ranges , start , end - start + 1 ) )
return_0 ;
2003-04-25 02:23:24 +04:00
}
return 1 ;
error :
2014-11-14 18:08:27 +03:00
log_error ( " Physical extent parsing error at %s. " , c ) ;
2003-04-25 02:23:24 +04:00
return 0 ;
}
2006-10-22 03:18:43 +04:00
static int _create_pv_entry ( struct dm_pool * mem , struct pv_list * pvl ,
2008-11-04 01:14:30 +03:00
char * colon , int allocatable_only , struct dm_list * r )
2004-03-08 20:19:15 +03:00
{
const char * pvname ;
2006-10-22 03:18:43 +04:00
struct pv_list * new_pvl = NULL , * pvl2 ;
2008-11-04 01:14:30 +03:00
struct dm_list * pe_ranges ;
2004-03-08 20:19:15 +03:00
2007-10-12 18:29:32 +04:00
pvname = pv_dev_name ( pvl - > pv ) ;
2004-08-18 01:55:23 +04:00
if ( allocatable_only & & ! ( pvl - > pv - > status & ALLOCATABLE_PV ) ) {
2016-11-25 16:17:56 +03:00
log_warn ( " WARNING: Physical volume %s not allocatable. " , pvname ) ;
2006-10-22 03:18:43 +04:00
return 1 ;
2004-03-08 20:19:15 +03:00
}
2010-03-16 17:37:38 +03:00
if ( allocatable_only & & is_missing_pv ( pvl - > pv ) ) {
2016-11-25 16:17:56 +03:00
log_warn ( " WARNING: Physical volume %s is missing. " , pvname ) ;
2009-04-23 20:45:30 +04:00
return 1 ;
}
2004-08-18 01:55:23 +04:00
if ( allocatable_only & &
( pvl - > pv - > pe_count = = pvl - > pv - > pe_alloc_count ) ) {
2016-11-25 16:17:56 +03:00
log_warn ( " WARNING: No free extents on physical volume \" %s \" . " , pvname ) ;
2006-10-22 03:18:43 +04:00
return 1 ;
2004-03-08 20:19:15 +03:00
}
2008-11-04 01:14:30 +03:00
dm_list_iterate_items ( pvl2 , r )
2006-10-22 03:18:43 +04:00
if ( pvl - > pv - > dev = = pvl2 - > pv - > dev ) {
new_pvl = pvl2 ;
break ;
}
2009-10-06 20:00:38 +04:00
2006-10-22 03:18:43 +04:00
if ( ! new_pvl ) {
if ( ! ( new_pvl = dm_pool_alloc ( mem , sizeof ( * new_pvl ) ) ) ) {
2009-07-16 00:02:46 +04:00
log_error ( " Unable to allocate physical volume list. " ) ;
2006-10-22 03:18:43 +04:00
return 0 ;
}
2004-03-08 20:19:15 +03:00
2006-10-22 03:18:43 +04:00
memcpy ( new_pvl , pvl , sizeof ( * new_pvl ) ) ;
2004-03-08 20:19:15 +03:00
2006-10-22 03:18:43 +04:00
if ( ! ( pe_ranges = dm_pool_alloc ( mem , sizeof ( * pe_ranges ) ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Allocation of pe_ranges list failed. " ) ;
2006-10-22 03:18:43 +04:00
return 0 ;
}
2008-11-04 01:14:30 +03:00
dm_list_init ( pe_ranges ) ;
2006-10-22 03:18:43 +04:00
new_pvl - > pe_ranges = pe_ranges ;
2008-11-04 01:14:30 +03:00
dm_list_add ( r , & new_pvl - > list ) ;
2004-03-08 20:19:15 +03:00
}
2004-08-18 01:55:23 +04:00
/* Determine selected physical extents */
2007-10-12 18:29:32 +04:00
if ( ! _parse_pes ( mem , colon , new_pvl - > pe_ranges , pv_dev_name ( pvl - > pv ) ,
2008-01-30 16:19:47 +03:00
pvl - > pv - > pe_count ) )
return_0 ;
2004-03-08 20:19:15 +03:00
2006-10-22 03:18:43 +04:00
return 1 ;
2004-03-08 20:19:15 +03:00
}
2008-11-04 01:14:30 +03:00
struct dm_list * create_pv_list ( struct dm_pool * mem , struct volume_group * vg , int argc ,
2004-08-18 01:55:23 +04:00
char * * argv , int allocatable_only )
2002-01-21 19:05:23 +03:00
{
2008-11-04 01:14:30 +03:00
struct dm_list * r ;
2004-03-08 20:19:15 +03:00
struct pv_list * pvl ;
2014-01-31 01:09:28 +04:00
struct dm_list tagsl , arg_pvnames ;
2010-09-23 16:02:33 +04:00
char * pvname = NULL ;
char * colon , * at_sign , * tagname ;
2002-01-21 19:05:23 +03:00
int i ;
/* Build up list of PVs */
2005-10-17 03:03:59 +04:00
if ( ! ( r = dm_pool_alloc ( mem , sizeof ( * r ) ) ) ) {
2016-11-25 16:08:39 +03:00
log_error ( " Allocation of list failed. " ) ;
2002-01-21 19:05:23 +03:00
return NULL ;
}
2008-11-04 01:14:30 +03:00
dm_list_init ( r ) ;
2002-01-21 19:05:23 +03:00
2014-01-31 01:09:28 +04:00
dm_list_init ( & tagsl ) ;
2008-11-04 01:14:30 +03:00
dm_list_init ( & arg_pvnames ) ;
2004-03-08 20:19:15 +03:00
2002-01-21 19:05:23 +03:00
for ( i = 0 ; i < argc ; i + + ) {
2011-08-30 18:55:15 +04:00
dm_unescape_colons_and_at_signs ( argv [ i ] , & colon , & at_sign ) ;
2010-09-23 16:02:33 +04:00
if ( at_sign & & ( at_sign = = argv [ i ] ) ) {
tagname = at_sign + 1 ;
2010-11-17 13:19:29 +03:00
if ( ! validate_tag ( tagname ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Skipping invalid tag %s. " , tagname ) ;
2004-03-08 20:19:15 +03:00
continue ;
}
2008-11-04 01:14:30 +03:00
dm_list_iterate_items ( pvl , & vg - > pvs ) {
2004-03-08 20:19:15 +03:00
if ( str_list_match_item ( & pvl - > pv - > tags ,
2004-05-19 01:55:55 +04:00
tagname ) ) {
2006-10-22 03:18:43 +04:00
if ( ! _create_pv_entry ( mem , pvl , NULL ,
allocatable_only ,
2008-01-30 16:19:47 +03:00
r ) )
return_NULL ;
2004-03-08 20:19:15 +03:00
}
2003-04-25 02:23:24 +04:00
}
2002-01-21 19:05:23 +03:00
continue ;
}
2004-03-08 20:19:15 +03:00
pvname = argv [ i ] ;
2003-04-25 02:23:24 +04:00
2010-09-23 16:02:33 +04:00
if ( colon & & ! ( pvname = dm_pool_strndup ( mem , pvname ,
( unsigned ) ( colon - pvname ) ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Failed to clone PV name. " ) ;
2010-09-23 16:02:33 +04:00
return NULL ;
2003-04-25 02:23:24 +04:00
}
2004-05-11 22:45:11 +04:00
if ( ! ( pvl = find_pv_in_vg ( vg , pvname ) ) ) {
2009-07-16 00:02:46 +04:00
log_error ( " Physical Volume \" %s \" not found in "
2014-11-14 18:08:27 +03:00
" Volume Group \" %s \" . " , pvname , vg - > name ) ;
2004-05-11 22:45:11 +04:00
return NULL ;
}
2008-01-30 16:19:47 +03:00
if ( ! _create_pv_entry ( mem , pvl , colon , allocatable_only , r ) )
return_NULL ;
2002-01-21 19:05:23 +03:00
}
2008-11-04 01:14:30 +03:00
if ( dm_list_empty ( r ) )
2014-11-14 18:08:27 +03:00
log_error ( " No specified PVs have space available. " ) ;
2004-03-08 20:19:15 +03:00
2008-11-04 01:14:30 +03:00
return dm_list_empty ( r ) ? NULL : r ;
2002-01-21 19:05:23 +03:00
}
2003-04-25 02:23:24 +04:00
2008-11-04 01:14:30 +03:00
struct dm_list * clone_pv_list ( struct dm_pool * mem , struct dm_list * pvsl )
2003-04-25 02:23:24 +04:00
{
2008-11-04 01:14:30 +03:00
struct dm_list * r ;
2003-04-25 02:23:24 +04:00
struct pv_list * pvl , * new_pvl ;
/* Build up list of PVs */
2005-10-17 03:03:59 +04:00
if ( ! ( r = dm_pool_alloc ( mem , sizeof ( * r ) ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Allocation of list failed. " ) ;
2003-04-25 02:23:24 +04:00
return NULL ;
}
2008-11-04 01:14:30 +03:00
dm_list_init ( r ) ;
2003-04-25 02:23:24 +04:00
2008-11-04 01:14:30 +03:00
dm_list_iterate_items ( pvl , pvsl ) {
2005-10-17 03:03:59 +04:00
if ( ! ( new_pvl = dm_pool_zalloc ( mem , sizeof ( * new_pvl ) ) ) ) {
2003-04-25 02:23:24 +04:00
log_error ( " Unable to allocate physical volume list. " ) ;
return NULL ;
}
memcpy ( new_pvl , pvl , sizeof ( * new_pvl ) ) ;
2008-11-04 01:14:30 +03:00
dm_list_add ( r , & new_pvl - > list ) ;
2003-04-25 02:23:24 +04:00
}
return r ;
}
2004-06-15 21:23:49 +04:00
2014-11-14 18:08:27 +03:00
const char _pe_size_may_not_be_negative_msg [ ] = " Physical extent size may not be negative. " ;
2014-09-12 12:03:12 +04:00
int vgcreate_params_set_defaults ( struct cmd_context * cmd ,
struct vgcreate_params * vp_def ,
struct volume_group * vg )
2009-11-01 23:02:32 +03:00
{
2014-09-12 12:03:12 +04:00
int64_t extent_size ;
2015-02-24 02:19:36 +03:00
/* Only vgsplit sets vg */
2009-11-01 23:02:32 +03:00
if ( vg ) {
vp_def - > vg_name = NULL ;
vp_def - > extent_size = vg - > extent_size ;
vp_def - > max_pv = vg - > max_pv ;
vp_def - > max_lv = vg - > max_lv ;
vp_def - > alloc = vg - > alloc ;
vp_def - > clustered = vg_is_clustered ( vg ) ;
2010-07-01 00:03:52 +04:00
vp_def - > vgmetadatacopies = vg - > mda_copies ;
2015-02-24 02:19:36 +03:00
vp_def - > system_id = vg - > system_id ; /* No need to clone this */
2009-11-01 23:02:32 +03:00
} else {
vp_def - > vg_name = NULL ;
2014-09-12 12:03:12 +04:00
extent_size = find_config_tree_int64 ( cmd ,
allocation_physical_extent_size_CFG , NULL ) * 2 ;
if ( extent_size < 0 ) {
log_error ( _pe_size_may_not_be_negative_msg ) ;
return 0 ;
}
vp_def - > extent_size = ( uint32_t ) extent_size ;
2009-11-01 23:02:32 +03:00
vp_def - > max_pv = DEFAULT_MAX_PV ;
vp_def - > max_lv = DEFAULT_MAX_LV ;
vp_def - > alloc = DEFAULT_ALLOC_POLICY ;
vp_def - > clustered = DEFAULT_CLUSTERED ;
2010-07-01 00:03:52 +04:00
vp_def - > vgmetadatacopies = DEFAULT_VGMETADATACOPIES ;
2015-02-24 02:19:36 +03:00
vp_def - > system_id = cmd - > system_id ;
2009-11-01 23:02:32 +03:00
}
2014-09-12 12:03:12 +04:00
return 1 ;
2009-11-01 23:02:32 +03:00
}
2008-01-15 00:07:58 +03:00
/*
2009-11-01 23:03:24 +03:00
* Set members of struct vgcreate_params from cmdline arguments .
2008-01-15 00:07:58 +03:00
* Do preliminary validation with arg_ * ( ) interface .
* Further , more generic validation is done in validate_vgcreate_params ( ) .
2008-01-16 22:54:39 +03:00
* This function is to remain in tools directory .
2008-01-15 00:07:58 +03:00
*/
2009-11-01 23:03:24 +03:00
int vgcreate_params_set_from_args ( struct cmd_context * cmd ,
struct vgcreate_params * vp_new ,
struct vgcreate_params * vp_def )
2008-01-15 00:07:58 +03:00
{
2015-02-24 02:19:36 +03:00
const char * system_id_arg_str ;
2015-03-05 23:00:44 +03:00
const char * lock_type = NULL ;
int locking_type ;
int use_lvmlockd ;
int use_clvmd ;
lock_type_t lock_type_num ;
2014-10-24 21:29:04 +04:00
2009-11-01 23:03:24 +03:00
vp_new - > vg_name = skip_dev_dir ( cmd , vp_def - > vg_name , NULL ) ;
2008-01-16 01:56:30 +03:00
vp_new - > max_lv = arg_uint_value ( cmd , maxlogicalvolumes_ARG ,
vp_def - > max_lv ) ;
vp_new - > max_pv = arg_uint_value ( cmd , maxphysicalvolumes_ARG ,
vp_def - > max_pv ) ;
2012-03-02 01:14:43 +04:00
vp_new - > alloc = ( alloc_policy_t ) arg_uint_value ( cmd , alloc_ARG , vp_def - > alloc ) ;
2008-01-15 00:07:58 +03:00
/* Units of 512-byte sectors */
2008-01-16 01:56:30 +03:00
vp_new - > extent_size =
arg_uint_value ( cmd , physicalextentsize_ARG , vp_def - > extent_size ) ;
2008-01-15 00:07:58 +03:00
2012-02-28 18:24:57 +04:00
if ( arg_sign_value ( cmd , physicalextentsize_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
2014-09-12 12:03:12 +04:00
log_error ( _pe_size_may_not_be_negative_msg ) ;
2012-10-16 12:07:27 +04:00
return 0 ;
2008-01-15 00:07:58 +03:00
}
2011-03-02 23:00:09 +03:00
if ( arg_uint64_value ( cmd , physicalextentsize_ARG , 0 ) > MAX_EXTENT_SIZE ) {
2016-01-19 18:07:39 +03:00
log_error ( " Physical extent size must be smaller than %s. " ,
2011-03-02 23:00:09 +03:00
display_size ( cmd , ( uint64_t ) MAX_EXTENT_SIZE ) ) ;
2012-10-16 12:07:27 +04:00
return 0 ;
2011-03-02 23:00:09 +03:00
}
2012-02-28 18:24:57 +04:00
if ( arg_sign_value ( cmd , maxlogicalvolumes_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
2014-11-14 18:08:27 +03:00
log_error ( " Max Logical Volumes may not be negative. " ) ;
2012-10-16 12:07:27 +04:00
return 0 ;
2008-01-15 00:07:58 +03:00
}
2012-02-28 18:24:57 +04:00
if ( arg_sign_value ( cmd , maxphysicalvolumes_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
2014-11-14 18:08:27 +03:00
log_error ( " Max Physical Volumes may not be negative. " ) ;
2012-10-16 12:07:27 +04:00
return 0 ;
2008-01-15 00:07:58 +03:00
}
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
if ( arg_is_set ( cmd , vgmetadatacopies_ARG ) )
2010-07-01 00:03:52 +04:00
vp_new - > vgmetadatacopies = arg_int_value ( cmd , vgmetadatacopies_ARG ,
2010-06-29 00:38:23 +04:00
DEFAULT_VGMETADATACOPIES ) ;
2015-02-24 02:19:36 +03:00
else
2013-06-25 14:30:34 +04:00
vp_new - > vgmetadatacopies = find_config_tree_int ( cmd , metadata_vgmetadatacopies_CFG , NULL ) ;
2010-06-29 00:38:23 +04:00
2015-03-05 23:00:44 +03:00
if ( ! ( system_id_arg_str = arg_str_value ( cmd , systemid_ARG , NULL ) ) ) {
2014-10-24 21:29:04 +04:00
vp_new - > system_id = vp_def - > system_id ;
2015-03-05 23:00:44 +03:00
} else {
2015-02-24 02:19:36 +03:00
if ( ! ( vp_new - > system_id = system_id_from_string ( cmd , system_id_arg_str ) ) )
return_0 ;
2014-10-24 21:29:04 +04:00
2015-02-24 02:19:36 +03:00
/* FIXME Take local/extra_system_ids into account */
2014-10-24 21:29:04 +04:00
if ( vp_new - > system_id & & cmd - > system_id & &
2015-02-25 17:12:24 +03:00
strcmp ( vp_new - > system_id , cmd - > system_id ) ) {
if ( * vp_new - > system_id )
2015-02-27 22:32:00 +03:00
log_warn ( " VG with system ID %s might become inaccessible as local system ID is %s " ,
2015-02-25 17:12:24 +03:00
vp_new - > system_id , cmd - > system_id ) ;
else
2015-02-25 17:17:35 +03:00
log_warn ( " WARNING: A VG without a system ID allows unsafe access from other hosts. " ) ;
2015-02-25 17:12:24 +03:00
}
2014-10-24 21:29:04 +04:00
}
2015-03-05 23:00:44 +03:00
if ( ( system_id_arg_str = arg_str_value ( cmd , systemid_ARG , NULL ) ) ) {
vp_new - > system_id = system_id_from_string ( cmd , system_id_arg_str ) ;
} else {
vp_new - > system_id = vp_def - > system_id ;
}
if ( system_id_arg_str ) {
if ( ! vp_new - > system_id | | ! vp_new - > system_id [ 0 ] )
log_warn ( " WARNING: A VG without a system ID allows unsafe access from other hosts. " ) ;
if ( vp_new - > system_id & & cmd - > system_id & &
strcmp ( vp_new - > system_id , cmd - > system_id ) ) {
log_warn ( " VG with system ID %s might become inaccessible as local system ID is %s " ,
vp_new - > system_id , cmd - > system_id ) ;
}
}
/*
* Locking : what kind of locking should be used for the
* new VG , and is it compatible with current lvm . conf settings .
*
* The end result is to set vp_new - > lock_type to :
* none | clvm | dlm | sanlock .
*
* If ' vgcreate - - lock - type < arg > ' is set , the answer is given
* directly by < arg > which is one of none | clvm | dlm | sanlock .
*
* ' vgcreate - - clustered y ' is the way to create clvm VGs .
*
* ' vgcreate - - shared ' is the way to create lockd VGs .
* lock_type of sanlock or dlm is selected based on
* which lock manager is running .
*
*
* 1. Using neither clvmd nor lvmlockd .
* - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
* lvm . conf :
* global / use_lvmlockd = 0
* global / locking_type = 1
*
* - no locking is enabled
* - clvmd is not used
* - lvmlockd is not used
* - VGs with CLUSTERED set are ignored ( requires clvmd )
* - VGs with lockd type are ignored ( requires lvmlockd )
* - vgcreate can create new VGs with lock_type none
* - ' vgcreate - - clustered y ' fails
* - ' vgcreate - - shared ' fails
* - ' vgcreate ' ( neither option ) creates a local VG
*
* 2. Using clvmd .
* - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
* lvm . conf :
* global / use_lvmlockd = 0
* global / locking_type = 3
*
* - locking through clvmd is enabled ( traditional clvm config )
* - clvmd is used
* - lvmlockd is not used
* - VGs with CLUSTERED set can be used
* - VGs with lockd type are ignored ( requires lvmlockd )
* - vgcreate can create new VGs with CLUSTERED status flag
* - ' vgcreate - - clustered y ' works
* - ' vgcreate - - shared ' fails
* - ' vgcreate ' ( neither option ) creates a clvm VG
*
* 3. Using lvmlockd .
* - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
* lvm . conf :
* global / use_lvmlockd = 1
* global / locking_type = 1
*
* - locking through lvmlockd is enabled
* - clvmd is not used
* - lvmlockd is used
* - VGs with CLUSTERED set are ignored ( requires clvmd )
* - VGs with lockd type can be used
* - vgcreate can create new VGs with lock_type sanlock or dlm
* - ' vgcreate - - clustered y ' fails
* - ' vgcreate - - shared ' works
* - ' vgcreate ' ( neither option ) creates a local VG
*/
locking_type = find_config_tree_int ( cmd , global_locking_type_CFG , NULL ) ;
use_lvmlockd = find_config_tree_bool ( cmd , global_use_lvmlockd_CFG , NULL ) ;
use_clvmd = ( locking_type = = 3 ) ;
if ( arg_is_set ( cmd , locktype_ARG ) ) {
2015-10-08 18:14:33 +03:00
if ( arg_is_set ( cmd , clustered_ARG ) ) {
log_error ( " A lock type cannot be specified with --clustered. " ) ;
2015-03-05 23:00:44 +03:00
return 0 ;
}
2015-10-08 18:14:33 +03:00
2015-03-05 23:00:44 +03:00
lock_type = arg_str_value ( cmd , locktype_ARG , " " ) ;
2015-10-08 18:14:33 +03:00
if ( arg_is_set ( cmd , shared_ARG ) & & ! is_lockd_type ( lock_type ) ) {
log_error ( " The --shared option requires lock type sanlock or dlm. " ) ;
return 0 ;
}
2015-03-05 23:00:44 +03:00
} else if ( arg_is_set ( cmd , clustered_ARG ) ) {
const char * arg_str = arg_str_value ( cmd , clustered_ARG , " " ) ;
int clustery = strcmp ( arg_str , " y " ) ? 0 : 1 ;
if ( use_clvmd ) {
lock_type = clustery ? " clvm " : " none " ;
} else if ( use_lvmlockd ) {
log_error ( " lvmlockd is configured, use --shared with lvmlockd, and --clustered with clvmd. " ) ;
return 0 ;
} else {
if ( clustery ) {
log_error ( " The --clustered option requires clvmd (locking_type=3). " ) ;
return 0 ;
}
2017-07-19 17:16:12 +03:00
lock_type = " none " ;
2015-03-05 23:00:44 +03:00
}
} else if ( arg_is_set ( cmd , shared_ARG ) ) {
2015-10-08 18:38:35 +03:00
int found_multiple = 0 ;
2015-03-05 23:00:44 +03:00
if ( use_lvmlockd ) {
2015-10-08 18:38:35 +03:00
if ( ! ( lock_type = lockd_running_lock_type ( cmd , & found_multiple ) ) ) {
if ( found_multiple )
log_error ( " Found multiple lock managers, select one with --lock-type. " ) ;
else
log_error ( " Failed to detect a running lock manager to select lock type. " ) ;
2015-03-05 23:00:44 +03:00
return 0 ;
}
} else if ( use_clvmd ) {
log_error ( " Use --shared with lvmlockd, and --clustered with clvmd. " ) ;
return 0 ;
} else {
2015-07-16 23:12:07 +03:00
log_error ( " Using a shared lock type requires lvmlockd. " ) ;
2015-03-05 23:00:44 +03:00
return 0 ;
}
} else {
if ( use_clvmd )
lock_type = locking_is_clustered ( ) ? " clvm " : " none " ;
else
lock_type = " none " ;
}
/*
* Check that the lock_type is recognized , and is being
* used with the correct lvm . conf settings .
*/
lock_type_num = get_lock_type_from_string ( lock_type ) ;
switch ( lock_type_num ) {
case LOCK_TYPE_INVALID :
log_error ( " lock_type %s is invalid " , lock_type ) ;
return 0 ;
case LOCK_TYPE_SANLOCK :
case LOCK_TYPE_DLM :
if ( ! use_lvmlockd ) {
2015-07-16 23:12:07 +03:00
log_error ( " Using a shared lock type requires lvmlockd. " ) ;
2015-03-05 23:00:44 +03:00
return 0 ;
}
break ;
case LOCK_TYPE_CLVM :
if ( ! use_clvmd ) {
2015-07-16 23:12:07 +03:00
log_error ( " Using clvm requires locking_type 3. " ) ;
2015-03-05 23:00:44 +03:00
return 0 ;
}
break ;
case LOCK_TYPE_NONE :
break ;
} ;
/*
* The vg is not owned by one host / system_id .
* Locking coordinates access from multiple hosts .
*/
if ( lock_type_num = = LOCK_TYPE_DLM | | lock_type_num = = LOCK_TYPE_SANLOCK | | lock_type_num = = LOCK_TYPE_CLVM )
vp_new - > system_id = NULL ;
vp_new - > lock_type = lock_type ;
if ( lock_type_num = = LOCK_TYPE_CLVM )
vp_new - > clustered = 1 ;
else
vp_new - > clustered = 0 ;
log_debug ( " Setting lock_type to %s " , vp_new - > lock_type ) ;
2012-10-16 12:07:27 +04:00
return 1 ;
2008-01-15 00:07:58 +03:00
}
2008-12-19 17:22:48 +03:00
2013-04-11 15:51:08 +04:00
/* Shared code for changing activation state for vgchange/lvchange */
int lv_change_activate ( struct cmd_context * cmd , struct logical_volume * lv ,
activation_change_t activate )
{
2013-11-30 00:25:58 +04:00
int r = 1 ;
2016-04-14 22:48:28 +03:00
struct logical_volume * snapshot_lv ;
2013-11-30 00:25:58 +04:00
2014-11-02 19:48:21 +03:00
if ( lv_is_cache_pool ( lv ) ) {
if ( is_change_activating ( activate ) ) {
log_verbose ( " Skipping activation of cache pool %s. " ,
display_lvname ( lv ) ) ;
return 1 ;
}
if ( ! dm_list_empty ( & lv - > segs_using_this_lv ) ) {
log_verbose ( " Skipping deactivation of used cache pool %s. " ,
display_lvname ( lv ) ) ;
return 1 ;
}
/*
* Allow to pass only deactivation of unused cache pool .
* Useful only for recovery of failed zeroing of metadata LV .
*/
}
2013-11-30 00:25:58 +04:00
if ( lv_is_merging_origin ( lv ) ) {
/*
* For merging origin , its snapshot must be inactive .
* If it ' s still active and cannot be deactivated
* activation or deactivation of origin fails !
*
* When origin is deactivated and merging snapshot is thin
* it allows to deactivate origin , but still report error ,
* since the thin snapshot remains active .
*
* User could retry to deactivate it with another
* deactivation of origin , which is the only visible LV
*/
2016-04-14 22:48:28 +03:00
snapshot_lv = find_snapshot ( lv ) - > lv ;
if ( lv_is_thin_type ( snapshot_lv ) & & ! deactivate_lv ( cmd , snapshot_lv ) ) {
2014-02-18 23:52:17 +04:00
if ( is_change_activating ( activate ) ) {
2016-04-18 12:04:06 +03:00
log_error ( " Refusing to activate merging volume %s while "
" snapshot volume %s is still active. " ,
display_lvname ( lv ) , display_lvname ( snapshot_lv ) ) ;
2013-11-30 00:25:58 +04:00
return 0 ;
}
2016-04-18 12:04:06 +03:00
log_error ( " Cannot fully deactivate merging origin volume %s while "
" snapshot volume %s is still active. " ,
display_lvname ( lv ) , display_lvname ( snapshot_lv ) ) ;
2013-11-30 00:25:58 +04:00
r = 0 ; /* and continue to deactivate origin... */
}
}
lvmcache: improve duplicate PV handling
Wait to compare and choose alternate duplicate devices until
after all devices are scanned. During scanning, the first
duplicate dev is kept in lvmcache, and others are kept in a
new list (_found_duplicate_devs).
After all devices are scanned, compare all the duplicates
available for a given PVID and decide which is best.
If the dev used in lvmcache is changed, drop the old dev
from lvmcache entirely and rescan the replacement dev.
Previously the VG metadata from the old dev was kept in
lvmcache and only the dev was replaced.
A new config setting devices/allow_changes_with_duplicate_pvs
can be set to 0 which disallows modifying a VG or activating
LVs in it when the VG contains PVs with duplicate devices.
Set to 1 is the old behavior which allowed the VG to be
changed.
The logic for which of two devs is preferred has changed.
The primary goal is to choose a device that is currently
in use if the other isn't, e.g. by an active LV.
. prefer dev with fs mounted if the other doesn't, else
. prefer dev that is dm if the other isn't, else
. prefer dev in subsystem if the other isn't
If neither device is preferred by these rules, then don't
change devices in lvmcache, leaving the one that was found
first.
The previous logic for preferring a device was:
. prefer dev in subsystem if the other isn't, else
. prefer dev without holders if the other has holders, else
. prefer dev that is dm if the other isn't
2016-02-09 22:06:27 +03:00
if ( is_change_activating ( activate ) & &
lvmcache_found_duplicate_pvs ( ) & &
vg_has_duplicate_pvs ( lv - > vg ) & &
! find_config_tree_bool ( cmd , devices_allow_changes_with_duplicate_pvs_CFG , NULL ) ) {
log_error ( " Cannot activate LVs in VG %s while PVs appear on duplicate devices. " ,
lv - > vg - > name ) ;
return 0 ;
}
2014-11-05 17:14:58 +03:00
if ( ! lv_active_change ( cmd , lv , activate , 0 ) )
2013-04-29 16:04:38 +04:00
return_0 ;
2013-04-11 15:51:08 +04:00
2016-02-22 18:42:03 +03:00
set_lv_notify ( lv - > vg - > cmd ) ;
2013-11-30 00:25:58 +04:00
return r ;
2013-04-11 15:51:08 +04:00
}
2008-12-19 17:22:48 +03:00
int lv_refresh ( struct cmd_context * cmd , struct logical_volume * lv )
{
2016-04-18 23:44:30 +03:00
struct logical_volume * snapshot_lv ;
if ( lv_is_merging_origin ( lv ) ) {
snapshot_lv = find_snapshot ( lv ) - > lv ;
if ( lv_is_thin_type ( snapshot_lv ) & & ! deactivate_lv ( cmd , snapshot_lv ) )
log_print_unless_silent ( " Delaying merge for origin volume %s since "
" snapshot volume %s is still active. " ,
display_lvname ( lv ) , display_lvname ( snapshot_lv ) ) ;
}
2016-05-20 11:55:05 +03:00
if ( ! lv_refresh_suspend_resume ( lv ) )
2015-06-16 21:38:40 +03:00
return_0 ;
2010-01-06 00:07:31 +03:00
2010-01-13 04:50:34 +03:00
/*
* check if snapshot merge should be polled
* - unfortunately : even though the dev_manager will clear
* the lv ' s merge attributes if a merge is not possible ;
* it is clearing a different instance of the lv ( as
* retrieved with lv_from_lvid )
* - fortunately : polldaemon will immediately shutdown if the
* origin doesn ' t have a status with a snapshot percentage
*/
2014-06-16 14:43:22 +04:00
if ( background_polling ( ) & & lv_is_merging_origin ( lv ) & & lv_is_active_locally ( lv ) )
2010-01-13 04:50:34 +03:00
lv_spawn_background_polling ( cmd , lv ) ;
2013-11-29 14:10:41 +04:00
return 1 ;
2008-12-19 17:22:48 +03:00
}
2008-12-22 12:00:51 +03:00
int vg_refresh_visible ( struct cmd_context * cmd , struct volume_group * vg )
{
struct lv_list * lvl ;
int r = 1 ;
2009-10-06 20:00:38 +04:00
2011-09-07 12:41:47 +04:00
sigint_allow ( ) ;
dm_list_iterate_items ( lvl , & vg - > lvs ) {
2013-07-01 18:30:12 +04:00
if ( sigint_caught ( ) ) {
r = 0 ;
stack ;
break ;
}
2011-09-07 12:41:47 +04:00
2013-07-01 18:30:12 +04:00
if ( lv_is_visible ( lvl - > lv ) & & ! lv_refresh ( cmd , lvl - > lv ) ) {
r = 0 ;
stack ;
}
2011-09-07 12:41:47 +04:00
}
sigint_restore ( ) ;
2009-10-06 20:00:38 +04:00
2008-12-22 12:00:51 +03:00
return r ;
}
2009-09-30 00:22:35 +04:00
void lv_spawn_background_polling ( struct cmd_context * cmd ,
struct logical_volume * lv )
{
const char * pvname ;
2015-04-29 17:25:50 +03:00
const struct logical_volume * lv_mirr = NULL ;
2009-09-30 00:22:35 +04:00
2015-04-29 17:25:50 +03:00
if ( lv_is_pvmove ( lv ) )
lv_mirr = lv ;
else if ( lv_is_locked ( lv ) )
lv_mirr = find_pvmove_lv_in_lv ( lv ) ;
if ( lv_mirr & &
( pvname = get_pvmove_pvname_from_lv_mirr ( lv_mirr ) ) ) {
2014-11-14 18:08:27 +03:00
log_verbose ( " Spawning background pvmove process for %s. " ,
2009-09-30 00:22:35 +04:00
pvname ) ;
2015-04-10 15:08:19 +03:00
pvmove_poll ( cmd , pvname , lv_mirr - > lvid . s , lv_mirr - > vg - > name , lv_mirr - > name , 1 ) ;
2009-09-30 00:22:35 +04:00
}
2014-09-16 00:33:53 +04:00
if ( lv_is_converting ( lv ) | | lv_is_merging ( lv ) ) {
2014-11-14 18:08:27 +03:00
log_verbose ( " Spawning background lvconvert process for %s. " ,
2015-04-29 17:25:50 +03:00
lv - > name ) ;
2009-09-30 00:22:35 +04:00
lvconvert_poll ( cmd , lv , 1 ) ;
}
}
2009-10-06 00:03:54 +04:00
2010-03-24 01:30:18 +03:00
int get_activation_monitoring_mode ( struct cmd_context * cmd ,
int * monitoring_mode )
{
* monitoring_mode = DEFAULT_DMEVENTD_MONITOR ;
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , monitor_ARG ) & &
( arg_is_set ( cmd , ignoremonitoring_ARG ) | |
arg_is_set ( cmd , sysinit_ARG ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " --ignoremonitoring or --sysinit option not allowed with --monitor option. " ) ;
2010-03-24 01:30:18 +03:00
return 0 ;
}
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , monitor_ARG ) )
2010-03-24 01:30:18 +03:00
* monitoring_mode = arg_int_value ( cmd , monitor_ARG ,
DEFAULT_DMEVENTD_MONITOR ) ;
2016-06-22 00:24:52 +03:00
else if ( is_static ( ) | | arg_is_set ( cmd , ignoremonitoring_ARG ) | |
arg_is_set ( cmd , sysinit_ARG ) | |
2013-06-25 14:31:53 +04:00
! find_config_tree_bool ( cmd , activation_monitoring_CFG , NULL ) )
2010-03-24 01:30:18 +03:00
* monitoring_mode = DMEVENTD_MONITOR_IGNORE ;
2010-03-29 20:09:40 +04:00
2010-03-24 01:30:18 +03:00
return 1 ;
}
2010-04-13 05:54:32 +04:00
2014-07-23 00:20:18 +04:00
/*
* Read pool options from cmdline
*/
2013-06-27 13:22:02 +04:00
int get_pool_params ( struct cmd_context * cmd ,
2014-07-23 00:20:18 +04:00
const struct segment_type * segtype ,
uint64_t * pool_metadata_size ,
int * pool_metadata_spare ,
2012-11-15 17:48:32 +04:00
uint32_t * chunk_size ,
thin_discards_t * discards ,
2017-03-03 22:46:13 +03:00
thin_zero_t * zero_new_blocks )
2012-11-15 17:48:32 +04:00
{
2014-07-23 00:20:18 +04:00
if ( segtype_is_thin_pool ( segtype ) | | segtype_is_thin ( segtype ) ) {
2014-10-31 13:41:03 +03:00
if ( arg_is_set ( cmd , zero_ARG ) ) {
2017-03-03 22:46:13 +03:00
* zero_new_blocks = arg_int_value ( cmd , zero_ARG , 0 ) ? THIN_ZERO_YES : THIN_ZERO_NO ;
log_very_verbose ( " %s pool zeroing. " ,
( * zero_new_blocks = = THIN_ZERO_YES ) ? " Enabling " : " Disabling " ) ;
} else
* zero_new_blocks = THIN_ZERO_UNSELECTED ;
2014-10-31 13:41:03 +03:00
if ( arg_is_set ( cmd , discards_ARG ) ) {
2014-07-23 00:20:18 +04:00
* discards = ( thin_discards_t ) arg_uint_value ( cmd , discards_ARG , 0 ) ;
2014-11-14 18:08:27 +03:00
log_very_verbose ( " Setting pool discards to %s. " ,
2014-07-23 00:20:18 +04:00
get_pool_discards_name ( * discards ) ) ;
2017-03-03 22:46:13 +03:00
} else
* discards = THIN_DISCARDS_UNSELECTED ;
2012-11-15 17:48:32 +04:00
}
2012-11-26 14:20:13 +04:00
2014-10-31 13:41:49 +03:00
if ( arg_from_list_is_negative ( cmd , " may not be negative " ,
chunksize_ARG ,
pooldatasize_ARG ,
poolmetadatasize_ARG ,
- 1 ) )
return_0 ;
if ( arg_from_list_is_zero ( cmd , " may not be zero " ,
chunksize_ARG ,
pooldatasize_ARG ,
poolmetadatasize_ARG ,
- 1 ) )
return_0 ;
2014-07-23 00:20:18 +04:00
2014-10-31 13:41:49 +03:00
if ( arg_is_set ( cmd , chunksize_ARG ) ) {
2014-07-23 00:20:18 +04:00
* chunk_size = arg_uint_value ( cmd , chunksize_ARG , 0 ) ;
2014-10-05 00:36:41 +04:00
if ( ! validate_pool_chunk_size ( cmd , segtype , * chunk_size ) )
return_0 ;
2014-11-14 18:08:27 +03:00
log_very_verbose ( " Setting pool chunk size to %s. " ,
2012-11-26 14:20:13 +04:00
display_size ( cmd , * chunk_size ) ) ;
2017-03-09 18:24:28 +03:00
} else
* chunk_size = 0 ;
2013-08-06 13:42:40 +04:00
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , poolmetadatasize_ARG ) ) {
if ( arg_is_set ( cmd , poolmetadata_ARG ) ) {
2014-07-23 00:20:18 +04:00
log_error ( " Please specify either metadata logical volume or its size. " ) ;
return 0 ;
}
2014-07-11 14:15:23 +04:00
* pool_metadata_size = arg_uint64_value ( cmd , poolmetadatasize_ARG ,
UINT64_C ( 0 ) ) ;
2017-03-09 18:24:28 +03:00
} else
* pool_metadata_size = 0 ;
2012-11-15 17:48:32 +04:00
2017-03-09 18:24:28 +03:00
/* TODO: default in lvm.conf and metadata profile ? */
2014-07-23 00:20:18 +04:00
* pool_metadata_spare = arg_int_value ( cmd , poolmetadataspare_ARG ,
DEFAULT_POOL_METADATA_SPARE ) ;
2012-11-15 17:48:32 +04:00
return 1 ;
}
2010-04-13 05:54:32 +04:00
/*
* Generic stripe parameter checks .
*/
2016-07-30 04:05:50 +03:00
static int _validate_stripe_params ( struct cmd_context * cmd , const struct segment_type * segtype ,
uint32_t * stripes , uint32_t * stripe_size )
2010-04-13 05:54:32 +04:00
{
2016-07-30 04:05:50 +03:00
int stripe_size_required = segtype_supports_stripe_size ( segtype ) ;
if ( ! stripe_size_required & & * stripe_size ) {
log_print_unless_silent ( " Ignoring stripesize argument for %s devices. " , segtype - > name ) ;
* stripe_size = 0 ;
2016-08-20 01:57:30 +03:00
} else if ( * stripes = = 1 & & ( segtype_is_striped_target ( segtype ) | | segtype_is_mirror ( segtype ) ) ) {
2016-07-30 04:05:50 +03:00
stripe_size_required = 0 ;
2016-08-15 21:38:45 +03:00
if ( * stripe_size ) {
log_print_unless_silent ( " Ignoring stripesize argument with single stripe. " ) ;
* stripe_size = 0 ;
}
2010-04-13 05:54:32 +04:00
}
2016-07-30 04:05:50 +03:00
if ( stripe_size_required ) {
if ( ! * stripe_size ) {
* stripe_size = find_config_tree_int ( cmd , metadata_stripesize_CFG , NULL ) * 2 ;
log_print_unless_silent ( " Using default stripesize %s. " ,
display_size ( cmd , ( uint64_t ) * stripe_size ) ) ;
}
if ( * stripe_size < STRIPE_SIZE_MIN | | ! is_power_of_2 ( * stripe_size ) ) {
log_error ( " Invalid stripe size %s. " ,
display_size ( cmd , ( uint64_t ) * stripe_size ) ) ;
return 0 ;
}
2010-04-13 05:54:32 +04:00
}
if ( * stripes < 1 | | * stripes > MAX_STRIPES ) {
2014-11-14 18:08:27 +03:00
log_error ( " Number of stripes (%d) must be between %d and %d. " ,
2010-04-13 05:54:32 +04:00
* stripes , 1 , MAX_STRIPES ) ;
return 0 ;
}
return 1 ;
}
/*
* The stripe size is limited by the size of a uint32_t , but since the
* value given by the user is doubled , and the final result must be a
* power of 2 , we must divide UINT_MAX by four and add 1 ( to round it
* up to the power of 2 )
*/
2016-08-19 15:51:43 +03:00
int get_stripe_params ( struct cmd_context * cmd , const struct segment_type * segtype ,
uint32_t * stripes , uint32_t * stripe_size ,
unsigned * stripes_supplied , unsigned * stripe_size_supplied )
2010-04-13 05:54:32 +04:00
{
/* stripes_long_ARG takes precedence (for lvconvert) */
2016-07-30 04:05:50 +03:00
/* FIXME Cope with relative +/- changes for lvconvert. */
2016-06-22 00:24:52 +03:00
* stripes = arg_uint_value ( cmd , arg_is_set ( cmd , stripes_long_ARG ) ? stripes_long_ARG : stripes_ARG , 1 ) ;
2016-08-19 15:51:43 +03:00
* stripes_supplied = arg_is_set ( cmd , stripes_long_ARG ) ? : arg_is_set ( cmd , stripes_ARG ) ;
2010-04-13 05:54:32 +04:00
* stripe_size = arg_uint_value ( cmd , stripesize_ARG , 0 ) ;
2016-08-19 15:51:43 +03:00
* stripe_size_supplied = arg_is_set ( cmd , stripesize_ARG ) ;
2010-04-13 05:54:32 +04:00
if ( * stripe_size ) {
2012-02-28 18:24:57 +04:00
if ( arg_sign_value ( cmd , stripesize_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
2014-11-14 18:08:27 +03:00
log_error ( " Negative stripesize is invalid. " ) ;
2010-04-13 05:54:32 +04:00
return 0 ;
}
2014-07-11 14:25:18 +04:00
if ( arg_uint64_value ( cmd , stripesize_ARG , 0 ) > STRIPE_SIZE_LIMIT * 2 ) {
2014-11-14 18:08:27 +03:00
log_error ( " Stripe size cannot be larger than %s. " ,
2010-04-13 05:54:32 +04:00
display_size ( cmd , ( uint64_t ) STRIPE_SIZE_LIMIT ) ) ;
return 0 ;
}
}
2016-07-30 04:05:50 +03:00
return _validate_stripe_params ( cmd , segtype , stripes , stripe_size ) ;
2010-04-13 05:54:32 +04:00
}
2017-05-05 17:59:12 +03:00
static int _validate_cachepool_params ( const char * policy_name , cache_mode_t cache_mode )
2014-11-19 20:39:29 +03:00
{
2017-05-05 17:59:12 +03:00
/*
* FIXME : it might be nice if cmd def rules could check option values ,
* then a rule could do this .
*/
if ( ( cache_mode = = CACHE_MODE_WRITEBACK ) & & policy_name & & ! strcmp ( policy_name , " cleaner " ) ) {
log_error ( " Cache mode \" writeback \" is not compatible with cache policy \" cleaner \" . " ) ;
return 0 ;
}
2014-11-19 20:39:29 +03:00
return 1 ;
}
2015-07-23 16:35:12 +03:00
int get_cache_params ( struct cmd_context * cmd ,
2017-03-09 18:20:44 +03:00
uint32_t * chunk_size ,
2017-02-26 22:18:37 +03:00
cache_metadata_format_t * cache_metadata_format ,
2016-04-25 14:39:30 +03:00
cache_mode_t * cache_mode ,
2015-07-23 16:35:12 +03:00
const char * * name ,
struct dm_config_tree * * settings )
2014-11-19 20:39:29 +03:00
{
const char * str ;
struct arg_value_group_list * group ;
struct dm_config_tree * result = NULL , * prev = NULL , * current = NULL ;
2014-11-20 19:49:32 +03:00
struct dm_config_node * cn ;
2014-11-20 13:30:19 +03:00
int ok = 0 ;
2014-11-19 20:39:29 +03:00
2017-02-27 16:53:45 +03:00
if ( arg_is_set ( cmd , chunksize_ARG ) ) {
* chunk_size = arg_uint_value ( cmd , chunksize_ARG , 0 ) ;
2015-07-23 16:35:12 +03:00
2017-02-27 16:53:45 +03:00
if ( ! validate_cache_chunk_size ( cmd , * chunk_size ) )
return_0 ;
2015-07-23 16:35:12 +03:00
2017-02-27 16:53:45 +03:00
log_very_verbose ( " Setting pool chunk size to %s. " ,
display_size ( cmd , * chunk_size ) ) ;
}
2017-02-26 22:18:37 +03:00
* cache_metadata_format = ( cache_metadata_format_t )
arg_uint_value ( cmd , cachemetadataformat_ARG , CACHE_METADATA_FORMAT_UNSELECTED ) ;
2017-02-27 16:53:45 +03:00
* cache_mode = ( cache_mode_t ) arg_uint_value ( cmd , cachemode_ARG , CACHE_MODE_UNSELECTED ) ;
* name = arg_str_value ( cmd , cachepolicy_ARG , NULL ) ;
2015-07-15 12:06:40 +03:00
2017-05-05 17:59:12 +03:00
if ( ! _validate_cachepool_params ( * name , * cache_mode ) )
goto_out ;
2014-11-19 20:39:29 +03:00
dm_list_iterate_items ( group , & cmd - > arg_value_groups ) {
2014-11-20 13:30:19 +03:00
if ( ! grouped_arg_is_set ( group - > arg_values , cachesettings_ARG ) )
2014-11-19 20:39:29 +03:00
continue ;
2015-07-15 12:06:40 +03:00
if ( ! ( current = dm_config_create ( ) ) )
2014-11-20 13:30:19 +03:00
goto_out ;
2014-11-19 20:39:29 +03:00
if ( prev )
current - > cascade = prev ;
prev = current ;
if ( ! ( str = grouped_arg_str_value ( group - > arg_values ,
2014-11-20 13:30:19 +03:00
cachesettings_ARG ,
2014-11-19 20:39:29 +03:00
NULL ) ) )
2014-11-20 13:30:19 +03:00
goto_out ;
2014-11-19 20:39:29 +03:00
2016-09-21 15:27:15 +03:00
if ( ! dm_config_parse_without_dup_node_check ( current , str , str + strlen ( str ) ) )
2014-11-20 13:30:19 +03:00
goto_out ;
2014-11-19 20:39:29 +03:00
}
2017-02-27 16:53:45 +03:00
if ( current ) {
if ( ! ( result = dm_config_flatten ( current ) ) )
goto_out ;
2015-07-23 16:35:12 +03:00
2017-02-27 16:53:45 +03:00
if ( result - > root ) {
if ( ! ( cn = dm_config_create_node ( result , " policy_settings " ) ) )
goto_out ;
2014-11-20 13:30:19 +03:00
2017-02-27 16:53:45 +03:00
cn - > child = result - > root ;
result - > root = cn ;
}
2015-02-24 13:36:30 +03:00
}
2014-11-20 13:30:19 +03:00
ok = 1 ;
out :
2014-11-26 13:46:13 +03:00
if ( ! ok & & result ) {
2014-11-19 20:39:29 +03:00
dm_config_destroy ( result ) ;
result = NULL ;
}
while ( prev ) {
current = prev - > cascade ;
dm_config_destroy ( prev ) ;
prev = current ;
}
2015-07-15 12:06:40 +03:00
* settings = result ;
return ok ;
2014-11-19 20:39:29 +03:00
}
2011-01-24 16:38:31 +03:00
/* FIXME move to lib */
static int _pv_change_tag ( struct physical_volume * pv , const char * tag , int addtag )
{
if ( addtag ) {
if ( ! str_list_add ( pv - > fmt - > cmd - > mem , & pv - > tags , tag ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Failed to add tag %s to physical volume %s. " ,
2011-01-24 16:38:31 +03:00
tag , pv_dev_name ( pv ) ) ;
return 0 ;
}
2012-02-08 16:52:58 +04:00
} else
str_list_del ( & pv - > tags , tag ) ;
2011-01-24 16:38:31 +03:00
return 1 ;
}
/* Set exactly one of VG, LV or PV */
int change_tag ( struct cmd_context * cmd , struct volume_group * vg ,
struct logical_volume * lv , struct physical_volume * pv , int arg )
{
const char * tag ;
struct arg_value_group_list * current_group ;
dm_list_iterate_items ( current_group , & cmd - > arg_value_groups ) {
if ( ! grouped_arg_is_set ( current_group - > arg_values , arg ) )
continue ;
if ( ! ( tag = grouped_arg_str_value ( current_group - > arg_values , arg , NULL ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Failed to get tag. " ) ;
2011-01-24 16:38:31 +03:00
return 0 ;
}
if ( vg & & ! vg_change_tag ( vg , tag , arg = = addtag_ARG ) )
return_0 ;
else if ( lv & & ! lv_change_tag ( lv , tag , arg = = addtag_ARG ) )
return_0 ;
else if ( pv & & ! _pv_change_tag ( pv , tag , arg = = addtag_ARG ) )
return_0 ;
}
return 1 ;
}
2011-09-15 19:26:40 +04:00
2014-11-27 17:02:13 +03:00
int process_each_label ( struct cmd_context * cmd , int argc , char * * argv ,
struct processing_handle * handle ,
2013-07-29 20:51:27 +04:00
process_single_label_fn_t process_single_label )
{
2016-06-20 14:46:35 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
2013-07-29 20:51:27 +04:00
struct label * label ;
struct dev_iter * iter ;
struct device * dev ;
int ret_max = ECMD_PROCESSED ;
2013-11-23 01:27:32 +04:00
int ret ;
2013-07-29 20:51:27 +04:00
int opt = 0 ;
2016-06-20 14:46:35 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_LABEL ) ;
2013-07-29 20:51:27 +04:00
if ( argc ) {
for ( ; opt < argc ; opt + + ) {
2014-10-02 14:00:57 +04:00
if ( ! ( dev = dev_cache_get ( argv [ opt ] , cmd - > full_filter ) ) ) {
2013-07-29 20:51:27 +04:00
log_error ( " Failed to find device "
2014-11-14 18:08:27 +03:00
" \" %s \" . " , argv [ opt ] ) ;
2013-07-29 20:51:27 +04:00
ret_max = ECMD_FAILED ;
continue ;
}
2016-06-20 14:46:35 +03:00
log_set_report_object_name_and_id ( dev_name ( dev ) , NULL ) ;
2013-08-21 03:32:51 +04:00
if ( ! label_read ( dev , & label , 0 ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " No physical volume label read from %s. " ,
2013-08-21 03:32:51 +04:00
argv [ opt ] ) ;
ret_max = ECMD_FAILED ;
2013-07-29 20:51:27 +04:00
continue ;
2013-08-21 03:32:51 +04:00
}
2013-07-29 20:51:27 +04:00
ret = process_single_label ( cmd , label , handle ) ;
2016-06-20 14:46:35 +03:00
report_log_ret_code ( ret ) ;
2013-07-29 20:51:27 +04:00
if ( ret > ret_max )
ret_max = ret ;
2016-06-20 14:46:35 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2013-07-29 20:51:27 +04:00
if ( sigint_caught ( ) )
break ;
}
2016-06-20 14:46:35 +03:00
goto out ;
2013-07-29 20:51:27 +04:00
}
2014-10-02 14:00:57 +04:00
if ( ! ( iter = dev_iter_create ( cmd - > full_filter , 1 ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " dev_iter creation failed. " ) ;
2016-06-20 14:46:35 +03:00
ret_max = ECMD_FAILED ;
goto out ;
2013-07-29 20:51:27 +04:00
}
while ( ( dev = dev_iter_get ( iter ) ) )
{
if ( ! label_read ( dev , & label , 0 ) )
continue ;
2016-06-20 14:46:35 +03:00
log_set_report_object_name_and_id ( dev_name ( label - > dev ) , NULL ) ;
2013-07-29 20:51:27 +04:00
ret = process_single_label ( cmd , label , handle ) ;
2016-06-20 14:46:35 +03:00
report_log_ret_code ( ret ) ;
2013-07-29 20:51:27 +04:00
if ( ret > ret_max )
ret_max = ret ;
2016-06-20 14:46:35 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2013-07-29 20:51:27 +04:00
if ( sigint_caught ( ) )
break ;
}
dev_iter_destroy ( iter ) ;
2016-06-20 14:46:35 +03:00
out :
log_restore_report_state ( saved_log_report_state ) ;
2013-07-29 20:51:27 +04:00
return ret_max ;
}
2014-09-27 20:53:08 +04:00
2014-10-23 16:26:16 +04:00
/*
* Parse persistent major minor parameters .
*
* - - persistent is unspecified = > state is deduced
* from presence of options - - minor or - - major .
*
* - Mn = > - - minor or - - major not allowed .
*
* - My = > - - minor is required ( and also - - major on < = 2.4 )
*/
2014-09-27 20:53:08 +04:00
int get_and_validate_major_minor ( const struct cmd_context * cmd ,
const struct format_type * fmt ,
int32_t * major , int32_t * minor )
{
2014-10-23 16:26:16 +04:00
if ( arg_count ( cmd , minor_ARG ) > 1 ) {
log_error ( " Option --minor may not be repeated. " ) ;
return 0 ;
}
if ( arg_count ( cmd , major_ARG ) > 1 ) {
log_error ( " Option -j|--major may not be repeated. " ) ;
return 0 ;
}
/* Check with default 'y' */
if ( ! arg_int_value ( cmd , persistent_ARG , 1 ) ) { /* -Mn */
2014-09-27 20:53:08 +04:00
if ( arg_is_set ( cmd , minor_ARG ) | | arg_is_set ( cmd , major_ARG ) ) {
2014-10-23 16:26:16 +04:00
log_error ( " Options --major and --minor are incompatible with -Mn. " ) ;
2014-09-27 20:53:08 +04:00
return 0 ;
}
* major = * minor = - 1 ;
return 1 ;
}
2014-10-23 16:26:16 +04:00
/* -1 cannot be entered as an argument for --major, --minor */
* major = arg_int_value ( cmd , major_ARG , - 1 ) ;
* minor = arg_int_value ( cmd , minor_ARG , - 1 ) ;
2014-09-27 20:53:08 +04:00
2014-10-23 16:26:16 +04:00
if ( arg_is_set ( cmd , persistent_ARG ) ) { /* -My */
if ( * minor = = - 1 ) {
log_error ( " Please specify minor number with --minor when using -My. " ) ;
return 0 ;
}
2014-09-27 20:53:08 +04:00
}
if ( ! strncmp ( cmd - > kernel_vsn , " 2.4. " , 4 ) ) {
/* Major is required for 2.4 */
2014-10-23 16:26:16 +04:00
if ( arg_is_set ( cmd , persistent_ARG ) & & * major < 0 ) {
log_error ( " Please specify major number with --major when using -My. " ) ;
2014-09-27 20:53:08 +04:00
return 0 ;
}
} else {
2014-10-23 16:26:16 +04:00
if ( * major ! = - 1 ) {
log_warn ( " WARNING: Ignoring supplied major number %d - "
2014-09-27 20:53:08 +04:00
" kernel assigns major numbers dynamically. "
" Using major number %d instead. " ,
2014-10-23 16:26:16 +04:00
* major , cmd - > dev_types - > device_mapper_major ) ;
2014-09-27 20:53:08 +04:00
}
2014-10-23 16:26:16 +04:00
/* Stay with dynamic major:minor if minor is not specified. */
* major = ( * minor = = - 1 ) ? - 1 : cmd - > dev_types - > device_mapper_major ;
2014-09-27 20:53:08 +04:00
}
2014-10-23 16:26:16 +04:00
if ( ( * minor ! = - 1 ) & & ! validate_major_minor ( cmd , fmt , * major , * minor ) )
2014-09-27 20:53:08 +04:00
return_0 ;
return 1 ;
}
2014-09-28 14:57:39 +04:00
/*
* Validate lvname parameter
*
* If it contains vgname , it is extracted from lvname .
* If there is passed vgname , it is compared whether its the same name .
*/
int validate_lvname_param ( struct cmd_context * cmd , const char * * vg_name ,
const char * * lv_name )
{
const char * vgname ;
const char * lvname ;
if ( ! lv_name | | ! * lv_name )
return 1 ; /* NULL lvname is ok */
/* If contains VG name, extract it. */
if ( strchr ( * lv_name , ( int ) ' / ' ) ) {
if ( ! ( vgname = _extract_vgname ( cmd , * lv_name , & lvname ) ) )
return_0 ;
if ( ! * vg_name )
* vg_name = vgname ;
else if ( strcmp ( vgname , * vg_name ) ) {
log_error ( " Please use a single volume group name "
2014-11-14 18:08:27 +03:00
" ( \" %s \" or \" %s \" ). " , vgname , * vg_name ) ;
2014-09-28 14:57:39 +04:00
return 0 ;
}
* lv_name = lvname ;
}
2014-09-30 23:45:10 +04:00
if ( ! validate_name ( * lv_name ) ) {
log_error ( " Logical volume name \" %s \" is invalid. " ,
* lv_name ) ;
return 0 ;
}
2014-09-28 14:57:39 +04:00
return 1 ;
}
2014-10-03 23:47:19 +04:00
2014-10-08 13:14:33 +04:00
/*
* Validate lvname parameter
* This name must follow restriction rules on prefixes and suffixes .
*
* If it contains vgname , it is extracted from lvname .
* If there is passed vgname , it is compared whether its the same name .
*/
int validate_restricted_lvname_param ( struct cmd_context * cmd , const char * * vg_name ,
const char * * lv_name )
{
if ( ! validate_lvname_param ( cmd , vg_name , lv_name ) )
return_0 ;
if ( lv_name & & * lv_name & & ! apply_lvname_restrictions ( * lv_name ) )
return_0 ;
2016-06-24 01:35:03 +03:00
return 1 ;
2014-10-08 13:14:33 +04:00
}
2014-10-03 23:47:19 +04:00
/*
* Extract list of VG names and list of tags from command line arguments .
*/
static int _get_arg_vgnames ( struct cmd_context * cmd ,
int argc , char * * argv ,
2015-12-01 02:00:26 +03:00
const char * one_vgname ,
2016-04-29 00:18:20 +03:00
struct dm_list * use_vgnames ,
2014-10-03 23:47:19 +04:00
struct dm_list * arg_vgnames ,
struct dm_list * arg_tags )
{
int opt = 0 ;
int ret_max = ECMD_PROCESSED ;
const char * vg_name ;
2015-12-01 02:00:26 +03:00
if ( one_vgname ) {
if ( ! str_list_add ( cmd - > mem , arg_vgnames ,
dm_pool_strdup ( cmd - > mem , one_vgname ) ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
return ret_max ;
}
2016-04-29 00:18:20 +03:00
if ( use_vgnames & & ! dm_list_empty ( use_vgnames ) ) {
dm_list_splice ( arg_vgnames , use_vgnames ) ;
return ret_max ;
}
2014-10-03 23:47:19 +04:00
for ( ; opt < argc ; opt + + ) {
vg_name = argv [ opt ] ;
2015-02-13 17:58:51 +03:00
2014-10-03 23:47:19 +04:00
if ( * vg_name = = ' @ ' ) {
if ( ! validate_tag ( vg_name + 1 ) ) {
log_error ( " Skipping invalid tag: %s " , vg_name ) ;
if ( ret_max < EINVALID_CMD_LINE )
ret_max = EINVALID_CMD_LINE ;
continue ;
}
2015-02-13 17:58:51 +03:00
2014-10-03 23:47:19 +04:00
if ( ! str_list_add ( cmd - > mem , arg_tags ,
dm_pool_strdup ( cmd - > mem , vg_name + 1 ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-03 23:47:19 +04:00
return ECMD_FAILED ;
}
2015-02-13 17:58:51 +03:00
2014-10-03 23:47:19 +04:00
continue ;
}
vg_name = skip_dev_dir ( cmd , vg_name , NULL ) ;
if ( strchr ( vg_name , ' / ' ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Invalid volume group name %s. " , vg_name ) ;
2014-10-03 23:47:19 +04:00
if ( ret_max < EINVALID_CMD_LINE )
ret_max = EINVALID_CMD_LINE ;
continue ;
}
2015-02-13 17:58:51 +03:00
2014-10-03 23:47:19 +04:00
if ( ! str_list_add ( cmd - > mem , arg_vgnames ,
dm_pool_strdup ( cmd - > mem , vg_name ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-03 23:47:19 +04:00
return ECMD_FAILED ;
}
}
return ret_max ;
}
2016-05-31 13:24:05 +03:00
struct processing_handle * init_processing_handle ( struct cmd_context * cmd , struct processing_handle * parent_handle )
2014-11-28 16:46:18 +03:00
{
struct processing_handle * handle ;
if ( ! ( handle = dm_pool_zalloc ( cmd - > mem , sizeof ( struct processing_handle ) ) ) ) {
log_error ( " _init_processing_handle: failed to allocate memory for processing handle " ) ;
return NULL ;
}
2016-05-31 13:24:05 +03:00
handle - > parent = parent_handle ;
2014-11-28 16:46:18 +03:00
/*
* For any reporting tool , the internal_report_for_select is reset to 0
* automatically because the internal reporting / selection is simply not
* needed - the reporting / selection is already a part of the code path
* used there .
*
* * The internal report for select is only needed for non - reporting tools ! *
*/
handle - > internal_report_for_select = arg_is_set ( cmd , select_ARG ) ;
2016-03-01 17:22:48 +03:00
handle - > include_historical_lvs = cmd - > include_historical_lvs ;
2014-11-28 16:46:18 +03:00
2016-08-03 16:37:14 +03:00
if ( ! parent_handle & & ! cmd - > cmd_report . report_group ) {
if ( ! report_format_init ( cmd ) ) {
2016-05-31 13:24:05 +03:00
dm_pool_free ( cmd - > mem , handle ) ;
return NULL ;
}
2016-05-03 12:46:52 +03:00
} else
2016-08-03 16:37:14 +03:00
cmd - > cmd_report . saved_log_report_state = log_get_report_state ( ) ;
2016-05-23 11:16:29 +03:00
2016-05-20 14:26:02 +03:00
log_set_report_context ( LOG_REPORT_CONTEXT_PROCESSING ) ;
2014-11-28 16:46:18 +03:00
return handle ;
}
2015-02-10 15:46:37 +03:00
int init_selection_handle ( struct cmd_context * cmd , struct processing_handle * handle ,
report_type_t initial_report_type )
2014-11-28 16:46:18 +03:00
{
struct selection_handle * sh ;
2016-05-26 16:20:27 +03:00
const char * selection ;
2014-11-28 16:46:18 +03:00
if ( ! ( sh = dm_pool_zalloc ( cmd - > mem , sizeof ( struct selection_handle ) ) ) ) {
log_error ( " _init_selection_handle: failed to allocate memory for selection handle " ) ;
return 0 ;
}
2016-06-27 11:14:17 +03:00
if ( ! report_get_single_selection ( cmd , initial_report_type , & selection ) )
2016-05-26 16:20:27 +03:00
return_0 ;
2015-02-10 15:46:37 +03:00
sh - > report_type = initial_report_type ;
2016-05-26 16:20:27 +03:00
if ( ! ( sh - > selection_rh = report_init_for_selection ( cmd , & sh - > report_type , selection ) ) ) {
2014-11-28 16:46:18 +03:00
dm_pool_free ( cmd - > mem , sh ) ;
return_0 ;
}
handle - > selection_handle = sh ;
return 1 ;
}
2015-02-13 12:42:21 +03:00
void destroy_processing_handle ( struct cmd_context * cmd , struct processing_handle * handle )
2014-11-28 16:46:18 +03:00
{
if ( handle ) {
if ( handle - > selection_handle & & handle - > selection_handle - > selection_rh )
dm_report_free ( handle - > selection_handle - > selection_rh ) ;
2016-05-03 12:46:52 +03:00
2016-08-03 16:37:14 +03:00
log_restore_report_state ( cmd - > cmd_report . saved_log_report_state ) ;
2016-05-03 12:46:52 +03:00
2016-08-04 14:42:57 +03:00
if ( ! cmd - > is_interactive ) {
if ( ! dm_report_group_destroy ( cmd - > cmd_report . report_group ) )
stack ;
cmd - > cmd_report . report_group = NULL ;
if ( cmd - > cmd_report . log_rh ) {
dm_report_free ( cmd - > cmd_report . log_rh ) ;
cmd - > cmd_report . log_rh = NULL ;
}
2016-05-20 16:30:58 +03:00
}
2016-02-12 13:34:26 +03:00
/*
* TODO : think about better alternatives :
* handle mempool , dm_alloc for handle memory . . .
*/
memset ( handle , 0 , sizeof ( * handle ) ) ;
2014-11-28 16:46:18 +03:00
}
}
2014-11-28 16:34:56 +03:00
int select_match_vg ( struct cmd_context * cmd , struct processing_handle * handle ,
2016-05-30 17:28:47 +03:00
struct volume_group * vg )
2014-11-24 13:08:41 +03:00
{
2016-05-31 10:08:59 +03:00
int r ;
2016-05-30 17:28:47 +03:00
if ( ! handle - > internal_report_for_select )
2014-11-28 16:34:56 +03:00
return 1 ;
2016-05-30 17:28:47 +03:00
handle - > selection_handle - > orig_report_type = VGS ;
2016-05-31 10:08:59 +03:00
if ( ! ( r = report_for_selection ( cmd , handle , NULL , vg , NULL ) ) )
2015-02-11 11:36:09 +03:00
log_error ( " Selection failed for VG %s. " , vg - > name ) ;
2016-05-30 17:28:47 +03:00
handle - > selection_handle - > orig_report_type = 0 ;
2014-12-01 16:19:30 +03:00
2016-05-31 10:08:59 +03:00
return r ;
2014-11-24 13:08:41 +03:00
}
2014-11-28 16:34:56 +03:00
int select_match_lv ( struct cmd_context * cmd , struct processing_handle * handle ,
2016-05-30 17:28:47 +03:00
struct volume_group * vg , struct logical_volume * lv )
2014-11-24 13:08:41 +03:00
{
2016-05-31 10:08:59 +03:00
int r ;
2016-05-30 17:28:47 +03:00
if ( ! handle - > internal_report_for_select )
2014-11-28 16:34:56 +03:00
return 1 ;
2016-05-30 17:28:47 +03:00
handle - > selection_handle - > orig_report_type = LVS ;
2016-05-31 10:08:59 +03:00
if ( ! ( r = report_for_selection ( cmd , handle , NULL , vg , lv ) ) )
2015-02-11 11:36:09 +03:00
log_error ( " Selection failed for LV %s. " , lv - > name ) ;
2016-05-30 17:28:47 +03:00
handle - > selection_handle - > orig_report_type = 0 ;
2014-12-01 16:19:30 +03:00
2016-05-31 10:08:59 +03:00
return r ;
2014-11-24 13:08:41 +03:00
}
2014-11-28 16:34:56 +03:00
int select_match_pv ( struct cmd_context * cmd , struct processing_handle * handle ,
2016-05-30 17:28:47 +03:00
struct volume_group * vg , struct physical_volume * pv )
2014-11-24 13:08:41 +03:00
{
2016-05-31 10:08:59 +03:00
int r ;
2016-05-30 17:28:47 +03:00
if ( ! handle - > internal_report_for_select )
2014-11-28 16:34:56 +03:00
return 1 ;
2016-05-30 17:28:47 +03:00
handle - > selection_handle - > orig_report_type = PVS ;
2016-05-31 10:08:59 +03:00
if ( ! ( r = report_for_selection ( cmd , handle , pv , vg , NULL ) ) )
2015-02-11 11:36:09 +03:00
log_error ( " Selection failed for PV %s. " , dev_name ( pv - > dev ) ) ;
2016-05-30 17:28:47 +03:00
handle - > selection_handle - > orig_report_type = 0 ;
2014-12-01 16:19:30 +03:00
2016-05-31 10:08:59 +03:00
return r ;
2014-11-24 13:08:41 +03:00
}
2016-05-30 17:28:47 +03:00
static int _select_matches ( struct processing_handle * handle )
{
if ( ! handle - > internal_report_for_select )
return 1 ;
return handle - > selection_handle - > selected ;
}
2015-10-27 18:52:01 +03:00
static int _process_vgnameid_list ( struct cmd_context * cmd , uint32_t read_flags ,
2014-10-03 23:47:19 +04:00
struct dm_list * vgnameids_to_process ,
struct dm_list * arg_vgnames ,
2014-11-27 17:02:13 +03:00
struct dm_list * arg_tags ,
struct processing_handle * handle ,
2014-10-03 23:47:19 +04:00
process_single_vg_fn_t process_single_vg )
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
char uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
2014-10-03 23:47:19 +04:00
struct volume_group * vg ;
struct vgnameid_list * vgnl ;
const char * vg_name ;
const char * vg_uuid ;
2015-07-08 15:53:23 +03:00
uint32_t lockd_state = 0 ;
2014-12-03 16:20:00 +03:00
int whole_selected = 0 ;
2014-10-03 23:47:19 +04:00
int ret_max = ECMD_PROCESSED ;
2014-11-15 00:00:35 +03:00
int ret ;
int skip ;
2015-10-23 23:09:20 +03:00
int notfound ;
2014-10-03 23:47:19 +04:00
int process_all = 0 ;
2016-02-16 23:15:24 +03:00
int already_locked ;
2016-05-23 16:27:09 +03:00
int do_report_ret_code = 1 ;
2014-10-03 23:47:19 +04:00
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_VG ) ;
2014-10-03 23:47:19 +04:00
/*
* If no VG names or tags were supplied , then process all VGs .
*/
if ( dm_list_empty ( arg_vgnames ) & & dm_list_empty ( arg_tags ) )
process_all = 1 ;
2015-02-13 17:58:51 +03:00
/*
2015-12-01 02:00:26 +03:00
* FIXME If one_vgname , only proceed if exactly one VG matches tags or selection .
2015-02-13 17:58:51 +03:00
*/
2014-10-03 23:47:19 +04:00
dm_list_iterate_items ( vgnl , vgnameids_to_process ) {
vg_name = vgnl - > vg_name ;
vg_uuid = vgnl - > vgid ;
2014-11-15 00:00:35 +03:00
skip = 0 ;
2015-10-23 23:09:20 +03:00
notfound = 0 ;
2014-10-03 23:47:19 +04:00
2016-05-20 14:26:02 +03:00
uuid [ 0 ] = ' \0 ' ;
2016-06-14 14:21:53 +03:00
if ( is_orphan_vg ( vg_name ) ) {
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_ORPHAN ) ;
log_set_report_object_name_and_id ( vg_name + sizeof ( VG_ORPHANS ) , uuid ) ;
} else {
if ( vg_uuid & & ! id_write_format ( ( const struct id * ) vg_uuid , uuid , sizeof ( uuid ) ) )
stack ;
log_set_report_object_name_and_id ( vg_name , uuid ) ;
}
2016-05-20 14:26:02 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
log_very_verbose ( " Processing VG %s %s " , vg_name , uuid ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
2015-03-05 23:00:44 +03:00
if ( ! lockd_vg ( cmd , vg_name , NULL , 0 , & lockd_state ) ) {
2014-11-15 00:00:35 +03:00
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2014-11-15 00:00:35 +03:00
continue ;
}
2015-03-05 23:00:44 +03:00
2016-02-16 23:15:24 +03:00
already_locked = lvmcache_vgname_is_locked ( vg_name ) ;
2015-10-27 18:52:01 +03:00
vg = vg_read ( cmd , vg_name , vg_uuid , read_flags , lockd_state ) ;
if ( _ignore_vg ( vg , vg_name , arg_vgnames , read_flags , & skip , & notfound ) ) {
2015-03-05 23:00:44 +03:00
stack ;
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2015-03-05 23:00:44 +03:00
goto endvg ;
2014-11-14 12:50:31 +03:00
}
2015-10-23 23:09:20 +03:00
if ( skip | | notfound )
2015-03-05 23:00:44 +03:00
goto endvg ;
2014-10-03 23:47:19 +04:00
2014-11-15 00:00:35 +03:00
/* Process this VG? */
2014-11-24 13:08:41 +03:00
if ( ( process_all | |
2014-11-15 00:00:35 +03:00
( ! dm_list_empty ( arg_vgnames ) & & str_list_match_item ( arg_vgnames , vg_name ) ) | |
2014-11-24 13:08:41 +03:00
( ! dm_list_empty ( arg_tags ) & & str_list_match_list ( arg_tags , & vg - > tags , NULL ) ) ) & &
2016-05-30 17:28:47 +03:00
select_match_vg ( cmd , handle , vg ) & & _select_matches ( handle ) ) {
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
log_very_verbose ( " Process single VG %s " , vg_name ) ;
2014-11-15 00:00:35 +03:00
ret = process_single_vg ( cmd , vg_name , vg , handle ) ;
2014-12-03 16:20:00 +03:00
_update_selection_result ( handle , & whole_selected ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2014-11-15 00:00:35 +03:00
if ( ret > ret_max )
ret_max = ret ;
}
2016-02-16 23:15:24 +03:00
if ( ! vg_read_error ( vg ) & & ! already_locked )
lvmetad: two phase vg_update
Previously, a command sent lvmetad new VG metadata in vg_commit().
In vg_commit(), devices are suspended, so any memory allocation
done by the command while sending to lvmetad, or by lvmetad while
updating its cache could deadlock if memory reclaim was triggered.
Now lvmetad is updated in unlock_vg(), after devices are resumed.
The new method for updating VG metadata in lvmetad is in two phases:
1. In vg_write(), before devices are suspended, the command sends
lvmetad a short message ("set_vg_info") telling it what the new
VG seqno will be. lvmetad sees that the seqno is newer than
the seqno of its cached VG, so it sets the INVALID flag for the
cached VG. If sending the message to lvmetad fails, the command
fails before the metadata is committed and the change is not made.
If sending the message succeeds, vg_commit() is called.
2. In unlock_vg(), after devices are resumed, the command sends
lvmetad the standard vg_update message with the new metadata.
lvmetad sees that the seqno in the new metadata matches the
seqno it saved from set_vg_info, and knows it has the latest
copy, so it clears the INVALID flag for the cached VG.
If a command fails between 1 and 2 (after committing the VG on disk,
but before sending lvmetad the new metadata), the cached VG retains
the INVALID flag in lvmetad. A subsequent command will read the
cached VG from lvmetad, see the INVALID flag, ignore the cached
copy, read the VG from disk instead, update the lvmetad copy
with the latest copy from disk, (this clears the INVALID flag
in lvmetad), and use the correct VG metadata for the command.
(This INVALID mechanism already existed for use by lvmlockd.)
2016-06-08 22:42:03 +03:00
unlock_vg ( cmd , vg , vg_name ) ;
2015-03-05 23:00:44 +03:00
endvg :
release_vg ( vg ) ;
2015-08-18 18:39:40 +03:00
if ( ! lockd_vg ( cmd , vg_name , " un " , 0 , & lockd_state ) )
2015-08-18 12:46:42 +03:00
stack ;
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2014-10-03 23:47:19 +04:00
}
2014-12-03 16:20:00 +03:00
/* the VG is selected if at least one LV is selected */
_set_final_selection_result ( handle , whole_selected ) ;
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2016-05-20 14:26:02 +03:00
out :
2016-05-23 16:27:09 +03:00
if ( do_report_ret_code )
report_log_ret_code ( ret_max ) ;
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-03 23:47:19 +04:00
return ret_max ;
}
2015-11-30 21:11:01 +03:00
/*
* Check if a command line VG name is ambiguous , i . e . there are multiple VGs on
* the system that have the given name . If * one * VG with the given name is
* local and the rest are foreign , then use the local VG ( removing foreign VGs
* with the same name from the vgnameids_on_system list ) . If multiple VGs with
* the given name are local , we don ' t know which VG is intended , so remove the
* ambiguous name from the list of args .
*/
static int _resolve_duplicate_vgnames ( struct cmd_context * cmd ,
struct dm_list * arg_vgnames ,
struct dm_list * vgnameids_on_system )
{
struct dm_str_list * sl , * sl2 ;
struct vgnameid_list * vgnl , * vgnl2 ;
char uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
int found ;
int ret = ECMD_PROCESSED ;
dm_list_iterate_items_safe ( sl , sl2 , arg_vgnames ) {
found = 0 ;
dm_list_iterate_items ( vgnl , vgnameids_on_system ) {
if ( strcmp ( sl - > str , vgnl - > vg_name ) )
continue ;
found + + ;
}
if ( found < 2 )
continue ;
/*
* More than one VG match the given name .
* If only one is local , use that one .
*/
found = 0 ;
dm_list_iterate_items_safe ( vgnl , vgnl2 , vgnameids_on_system ) {
if ( strcmp ( sl - > str , vgnl - > vg_name ) )
continue ;
/*
* Without lvmetad , a label scan has already populated
* lvmcache vginfo with this information .
* With lvmetad , this function does vg_lookup on this
* name / vgid and checks system_id in the metadata .
*/
if ( lvmcache_vg_is_foreign ( cmd , vgnl - > vg_name , vgnl - > vgid ) ) {
2016-05-31 10:56:10 +03:00
if ( ! id_write_format ( ( const struct id * ) vgnl - > vgid , uuid , sizeof ( uuid ) ) )
stack ;
2015-11-30 21:11:01 +03:00
log_warn ( " WARNING: Ignoring foreign VG with matching name %s UUID %s. " ,
vgnl - > vg_name , uuid ) ;
dm_list_del ( & vgnl - > list ) ;
} else {
found + + ;
}
}
if ( found < 2 )
continue ;
/*
* More than one VG with this name is local so the intended VG
* is unknown .
*/
log_error ( " Multiple VGs found with the same name: skipping %s " , sl - > str ) ;
2016-05-19 23:06:56 +03:00
log_error ( " Use --select vg_uuid=<uuid> in place of the VG name. " ) ;
2015-11-30 21:11:01 +03:00
dm_list_del ( & sl - > list ) ;
ret = ECMD_FAILED ;
}
return ret ;
}
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
/*
* For each arg_vgname , move the corresponding entry from
* vgnameids_on_system to vgnameids_to_process . If an
* item in arg_vgnames doesn ' t exist in vgnameids_on_system ,
* then add a new entry for it to vgnameids_to_process .
*/
static void _choose_vgs_to_process ( struct cmd_context * cmd ,
struct dm_list * arg_vgnames ,
struct dm_list * vgnameids_on_system ,
struct dm_list * vgnameids_to_process )
{
2015-12-01 21:00:57 +03:00
char uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
struct dm_str_list * sl , * sl2 ;
struct vgnameid_list * vgnl , * vgnl2 ;
2015-12-01 21:00:57 +03:00
struct id id ;
2015-12-02 00:50:14 +03:00
int arg_is_uuid = 0 ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
int found ;
dm_list_iterate_items_safe ( sl , sl2 , arg_vgnames ) {
found = 0 ;
dm_list_iterate_items_safe ( vgnl , vgnl2 , vgnameids_on_system ) {
if ( strcmp ( sl - > str , vgnl - > vg_name ) )
continue ;
dm_list_del ( & vgnl - > list ) ;
dm_list_add ( vgnameids_to_process , & vgnl - > list ) ;
found = 1 ;
break ;
}
2015-12-01 21:00:57 +03:00
/*
* If the VG name arg looks like a UUID , then check if it
2015-12-02 00:50:14 +03:00
* matches the UUID of a VG . ( - - select should generally
* be used to select a VG by uuid instead . )
2015-12-01 21:00:57 +03:00
*/
2017-01-14 00:08:51 +03:00
if ( ! found & & ( cmd - > cname - > flags & ALLOW_UUID_AS_NAME ) )
2015-12-03 17:26:44 +03:00
arg_is_uuid = id_read_format_try ( & id , sl - > str ) ;
2015-12-01 21:00:57 +03:00
if ( ! found & & arg_is_uuid ) {
dm_list_iterate_items_safe ( vgnl , vgnl2 , vgnameids_on_system ) {
if ( ! ( id_write_format ( ( const struct id * ) vgnl - > vgid , uuid , sizeof ( uuid ) ) ) )
continue ;
if ( strcmp ( sl - > str , uuid ) )
continue ;
log_print ( " Processing VG %s because of matching UUID %s " ,
vgnl - > vg_name , uuid ) ;
dm_list_del ( & vgnl - > list ) ;
dm_list_add ( vgnameids_to_process , & vgnl - > list ) ;
/* Make the arg_vgnames entry use the actual VG name. */
sl - > str = dm_pool_strdup ( cmd - > mem , vgnl - > vg_name ) ;
found = 1 ;
break ;
}
}
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
/*
* If the name arg was not found in the list of all VGs , then
* it probably doesn ' t exist , but we want the " VG not found "
* failure to be handled by the existing vg_read ( ) code for
* that error . So , create an entry with just the VG name so
* that the processing loop will attempt to process it and use
* the vg_read ( ) error path .
*/
if ( ! found ) {
log_verbose ( " VG name on command line not found in list of VGs: %s " , sl - > str ) ;
if ( ! ( vgnl = dm_pool_alloc ( cmd - > mem , sizeof ( * vgnl ) ) ) )
continue ;
vgnl - > vgid = NULL ;
if ( ! ( vgnl - > vg_name = dm_pool_strdup ( cmd - > mem , sl - > str ) ) )
continue ;
dm_list_add ( vgnameids_to_process , & vgnl - > list ) ;
}
}
}
2014-10-03 23:47:19 +04:00
/*
* Call process_single_vg ( ) for each VG selected by the command line arguments .
2016-04-29 00:18:20 +03:00
* If one_vgname is set , process only that VG and ignore argc / argv ( which should be 0 / NULL ) .
2015-12-01 02:00:26 +03:00
* If one_vgname is not set , get VG names to process from argc / argv .
2014-10-03 23:47:19 +04:00
*/
2016-04-29 00:18:20 +03:00
int process_each_vg ( struct cmd_context * cmd ,
int argc , char * * argv ,
const char * one_vgname ,
struct dm_list * use_vgnames ,
uint32_t read_flags ,
2016-05-03 12:46:28 +03:00
int include_internal ,
2015-12-01 02:00:26 +03:00
struct processing_handle * handle ,
2014-10-03 23:47:19 +04:00
process_single_vg_fn_t process_single_vg )
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
2014-11-28 17:04:25 +03:00
int handle_supplied = handle ! = NULL ;
2014-10-03 23:47:19 +04:00
struct dm_list arg_tags ; /* str_list */
struct dm_list arg_vgnames ; /* str_list */
struct dm_list vgnameids_on_system ; /* vgnameid_list */
struct dm_list vgnameids_to_process ; /* vgnameid_list */
2017-01-14 00:08:51 +03:00
int enable_all_vgs = ( cmd - > cname - > flags & ALL_VGS_IS_DEFAULT ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
int process_all_vgs_on_system = 0 ;
int ret_max = ECMD_PROCESSED ;
2014-10-03 23:47:19 +04:00
int ret ;
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_VG ) ;
2016-02-16 23:15:24 +03:00
log_debug ( " Processing each VG " ) ;
2015-03-05 23:00:44 +03:00
/* Disable error in vg_read so we can print it from ignore_vg. */
cmd - > vg_read_print_access_error = 0 ;
2015-02-27 01:06:32 +03:00
2014-10-03 23:47:19 +04:00
dm_list_init ( & arg_tags ) ;
dm_list_init ( & arg_vgnames ) ;
dm_list_init ( & vgnameids_on_system ) ;
dm_list_init ( & vgnameids_to_process ) ;
/*
* Find any VGs or tags explicitly provided on the command line .
*/
2016-04-29 00:18:20 +03:00
if ( ( ret = _get_arg_vgnames ( cmd , argc , argv , one_vgname , use_vgnames , & arg_vgnames , & arg_tags ) ) ! = ECMD_PROCESSED ) {
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ret ;
2014-11-28 17:04:25 +03:00
goto_out ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
}
2014-10-03 23:47:19 +04:00
/*
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
* Process all VGs on the system when :
* . tags are specified and all VGs need to be read to
* look for matching tags .
* . no VG names are specified and the command defaults
* to processing all VGs when none are specified .
2014-10-03 23:47:19 +04:00
*/
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
if ( ( dm_list_empty ( & arg_vgnames ) & & enable_all_vgs ) | | ! dm_list_empty ( & arg_tags ) )
process_all_vgs_on_system = 1 ;
2015-03-05 23:00:44 +03:00
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
/*
* Needed for a current listing of the global VG namespace .
*/
if ( process_all_vgs_on_system & & ! lockd_gl ( cmd , " sh " , 0 ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2015-12-01 23:09:01 +03:00
/*
* First rescan for available devices , then force the next
* label scan to be done . get_vgnameids ( ) will scan labels
* ( when not using lvmetad ) .
*/
2017-01-14 00:08:51 +03:00
if ( cmd - > cname - > flags & REQUIRES_FULL_LABEL_SCAN ) {
2015-12-01 23:09:01 +03:00
dev_cache_full_scan ( cmd - > full_filter ) ;
lvmcache_force_next_label_scan ( ) ;
}
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
/*
* A list of all VGs on the system is needed when :
* . processing all VGs on the system
* . A VG name is specified which may refer to one
* of multiple VGs on the system with that name .
*/
2016-02-16 23:15:24 +03:00
log_debug ( " Get list of VGs on system " ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
2016-05-03 12:46:28 +03:00
if ( ! get_vgnameids ( cmd , & vgnameids_on_system , NULL , include_internal ) ) {
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ECMD_FAILED ;
goto_out ;
2015-03-05 23:00:44 +03:00
}
2014-10-03 23:47:19 +04:00
2015-11-30 21:11:01 +03:00
if ( ! dm_list_empty ( & arg_vgnames ) ) {
/* This may remove entries from arg_vgnames or vgnameids_on_system. */
ret = _resolve_duplicate_vgnames ( cmd , & arg_vgnames , & vgnameids_on_system ) ;
if ( ret > ret_max )
ret_max = ret ;
if ( dm_list_empty ( & arg_vgnames ) & & dm_list_empty ( & arg_tags ) ) {
ret_max = ECMD_FAILED ;
goto out ;
}
}
2014-10-03 23:47:19 +04:00
if ( dm_list_empty ( & arg_vgnames ) & & dm_list_empty ( & vgnameids_on_system ) ) {
2014-10-04 02:37:49 +04:00
/* FIXME Should be log_print, but suppressed for reporting cmds */
2014-11-14 18:11:43 +03:00
log_verbose ( " No volume groups found. " ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ECMD_PROCESSED ;
2014-11-28 17:04:25 +03:00
goto out ;
2014-10-03 23:47:19 +04:00
}
2015-10-27 18:52:01 +03:00
if ( dm_list_empty ( & arg_vgnames ) )
read_flags | = READ_OK_NOTFOUND ;
2014-10-03 23:47:19 +04:00
/*
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
* When processing all VGs , vgnameids_on_system simply becomes
* vgnameids_to_process .
* When processing only specified VGs , then for each item in
* arg_vgnames , move the corresponding entry from
* vgnameids_on_system to vgnameids_to_process .
2014-10-03 23:47:19 +04:00
*/
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
if ( process_all_vgs_on_system )
2014-10-03 23:47:19 +04:00
dm_list_splice ( & vgnameids_to_process , & vgnameids_on_system ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
else
_choose_vgs_to_process ( cmd , & arg_vgnames , & vgnameids_on_system , & vgnameids_to_process ) ;
2014-11-28 17:04:25 +03:00
2016-05-31 13:24:05 +03:00
if ( ! handle & & ! ( handle = init_processing_handle ( cmd , NULL ) ) ) {
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ECMD_FAILED ;
2014-11-28 17:04:25 +03:00
goto_out ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
}
2014-11-28 17:04:25 +03:00
if ( handle - > internal_report_for_select & & ! handle - > selection_handle & &
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
! init_selection_handle ( cmd , handle , VGS ) ) {
ret_max = ECMD_FAILED ;
2014-11-28 17:04:25 +03:00
goto_out ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
}
2014-10-03 23:47:19 +04:00
2015-10-27 18:52:01 +03:00
ret = _process_vgnameid_list ( cmd , read_flags , & vgnameids_to_process ,
2014-11-28 17:04:25 +03:00
& arg_vgnames , & arg_tags , handle , process_single_vg ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
if ( ret > ret_max )
ret_max = ret ;
2014-11-28 17:04:25 +03:00
out :
if ( ! handle_supplied )
2015-02-13 12:42:21 +03:00
destroy_processing_handle ( cmd , handle ) ;
2015-02-13 17:58:51 +03:00
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
return ret_max ;
2014-10-03 23:47:19 +04:00
}
2014-10-04 02:37:49 +04:00
2016-03-01 17:23:05 +03:00
static struct dm_str_list * _str_list_match_item_with_prefix ( const struct dm_list * sll , const char * prefix , const char * str )
{
struct dm_str_list * sl ;
size_t prefix_len = strlen ( prefix ) ;
dm_list_iterate_items ( sl , sll ) {
if ( ! strncmp ( prefix , sl - > str , prefix_len ) & &
! strcmp ( sl - > str + prefix_len , str ) )
return sl ;
}
return NULL ;
}
/*
* Dummy LV , segment type and segment to represent all historical LVs .
*/
static struct logical_volume _historical_lv = {
. name = " " ,
. major = - 1 ,
. minor = - 1 ,
. snapshot_segs = DM_LIST_HEAD_INIT ( _historical_lv . snapshot_segs ) ,
. segments = DM_LIST_HEAD_INIT ( _historical_lv . segments ) ,
. tags = DM_LIST_HEAD_INIT ( _historical_lv . tags ) ,
. segs_using_this_lv = DM_LIST_HEAD_INIT ( _historical_lv . segs_using_this_lv ) ,
. indirect_glvs = DM_LIST_HEAD_INIT ( _historical_lv . indirect_glvs ) ,
. hostname = " " ,
} ;
static struct segment_type _historical_segment_type = {
. name = " historical " ,
. flags = SEG_VIRTUAL | SEG_CANNOT_BE_ZEROED ,
} ;
static struct lv_segment _historical_lv_segment = {
. lv = & _historical_lv ,
. segtype = & _historical_segment_type ,
. len = 0 ,
. tags = DM_LIST_HEAD_INIT ( _historical_lv_segment . tags ) ,
. origin_list = DM_LIST_HEAD_INIT ( _historical_lv_segment . origin_list ) ,
} ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
int opt_in_list_is_set ( struct cmd_context * cmd , int * opts , int count ,
int * match_count , int * unmatch_count )
{
int match = 0 ;
int unmatch = 0 ;
int i ;
for ( i = 0 ; i < count ; i + + ) {
if ( arg_is_set ( cmd , opts [ i ] ) )
match + + ;
else
unmatch + + ;
}
if ( match_count )
* match_count = match ;
if ( unmatch_count )
* unmatch_count = unmatch ;
return match ? 1 : 0 ;
}
void opt_array_to_str ( struct cmd_context * cmd , int * opts , int count ,
char * buf , int len )
{
int pos = 0 ;
int ret ;
int i ;
for ( i = 0 ; i < count ; i + + ) {
ret = snprintf ( buf + pos , len - pos , " %s " , arg_long_option_name ( opts [ i ] ) ) ;
if ( ret > = len - pos )
break ;
pos + = ret ;
}
buf [ len - 1 ] = ' \0 ' ;
}
2017-10-18 17:57:46 +03:00
static void _lvp_bits_to_str ( uint64_t bits , char * buf , int len )
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
{
2017-03-07 21:08:23 +03:00
struct lv_prop * prop ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
int lvp_enum ;
int pos = 0 ;
int ret ;
for ( lvp_enum = 0 ; lvp_enum < LVP_COUNT ; lvp_enum + + ) {
if ( ! ( prop = get_lv_prop ( lvp_enum ) ) )
continue ;
if ( lvp_bit_is_set ( bits , lvp_enum ) ) {
ret = snprintf ( buf + pos , len - pos , " %s " , prop - > name ) ;
if ( ret > = len - pos )
break ;
pos + = ret ;
}
}
buf [ len - 1 ] = ' \0 ' ;
}
2017-10-18 17:57:46 +03:00
static void _lvt_bits_to_str ( uint64_t bits , char * buf , int len )
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
{
2017-03-07 21:08:23 +03:00
struct lv_type * type ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
int lvt_enum ;
int pos = 0 ;
int ret ;
for ( lvt_enum = 0 ; lvt_enum < LVT_COUNT ; lvt_enum + + ) {
if ( ! ( type = get_lv_type ( lvt_enum ) ) )
continue ;
if ( lvt_bit_is_set ( bits , lvt_enum ) ) {
ret = snprintf ( buf + pos , len - pos , " %s " , type - > name ) ;
if ( ret > = len - pos )
break ;
pos + = ret ;
}
}
buf [ len - 1 ] = ' \0 ' ;
}
/*
* This is the lv_prop function pointer used for lv_is_foo ( ) # defines .
* Alternatively , lv_is_foo ( ) could all be turned into functions .
*/
static int _lv_is_prop ( struct cmd_context * cmd , struct logical_volume * lv , int lvp_enum )
{
switch ( lvp_enum ) {
case is_locked_LVP :
return lv_is_locked ( lv ) ;
case is_partial_LVP :
return lv_is_partial ( lv ) ;
case is_virtual_LVP :
return lv_is_virtual ( lv ) ;
case is_merging_LVP :
return lv_is_merging ( lv ) ;
case is_merging_origin_LVP :
return lv_is_merging_origin ( lv ) ;
case is_converting_LVP :
return lv_is_converting ( lv ) ;
case is_external_origin_LVP :
return lv_is_external_origin ( lv ) ;
case is_virtual_origin_LVP :
return lv_is_virtual_origin ( lv ) ;
case is_not_synced_LVP :
return lv_is_not_synced ( lv ) ;
case is_pending_delete_LVP :
return lv_is_pending_delete ( lv ) ;
case is_error_when_full_LVP :
return lv_is_error_when_full ( lv ) ;
case is_pvmove_LVP :
return lv_is_pvmove ( lv ) ;
case is_removed_LVP :
return lv_is_removed ( lv ) ;
case is_vg_writable_LVP :
return ( lv - > vg - > status & LVM_WRITE ) ? 1 : 0 ;
case is_thinpool_data_LVP :
return lv_is_thin_pool_data ( lv ) ;
case is_thinpool_metadata_LVP :
return lv_is_thin_pool_metadata ( lv ) ;
case is_cachepool_data_LVP :
return lv_is_cache_pool_data ( lv ) ;
case is_cachepool_metadata_LVP :
return lv_is_cache_pool_metadata ( lv ) ;
case is_mirror_image_LVP :
return lv_is_mirror_image ( lv ) ;
case is_mirror_log_LVP :
return lv_is_mirror_log ( lv ) ;
case is_raid_image_LVP :
return lv_is_raid_image ( lv ) ;
case is_raid_metadata_LVP :
return lv_is_raid_metadata ( lv ) ;
case is_origin_LVP : /* use lv_is_thick_origin */
return lv_is_origin ( lv ) ;
case is_thick_origin_LVP :
return lv_is_thick_origin ( lv ) ;
case is_thick_snapshot_LVP :
return lv_is_thick_snapshot ( lv ) ;
case is_thin_origin_LVP :
return lv_is_thin_origin ( lv , NULL ) ;
case is_thin_snapshot_LVP :
return lv_is_thin_snapshot ( lv ) ;
case is_cache_origin_LVP :
return lv_is_cache_origin ( lv ) ;
case is_merging_cow_LVP :
return lv_is_merging_cow ( lv ) ;
case is_cow_covering_origin_LVP :
return lv_is_cow_covering_origin ( lv ) ;
case is_visible_LVP :
return lv_is_visible ( lv ) ;
case is_historical_LVP :
return lv_is_historical ( lv ) ;
case is_raid_with_tracking_LVP :
return lv_is_raid_with_tracking ( lv ) ;
default :
log_error ( INTERNAL_ERROR " unknown lv property value lvp_enum %d " , lvp_enum ) ;
}
return 0 ;
}
/*
* Check if an LV matches a given LV type enum .
*/
static int _lv_is_type ( struct cmd_context * cmd , struct logical_volume * lv , int lvt_enum )
{
struct lv_segment * seg = first_seg ( lv ) ;
switch ( lvt_enum ) {
case striped_LVT :
return seg_is_striped ( seg ) & & ! lv_is_cow ( lv ) ;
case linear_LVT :
return seg_is_linear ( seg ) & & ! lv_is_cow ( lv ) ;
case snapshot_LVT :
return lv_is_cow ( lv ) ;
case thin_LVT :
return lv_is_thin_volume ( lv ) ;
case thinpool_LVT :
return lv_is_thin_pool ( lv ) ;
case cache_LVT :
return lv_is_cache ( lv ) ;
case cachepool_LVT :
return lv_is_cache_pool ( lv ) ;
case mirror_LVT :
return lv_is_mirror ( lv ) ;
case raid_LVT :
return lv_is_raid ( lv ) ;
case raid0_LVT :
2017-02-06 20:51:06 +03:00
return seg_is_any_raid0 ( seg ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
case raid1_LVT :
return seg_is_raid1 ( seg ) ;
case raid4_LVT :
return seg_is_raid4 ( seg ) ;
case raid5_LVT :
2017-02-06 20:51:06 +03:00
return seg_is_any_raid5 ( seg ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
case raid6_LVT :
2017-02-06 20:51:06 +03:00
return seg_is_any_raid6 ( seg ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
case raid10_LVT :
return seg_is_raid10 ( seg ) ;
case error_LVT :
return ! strcmp ( seg - > segtype - > name , SEG_TYPE_NAME_ERROR ) ;
case zero_LVT :
return ! strcmp ( seg - > segtype - > name , SEG_TYPE_NAME_ZERO ) ;
default :
log_error ( INTERNAL_ERROR " unknown lv type value lvt_enum %d " , lvt_enum ) ;
}
return 0 ;
}
2016-12-07 23:30:57 +03:00
int get_lvt_enum ( struct logical_volume * lv )
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
{
struct lv_segment * seg = first_seg ( lv ) ;
/*
* The order these are checked is important , because a snapshot LV has
* a linear seg type .
*/
if ( lv_is_cow ( lv ) )
return snapshot_LVT ;
if ( seg_is_linear ( seg ) )
return linear_LVT ;
if ( seg_is_striped ( seg ) )
return striped_LVT ;
if ( lv_is_thin_volume ( lv ) )
return thin_LVT ;
if ( lv_is_thin_pool ( lv ) )
return thinpool_LVT ;
if ( lv_is_cache ( lv ) )
return cache_LVT ;
if ( lv_is_cache_pool ( lv ) )
return cachepool_LVT ;
if ( lv_is_mirror ( lv ) )
return mirror_LVT ;
if ( lv_is_raid ( lv ) )
return raid_LVT ;
2017-02-06 20:51:06 +03:00
if ( seg_is_any_raid0 ( seg ) )
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
return raid0_LVT ;
if ( seg_is_raid1 ( seg ) )
return raid1_LVT ;
if ( seg_is_raid4 ( seg ) )
return raid4_LVT ;
2017-02-06 20:51:06 +03:00
if ( seg_is_any_raid5 ( seg ) )
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
return raid5_LVT ;
2017-02-06 20:51:06 +03:00
if ( seg_is_any_raid6 ( seg ) )
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
return raid6_LVT ;
if ( seg_is_raid10 ( seg ) )
return raid10_LVT ;
if ( ! strcmp ( seg - > segtype - > name , SEG_TYPE_NAME_ERROR ) )
return error_LVT ;
if ( ! strcmp ( seg - > segtype - > name , SEG_TYPE_NAME_ZERO ) )
return zero_LVT ;
return 0 ;
}
/*
* Call lv_is_ < type > for each < type > _LVT bit set in lvt_bits .
* If lv matches one of the specified lv types , then return 1.
*/
static int _lv_types_match ( struct cmd_context * cmd , struct logical_volume * lv , uint64_t lvt_bits ,
uint64_t * match_bits , uint64_t * unmatch_bits )
{
2017-03-07 21:08:23 +03:00
struct lv_type * type ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
int lvt_enum ;
int found_a_match = 0 ;
int match ;
if ( match_bits )
* match_bits = 0 ;
if ( unmatch_bits )
* unmatch_bits = 0 ;
for ( lvt_enum = 1 ; lvt_enum < LVT_COUNT ; lvt_enum + + ) {
if ( ! lvt_bit_is_set ( lvt_bits , lvt_enum ) )
continue ;
if ( ! ( type = get_lv_type ( lvt_enum ) ) )
continue ;
/*
* All types are currently handled by _lv_is_type ( )
* because lv_is_type ( ) are # defines and not exposed
* in tools . h
*/
if ( ! type - > fn )
match = _lv_is_type ( cmd , lv , lvt_enum ) ;
else
match = type - > fn ( cmd , lv ) ;
if ( match )
found_a_match = 1 ;
if ( match_bits & & match )
* match_bits | = lvt_enum_to_bit ( lvt_enum ) ;
if ( unmatch_bits & & ! match )
* unmatch_bits | = lvt_enum_to_bit ( lvt_enum ) ;
}
return found_a_match ;
}
/*
* Call lv_is_ < prop > for each < prop > _LVP bit set in lvp_bits .
* If lv matches all of the specified lv properties , then return 1.
*/
static int _lv_props_match ( struct cmd_context * cmd , struct logical_volume * lv , uint64_t lvp_bits ,
uint64_t * match_bits , uint64_t * unmatch_bits )
{
2017-03-07 21:08:23 +03:00
struct lv_prop * prop ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
int lvp_enum ;
int found_a_mismatch = 0 ;
int match ;
if ( match_bits )
* match_bits = 0 ;
if ( unmatch_bits )
* unmatch_bits = 0 ;
for ( lvp_enum = 1 ; lvp_enum < LVP_COUNT ; lvp_enum + + ) {
if ( ! lvp_bit_is_set ( lvp_bits , lvp_enum ) )
continue ;
if ( ! ( prop = get_lv_prop ( lvp_enum ) ) )
continue ;
if ( ! prop - > fn )
match = _lv_is_prop ( cmd , lv , lvp_enum ) ;
else
match = prop - > fn ( cmd , lv ) ;
if ( ! match )
found_a_mismatch = 1 ;
if ( match_bits & & match )
* match_bits | = lvp_enum_to_bit ( lvp_enum ) ;
if ( unmatch_bits & & ! match )
* unmatch_bits | = lvp_enum_to_bit ( lvp_enum ) ;
}
return ! found_a_mismatch ;
}
static int _check_lv_types ( struct cmd_context * cmd , struct logical_volume * lv , int pos )
{
2017-06-27 12:38:56 +03:00
int ret ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
if ( ! pos )
return 1 ;
if ( ! cmd - > command - > required_pos_args [ pos - 1 ] . def . lvt_bits )
return 1 ;
if ( ! val_bit_is_set ( cmd - > command - > required_pos_args [ pos - 1 ] . def . val_bits , lv_VAL ) ) {
2017-02-10 20:36:11 +03:00
log_error ( INTERNAL_ERROR " Command %d:%s arg position %d does not permit an LV (%llx) " ,
cmd - > command - > command_index , cmd - > command - > command_id ,
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
pos , ( unsigned long long ) cmd - > command - > required_pos_args [ pos - 1 ] . def . val_bits ) ;
return 0 ;
}
ret = _lv_types_match ( cmd , lv , cmd - > command - > required_pos_args [ pos - 1 ] . def . lvt_bits , NULL , NULL ) ;
if ( ! ret ) {
2016-12-07 23:30:57 +03:00
int lvt_enum = get_lvt_enum ( lv ) ;
2017-03-07 21:08:23 +03:00
struct lv_type * type = get_lv_type ( lvt_enum ) ;
2017-04-25 20:19:11 +03:00
log_warn ( " Command on LV %s does not accept LV type %s. " ,
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
display_lvname ( lv ) , type ? type - > name : " unknown " ) ;
}
return ret ;
}
/* Check if LV passes each rule specified in command definition. */
static int _check_lv_rules ( struct cmd_context * cmd , struct logical_volume * lv )
{
char buf [ 64 ] ;
struct cmd_rule * rule ;
2017-03-07 21:08:23 +03:00
struct lv_type * lvtype = NULL ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
uint64_t lv_props_match_bits , lv_props_unmatch_bits ;
uint64_t lv_types_match_bits , lv_types_unmatch_bits ;
int opts_match_count , opts_unmatch_count ;
int lvt_enum ;
int ret = 1 ;
int i ;
2016-12-07 23:30:57 +03:00
lvt_enum = get_lvt_enum ( lv ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
if ( lvt_enum )
lvtype = get_lv_type ( lvt_enum ) ;
for ( i = 0 ; i < cmd - > command - > rule_count ; i + + ) {
rule = & cmd - > command - > rules [ i ] ;
/*
* RULE : < conditions > INVALID | REQUIRE < checks >
*
* If all the conditions apply to the command + LV , then
* the checks are performed . If all conditions are zero
* ( ! opts_count , ! lvt_bits , ! lvp_bits ) , then the check
* is always performed .
*
* Conditions :
*
* 1. options ( opts ) : if any of the specified options are set ,
* then the checks may apply .
*
* 2. LV types ( lvt_bits ) : if any of the specified LV types
* match the LV , then the checks may apply .
*
* 3. LV properties ( lvp_bits ) : if all of the specified
* LV properties match the LV , then the checks may apply .
*
* If conditions 1 , 2 , 3 all pass , then the checks apply .
*
* Checks :
*
* 1. options ( check_opts ) :
* INVALID : if any of the specified options are set ,
* then the command fails .
* REQUIRE : if any of the specified options are not set ,
* then the command fails .
*
* 2. LV types ( check_lvt_bits ) :
* INVALID : if any of the specified LV types match the LV ,
* then the command fails .
* REQUIRE : if none of the specified LV types match the LV ,
* then the command fails .
*
* 3. LV properties ( check_lvp_bits ) :
* INVALID : if any of the specified LV properties match
* the LV , then the command fails .
* REQUIRE : if any of the specified LV properties do not match
* the LV , then the command fails .
*/
if ( rule - > opts_count & & ! opt_in_list_is_set ( cmd , rule - > opts , rule - > opts_count , NULL , NULL ) )
continue ;
/* If LV matches one type in lvt_bits, this returns 1. */
if ( rule - > lvt_bits & & ! _lv_types_match ( cmd , lv , rule - > lvt_bits , NULL , NULL ) )
continue ;
/* If LV matches all properties in lvp_bits, this returns 1. */
if ( rule - > lvp_bits & & ! _lv_props_match ( cmd , lv , rule - > lvp_bits , NULL , NULL ) )
continue ;
/*
* Check the options , LV types , LV properties .
*/
if ( rule - > check_opts )
opt_in_list_is_set ( cmd , rule - > check_opts , rule - > check_opts_count ,
& opts_match_count , & opts_unmatch_count ) ;
if ( rule - > check_lvt_bits )
_lv_types_match ( cmd , lv , rule - > check_lvt_bits ,
& lv_types_match_bits , & lv_types_unmatch_bits ) ;
if ( rule - > check_lvp_bits )
_lv_props_match ( cmd , lv , rule - > check_lvp_bits ,
& lv_props_match_bits , & lv_props_unmatch_bits ) ;
/*
* Evaluate if the check results pass based on the rule .
* The options are checked again here because the previous
* option validation ( during command matching ) does not cover
* cases where the option is combined with conditions of LV types
* or properties .
*/
/* Fail if any invalid options are set. */
if ( rule - > check_opts & & ( rule - > rule = = RULE_INVALID ) & & opts_match_count ) {
memset ( buf , 0 , sizeof ( buf ) ) ;
opt_array_to_str ( cmd , rule - > check_opts , rule - > check_opts_count , buf , sizeof ( buf ) ) ;
2017-09-20 18:51:52 +03:00
log_warn ( " Command on LV %s has invalid use of option %s. " ,
2017-04-25 20:19:11 +03:00
display_lvname ( lv ) , buf ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret = 0 ;
}
/* Fail if any required options are not set. */
if ( rule - > check_opts & & ( rule - > rule = = RULE_REQUIRE ) & & opts_unmatch_count ) {
memset ( buf , 0 , sizeof ( buf ) ) ;
opt_array_to_str ( cmd , rule - > check_opts , rule - > check_opts_count , buf , sizeof ( buf ) ) ;
2017-04-25 20:19:11 +03:00
log_warn ( " Command on LV %s requires option %s. " ,
display_lvname ( lv ) , buf ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret = 0 ;
}
/* Fail if the LV matches any of the invalid LV types. */
if ( rule - > check_lvt_bits & & ( rule - > rule = = RULE_INVALID ) & & lv_types_match_bits ) {
2017-09-20 18:51:52 +03:00
if ( rule - > opts_count )
log_warn ( " Command on LV %s uses options invalid with LV type %s. " ,
display_lvname ( lv ) , lvtype ? lvtype - > name : " unknown " ) ;
else
log_warn ( " Command on LV %s with invalid LV type %s. " ,
display_lvname ( lv ) , lvtype ? lvtype - > name : " unknown " ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret = 0 ;
}
/* Fail if the LV does not match any of the required LV types. */
if ( rule - > check_lvt_bits & & ( rule - > rule = = RULE_REQUIRE ) & & ! lv_types_match_bits ) {
memset ( buf , 0 , sizeof ( buf ) ) ;
2017-10-18 17:57:46 +03:00
_lvt_bits_to_str ( rule - > check_lvt_bits , buf , sizeof ( buf ) ) ;
2017-09-20 18:51:52 +03:00
if ( rule - > opts_count )
log_warn ( " Command on LV %s uses options that require LV types %s. " ,
display_lvname ( lv ) , buf ) ;
else
log_warn ( " Command on LV %s does not accept LV type %s. Required LV types are %s. " ,
display_lvname ( lv ) , lvtype ? lvtype - > name : " unknown " , buf ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret = 0 ;
}
/* Fail if the LV matches any of the invalid LV properties. */
if ( rule - > check_lvp_bits & & ( rule - > rule = = RULE_INVALID ) & & lv_props_match_bits ) {
memset ( buf , 0 , sizeof ( buf ) ) ;
2017-10-18 17:57:46 +03:00
_lvp_bits_to_str ( lv_props_match_bits , buf , sizeof ( buf ) ) ;
2017-09-20 18:51:52 +03:00
if ( rule - > opts_count )
log_warn ( " Command on LV %s uses options that are invalid with LV properties: %s. " ,
display_lvname ( lv ) , buf ) ;
else
log_warn ( " Command on LV %s is invalid on LV with properties: %s. " ,
display_lvname ( lv ) , buf ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret = 0 ;
}
/* Fail if the LV does not match any of the required LV properties. */
if ( rule - > check_lvp_bits & & ( rule - > rule = = RULE_REQUIRE ) & & lv_props_unmatch_bits ) {
memset ( buf , 0 , sizeof ( buf ) ) ;
2017-10-18 17:57:46 +03:00
_lvp_bits_to_str ( lv_props_unmatch_bits , buf , sizeof ( buf ) ) ;
2017-09-20 18:51:52 +03:00
if ( rule - > opts_count )
log_warn ( " Command on LV %s uses options that require LV properties: %s. " ,
display_lvname ( lv ) , buf ) ;
else
log_warn ( " Command on LV %s requires LV with properties: %s. " ,
display_lvname ( lv ) , buf ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret = 0 ;
}
}
return ret ;
}
/*
* Return which arg position the given LV is at ,
* where 1 represents the first position arg .
* When the first position arg is repeatable ,
* return 1 for all .
*
* Return 0 when the command has no required
* position args . ( optional position args are
* not considered . )
*/
static int _find_lv_arg_position ( struct cmd_context * cmd , struct logical_volume * lv )
{
const char * sep , * lvname ;
int i ;
if ( cmd - > command - > rp_count = = 0 )
return 0 ;
if ( cmd - > command - > rp_count = = 1 )
return 1 ;
for ( i = 0 ; i < cmd - > position_argc ; i + + ) {
if ( i = = cmd - > command - > rp_count )
break ;
if ( ! val_bit_is_set ( cmd - > command - > required_pos_args [ i ] . def . val_bits , lv_VAL ) )
continue ;
if ( ( sep = strstr ( cmd - > position_argv [ i ] , " / " ) ) )
lvname = sep + 1 ;
else
lvname = cmd - > position_argv [ i ] ;
if ( ! strcmp ( lvname , lv - > name ) )
return i + 1 ;
}
/*
* If the last position arg is an LV and this
* arg is beyond that position , then the last
* LV position arg is repeatable , so return
* that position .
*/
if ( i = = cmd - > command - > rp_count ) {
int last_pos = cmd - > command - > rp_count ;
if ( val_bit_is_set ( cmd - > command - > required_pos_args [ last_pos - 1 ] . def . val_bits , lv_VAL ) )
return last_pos ;
}
return 0 ;
}
2014-10-04 02:37:49 +04:00
int process_each_lv_in_vg ( struct cmd_context * cmd , struct volume_group * vg ,
struct dm_list * arg_lvnames , const struct dm_list * tags_in ,
2014-10-07 19:45:45 +04:00
int stop_on_error ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2016-11-29 21:00:15 +03:00
check_single_lv_fn_t check_single_lv ,
2014-11-27 17:02:13 +03:00
process_single_lv_fn_t process_single_lv )
2014-10-04 02:37:49 +04:00
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
char lv_uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
char vg_uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
2014-10-04 02:37:49 +04:00
int ret_max = ECMD_PROCESSED ;
int ret = 0 ;
2014-12-03 16:20:00 +03:00
int whole_selected = 0 ;
2014-11-28 17:04:25 +03:00
int handle_supplied = handle ! = NULL ;
2014-11-24 13:08:41 +03:00
unsigned process_lv ;
2014-10-04 02:37:49 +04:00
unsigned process_all = 0 ;
unsigned tags_supplied = 0 ;
unsigned lvargs_supplied = 0 ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
int lv_is_named_arg ;
int lv_arg_pos ;
2014-10-04 02:37:49 +04:00
struct lv_list * lvl ;
struct dm_str_list * sl ;
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
struct dm_list final_lvs ;
struct lv_list * final_lvl ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
struct dm_list found_arg_lvnames ;
2016-03-01 17:23:05 +03:00
struct glv_list * glvl , * tglvl ;
2016-05-23 16:27:09 +03:00
int do_report_ret_code = 1 ;
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_LV ) ;
vg_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & vg - > id , vg_uuid , sizeof ( vg_uuid ) ) )
stack ;
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
dm_list_init ( & final_lvs ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
dm_list_init ( & found_arg_lvnames ) ;
2014-10-04 02:37:49 +04:00
2014-11-28 17:04:25 +03:00
if ( ! vg_check_status ( vg , EXPORTED_VG ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-10-04 02:37:49 +04:00
if ( tags_in & & ! dm_list_empty ( tags_in ) )
tags_supplied = 1 ;
if ( arg_lvnames & & ! dm_list_empty ( arg_lvnames ) )
lvargs_supplied = 1 ;
2016-05-31 13:24:05 +03:00
if ( ! handle & & ! ( handle = init_processing_handle ( cmd , NULL ) ) ) {
2014-11-28 17:04:25 +03:00
ret_max = ECMD_FAILED ;
goto_out ;
}
if ( handle - > internal_report_for_select & & ! handle - > selection_handle & &
2015-02-10 15:46:37 +03:00
! init_selection_handle ( cmd , handle , LVS ) ) {
2014-11-28 17:04:25 +03:00
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-10-04 02:37:49 +04:00
/* Process all LVs in this VG if no restrictions given
* or if VG tags match . */
if ( ( ! tags_supplied & & ! lvargs_supplied ) | |
( tags_supplied & & str_list_match_list ( tags_in , & vg - > tags , NULL ) ) )
process_all = 1 ;
2016-05-20 14:26:02 +03:00
log_set_report_object_group_and_group_id ( vg - > name , vg_uuid ) ;
2014-10-04 02:37:49 +04:00
dm_list_iterate_items ( lvl , & vg - > lvs ) {
2016-05-20 14:26:02 +03:00
lv_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & lvl - > lv - > lvid . id [ 1 ] , lv_uuid , sizeof ( lv_uuid ) ) )
stack ;
log_set_report_object_name_and_id ( lvl - > lv - > name , lv_uuid ) ;
2014-11-28 17:04:25 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-11-14 12:50:31 +03:00
2016-12-13 02:09:15 +03:00
if ( lv_is_snapshot ( lvl - > lv ) )
2014-10-04 02:37:49 +04:00
continue ;
/* Skip availability change for non-virt snaps when processing all LVs */
/* FIXME: pass process_all to process_single_lv() */
2016-06-22 00:24:52 +03:00
if ( process_all & & arg_is_set ( cmd , activate_ARG ) & &
2014-10-04 02:37:49 +04:00
lv_is_cow ( lvl - > lv ) & & ! lv_is_virtual_origin ( origin_from_cow ( lvl - > lv ) ) )
continue ;
2016-06-22 00:24:52 +03:00
if ( lv_is_virtual_origin ( lvl - > lv ) & & ! arg_is_set ( cmd , all_ARG ) ) {
2014-10-04 02:37:49 +04:00
if ( lvargs_supplied & &
str_list_match_item ( arg_lvnames , lvl - > lv - > name ) )
log_print_unless_silent ( " Ignoring virtual origin logical volume %s. " ,
display_lvname ( lvl - > lv ) ) ;
continue ;
}
/*
2015-07-08 00:04:18 +03:00
* Only let hidden LVs through if - - all was used or the LVs
2014-10-04 02:37:49 +04:00
* were specifically named on the command line .
*/
2016-06-22 00:24:52 +03:00
if ( ! lvargs_supplied & & ! lv_is_visible ( lvl - > lv ) & & ! arg_is_set ( cmd , all_ARG ) )
2014-10-04 02:37:49 +04:00
continue ;
2015-07-08 00:04:18 +03:00
/*
* Only let sanlock LV through if - - all was used or if
* it is named on the command line .
*/
if ( lv_is_lockd_sanlock_lv ( lvl - > lv ) ) {
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , all_ARG ) | |
2015-07-08 00:04:18 +03:00
( lvargs_supplied & & str_list_match_item ( arg_lvnames , lvl - > lv - > name ) ) ) {
log_very_verbose ( " Processing lockd_sanlock_lv %s/%s. " , vg - > name , lvl - > lv - > name ) ;
} else {
continue ;
}
}
2014-11-24 13:08:41 +03:00
/*
* process the LV if one of the following :
* - process_all is set
* - LV name matches a supplied LV name
* - LV tag matches a supplied LV tag
* - LV matches the selection
*/
process_lv = process_all ;
if ( lvargs_supplied & & str_list_match_item ( arg_lvnames , lvl - > lv - > name ) ) {
2014-10-04 02:37:49 +04:00
/* Remove LV from list of unprocessed LV names */
str_list_del ( arg_lvnames , lvl - > lv - > name ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
str_list_add ( cmd - > mem , & found_arg_lvnames , lvl - > lv - > name ) ;
2014-11-24 13:08:41 +03:00
process_lv = 1 ;
}
if ( ! process_lv & & tags_supplied & & str_list_match_list ( tags_in , & lvl - > lv - > tags , NULL ) )
process_lv = 1 ;
2016-05-30 17:28:47 +03:00
process_lv = process_lv & & select_match_lv ( cmd , handle , vg , lvl - > lv ) & & _select_matches ( handle ) ;
2014-11-24 13:08:41 +03:00
2014-11-28 17:04:25 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-11-24 13:08:41 +03:00
if ( ! process_lv )
2014-10-04 02:37:49 +04:00
continue ;
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
log_very_verbose ( " Adding %s/%s to the list of LVs to be processed. " , vg - > name , lvl - > lv - > name ) ;
2016-01-21 15:18:11 +03:00
if ( ! ( final_lvl = dm_pool_zalloc ( cmd - > mem , sizeof ( struct lv_list ) ) ) ) {
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
log_error ( " Failed to allocate final LV list item. " ) ;
ret_max = ECMD_FAILED ;
2016-11-25 15:46:06 +03:00
goto out ;
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
}
final_lvl - > lv = lvl - > lv ;
dm_list_add ( & final_lvs , & final_lvl - > list ) ;
}
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
dm_list_iterate_items ( lvl , & final_lvs ) {
2016-05-20 14:26:02 +03:00
lv_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & lvl - > lv - > lvid . id [ 1 ] , lv_uuid , sizeof ( lv_uuid ) ) )
stack ;
log_set_report_object_name_and_id ( lvl - > lv - > name , lv_uuid ) ;
2016-01-21 15:19:27 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2015-03-23 15:32:00 +03:00
/*
* FIXME : Once we have index over vg - > removed_lvs , check directly
* LV presence there and remove LV_REMOVE flag / lv_is_removed fn
* as they won ' t be needed anymore .
*/
metadata: process_each_lv_in_vg: get the list of LVs to process first, then do the processing
This avoids a problem in which we're using selection on LV list - we
need to do the selection on initial state and not on any intermediary
state as we process LVs one by one - some of the relations among LVs
can be gone during this processing.
For example, processing one LV can cause the other LVs to lose the
relation to this LV and hence they're not selectable anymore with
the original selection criteria as it would be if we did selection
on inital state. A perfect example is with thin snapshots:
$ lvs -o lv_name,origin,layout,role vg
LV Origin Layout Role
lvol1 thin,sparse public,origin,thinorigin,multithinorigin
lvol2 lvol1 thin,sparse public,snapshot,thinsnapshot
lvol3 lvol1 thin,sparse public,snapshot,thinsnapshot
pool thin,pool private
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
The lvremove command above was supposed to remove lvol1 as well as
all its snapshots which have origin=lvol1. It failed to do so, because
once we removed the origin lvol1, the lvol2 and lvol3 which were
snapshots before are not snapshots anymore - the relations change
as we're processing these LVs one by one.
If we do the selection first and then execute any concrete actions on
these LVs (which is what this patch does), the behaviour is correct
then - the selection is done on the *initial state*:
$ lvremove -ff -S 'lv_name=lvol1 || origin=lvol1'
Logical volume "lvol1" successfully removed
Logical volume "lvol2" successfully removed
Logical volume "lvol3" successfully removed
Similarly for all the other situations in which relations among
LVs are being changed by processing the LVs one by one.
This patch also introduces LV_REMOVED internal LV status flag
to mark removed LVs so they're not processed further when we
iterate over collected list of LVs to be processed.
Previously, when we iterated directly over vg->lvs list to
process the LVs, we relied on the fact that once the LV is removed,
it is also removed from the vg->lvs list we're iterating over.
But that was incorrect as we shouldn't remove LVs from the list
during one iteration while we're iterating over that exact list
(dm_list_iterate_items safe can handle only one removal at
one iteration anyway, so it can't be used here).
2015-03-16 19:10:21 +03:00
if ( lv_is_removed ( lvl - > lv ) )
continue ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
lv_is_named_arg = str_list_match_item ( & found_arg_lvnames , lvl - > lv - > name ) ;
lv_arg_pos = _find_lv_arg_position ( cmd , lvl - > lv ) ;
/*
* The command definition may include restrictions on the
* types and properties of LVs that can be processed .
*/
if ( ! _check_lv_types ( cmd , lvl - > lv , lv_arg_pos ) ) {
/* FIXME: include this result in report log? */
if ( lv_is_named_arg ) {
2017-04-25 20:19:11 +03:00
log_error ( " Command not permitted on LV %s. " , display_lvname ( lvl - > lv ) ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret_max = ECMD_FAILED ;
}
continue ;
}
if ( ! _check_lv_rules ( cmd , lvl - > lv ) ) {
/* FIXME: include this result in report log? */
if ( lv_is_named_arg ) {
2017-04-25 20:19:11 +03:00
log_error ( " Command not permitted on LV %s. " , display_lvname ( lvl - > lv ) ) ;
commands: new method for defining commands
. Define a prototype for every lvm command.
. Match every user command with one definition.
. Generate help text and man pages from them.
The new file command-lines.in defines a prototype for every
unique lvm command. A unique lvm command is a unique
combination of: command name + required option args +
required positional args. Each of these prototypes also
includes the optional option args and optional positional
args that the command will accept, a description, and a
unique string ID for the definition. Any valid command
will match one of the prototypes.
Here's an example of the lvresize command definitions from
command-lines.in, there are three unique lvresize commands:
lvresize --size SizeMB LV
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync, --reportformat String, --resizefs,
--stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB
OP: PV ...
ID: lvresize_by_size
DESC: Resize an LV by a specified size.
lvresize LV PV ...
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --resizefs, --stripes Number, --stripesize SizeKB
ID: lvresize_by_pv
DESC: Resize an LV by specified PV extents.
FLAGS: SECONDARY_SYNTAX
lvresize --poolmetadatasize SizeMB LV_thinpool
OO: --alloc Alloc, --autobackup Bool, --force,
--nofsck, --nosync, --noudevsync,
--reportformat String, --stripes Number, --stripesize SizeKB
OP: PV ...
ID: lvresize_pool_metadata_by_size
DESC: Resize a pool metadata SubLV by a specified size.
The three commands have separate definitions because they have
different required parameters. Required parameters are specified
on the first line of the definition. Optional options are
listed after OO, and optional positional args are listed after OP.
This data is used to generate corresponding command definition
structures for lvm in command-lines.h. usage/help output is also
auto generated, so it is always in sync with the definitions.
Every user-entered command is compared against the set of
command structures, and matched with one. An error is
reported if an entered command does not have the required
parameters for any definition. The closest match is printed
as a suggestion, and running lvresize --help will display
the usage for each possible lvresize command.
The prototype syntax used for help/man output includes
required --option and positional args on the first line,
and optional --option and positional args enclosed in [ ]
on subsequent lines.
command_name <required_opt_args> <required_pos_args>
[ <optional_opt_args> ]
[ <optional_pos_args> ]
Command definitions that are not to be advertised/suggested
have the flag SECONDARY_SYNTAX. These commands will not be
printed in the normal help output.
Man page prototypes are also generated from the same original
command definitions, and are always in sync with the code
and help text.
Very early in command execution, a matching command definition
is found. lvm then knows the operation being done, and that
the provided args conform to the definition. This will allow
lots of ad hoc checking/validation to be removed throughout
the code.
Each command definition can also be routed to a specific
function to implement it. The function is associated with
an enum value for the command definition (generated from
the ID string.) These per-command-definition implementation
functions have not yet been created, so all commands
currently fall back to the existing per-command-name
implementation functions.
Using per-command-definition functions will allow lots of
code to be removed which tries to figure out what the
command is meant to do. This is currently based on ad hoc
and complicated option analysis. When using the new
functions, what the command is doing is already known
from the associated command definition.
2016-08-12 23:52:18 +03:00
ret_max = ECMD_FAILED ;
}
continue ;
}
2016-11-29 21:00:15 +03:00
if ( check_single_lv & & ! check_single_lv ( cmd , lvl - > lv , handle , lv_is_named_arg ) ) {
if ( lv_is_named_arg )
ret_max = ECMD_FAILED ;
continue ;
}
2014-11-14 18:08:27 +03:00
log_very_verbose ( " Processing LV %s in VG %s. " , lvl - > lv - > name , vg - > name ) ;
2014-10-04 02:37:49 +04:00
2014-11-15 00:00:35 +03:00
ret = process_single_lv ( cmd , lvl - > lv , handle ) ;
2014-12-03 16:20:00 +03:00
if ( handle_supplied )
_update_selection_result ( handle , & whole_selected ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
2014-11-14 12:50:31 +03:00
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2014-10-04 02:37:49 +04:00
if ( ret > ret_max )
ret_max = ret ;
2014-10-07 19:45:45 +04:00
2016-05-20 14:26:02 +03:00
if ( stop_on_error & & ret ! = ECMD_PROCESSED ) {
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2014-11-28 17:04:25 +03:00
goto_out ;
2016-05-20 14:26:02 +03:00
}
2014-10-04 02:37:49 +04:00
}
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2014-10-04 02:37:49 +04:00
2016-03-01 17:23:05 +03:00
if ( handle - > include_historical_lvs & & ! tags_supplied ) {
if ( ! dm_list_size ( & _historical_lv . segments ) )
dm_list_add ( & _historical_lv . segments , & _historical_lv_segment . list ) ;
_historical_lv . vg = vg ;
dm_list_iterate_items_safe ( glvl , tglvl , & vg - > historical_lvs ) {
2016-05-20 14:26:02 +03:00
lv_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & glvl - > glv - > historical - > lvid . id [ 1 ] , lv_uuid , sizeof ( lv_uuid ) ) )
stack ;
log_set_report_object_name_and_id ( glvl - > glv - > historical - > name , lv_uuid ) ;
2016-03-01 17:23:05 +03:00
process_lv = process_all ;
if ( lvargs_supplied & &
( sl = _str_list_match_item_with_prefix ( arg_lvnames , HISTORICAL_LV_PREFIX , glvl - > glv - > historical - > name ) ) ) {
str_list_del ( arg_lvnames , glvl - > glv - > historical - > name ) ;
dm_list_del ( & sl - > list ) ;
process_lv = 1 ;
}
2016-05-30 17:28:47 +03:00
process_lv = process_lv & & select_match_lv ( cmd , handle , vg , lvl - > lv ) & & _select_matches ( handle ) ;
2016-03-01 17:23:05 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
if ( ! process_lv )
continue ;
_historical_lv . this_glv = glvl - > glv ;
_historical_lv . name = glvl - > glv - > historical - > name ;
log_very_verbose ( " Processing historical LV %s in VG %s. " , glvl - > glv - > historical - > name , vg - > name ) ;
ret = process_single_lv ( cmd , & _historical_lv , handle ) ;
if ( handle_supplied )
_update_selection_result ( handle , & whole_selected ) ;
if ( ret ! = ECMD_PROCESSED )
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2016-03-01 17:23:05 +03:00
if ( ret > ret_max )
ret_max = ret ;
2016-05-20 14:26:02 +03:00
if ( stop_on_error & & ret ! = ECMD_PROCESSED ) {
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2016-03-01 17:23:05 +03:00
goto_out ;
2016-05-20 14:26:02 +03:00
}
2016-03-01 17:23:05 +03:00
}
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2016-03-01 17:23:05 +03:00
}
2014-10-04 02:37:49 +04:00
if ( lvargs_supplied ) {
/*
* FIXME : lvm supports removal of LV with all its dependencies
* this leads to miscalculation that depends on the order of args .
*/
dm_list_iterate_items ( sl , arg_lvnames ) {
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( sl - > str , NULL ) ;
2014-10-04 02:37:49 +04:00
log_error ( " Failed to find logical volume \" %s/%s \" " ,
vg - > name , sl - > str ) ;
if ( ret_max < ECMD_FAILED )
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2014-10-04 02:37:49 +04:00
}
}
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2014-11-28 17:04:25 +03:00
out :
2016-05-23 16:27:09 +03:00
if ( do_report_ret_code )
report_log_ret_code ( ret_max ) ;
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
log_set_report_object_group_and_group_id ( NULL , NULL ) ;
2014-11-28 17:04:25 +03:00
if ( ! handle_supplied )
2015-02-13 12:42:21 +03:00
destroy_processing_handle ( cmd , handle ) ;
2014-12-03 16:20:00 +03:00
else
_set_final_selection_result ( handle , whole_selected ) ;
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-04 02:37:49 +04:00
return ret_max ;
}
/*
* If arg is tag , add it to arg_tags
* else the arg is either vgname or vgname / lvname :
* - add the vgname of each arg to arg_vgnames
* - if arg has no lvname , add just vgname arg_lvnames ,
* it represents all lvs in the vg
* - if arg has lvname , add vgname / lvname to arg_lvnames
*/
static int _get_arg_lvnames ( struct cmd_context * cmd ,
int argc , char * * argv ,
2016-05-23 21:42:17 +03:00
const char * one_vgname , const char * one_lvname ,
2014-10-04 02:37:49 +04:00
struct dm_list * arg_vgnames ,
struct dm_list * arg_lvnames ,
struct dm_list * arg_tags )
{
int opt = 0 ;
int ret_max = ECMD_PROCESSED ;
char * vglv ;
size_t vglv_sz ;
const char * vgname ;
const char * lv_name ;
const char * tmp_lv_name ;
2014-10-06 18:22:01 +04:00
const char * vgname_def ;
2014-10-04 02:37:49 +04:00
unsigned dev_dir_found ;
2016-05-23 21:42:17 +03:00
if ( one_vgname ) {
if ( ! str_list_add ( cmd - > mem , arg_vgnames ,
dm_pool_strdup ( cmd - > mem , one_vgname ) ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
if ( ! one_lvname ) {
if ( ! str_list_add ( cmd - > mem , arg_lvnames ,
dm_pool_strdup ( cmd - > mem , one_vgname ) ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
} else {
vglv_sz = strlen ( one_vgname ) + strlen ( one_lvname ) + 2 ;
if ( ! ( vglv = dm_pool_alloc ( cmd - > mem , vglv_sz ) ) | |
dm_snprintf ( vglv , vglv_sz , " %s/%s " , one_vgname , one_lvname ) < 0 ) {
log_error ( " vg/lv string alloc failed. " ) ;
return ECMD_FAILED ;
}
if ( ! str_list_add ( cmd - > mem , arg_lvnames , vglv ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
}
return ret_max ;
}
2014-10-04 02:37:49 +04:00
for ( ; opt < argc ; opt + + ) {
lv_name = argv [ opt ] ;
dev_dir_found = 0 ;
/* Do we have a tag or vgname or lvname? */
vgname = lv_name ;
if ( * vgname = = ' @ ' ) {
if ( ! validate_tag ( vgname + 1 ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Skipping invalid tag %s. " , vgname ) ;
2014-10-04 02:37:49 +04:00
continue ;
}
if ( ! str_list_add ( cmd - > mem , arg_tags ,
dm_pool_strdup ( cmd - > mem , vgname + 1 ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-04 02:37:49 +04:00
return ECMD_FAILED ;
}
continue ;
}
/* FIXME Jumbled parsing */
vgname = skip_dev_dir ( cmd , vgname , & dev_dir_found ) ;
if ( * vgname = = ' / ' ) {
2014-11-14 18:08:27 +03:00
log_error ( " \" %s \" : Invalid path for Logical Volume. " ,
2014-10-04 02:37:49 +04:00
argv [ opt ] ) ;
if ( ret_max < ECMD_FAILED )
ret_max = ECMD_FAILED ;
continue ;
}
lv_name = vgname ;
if ( ( tmp_lv_name = strchr ( vgname , ' / ' ) ) ) {
/* Must be an LV */
lv_name = tmp_lv_name ;
while ( * lv_name = = ' / ' )
lv_name + + ;
if ( ! ( vgname = extract_vgname ( cmd , vgname ) ) ) {
if ( ret_max < ECMD_FAILED ) {
stack ;
ret_max = ECMD_FAILED ;
}
continue ;
}
} else if ( ! dev_dir_found & &
2014-10-06 18:22:01 +04:00
( vgname_def = _default_vgname ( cmd ) ) )
2014-10-04 02:37:49 +04:00
vgname = vgname_def ;
else
lv_name = NULL ;
if ( ! str_list_add ( cmd - > mem , arg_vgnames ,
dm_pool_strdup ( cmd - > mem , vgname ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-04 02:37:49 +04:00
return ECMD_FAILED ;
}
if ( ! lv_name ) {
if ( ! str_list_add ( cmd - > mem , arg_lvnames ,
dm_pool_strdup ( cmd - > mem , vgname ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-04 02:37:49 +04:00
return ECMD_FAILED ;
}
} else {
vglv_sz = strlen ( vgname ) + strlen ( lv_name ) + 2 ;
if ( ! ( vglv = dm_pool_alloc ( cmd - > mem , vglv_sz ) ) | |
dm_snprintf ( vglv , vglv_sz , " %s/%s " , vgname , lv_name ) < 0 ) {
2014-11-14 18:08:27 +03:00
log_error ( " vg/lv string alloc failed. " ) ;
2014-10-04 02:37:49 +04:00
return ECMD_FAILED ;
}
if ( ! str_list_add ( cmd - > mem , arg_lvnames , vglv ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-04 02:37:49 +04:00
return ECMD_FAILED ;
}
}
}
return ret_max ;
}
2016-12-09 22:30:42 +03:00
/*
2017-10-24 15:56:42 +03:00
* Finding vgname / lvname to process .
2016-12-09 22:30:42 +03:00
*
2017-10-24 15:56:42 +03:00
* When the position arg is a single name without any ' / '
* it is treated as an LV name ( leaving the VG unknown ) .
* Other option values , or env var , must be searched for a VG name .
* If one of the option values contains a vgname / lvname value ,
* then the VG name is extracted and used for the LV position arg .
* Or , if the env var has the VG name , that is used .
2016-12-09 22:30:42 +03:00
*
* Other option values that are searched for a VG name are :
2017-10-24 15:56:42 +03:00
* - - thinpool , - - cachepool , - - poolmetadata .
2016-12-09 22:30:42 +03:00
*
* . command vg / lv1
* . add vg to arg_vgnames
* . add vg / lv1 to arg_lvnames
*
* command lv1
2017-02-16 00:06:52 +03:00
* . error : no vg name ( unless LVM_VG_NAME )
2016-12-09 22:30:42 +03:00
*
2017-02-16 00:06:52 +03:00
* command - - option = vg / lv1 vg / lv2
2016-12-09 22:30:42 +03:00
* . verify both vg names match
* . add vg to arg_vgnames
* . add vg / lv2 to arg_lvnames
*
2017-02-16 00:06:52 +03:00
* command - - option = lv1 lv2
* . error : no vg name ( unless LVM_VG_NAME )
2016-12-09 22:30:42 +03:00
*
2017-02-16 00:06:52 +03:00
* command - - option = vg / lv1 lv2
2016-12-09 22:30:42 +03:00
* . add vg to arg_vgnames
* . add vg / lv2 to arg_lvnames
*
2017-02-16 00:06:52 +03:00
* command - - option = lv1 vg / lv2
2016-12-09 22:30:42 +03:00
* . add vg to arg_vgnames
* . add vg / lv2 to arg_lvnames
*/
static int _get_arg_lvnames_using_options ( struct cmd_context * cmd ,
int argc , char * * argv ,
struct dm_list * arg_vgnames ,
struct dm_list * arg_lvnames ,
struct dm_list * arg_tags )
{
2017-10-24 15:56:42 +03:00
/* Array with args which may provide vgname */
static const unsigned _opts_with_vgname [ ] = {
cachepool_ARG , poolmetadata_ARG , thinpool_ARG
} ;
unsigned i ;
2016-12-09 22:30:42 +03:00
const char * pos_name = NULL ;
const char * arg_name = NULL ;
const char * pos_vgname = NULL ;
const char * opt_vgname = NULL ;
const char * pos_lvname = NULL ;
const char * use_vgname = NULL ;
char * vglv ;
size_t vglv_sz ;
if ( argc ! = 1 ) {
log_error ( " One LV position arg is required. " ) ;
return ECMD_FAILED ;
}
if ( ! ( pos_name = dm_pool_strdup ( cmd - > mem , argv [ 0 ] ) ) ) {
log_error ( " string alloc failed. " ) ;
return ECMD_FAILED ;
}
if ( * pos_name = = ' @ ' ) {
if ( ! validate_tag ( pos_name + 1 ) ) {
log_error ( " Skipping invalid tag %s. " , pos_name ) ;
return ECMD_FAILED ;
}
if ( ! str_list_add ( cmd - > mem , arg_tags ,
dm_pool_strdup ( cmd - > mem , pos_name + 1 ) ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
return ECMD_PROCESSED ;
}
2017-10-24 15:56:42 +03:00
if ( strchr ( pos_name , ' / ' ) ) {
2017-02-16 00:06:52 +03:00
/*
* This splits pos_name ' x / y ' into pos_vgname ' x ' and pos_lvname ' y '
* It skips repeated ' / ' , e . g . x //y
* It also checks and fails for extra ' / ' , e . g . x / y / z
*/
2017-10-24 15:56:42 +03:00
if ( ! ( pos_vgname = _extract_vgname ( cmd , pos_name , & pos_lvname ) ) )
return_0 ;
use_vgname = pos_vgname ;
} else
2016-12-09 22:30:42 +03:00
pos_lvname = pos_name ;
2017-10-24 15:56:42 +03:00
/* Go through the list of options which can provide vgname */
for ( i = 0 ; i < DM_ARRAY_SIZE ( _opts_with_vgname ) ; + + i ) {
if ( ( arg_name = arg_str_value ( cmd , _opts_with_vgname [ i ] , NULL ) ) & &
strchr ( arg_name , ' / ' ) ) {
/* Combined VG/LV */
/* Don't care about opt lvname, only extract vgname. */
if ( ! ( opt_vgname = _extract_vgname ( cmd , arg_name , NULL ) ) )
return_0 ;
/* Compare with already known vgname */
if ( use_vgname ) {
if ( strcmp ( use_vgname , opt_vgname ) ) {
log_error ( " VG name mismatch from %s arg (%s) and option arg (%s). " ,
pos_vgname ? " position " : " option " ,
use_vgname , opt_vgname ) ;
return ECMD_FAILED ;
}
} else
use_vgname = opt_vgname ;
2016-12-09 22:30:42 +03:00
}
}
2017-10-24 15:56:42 +03:00
/* VG not specified as position nor as optional arg, so check for default VG */
if ( ! use_vgname & & ! ( use_vgname = _default_vgname ( cmd ) ) ) {
2016-12-09 22:30:42 +03:00
log_error ( " Cannot find VG name for LV %s. " , pos_lvname ) ;
return ECMD_FAILED ;
}
if ( ! str_list_add ( cmd - > mem , arg_vgnames , dm_pool_strdup ( cmd - > mem , use_vgname ) ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
vglv_sz = strlen ( use_vgname ) + strlen ( pos_lvname ) + 2 ;
if ( ! ( vglv = dm_pool_alloc ( cmd - > mem , vglv_sz ) ) | |
dm_snprintf ( vglv , vglv_sz , " %s/%s " , use_vgname , pos_lvname ) < 0 ) {
log_error ( " vg/lv string alloc failed. " ) ;
return ECMD_FAILED ;
}
if ( ! str_list_add ( cmd - > mem , arg_lvnames , vglv ) ) {
log_error ( " strlist allocation failed. " ) ;
return ECMD_FAILED ;
}
return ECMD_PROCESSED ;
}
2015-10-27 18:52:01 +03:00
static int _process_lv_vgnameid_list ( struct cmd_context * cmd , uint32_t read_flags ,
2014-10-04 02:37:49 +04:00
struct dm_list * vgnameids_to_process ,
struct dm_list * arg_vgnames ,
struct dm_list * arg_lvnames ,
struct dm_list * arg_tags ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2016-11-29 21:00:15 +03:00
check_single_lv_fn_t check_single_lv ,
2014-10-04 02:37:49 +04:00
process_single_lv_fn_t process_single_lv )
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
char uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
2014-10-04 02:37:49 +04:00
struct volume_group * vg ;
2014-10-07 01:02:00 +04:00
struct vgnameid_list * vgnl ;
2014-10-04 02:37:49 +04:00
struct dm_str_list * sl ;
struct dm_list * tags_arg ;
struct dm_list lvnames ;
2015-07-08 15:53:23 +03:00
uint32_t lockd_state = 0 ;
2014-10-04 02:37:49 +04:00
const char * vg_name ;
const char * vg_uuid ;
const char * vgn ;
const char * lvn ;
int ret_max = ECMD_PROCESSED ;
int ret ;
2014-11-14 12:50:31 +03:00
int skip ;
2015-10-23 23:09:20 +03:00
int notfound ;
2016-02-16 23:15:24 +03:00
int already_locked ;
2016-05-23 16:27:09 +03:00
int do_report_ret_code = 1 ;
2014-10-04 02:37:49 +04:00
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_VG ) ;
2014-11-14 12:50:31 +03:00
2016-05-20 14:26:02 +03:00
dm_list_iterate_items ( vgnl , vgnameids_to_process ) {
2014-10-07 01:02:00 +04:00
vg_name = vgnl - > vg_name ;
vg_uuid = vgnl - > vgid ;
2014-11-15 00:00:35 +03:00
skip = 0 ;
2015-10-23 23:09:20 +03:00
notfound = 0 ;
2014-10-04 02:37:49 +04:00
2016-05-20 14:26:02 +03:00
uuid [ 0 ] = ' \0 ' ;
if ( vg_uuid & & ! id_write_format ( ( const struct id * ) vg_uuid , uuid , sizeof ( uuid ) ) )
stack ;
log_set_report_object_name_and_id ( vg_name , uuid ) ;
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-10-04 02:37:49 +04:00
/*
* arg_lvnames contains some elements that are just " vgname "
* which means process all lvs in the vg . Other elements
* are " vgname/lvname " which means process only the select
* lvs in the vg .
*/
tags_arg = arg_tags ;
dm_list_init ( & lvnames ) ; /* LVs to be processed in this VG */
dm_list_iterate_items ( sl , arg_lvnames ) {
vgn = sl - > str ;
lvn = strchr ( vgn , ' / ' ) ;
if ( ! lvn & & ! strcmp ( vgn , vg_name ) ) {
/* Process all LVs in this VG */
tags_arg = NULL ;
dm_list_init ( & lvnames ) ;
break ;
}
if ( lvn & & ! strncmp ( vgn , vg_name , strlen ( vg_name ) ) & &
strlen ( vg_name ) = = ( size_t ) ( lvn - vgn ) ) {
if ( ! str_list_add ( cmd - > mem , & lvnames ,
dm_pool_strdup ( cmd - > mem , lvn + 1 ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2016-05-20 14:26:02 +03:00
ret_max = ECMD_FAILED ;
goto out ;
2014-10-04 02:37:49 +04:00
}
}
}
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
log_very_verbose ( " Processing VG %s %s " , vg_name , vg_uuid ? uuid : " " ) ;
2015-03-05 23:00:44 +03:00
if ( ! lockd_vg ( cmd , vg_name , NULL , 0 , & lockd_state ) ) {
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2015-03-05 23:00:44 +03:00
continue ;
}
2016-02-16 23:15:24 +03:00
already_locked = lvmcache_vgname_is_locked ( vg_name ) ;
2015-10-27 18:52:01 +03:00
vg = vg_read ( cmd , vg_name , vg_uuid , read_flags , lockd_state ) ;
if ( _ignore_vg ( vg , vg_name , arg_vgnames , read_flags , & skip , & notfound ) ) {
2014-10-04 02:37:49 +04:00
stack ;
2014-11-15 00:00:35 +03:00
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2015-03-05 23:00:44 +03:00
goto endvg ;
2014-11-15 00:00:35 +03:00
}
2015-10-23 23:09:20 +03:00
if ( skip | | notfound )
2015-03-05 23:00:44 +03:00
goto endvg ;
2014-10-04 02:37:49 +04:00
2014-11-15 00:00:35 +03:00
ret = process_each_lv_in_vg ( cmd , vg , & lvnames , tags_arg , 0 ,
2016-11-29 21:00:15 +03:00
handle , check_single_lv , process_single_lv ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2014-10-04 02:37:49 +04:00
if ( ret > ret_max )
ret_max = ret ;
2014-11-15 00:00:35 +03:00
2016-02-16 23:15:24 +03:00
if ( ! already_locked )
lvmetad: two phase vg_update
Previously, a command sent lvmetad new VG metadata in vg_commit().
In vg_commit(), devices are suspended, so any memory allocation
done by the command while sending to lvmetad, or by lvmetad while
updating its cache could deadlock if memory reclaim was triggered.
Now lvmetad is updated in unlock_vg(), after devices are resumed.
The new method for updating VG metadata in lvmetad is in two phases:
1. In vg_write(), before devices are suspended, the command sends
lvmetad a short message ("set_vg_info") telling it what the new
VG seqno will be. lvmetad sees that the seqno is newer than
the seqno of its cached VG, so it sets the INVALID flag for the
cached VG. If sending the message to lvmetad fails, the command
fails before the metadata is committed and the change is not made.
If sending the message succeeds, vg_commit() is called.
2. In unlock_vg(), after devices are resumed, the command sends
lvmetad the standard vg_update message with the new metadata.
lvmetad sees that the seqno in the new metadata matches the
seqno it saved from set_vg_info, and knows it has the latest
copy, so it clears the INVALID flag for the cached VG.
If a command fails between 1 and 2 (after committing the VG on disk,
but before sending lvmetad the new metadata), the cached VG retains
the INVALID flag in lvmetad. A subsequent command will read the
cached VG from lvmetad, see the INVALID flag, ignore the cached
copy, read the VG from disk instead, update the lvmetad copy
with the latest copy from disk, (this clears the INVALID flag
in lvmetad), and use the correct VG metadata for the command.
(This INVALID mechanism already existed for use by lvmlockd.)
2016-06-08 22:42:03 +03:00
unlock_vg ( cmd , vg , vg_name ) ;
2015-03-05 23:00:44 +03:00
endvg :
release_vg ( vg ) ;
2015-08-18 18:39:40 +03:00
if ( ! lockd_vg ( cmd , vg_name , " un " , 0 , & lockd_state ) )
2015-08-18 12:46:42 +03:00
stack ;
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2014-10-04 02:37:49 +04:00
}
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2016-05-20 14:26:02 +03:00
out :
2016-05-23 16:27:09 +03:00
if ( do_report_ret_code )
report_log_ret_code ( ret_max ) ;
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-04 02:37:49 +04:00
return ret_max ;
}
/*
* Call process_single_lv ( ) for each LV selected by the command line arguments .
*/
2016-05-23 21:42:17 +03:00
int process_each_lv ( struct cmd_context * cmd ,
int argc , char * * argv ,
const char * one_vgname , const char * one_lvname ,
uint32_t read_flags ,
struct processing_handle * handle ,
2016-11-29 21:00:15 +03:00
check_single_lv_fn_t check_single_lv ,
2016-05-23 21:42:17 +03:00
process_single_lv_fn_t process_single_lv )
2014-10-04 02:37:49 +04:00
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
2014-11-28 17:04:25 +03:00
int handle_supplied = handle ! = NULL ;
2014-10-04 02:37:49 +04:00
struct dm_list arg_tags ; /* str_list */
struct dm_list arg_vgnames ; /* str_list */
struct dm_list arg_lvnames ; /* str_list */
struct dm_list vgnameids_on_system ; /* vgnameid_list */
struct dm_list vgnameids_to_process ; /* vgnameid_list */
2017-01-14 00:08:51 +03:00
int enable_all_vgs = ( cmd - > cname - > flags & ALL_VGS_IS_DEFAULT ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
int process_all_vgs_on_system = 0 ;
int ret_max = ECMD_PROCESSED ;
2014-10-04 02:37:49 +04:00
int ret ;
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_LV ) ;
2015-03-05 23:00:44 +03:00
/* Disable error in vg_read so we can print it from ignore_vg. */
cmd - > vg_read_print_access_error = 0 ;
2015-02-27 01:06:32 +03:00
2014-10-04 02:37:49 +04:00
dm_list_init ( & arg_tags ) ;
dm_list_init ( & arg_vgnames ) ;
dm_list_init ( & arg_lvnames ) ;
dm_list_init ( & vgnameids_on_system ) ;
dm_list_init ( & vgnameids_to_process ) ;
/*
* Find any LVs , VGs or tags explicitly provided on the command line .
*/
2017-01-14 00:08:51 +03:00
if ( cmd - > cname - > flags & GET_VGNAME_FROM_OPTIONS )
2016-12-09 22:30:42 +03:00
ret = _get_arg_lvnames_using_options ( cmd , argc , argv , & arg_vgnames , & arg_lvnames , & arg_tags ) ;
else
ret = _get_arg_lvnames ( cmd , argc , argv , one_vgname , one_lvname , & arg_vgnames , & arg_lvnames , & arg_tags ) ;
if ( ret ! = ECMD_PROCESSED ) {
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ret ;
2014-11-28 17:04:25 +03:00
goto_out ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
}
2014-11-28 17:04:25 +03:00
2016-05-31 13:24:05 +03:00
if ( ! handle & & ! ( handle = init_processing_handle ( cmd , NULL ) ) ) {
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ECMD_FAILED ;
2014-11-28 17:04:25 +03:00
goto_out ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
}
2014-11-28 17:04:25 +03:00
if ( handle - > internal_report_for_select & & ! handle - > selection_handle & &
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
! init_selection_handle ( cmd , handle , LVS ) ) {
ret_max = ECMD_FAILED ;
2014-11-28 17:04:25 +03:00
goto_out ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
}
2014-10-04 02:37:49 +04:00
/*
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
* Process all VGs on the system when :
* . tags are specified and all VGs need to be read to
* look for matching tags .
* . no VG names are specified and the command defaults
* to processing all VGs when none are specified .
* . no VG names are specified and the select option needs
* resolving .
*/
2015-05-06 00:24:50 +03:00
if ( ! dm_list_empty ( & arg_tags ) )
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
process_all_vgs_on_system = 1 ;
2015-05-06 00:24:50 +03:00
else if ( dm_list_empty ( & arg_vgnames ) & & enable_all_vgs )
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
process_all_vgs_on_system = 1 ;
2015-05-06 00:24:50 +03:00
else if ( dm_list_empty ( & arg_vgnames ) & & handle - > internal_report_for_select )
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
process_all_vgs_on_system = 1 ;
2015-05-06 00:24:50 +03:00
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
/*
* Needed for a current listing of the global VG namespace .
*/
if ( process_all_vgs_on_system & & ! lockd_gl ( cmd , " sh " , 0 ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2015-03-05 23:00:44 +03:00
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
/*
* A list of all VGs on the system is needed when :
* . processing all VGs on the system
* . A VG name is specified which may refer to one
* of multiple VGs on the system with that name .
*/
2016-02-16 23:15:24 +03:00
log_debug ( " Get list of VGs on system " ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
if ( ! get_vgnameids ( cmd , & vgnameids_on_system , NULL , 0 ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
2015-03-05 23:00:44 +03:00
}
2014-10-04 02:37:49 +04:00
2015-11-30 21:11:01 +03:00
if ( ! dm_list_empty ( & arg_vgnames ) ) {
/* This may remove entries from arg_vgnames or vgnameids_on_system. */
ret = _resolve_duplicate_vgnames ( cmd , & arg_vgnames , & vgnameids_on_system ) ;
if ( ret > ret_max )
ret_max = ret ;
if ( dm_list_empty ( & arg_vgnames ) & & dm_list_empty ( & arg_tags ) ) {
ret_max = ECMD_FAILED ;
2017-06-23 11:59:12 +03:00
goto_out ;
2015-11-30 21:11:01 +03:00
}
}
2014-10-04 02:37:49 +04:00
if ( dm_list_empty ( & arg_vgnames ) & & dm_list_empty ( & vgnameids_on_system ) ) {
/* FIXME Should be log_print, but suppressed for reporting cmds */
2014-11-14 18:11:43 +03:00
log_verbose ( " No volume groups found. " ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
ret_max = ECMD_PROCESSED ;
2014-11-28 17:04:25 +03:00
goto out ;
2014-10-04 02:37:49 +04:00
}
2015-10-27 18:52:01 +03:00
if ( dm_list_empty ( & arg_vgnames ) )
read_flags | = READ_OK_NOTFOUND ;
2014-10-04 02:37:49 +04:00
/*
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
* When processing all VGs , vgnameids_on_system simply becomes
* vgnameids_to_process .
* When processing only specified VGs , then for each item in
* arg_vgnames , move the corresponding entry from
* vgnameids_on_system to vgnameids_to_process .
2014-10-04 02:37:49 +04:00
*/
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
if ( process_all_vgs_on_system )
2014-10-04 02:37:49 +04:00
dm_list_splice ( & vgnameids_to_process , & vgnameids_on_system ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
else
_choose_vgs_to_process ( cmd , & arg_vgnames , & vgnameids_on_system , & vgnameids_to_process ) ;
2014-10-04 02:37:49 +04:00
2015-10-27 18:52:01 +03:00
ret = _process_lv_vgnameid_list ( cmd , read_flags , & vgnameids_to_process , & arg_vgnames , & arg_lvnames ,
2016-11-29 21:00:15 +03:00
& arg_tags , handle , check_single_lv , process_single_lv ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
if ( ret > ret_max )
ret_max = ret ;
2014-11-28 17:04:25 +03:00
out :
if ( ! handle_supplied )
2015-02-13 12:42:21 +03:00
destroy_processing_handle ( cmd , handle ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
process_each: always use list of vgnames on system
This makes process_each_vg/lv always use the list of
vgnames on the system. When specific VGs are named on
the command line, the corresponding entries from
vgnameids_on_system are moved to vgnameids_to_process.
Previously, when specific VGs were named on the command
line, the vgnameids_on_system list was not created, and
vgnameids_to_process was created from the arg_vgnames
list (which is only names, without vgids).
Now, vgnameids_on_system is always created, and entries
are moved from that list to vgnameids_to_process -- either
some (when arg_vgnames specifies only some), or all (when
the command is processing all VGs, or needs to look at
all VGs for checking tags/selection).
This change adds one new lvmetad lookup (vg_list) to a
command that specifies VG names. It adds no new work
for other commands, e.g. non-lvmetad commands, or
commands that look at all VGs.
When using lvmetad, 'lvs foo' previously sent one
request to lvmetad: 'vg_lookup foo'.
Now, 'lvs foo' sends two requests to lvmetad:
'vg_list' and 'vg_lookup foo <uuid>'.
(The lookup can now always include the uuid in the request
because the initial vg_list contains name/vgid pairs.)
2015-11-30 21:51:44 +03:00
return ret_max ;
2014-10-04 02:37:49 +04:00
}
2014-10-07 01:02:00 +04:00
2014-10-07 03:34:04 +04:00
static int _get_arg_pvnames ( struct cmd_context * cmd ,
int argc , char * * argv ,
struct dm_list * arg_pvnames ,
struct dm_list * arg_tags )
2014-10-07 01:02:00 +04:00
{
2014-10-07 03:34:04 +04:00
int opt = 0 ;
char * at_sign , * tagname ;
char * arg_name ;
2014-10-07 01:02:00 +04:00
int ret_max = ECMD_PROCESSED ;
2014-10-07 03:34:04 +04:00
for ( ; opt < argc ; opt + + ) {
arg_name = argv [ opt ] ;
dm_unescape_colons_and_at_signs ( arg_name , NULL , & at_sign ) ;
if ( at_sign & & ( at_sign = = arg_name ) ) {
tagname = at_sign + 1 ;
if ( ! validate_tag ( tagname ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " Skipping invalid tag %s. " , tagname ) ;
2014-10-07 03:34:04 +04:00
if ( ret_max < EINVALID_CMD_LINE )
ret_max = EINVALID_CMD_LINE ;
continue ;
}
if ( ! str_list_add ( cmd - > mem , arg_tags ,
dm_pool_strdup ( cmd - > mem , tagname ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-07 03:34:04 +04:00
return ECMD_FAILED ;
}
2014-10-07 01:02:00 +04:00
continue ;
}
2014-10-07 03:34:04 +04:00
if ( ! str_list_add ( cmd - > mem , arg_pvnames ,
dm_pool_strdup ( cmd - > mem , arg_name ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " strlist allocation failed. " ) ;
2014-10-07 03:34:04 +04:00
return ECMD_FAILED ;
}
2014-10-07 01:02:00 +04:00
}
return ret_max ;
}
2015-01-07 23:04:12 +03:00
static int _get_arg_devices ( struct cmd_context * cmd ,
struct dm_list * arg_pvnames ,
struct dm_list * arg_devices )
{
struct dm_str_list * sl ;
2015-01-09 23:55:16 +03:00
struct device_id_list * dil ;
2015-01-07 23:04:12 +03:00
int ret_max = ECMD_PROCESSED ;
dm_list_iterate_items ( sl , arg_pvnames ) {
2015-01-09 23:55:16 +03:00
if ( ! ( dil = dm_pool_alloc ( cmd - > mem , sizeof ( * dil ) ) ) ) {
log_error ( " device_id_list alloc failed. " ) ;
2015-01-07 23:04:12 +03:00
return ECMD_FAILED ;
}
2015-01-09 23:55:16 +03:00
if ( ! ( dil - > dev = dev_cache_get ( sl - > str , cmd - > filter ) ) ) {
log_error ( " Failed to find device for physical volume \" %s \" . " , sl - > str ) ;
2015-01-07 23:04:12 +03:00
ret_max = ECMD_FAILED ;
} else {
2015-01-09 23:55:16 +03:00
strncpy ( dil - > pvid , dil - > dev - > pvid , ID_LEN ) ;
dm_list_add ( arg_devices , & dil - > list ) ;
2015-01-07 23:04:12 +03:00
}
}
return ret_max ;
}
tolllib: process_each_pv: always use full_filter unconditionally when getting all devices
(This reverts patch #d95c6154)
Filter complete device list through full_filter unconditionally when
we're getting the list of *all* devices even in case we're interested
only in fraction of those devices - the PVs, not the other devices
which are not PVs yet (e.g. pvs vs. pvs -a).
We need to do this full filtering whenever we're handling *complete*
list of devices, we need to be safe here, mainly if there are any
future changes and we'd forgot to change to use proper filtering then.
Also properly preventing duplicates if there are any block subsystem
components used (mpath, MD ...).
Thing here is that (under use_lvmetad=1), cmd->filter can be used
only if we're sure that the list of devices we're filtering contains
only PVs. We have to use cmd->full_filter otherwise (like it is in
case of _get_all_devices fn which acquires complete list of devices,
no matter if it is a PV or not).
Of course, cmd->full_filter is more extensive than cmd->filter
which is only a subset of full_filter.
We could optimize this in a way that if we're interested in PVs only
during process_each_pv processing (e.g. using pvs in contrast to pvs -a),
we'd get the list of PV devices directly from lvmetad from the
lvmcache_seed_infos_from_lvmetad fn call which currently updates
lvmcache only. We'd add an additional output arg for this fn to get
the list of PV devices directly in addition, without a need to iterate
over all devices which include non-PVs which we're not interested in
anyway, hence we could use only cmd->filter, not the cmd->full_filter.
So the code would look something like this:
static int _get_all_devices(....)
{
struct device_id_list *dil;
if (interested_in_pvs_only)
lvmcache_seed_infos_from_lvmetad(cmd, &dil); /* new "dil" arg */
/* the "dil" list would be filtered through cmd->filter inside lvmcache_seed_infos_from_lvmetad */
else {
lvmcache_seed_infos_from_lvmetad(cmd, NULL);
dev_iter_create(cmd->full_filter)
while (dev = dev_iter_get ...) {
dm_list_add(all_devices, &dil->list);
}
}
}
2015-02-13 12:59:19 +03:00
static int _get_all_devices ( struct cmd_context * cmd , struct dm_list * all_devices )
2014-10-07 01:02:00 +04:00
{
struct dev_iter * iter ;
struct device * dev ;
2015-01-09 23:55:16 +03:00
struct device_id_list * dil ;
2014-11-12 11:18:55 +03:00
int r = ECMD_FAILED ;
2014-10-07 01:02:00 +04:00
2016-02-16 23:15:24 +03:00
log_debug ( " Getting list of all devices " ) ;
2014-10-07 01:02:00 +04:00
lvmcache_seed_infos_from_lvmetad ( cmd ) ;
tolllib: process_each_pv: always use full_filter unconditionally when getting all devices
(This reverts patch #d95c6154)
Filter complete device list through full_filter unconditionally when
we're getting the list of *all* devices even in case we're interested
only in fraction of those devices - the PVs, not the other devices
which are not PVs yet (e.g. pvs vs. pvs -a).
We need to do this full filtering whenever we're handling *complete*
list of devices, we need to be safe here, mainly if there are any
future changes and we'd forgot to change to use proper filtering then.
Also properly preventing duplicates if there are any block subsystem
components used (mpath, MD ...).
Thing here is that (under use_lvmetad=1), cmd->filter can be used
only if we're sure that the list of devices we're filtering contains
only PVs. We have to use cmd->full_filter otherwise (like it is in
case of _get_all_devices fn which acquires complete list of devices,
no matter if it is a PV or not).
Of course, cmd->full_filter is more extensive than cmd->filter
which is only a subset of full_filter.
We could optimize this in a way that if we're interested in PVs only
during process_each_pv processing (e.g. using pvs in contrast to pvs -a),
we'd get the list of PV devices directly from lvmetad from the
lvmcache_seed_infos_from_lvmetad fn call which currently updates
lvmcache only. We'd add an additional output arg for this fn to get
the list of PV devices directly in addition, without a need to iterate
over all devices which include non-PVs which we're not interested in
anyway, hence we could use only cmd->filter, not the cmd->full_filter.
So the code would look something like this:
static int _get_all_devices(....)
{
struct device_id_list *dil;
if (interested_in_pvs_only)
lvmcache_seed_infos_from_lvmetad(cmd, &dil); /* new "dil" arg */
/* the "dil" list would be filtered through cmd->filter inside lvmcache_seed_infos_from_lvmetad */
else {
lvmcache_seed_infos_from_lvmetad(cmd, NULL);
dev_iter_create(cmd->full_filter)
while (dev = dev_iter_get ...) {
dm_list_add(all_devices, &dil->list);
}
}
}
2015-02-13 12:59:19 +03:00
if ( ! ( iter = dev_iter_create ( cmd - > full_filter , 1 ) ) ) {
2014-11-14 18:08:27 +03:00
log_error ( " dev_iter creation failed. " ) ;
2014-10-07 01:02:00 +04:00
return ECMD_FAILED ;
}
2014-10-07 03:34:04 +04:00
while ( ( dev = dev_iter_get ( iter ) ) ) {
2015-01-09 23:55:16 +03:00
if ( ! ( dil = dm_pool_alloc ( cmd - > mem , sizeof ( * dil ) ) ) ) {
log_error ( " device_id_list alloc failed. " ) ;
2014-11-12 11:18:55 +03:00
goto out ;
2014-10-07 01:02:00 +04:00
}
2015-01-14 23:16:03 +03:00
strncpy ( dil - > pvid , dev - > pvid , ID_LEN ) ;
2015-01-09 23:55:16 +03:00
dil - > dev = dev ;
dm_list_add ( all_devices , & dil - > list ) ;
2014-10-07 03:34:04 +04:00
}
2014-11-12 11:18:55 +03:00
r = ECMD_PROCESSED ;
out :
2014-10-07 03:34:04 +04:00
dev_iter_destroy ( iter ) ;
2014-11-12 11:18:55 +03:00
return r ;
2014-10-07 03:34:04 +04:00
}
2015-01-09 23:55:16 +03:00
static int _device_list_remove ( struct dm_list * devices , struct device * dev )
2014-10-07 03:34:04 +04:00
{
2015-01-09 23:55:16 +03:00
struct device_id_list * dil ;
2014-10-07 03:34:04 +04:00
2015-01-09 23:55:16 +03:00
dm_list_iterate_items ( dil , devices ) {
if ( dil - > dev = = dev ) {
dm_list_del ( & dil - > list ) ;
2014-10-07 03:34:04 +04:00
return 1 ;
}
}
return 0 ;
}
2015-01-09 23:55:16 +03:00
static struct device_id_list * _device_list_find_dev ( struct dm_list * devices , struct device * dev )
2015-01-07 23:04:12 +03:00
{
2015-01-09 23:55:16 +03:00
struct device_id_list * dil ;
2015-01-07 23:04:12 +03:00
2015-01-09 23:55:16 +03:00
dm_list_iterate_items ( dil , devices ) {
if ( dil - > dev = = dev )
return dil ;
2015-01-07 23:04:12 +03:00
}
2015-01-09 23:55:16 +03:00
return NULL ;
}
2015-10-23 23:09:20 +03:00
static int _device_list_copy ( struct cmd_context * cmd , struct dm_list * src , struct dm_list * dst )
{
struct device_id_list * dil ;
struct device_id_list * dil_new ;
dm_list_iterate_items ( dil , src ) {
if ( ! ( dil_new = dm_pool_alloc ( cmd - > mem , sizeof ( * dil_new ) ) ) ) {
log_error ( " device_id_list alloc failed. " ) ;
return ECMD_FAILED ;
}
dil_new - > dev = dil - > dev ;
strncpy ( dil_new - > pvid , dil - > pvid , ID_LEN ) ;
dm_list_add ( dst , & dil_new - > list ) ;
}
return ECMD_PROCESSED ;
}
/*
* For each device in arg_devices or all_devices that has a pvid , add a copy of
* that device to arg_missed . All PVs ( devices with a pvid ) should have been
* found while processing all VGs ( including orphan VGs ) . But , some may have
* been missed if VGs were changing at the same time . This function creates a
* list of PVs that still remain in the given list , i . e . were missed the first
* time . A second iteration through VGs can look for these explicitly .
* ( arg_devices is used if specific PVs are being processed ; all_devices is
* used if all devs are being processed )
*/
static int _get_missed_pvs ( struct cmd_context * cmd ,
struct dm_list * devices ,
struct dm_list * arg_missed )
{
struct device_id_list * dil ;
struct device_id_list * dil_missed ;
dm_list_iterate_items ( dil , devices ) {
if ( ! dil - > pvid [ 0 ] )
continue ;
if ( ! ( dil_missed = dm_pool_alloc ( cmd - > mem , sizeof ( * dil_missed ) ) ) ) {
log_error ( " device_id_list alloc failed. " ) ;
return ECMD_FAILED ;
}
dil_missed - > dev = dil - > dev ;
strncpy ( dil_missed - > pvid , dil - > pvid , ID_LEN ) ;
dm_list_add ( arg_missed , & dil_missed - > list ) ;
}
return ECMD_PROCESSED ;
}
2014-10-07 03:34:04 +04:00
static int _process_device_list ( struct cmd_context * cmd , struct dm_list * all_devices ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
process_single_pv_fn_t process_single_pv )
2014-10-07 03:34:04 +04:00
{
struct physical_volume pv_dummy ;
struct physical_volume * pv ;
2015-01-09 23:55:16 +03:00
struct device_id_list * dil ;
2014-10-07 03:34:04 +04:00
int ret_max = ECMD_PROCESSED ;
int ret = 0 ;
2016-02-16 23:15:24 +03:00
log_debug ( " Processing devices that are not PVs " ) ;
2014-10-07 03:34:04 +04:00
/*
* Pretend that each device is a PV with dummy values .
* FIXME Formalise this extension or find an alternative .
*/
2015-01-09 23:55:16 +03:00
dm_list_iterate_items ( dil , all_devices ) {
2014-11-14 12:50:31 +03:00
if ( sigint_caught ( ) )
return_ECMD_FAILED ;
2014-10-07 01:02:00 +04:00
memset ( & pv_dummy , 0 , sizeof ( pv_dummy ) ) ;
dm_list_init ( & pv_dummy . tags ) ;
dm_list_init ( & pv_dummy . segments ) ;
2015-01-09 23:55:16 +03:00
pv_dummy . dev = dil - > dev ;
2014-10-07 01:02:00 +04:00
pv = & pv_dummy ;
2015-01-09 23:55:16 +03:00
log_very_verbose ( " Processing device %s. " , dev_name ( dil - > dev ) ) ;
2014-10-07 01:02:00 +04:00
ret = process_single_pv ( cmd , NULL , pv , handle ) ;
if ( ret > ret_max )
ret_max = ret ;
}
2014-10-07 03:34:04 +04:00
return ECMD_PROCESSED ;
}
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
static int _process_duplicate_pvs ( struct cmd_context * cmd ,
struct dm_list * all_devices ,
struct dm_list * arg_devices ,
int process_all_devices ,
struct processing_handle * handle ,
process_single_pv_fn_t process_single_pv )
{
struct device_id_list * dil ;
struct device_list * devl ;
struct dm_list unused_duplicate_devs ;
struct lvmcache_info * info ;
2017-07-12 18:51:54 +03:00
const char * vgname ;
const char * vgid ;
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
int ret_max = ECMD_PROCESSED ;
int ret = 0 ;
2017-07-12 18:51:54 +03:00
struct physical_volume dummy_pv = {
. tags = DM_LIST_HEAD_INIT ( dummy_pv . tags ) ,
. segments = DM_LIST_HEAD_INIT ( dummy_pv . segments ) ,
} ;
struct format_instance dummy_fid = {
. metadata_areas_in_use = DM_LIST_HEAD_INIT ( dummy_fid . metadata_areas_in_use ) ,
. metadata_areas_ignored = DM_LIST_HEAD_INIT ( dummy_fid . metadata_areas_ignored ) ,
} ;
struct volume_group dummy_vg = {
. fid = & dummy_fid ,
. name = " " ,
. system_id = ( char * ) " " ,
. lvm1_system_id = ( char * ) " " ,
. pvs = DM_LIST_HEAD_INIT ( dummy_vg . pvs ) ,
. lvs = DM_LIST_HEAD_INIT ( dummy_vg . lvs ) ,
. historical_lvs = DM_LIST_HEAD_INIT ( dummy_vg . historical_lvs ) ,
. tags = DM_LIST_HEAD_INIT ( dummy_vg . tags ) ,
} ;
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
dm_list_init ( & unused_duplicate_devs ) ;
if ( ! lvmcache_get_unused_duplicate_devs ( cmd , & unused_duplicate_devs ) )
return_ECMD_FAILED ;
dm_list_iterate_items ( devl , & unused_duplicate_devs ) {
/* Duplicates are displayed if -a is used or the dev is named as an arg. */
_device_list_remove ( all_devices , devl - > dev ) ;
if ( ! process_all_devices & & dm_list_empty ( arg_devices ) )
continue ;
if ( ( dil = _device_list_find_dev ( arg_devices , devl - > dev ) ) )
_device_list_remove ( arg_devices , devl - > dev ) ;
if ( ! process_all_devices & & ! dil )
continue ;
2017-01-14 00:08:51 +03:00
if ( ! ( cmd - > cname - > flags & ENABLE_DUPLICATE_DEVS ) )
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
continue ;
/*
* Use the cached VG from the preferred device for the PV ,
* the vg is only used to display the VG name .
*
* This VG from lvmcache was not read from the duplicate
* dev being processed here , but from the preferred dev
* in lvmcache .
*
* When a duplicate PV is displayed , the reporting fields
* that come from the VG metadata are not shown , because
* the dev is not a part of the VG , the dev for the
* preferred PV is ( also the VG metadata in lvmcache is
* not from the duplicate dev , but from the preferred dev ) .
*/
log_very_verbose ( " Processing duplicate device %s. " , dev_name ( devl - > dev ) ) ;
2016-06-06 22:04:17 +03:00
/*
* Don ' t pass dev to lvmcache_info_from_pvid because we looking
* for the chosen / preferred dev for this pvid .
*/
2016-10-05 00:25:32 +03:00
if ( ! ( info = lvmcache_info_from_pvid ( devl - > dev - > pvid , NULL , 0 ) ) ) {
log_error ( INTERNAL_ERROR " No info for pvid " ) ;
return_ECMD_FAILED ;
}
vgname = lvmcache_vgname_from_info ( info ) ;
2017-07-12 18:51:54 +03:00
vgid = vgname ? lvmcache_vgid_from_vgname ( cmd , vgname ) : NULL ;
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
2017-07-12 18:51:54 +03:00
dummy_pv . dev = devl - > dev ;
dummy_pv . fmt = lvmcache_fmt_from_info ( info ) ;
dummy_vg . name = vgname ? : " " ;
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
2017-07-12 18:51:54 +03:00
if ( vgid )
memcpy ( & dummy_vg . id , vgid , ID_LEN ) ;
else
memset ( & dummy_vg . id , 0 , sizeof ( dummy_vg . id ) ) ;
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
2017-07-12 18:51:54 +03:00
ret = process_single_pv ( cmd , & dummy_vg , & dummy_pv , handle ) ;
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
if ( ret > ret_max )
ret_max = ret ;
if ( sigint_caught ( ) )
return_ECMD_FAILED ;
}
return ECMD_PROCESSED ;
}
2014-10-07 03:34:04 +04:00
static int _process_pvs_in_vg ( struct cmd_context * cmd ,
struct volume_group * vg ,
struct dm_list * all_devices ,
2015-01-07 23:04:12 +03:00
struct dm_list * arg_devices ,
2014-10-07 03:34:04 +04:00
struct dm_list * arg_tags ,
2015-01-14 23:16:03 +03:00
int process_all_pvs ,
int process_all_devices ,
2014-10-07 03:34:04 +04:00
int skip ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2014-10-07 03:34:04 +04:00
process_single_pv_fn_t process_single_pv )
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
char pv_uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
char vg_uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
2014-11-28 17:04:25 +03:00
int handle_supplied = handle ! = NULL ;
2014-10-07 03:34:04 +04:00
struct physical_volume * pv ;
struct pv_list * pvl ;
2015-01-09 23:55:16 +03:00
struct device_id_list * dil ;
2014-10-07 03:34:04 +04:00
const char * pv_name ;
int process_pv ;
2016-05-23 16:27:09 +03:00
int do_report_ret_code = 1 ;
2014-10-07 03:34:04 +04:00
int ret_max = ECMD_PROCESSED ;
int ret = 0 ;
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_PV ) ;
vg_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & vg - > id , vg_uuid , sizeof ( vg_uuid ) ) )
stack ;
2016-05-31 13:24:05 +03:00
if ( ! handle & & ( ! ( handle = init_processing_handle ( cmd , NULL ) ) ) ) {
2014-11-28 17:04:25 +03:00
ret_max = ECMD_FAILED ;
goto_out ;
}
if ( handle - > internal_report_for_select & & ! handle - > selection_handle & &
2015-02-10 15:46:37 +03:00
! init_selection_handle ( cmd , handle , PVS ) ) {
2014-11-28 17:04:25 +03:00
ret_max = ECMD_FAILED ;
goto_out ;
}
2016-06-14 14:21:53 +03:00
if ( ! is_orphan_vg ( vg - > name ) )
log_set_report_object_group_and_group_id ( vg - > name , vg_uuid ) ;
2016-05-20 14:26:02 +03:00
2014-10-07 03:34:04 +04:00
dm_list_iterate_items ( pvl , & vg - > pvs ) {
2016-05-20 14:26:02 +03:00
pv = pvl - > pv ;
pv_name = pv_dev_name ( pv ) ;
pv_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & pv - > id , pv_uuid , sizeof ( pv_uuid ) ) )
stack ;
log_set_report_object_name_and_id ( pv_name , pv_uuid ) ;
2014-11-28 17:04:25 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-11-14 12:50:31 +03:00
2015-01-14 23:16:03 +03:00
process_pv = process_all_pvs ;
2014-10-07 03:34:04 +04:00
2015-01-07 23:04:12 +03:00
/* Remove each arg_devices entry as it is processed. */
if ( ! process_pv & & ! dm_list_empty ( arg_devices ) & &
2015-01-09 23:55:16 +03:00
( dil = _device_list_find_dev ( arg_devices , pv - > dev ) ) ) {
2014-10-07 03:34:04 +04:00
process_pv = 1 ;
2015-01-09 23:55:16 +03:00
_device_list_remove ( arg_devices , dil - > dev ) ;
}
2014-10-07 03:34:04 +04:00
if ( ! process_pv & & ! dm_list_empty ( arg_tags ) & &
str_list_match_list ( arg_tags , & pv - > tags , NULL ) )
process_pv = 1 ;
2016-05-30 17:28:47 +03:00
process_pv = process_pv & & select_match_pv ( cmd , handle , vg , pv ) & & _select_matches ( handle ) ;
2014-11-24 13:08:41 +03:00
2014-10-07 03:34:04 +04:00
if ( process_pv ) {
if ( skip )
2014-11-14 18:08:27 +03:00
log_verbose ( " Skipping PV %s in VG %s. " , pv_name , vg - > name ) ;
2014-10-07 03:34:04 +04:00
else
2014-11-14 18:08:27 +03:00
log_very_verbose ( " Processing PV %s in VG %s. " , pv_name , vg - > name ) ;
2014-10-07 03:34:04 +04:00
2016-01-14 22:47:44 +03:00
_device_list_remove ( all_devices , pv - > dev ) ;
2014-10-07 03:34:04 +04:00
2016-01-19 00:40:42 +03:00
/*
* pv - > dev should be found in all_devices unless it ' s a
* case of a " missing device " . Previously there have
* been cases where we needed to skip processing the PV
* if pv - > dev was not found in all_devices to avoid
* processing a PV twice , i . e . when the PV had no MDAs
* it would be seen once in its real VG and again
* wrongly in the orphan VG . This no longer happens .
*/
2014-11-14 12:50:31 +03:00
if ( ! skip ) {
2014-11-15 00:00:35 +03:00
ret = process_single_pv ( cmd , vg , pv , handle ) ;
if ( ret ! = ECMD_PROCESSED )
2014-11-14 12:50:31 +03:00
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2014-11-14 12:50:31 +03:00
if ( ret > ret_max )
ret_max = ret ;
}
2014-10-07 03:34:04 +04:00
}
/*
2015-01-07 23:04:12 +03:00
* When processing only specific PVs , we can quit once they ' ve all been found .
2014-10-07 03:34:04 +04:00
*/
2015-01-14 23:16:03 +03:00
if ( ! process_all_pvs & & dm_list_empty ( arg_tags ) & & dm_list_empty ( arg_devices ) )
2014-10-07 03:34:04 +04:00
break ;
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2014-10-07 03:34:04 +04:00
}
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2014-11-28 17:04:25 +03:00
out :
2016-05-23 16:27:09 +03:00
if ( do_report_ret_code )
report_log_ret_code ( ret_max ) ;
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
log_set_report_object_group_and_group_id ( NULL , NULL ) ;
2014-11-28 17:04:25 +03:00
if ( ! handle_supplied )
2015-02-13 12:42:21 +03:00
destroy_processing_handle ( cmd , handle ) ;
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-07 01:02:00 +04:00
return ret_max ;
}
/*
2014-10-07 03:34:04 +04:00
* Iterate through all PVs in each listed VG . Process a PV if
2015-01-07 23:04:12 +03:00
* its dev or tag matches arg_devices or arg_tags . If both
* arg_devices and arg_tags are empty , then process all PVs .
2014-10-07 03:34:04 +04:00
* No PV should be processed more than once .
*
2015-01-07 23:04:12 +03:00
* Each PV is removed from arg_devices and all_devices when it is
* processed . Any names remaining in arg_devices were not found , and
2014-10-07 03:34:04 +04:00
* should produce an error . Any devices remaining in all_devices were
2015-01-09 23:55:16 +03:00
* not found and should be processed by process_device_list ( ) .
2014-10-07 01:02:00 +04:00
*/
2015-10-22 22:56:22 +03:00
static int _process_pvs_in_vgs ( struct cmd_context * cmd , uint32_t read_flags ,
2014-10-07 03:34:04 +04:00
struct dm_list * all_vgnameids ,
struct dm_list * all_devices ,
2015-01-07 23:04:12 +03:00
struct dm_list * arg_devices ,
2014-10-07 03:34:04 +04:00
struct dm_list * arg_tags ,
2015-01-14 23:16:03 +03:00
int process_all_pvs ,
int process_all_devices ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2014-10-07 03:34:04 +04:00
process_single_pv_fn_t process_single_pv )
2014-10-07 01:02:00 +04:00
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
char uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
2014-10-07 03:34:04 +04:00
struct volume_group * vg ;
struct vgnameid_list * vgnl ;
const char * vg_name ;
const char * vg_uuid ;
2015-07-08 15:53:23 +03:00
uint32_t lockd_state = 0 ;
2014-10-07 01:02:00 +04:00
int ret_max = ECMD_PROCESSED ;
int ret ;
2014-11-15 00:00:35 +03:00
int skip ;
2015-10-23 23:09:20 +03:00
int notfound ;
2016-02-16 23:15:24 +03:00
int already_locked ;
2016-06-27 11:12:41 +03:00
int do_report_ret_code = 1 ;
2014-10-07 01:02:00 +04:00
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_VG ) ;
2014-11-14 12:50:31 +03:00
2016-05-20 14:26:02 +03:00
dm_list_iterate_items ( vgnl , all_vgnameids ) {
2014-10-07 03:34:04 +04:00
vg_name = vgnl - > vg_name ;
vg_uuid = vgnl - > vgid ;
2014-11-15 00:00:35 +03:00
skip = 0 ;
2015-10-23 23:09:20 +03:00
notfound = 0 ;
2014-10-07 01:02:00 +04:00
2016-05-20 14:26:02 +03:00
uuid [ 0 ] = ' \0 ' ;
2016-06-14 14:21:53 +03:00
if ( is_orphan_vg ( vg_name ) ) {
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_ORPHAN ) ;
log_set_report_object_name_and_id ( vg_name + sizeof ( VG_ORPHANS ) , uuid ) ;
} else {
if ( vg_uuid & & ! id_write_format ( ( const struct id * ) vg_uuid , uuid , sizeof ( uuid ) ) )
stack ;
log_set_report_object_name_and_id ( vg_name , uuid ) ;
}
2016-05-20 14:26:02 +03:00
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2015-03-05 23:00:44 +03:00
if ( ! lockd_vg ( cmd , vg_name , NULL , 0 , & lockd_state ) ) {
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2015-03-05 23:00:44 +03:00
continue ;
}
2016-02-16 23:15:24 +03:00
log_debug ( " Processing PVs in VG %s " , vg_name ) ;
already_locked = lvmcache_vgname_is_locked ( vg_name ) ;
2015-10-22 22:56:22 +03:00
vg = vg_read ( cmd , vg_name , vg_uuid , read_flags , lockd_state ) ;
2015-10-23 23:09:20 +03:00
if ( _ignore_vg ( vg , vg_name , NULL , read_flags , & skip , & notfound ) ) {
2014-11-14 12:50:31 +03:00
stack ;
2014-11-18 18:22:37 +03:00
ret_max = ECMD_FAILED ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret_max ) ;
2015-03-05 23:00:44 +03:00
if ( ! skip )
goto endvg ;
2015-03-19 02:31:46 +03:00
/* Drop through to eliminate a clustered VG's PVs from the devices list */
2014-11-15 00:00:35 +03:00
}
2015-10-23 23:09:20 +03:00
if ( notfound )
goto endvg ;
2014-11-15 00:00:35 +03:00
2014-11-18 18:22:37 +03:00
/*
* Don ' t continue when skip is set , because we need to remove
* vg - > pvs entries from devices list .
*/
2015-01-07 23:04:12 +03:00
ret = _process_pvs_in_vg ( cmd , vg , all_devices , arg_devices , arg_tags ,
2015-01-14 23:16:03 +03:00
process_all_pvs , process_all_devices , skip ,
handle , process_single_pv ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2014-11-18 18:22:37 +03:00
if ( ret > ret_max )
2014-10-07 03:34:04 +04:00
ret_max = ret ;
2016-02-16 23:15:24 +03:00
if ( ! skip & & ! already_locked )
lvmetad: two phase vg_update
Previously, a command sent lvmetad new VG metadata in vg_commit().
In vg_commit(), devices are suspended, so any memory allocation
done by the command while sending to lvmetad, or by lvmetad while
updating its cache could deadlock if memory reclaim was triggered.
Now lvmetad is updated in unlock_vg(), after devices are resumed.
The new method for updating VG metadata in lvmetad is in two phases:
1. In vg_write(), before devices are suspended, the command sends
lvmetad a short message ("set_vg_info") telling it what the new
VG seqno will be. lvmetad sees that the seqno is newer than
the seqno of its cached VG, so it sets the INVALID flag for the
cached VG. If sending the message to lvmetad fails, the command
fails before the metadata is committed and the change is not made.
If sending the message succeeds, vg_commit() is called.
2. In unlock_vg(), after devices are resumed, the command sends
lvmetad the standard vg_update message with the new metadata.
lvmetad sees that the seqno in the new metadata matches the
seqno it saved from set_vg_info, and knows it has the latest
copy, so it clears the INVALID flag for the cached VG.
If a command fails between 1 and 2 (after committing the VG on disk,
but before sending lvmetad the new metadata), the cached VG retains
the INVALID flag in lvmetad. A subsequent command will read the
cached VG from lvmetad, see the INVALID flag, ignore the cached
copy, read the VG from disk instead, update the lvmetad copy
with the latest copy from disk, (this clears the INVALID flag
in lvmetad), and use the correct VG metadata for the command.
(This INVALID mechanism already existed for use by lvmlockd.)
2016-06-08 22:42:03 +03:00
unlock_vg ( cmd , vg , vg - > name ) ;
2015-03-05 23:00:44 +03:00
endvg :
release_vg ( vg ) ;
2015-08-18 18:39:40 +03:00
if ( ! lockd_vg ( cmd , vg_name , " un " , 0 , & lockd_state ) )
2015-08-18 12:46:42 +03:00
stack ;
2014-11-15 00:00:35 +03:00
2014-10-07 03:34:04 +04:00
/* Quit early when possible. */
2016-05-23 16:27:09 +03:00
if ( ! process_all_pvs & & dm_list_empty ( arg_tags ) & & dm_list_empty ( arg_devices ) ) {
do_report_ret_code = 0 ;
2016-05-20 14:26:02 +03:00
goto_out ;
2016-05-23 16:27:09 +03:00
}
2014-10-07 01:02:00 +04:00
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
}
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2016-05-20 14:26:02 +03:00
out :
2016-05-23 16:27:09 +03:00
if ( do_report_ret_code )
report_log_ret_code ( ret_max ) ;
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-07 03:34:04 +04:00
return ret_max ;
}
2014-10-07 01:02:00 +04:00
2014-10-07 03:34:04 +04:00
int process_each_pv ( struct cmd_context * cmd ,
2016-02-16 23:15:24 +03:00
int argc , char * * argv , const char * only_this_vgname ,
int all_is_set , uint32_t read_flags ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
2014-10-07 03:34:04 +04:00
process_single_pv_fn_t process_single_pv )
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
2014-10-07 03:53:56 +04:00
struct dm_list arg_tags ; /* str_list */
struct dm_list arg_pvnames ; /* str_list */
2015-01-09 23:55:16 +03:00
struct dm_list arg_devices ; /* device_id_list */
2015-10-23 23:09:20 +03:00
struct dm_list arg_missed ; /* device_id_list */
2014-10-07 03:53:56 +04:00
struct dm_list all_vgnameids ; /* vgnameid_list */
2015-01-09 23:55:16 +03:00
struct dm_list all_devices ; /* device_id_list */
struct device_id_list * dil ;
2014-10-07 03:34:04 +04:00
int process_all_pvs ;
int process_all_devices ;
2016-02-16 23:15:24 +03:00
int orphans_locked ;
2014-11-15 00:00:35 +03:00
int ret_max = ECMD_PROCESSED ;
2014-10-07 03:34:04 +04:00
int ret ;
2014-10-07 01:02:00 +04:00
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_PV ) ;
2016-02-16 23:15:24 +03:00
log_debug ( " Processing each PV " ) ;
2015-10-22 22:56:22 +03:00
/*
* When processing a specific VG name , warn if it ' s inconsistent and
* print an error if it ' s not found . Otherwise we ' re processing all
* VGs , in which case the command doesn ' t care if the VG is inconsisent
* or not found ; it just wants to skip that VG . ( It may be not found
* if it was removed between creating the list of all VGs and then
* processing each VG .
*/
if ( only_this_vgname )
read_flags | = READ_WARN_INCONSISTENT ;
else
read_flags | = READ_OK_NOTFOUND ;
2015-03-05 23:00:44 +03:00
/* Disable error in vg_read so we can print it from ignore_vg. */
cmd - > vg_read_print_access_error = 0 ;
2015-02-27 01:06:32 +03:00
2014-10-07 03:34:04 +04:00
dm_list_init ( & arg_tags ) ;
dm_list_init ( & arg_pvnames ) ;
2015-01-07 23:04:12 +03:00
dm_list_init ( & arg_devices ) ;
2015-10-23 23:09:20 +03:00
dm_list_init ( & arg_missed ) ;
2014-10-07 03:34:04 +04:00
dm_list_init ( & all_vgnameids ) ;
dm_list_init ( & all_devices ) ;
2014-10-07 01:02:00 +04:00
2014-10-07 03:34:04 +04:00
/*
* Create two lists from argv :
* arg_pvnames : pvs explicitly named in argv
* arg_tags : tags explicitly named in argv
2015-01-07 23:04:12 +03:00
*
* Then convert arg_pvnames , which are free - form , user - specified ,
* names / paths into arg_devices which can be used to match below .
2014-10-07 03:34:04 +04:00
*/
2015-01-07 23:04:12 +03:00
if ( ( ret = _get_arg_pvnames ( cmd , argc , argv , & arg_pvnames , & arg_tags ) ) ! = ECMD_PROCESSED ) {
2016-05-20 14:26:02 +03:00
ret_max = ret ;
goto_out ;
2015-01-07 23:04:12 +03:00
}
2014-10-07 01:02:00 +04:00
2017-01-14 00:08:51 +03:00
if ( ( cmd - > cname - > flags & DISALLOW_TAG_ARGS ) & & ! dm_list_empty ( & arg_tags ) ) {
2016-06-03 17:56:48 +03:00
log_error ( " Tags cannot be used with this command. " ) ;
return ECMD_FAILED ;
}
2016-02-16 23:15:24 +03:00
orphans_locked = lvmcache_vgname_is_locked ( VG_ORPHANS ) ;
2014-10-07 03:34:04 +04:00
process_all_pvs = dm_list_empty ( & arg_pvnames ) & & dm_list_empty ( & arg_tags ) ;
2014-10-07 01:02:00 +04:00
2017-01-14 00:08:51 +03:00
process_all_devices = process_all_pvs & & ( cmd - > cname - > flags & ENABLE_ALL_DEVS ) & & all_is_set ;
2015-01-07 23:04:12 +03:00
2015-03-05 23:00:44 +03:00
/* Needed for a current listing of the global VG namespace. */
2016-05-20 14:26:02 +03:00
if ( ! only_this_vgname & & ! lockd_gl ( cmd , " sh " , 0 ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2015-03-05 23:00:44 +03:00
2015-12-11 23:02:36 +03:00
/*
* This full scan would be done by _get_all_devices ( ) if
* it were not done here first . It ' s called here first
* so that get_vgnameids ( ) will look at any new devices .
2016-02-16 23:15:24 +03:00
* When orphans is already locked , these steps are done
* before process_each_pv is called .
2015-12-11 23:02:36 +03:00
*/
2016-02-16 23:15:24 +03:00
if ( ! trust_cache ( ) & & ! orphans_locked ) {
log_debug ( " Scanning for available devices " ) ;
2015-12-14 23:14:59 +03:00
lvmcache_destroy ( cmd , 1 , 0 ) ;
2016-02-16 23:15:24 +03:00
dev_cache_full_scan ( cmd - > full_filter ) ;
2015-12-14 23:14:59 +03:00
}
2015-12-11 23:02:36 +03:00
2015-05-06 00:24:50 +03:00
if ( ! get_vgnameids ( cmd , & all_vgnameids , only_this_vgname , 1 ) ) {
2016-05-20 14:26:02 +03:00
ret_max = ret ;
goto_out ;
toollib: fix duplicate handling in process_each_pv
With use_lvmetad=0, duplicate PVs /dev/loop0 and /dev/loop1,
where in this example, /dev/loop1 is the cached device
referenced by pv->dev, the command 'pvs /dev/loop0' reports:
Failed to find physical volume "/dev/loop0".
This is because the duplicate PV detection by pvid is
not working because _get_all_devices() is not setting
any dev->pvid for any entries. This is because the
pvid information has not yet been saved in lvmcache.
This is fixed by calling _get_vgnameids_on_system()
before _get_all_devices(), which has the effect of
caching the necessary pvid information.
With this fix, running pvs /dev/loop0, or pvs /dev/loop1,
produces no error and one line of output for the PV (the
device printed is the one cached in pv->dev, in this
example /dev/loop1.)
Running 'pvs /dev/loop0 /dev/loop1' produces no error
and two lines of output, with each device displayed
on one of the lines.
Running 'pvs -a' shows two PVs, one with loop0 and one
with loop1, and both shown as a member of the same VG.
Running 'pvs' shows only one of the duplicate PVs,
and that shows the device cached in pv->dev (loop1).
The above output is what the duplicate handling code
was previously designed to output in commits:
b64da4d8b521 toollib: search for duplicate PVs only when needed
3a7c47af0e88 toollib: pvs -a should display VG name for each duplicate PV
57d74a45a05e toollib: override the PV device with duplicates
c1f246fedfc3 toollib: handle duplicate pvs in process_in_pv
As a further step after this, we may choose to change
some of those.
For all of these commands, a warning is printed about
the existence of the duplicate PVs:
Found duplicate PV ...: using /dev/loop1 not /dev/loop0
2015-04-20 22:35:35 +03:00
}
2014-10-07 03:34:04 +04:00
/*
* If the caller wants to process all devices ( not just PVs ) , then all PVs
* from all VGs are processed first , removing them from all_devices . Then
* any devs remaining in all_devices are processed .
*/
2017-09-19 17:19:24 +03:00
if ( ( ret = _get_all_devices ( cmd , & all_devices ) ) ! = ECMD_PROCESSED ) {
2016-05-20 14:26:02 +03:00
ret_max = ret ;
goto_out ;
2014-10-07 03:34:04 +04:00
}
2014-10-07 01:02:00 +04:00
2015-10-27 00:27:26 +03:00
if ( ( ret = _get_arg_devices ( cmd , & arg_pvnames , & arg_devices ) ) ! = ECMD_PROCESSED )
2015-03-19 02:34:46 +03:00
/* get_arg_devices reports the error for any PV names not found. */
ret_max = ECMD_FAILED ;
2015-10-22 22:56:22 +03:00
ret = _process_pvs_in_vgs ( cmd , read_flags , & all_vgnameids , & all_devices ,
2015-01-14 23:16:03 +03:00
& arg_devices , & arg_tags ,
process_all_pvs , process_all_devices ,
2014-11-15 00:00:35 +03:00
handle , process_single_pv ) ;
if ( ret ! = ECMD_PROCESSED )
lvmcache: process duplicate PVs directly
Previously, duplicate PVs were processed as a side effect
of processing the "chosen" PV in lvmcache. The duplicate
PV would be hacked into lvmcache temporarily in place of
the chosen PV.
In the old way, we had to always process the "chosen" PV
device, even if a duplicate of it was named on the command
line. This meant we were processing a different device than
was asked for. This could be worked around by naming
multiple duplicate devs on the command line in which case
they were swapped in and out of lvmcache for processing.
Now, the duplicate devs are processed directly in their
own processing loop. This means we can remove the old
hacks related to processing dups as a side effect of
processing the chosen device. We can now simply process
the device that was named on the command line.
When the same PVID exists on two or more devices, one device
is preferred and used in the VG, and the others are duplicates
and are not used in the VG. The preferred device exists in
lvmcache as usual. The duplicates exist in a specical list
of unused duplicate devices.
The duplicate devs have the "d" attribute and the "duplicate"
reporting field displays "duplicate" for them.
'pvs' warns about duplicates, but the formal output only
includes the single preferred PV.
'pvs -a' has the same warnings, and the duplicate devs are
included in the output.
'pvs <path>' has the same warnings, and displays the named
device, whether it is preferred or a duplicate.
2016-02-11 21:37:36 +03:00
stack ;
if ( ret > ret_max )
ret_max = ret ;
/*
* Process the list of unused duplicate devs so they can be shown by
* report / display commands . These are the devices that were not chosen
* to be used in lvmcache because another device with the same PVID was
* preferred . The unused duplicate devs are not seen by
* _process_pvs_in_vgs , which only sees the preferred device for the
* PVID .
*
* The main purpose in reporting / displaying the unused duplicate PVs
* here is so that they do not appear to be unused / free devices or
* orphans .
*
* We do not allow modifying the unused duplicate PVs . To modify a
* non - preferred duplicate PV , e . g . pvchange - u , a filter needs to be
* used with the command to exclude the other devices with the same
* PVID . This results in the command seeing only the one device with
* the PVID and allows it to be changed . ( If the duplicates actually
* represent the same underlying storage , these precautions are
* unnecessary , but lvm can ' t tell when the duplicates are different
* paths to the same storage or different underlying storage . )
*
* Even the preferred duplicate PV in lvmcache is limitted from being
* modified ( by allow_changes_with_duplicate_pvs setting ) , because lvm
* cannot be sure that the preferred duplicate device is the correct one ,
* e . g . if a VG has two PVs , and both PVs are cloned , lvm might prefer
* one of the original PVs and one of the cloned PVs , pairing them
* together as the VG . Any changes on the VG or PVs in that state would
* end up changing one of the original PVs and one of the cloned PVs .
*
* vgimportclone of the two cloned PVs changes their PV UUIDs and gives
* them a new VG name .
*/
ret = _process_duplicate_pvs ( cmd , & all_devices , & arg_devices , process_all_devices ,
handle , process_single_pv ) ;
if ( ret ! = ECMD_PROCESSED )
2014-11-14 12:50:31 +03:00
stack ;
2014-11-15 00:00:35 +03:00
if ( ret > ret_max )
ret_max = ret ;
2014-10-07 03:34:04 +04:00
2016-02-16 23:15:24 +03:00
/*
* If the orphans lock was held , there shouldn ' t be missed devices . If
* there were , we cannot clear the cache while holding the orphans lock
* anyway .
*/
if ( orphans_locked )
goto skip_missed ;
2015-10-23 23:09:20 +03:00
/*
* Some PVs may have been missed by the first search if another command
* moved them at the same time . Repeat the search for only the
* specific PVs missed . lvmcache needs clearing for a fresh search .
*
* If missed PVs are found in this repeated search , they are removed
* from the arg_missed list , but they also need to be removed from the
* arg_devices list , otherwise the check at the end will produce an
* error , thinking they weren ' t found . This is the reason for saving
* and comparing the original arg_missed list .
*/
if ( ! process_all_pvs )
_get_missed_pvs ( cmd , & arg_devices , & arg_missed ) ;
else
_get_missed_pvs ( cmd , & all_devices , & arg_missed ) ;
if ( ! dm_list_empty ( & arg_missed ) ) {
struct dm_list arg_missed_orig ;
dm_list_init ( & arg_missed_orig ) ;
_device_list_copy ( cmd , & arg_missed , & arg_missed_orig ) ;
2015-10-27 20:03:57 +03:00
log_verbose ( " Some PVs were not found in first search, retrying. " ) ;
2015-10-23 23:09:20 +03:00
lvmcache_destroy ( cmd , 0 , 0 ) ;
2015-11-09 11:47:21 +03:00
if ( ! lvmcache_init ( ) ) {
log_error ( " Failed to initalize lvm cache. " ) ;
ret_max = ECMD_FAILED ;
goto out ;
}
2015-10-23 23:09:20 +03:00
lvmcache_seed_infos_from_lvmetad ( cmd ) ;
ret = _process_pvs_in_vgs ( cmd , read_flags , & all_vgnameids , & all_devices ,
& arg_missed , & arg_tags , 0 , 0 ,
handle , process_single_pv ) ;
if ( ret ! = ECMD_PROCESSED )
stack ;
if ( ret > ret_max )
ret_max = ret ;
/* Devices removed from arg_missed are removed from arg_devices. */
dm_list_iterate_items ( dil , & arg_missed_orig ) {
if ( ! _device_list_find_dev ( & arg_missed , dil - > dev ) )
_device_list_remove ( & arg_devices , dil - > dev ) ;
}
}
2016-02-16 23:15:24 +03:00
skip_missed :
2015-01-09 23:55:16 +03:00
dm_list_iterate_items ( dil , & arg_devices ) {
log_error ( " Failed to find physical volume \" %s \" . " , dev_name ( dil - > dev ) ) ;
2015-01-07 23:04:12 +03:00
ret_max = ECMD_FAILED ;
}
2014-11-15 00:00:35 +03:00
if ( ! process_all_devices )
goto out ;
2014-10-07 03:34:04 +04:00
2014-11-15 00:00:35 +03:00
ret = _process_device_list ( cmd , & all_devices , handle , process_single_pv ) ;
if ( ret ! = ECMD_PROCESSED )
stack ;
if ( ret > ret_max )
ret_max = ret ;
out :
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-07 01:02:00 +04:00
return ret_max ;
2014-10-07 03:34:04 +04:00
}
int process_each_pv_in_vg ( struct cmd_context * cmd , struct volume_group * vg ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle ,
process_single_pv_fn_t process_single_pv )
2014-10-07 03:34:04 +04:00
{
2016-05-20 14:26:02 +03:00
log_report_t saved_log_report_state = log_get_report_state ( ) ;
char pv_uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
char vg_uuid [ 64 ] __attribute__ ( ( aligned ( 8 ) ) ) ;
2014-12-03 16:20:00 +03:00
int whole_selected = 0 ;
2014-10-07 03:34:04 +04:00
int ret_max = ECMD_PROCESSED ;
int ret ;
2016-05-23 16:27:09 +03:00
int do_report_ret_code = 1 ;
2014-10-07 03:34:04 +04:00
struct pv_list * pvl ;
2014-10-07 01:02:00 +04:00
2016-05-20 14:26:02 +03:00
log_set_report_object_type ( LOG_REPORT_OBJECT_TYPE_PV ) ;
vg_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & vg - > id , vg_uuid , sizeof ( vg_uuid ) ) )
stack ;
2016-06-14 14:21:53 +03:00
if ( ! is_orphan_vg ( vg - > name ) )
log_set_report_object_group_and_group_id ( vg - > name , vg_uuid ) ;
2016-05-20 14:26:02 +03:00
2014-10-07 03:34:04 +04:00
dm_list_iterate_items ( pvl , & vg - > pvs ) {
2016-05-20 14:26:02 +03:00
pv_uuid [ 0 ] = ' \0 ' ;
if ( ! id_write_format ( & pvl - > pv - > id , pv_uuid , sizeof ( pv_uuid ) ) )
stack ;
log_set_report_object_name_and_id ( pv_dev_name ( pvl - > pv ) , pv_uuid ) ;
if ( sigint_caught ( ) ) {
ret_max = ECMD_FAILED ;
goto_out ;
}
2014-11-14 21:32:03 +03:00
2014-11-15 00:00:35 +03:00
ret = process_single_pv ( cmd , vg , pvl - > pv , handle ) ;
2014-12-03 16:20:00 +03:00
_update_selection_result ( handle , & whole_selected ) ;
2014-11-15 00:00:35 +03:00
if ( ret ! = ECMD_PROCESSED )
stack ;
2016-05-23 16:27:09 +03:00
report_log_ret_code ( ret ) ;
2014-11-14 21:32:03 +03:00
if ( ret > ret_max )
2014-10-07 03:34:04 +04:00
ret_max = ret ;
2016-05-20 14:26:02 +03:00
log_set_report_object_name_and_id ( NULL , NULL ) ;
2014-10-07 03:34:04 +04:00
}
2014-12-03 16:20:00 +03:00
_set_final_selection_result ( handle , whole_selected ) ;
2016-05-23 16:27:09 +03:00
do_report_ret_code = 0 ;
2016-05-20 14:26:02 +03:00
out :
2016-05-23 16:27:09 +03:00
if ( do_report_ret_code )
report_log_ret_code ( ret_max ) ;
2016-05-20 14:26:02 +03:00
log_restore_report_state ( saved_log_report_state ) ;
2014-10-07 03:34:04 +04:00
return ret_max ;
2014-10-07 01:02:00 +04:00
}
2014-10-07 19:45:45 +04:00
int lvremove_single ( struct cmd_context * cmd , struct logical_volume * lv ,
2014-11-27 17:02:13 +03:00
struct processing_handle * handle __attribute__ ( ( unused ) ) )
2014-10-07 19:45:45 +04:00
{
/*
* Single force is equivalent to single - - yes
* Even multiple - - yes are equivalent to single - - force
* When we require - ff it cannot be replaced with - f - y
*/
force_t force = ( force_t ) arg_count ( cmd , force_ARG )
? : ( arg_is_set ( cmd , yes_ARG ) ? DONT_PROMPT : PROMPT ) ;
if ( ! lv_remove_with_dependencies ( cmd , lv , force , 0 ) )
return_ECMD_FAILED ;
return ECMD_PROCESSED ;
}
2016-02-16 23:15:24 +03:00
2016-02-19 00:38:23 +03:00
int pvcreate_params_from_args ( struct cmd_context * cmd , struct pvcreate_params * pp )
2016-02-16 23:15:24 +03:00
{
pp - > yes = arg_count ( cmd , yes_ARG ) ;
pp - > force = ( force_t ) arg_count ( cmd , force_ARG ) ;
if ( arg_int_value ( cmd , labelsector_ARG , 0 ) > = LABEL_SCAN_SECTORS ) {
log_error ( " labelsector must be less than %lu. " ,
LABEL_SCAN_SECTORS ) ;
return 0 ;
}
2017-07-19 17:16:12 +03:00
pp - > pva . label_sector = arg_int64_value ( cmd , labelsector_ARG ,
DEFAULT_LABELSECTOR ) ;
2016-02-16 23:15:24 +03:00
if ( ! ( cmd - > fmt - > features & FMT_MDAS ) & &
2016-06-22 00:24:52 +03:00
( arg_is_set ( cmd , pvmetadatacopies_ARG ) | |
arg_is_set ( cmd , metadatasize_ARG ) | |
arg_is_set ( cmd , dataalignment_ARG ) | |
arg_is_set ( cmd , dataalignmentoffset_ARG ) ) ) {
2016-02-16 23:15:24 +03:00
log_error ( " Metadata and data alignment parameters only "
" apply to text format. " ) ;
return 0 ;
}
if ( ! ( cmd - > fmt - > features & FMT_BAS ) & &
2016-06-22 00:24:52 +03:00
arg_is_set ( cmd , bootloaderareasize_ARG ) ) {
2016-02-16 23:15:24 +03:00
log_error ( " Bootloader area parameters only "
" apply to text format. " ) ;
return 0 ;
}
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , metadataignore_ARG ) )
2016-02-19 00:31:27 +03:00
pp - > pva . metadataignore = arg_int_value ( cmd , metadataignore_ARG ,
2016-02-16 23:15:24 +03:00
DEFAULT_PVMETADATAIGNORE ) ;
else
2016-02-19 00:31:27 +03:00
pp - > pva . metadataignore = find_config_tree_bool ( cmd , metadata_pvmetadataignore_CFG , NULL ) ;
2016-02-16 23:15:24 +03:00
2016-06-22 00:24:52 +03:00
if ( arg_is_set ( cmd , pvmetadatacopies_ARG ) & &
2016-02-16 23:15:24 +03:00
! arg_int_value ( cmd , pvmetadatacopies_ARG , - 1 ) & &
2016-02-19 00:31:27 +03:00
pp - > pva . metadataignore ) {
2017-06-23 11:59:12 +03:00
log_error ( " metadataignore only applies to metadatacopies > 0. " ) ;
2016-02-16 23:15:24 +03:00
return 0 ;
}
pp - > zero = arg_int_value ( cmd , zero_ARG , 1 ) ;
if ( arg_sign_value ( cmd , dataalignment_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
log_error ( " Physical volume data alignment may not be negative. " ) ;
return 0 ;
}
2016-02-19 00:31:27 +03:00
pp - > pva . data_alignment = arg_uint64_value ( cmd , dataalignment_ARG , UINT64_C ( 0 ) ) ;
2016-02-16 23:15:24 +03:00
2016-02-19 00:31:27 +03:00
if ( pp - > pva . data_alignment > UINT32_MAX ) {
2016-02-16 23:15:24 +03:00
log_error ( " Physical volume data alignment is too big. " ) ;
return 0 ;
}
if ( arg_sign_value ( cmd , dataalignmentoffset_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
2017-06-23 11:59:12 +03:00
log_error ( " Physical volume data alignment offset may not be negative. " ) ;
2016-02-16 23:15:24 +03:00
return 0 ;
}
2016-02-19 00:31:27 +03:00
pp - > pva . data_alignment_offset = arg_uint64_value ( cmd , dataalignmentoffset_ARG , UINT64_C ( 0 ) ) ;
2016-02-16 23:15:24 +03:00
2016-02-19 00:31:27 +03:00
if ( pp - > pva . data_alignment_offset > UINT32_MAX ) {
2016-02-16 23:15:24 +03:00
log_error ( " Physical volume data alignment offset is too big. " ) ;
return 0 ;
}
2016-02-19 00:31:27 +03:00
if ( ( pp - > pva . data_alignment + pp - > pva . data_alignment_offset ) & &
( pp - > pva . pe_start ! = PV_PE_START_CALC ) ) {
if ( ( pp - > pva . data_alignment ? pp - > pva . pe_start % pp - > pva . data_alignment : pp - > pva . pe_start ) ! = pp - > pva . data_alignment_offset ) {
2016-02-16 23:15:24 +03:00
log_warn ( " WARNING: Ignoring data alignment %s "
2017-06-23 11:59:12 +03:00
" incompatible with restored pe_start value %s. " ,
2016-02-19 00:31:27 +03:00
display_size ( cmd , pp - > pva . data_alignment + pp - > pva . data_alignment_offset ) ,
display_size ( cmd , pp - > pva . pe_start ) ) ;
pp - > pva . data_alignment = 0 ;
pp - > pva . data_alignment_offset = 0 ;
2016-02-16 23:15:24 +03:00
}
}
if ( arg_sign_value ( cmd , metadatasize_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
log_error ( " Metadata size may not be negative. " ) ;
return 0 ;
}
if ( arg_sign_value ( cmd , bootloaderareasize_ARG , SIGN_NONE ) = = SIGN_MINUS ) {
log_error ( " Bootloader area size may not be negative. " ) ;
return 0 ;
}
2016-02-19 00:31:27 +03:00
pp - > pva . pvmetadatasize = arg_uint64_value ( cmd , metadatasize_ARG , UINT64_C ( 0 ) ) ;
if ( ! pp - > pva . pvmetadatasize )
pp - > pva . pvmetadatasize = find_config_tree_int ( cmd , metadata_pvmetadatasize_CFG , NULL ) ;
2016-02-16 23:15:24 +03:00
2016-02-19 00:31:27 +03:00
pp - > pva . pvmetadatacopies = arg_int_value ( cmd , pvmetadatacopies_ARG , - 1 ) ;
if ( pp - > pva . pvmetadatacopies < 0 )
pp - > pva . pvmetadatacopies = find_config_tree_int ( cmd , metadata_pvmetadatacopies_CFG , NULL ) ;
2016-02-16 23:15:24 +03:00
2016-02-19 00:31:27 +03:00
pp - > pva . ba_size = arg_uint64_value ( cmd , bootloaderareasize_ARG , pp - > pva . ba_size ) ;
2016-02-16 23:15:24 +03:00
return 1 ;
}
enum {
PROMPT_PVCREATE_PV_IN_VG = 1 ,
2016-02-17 00:00:50 +03:00
PROMPT_PVREMOVE_PV_IN_VG = 2 ,
2017-04-27 20:13:09 +03:00
PROMPT_PVCREATE_DEV_SIZE = 4 ,
2016-02-16 23:15:24 +03:00
} ;
enum {
PROMPT_ANSWER_NO = 1 ,
PROMPT_ANSWER_YES = 2
} ;
/*
* When a prompt entry is created , save any strings or info
* in this struct that are needed for the prompt messages .
* The VG / PV structs are not be available when the prompt
* is run .
*/
struct pvcreate_prompt {
struct dm_list list ;
uint32_t type ;
2017-04-27 20:13:09 +03:00
uint64_t size ;
uint64_t new_size ;
2016-02-16 23:15:24 +03:00
const char * pv_name ;
const char * vg_name ;
struct device * dev ;
int answer ;
unsigned abort_command : 1 ;
unsigned vg_name_unknown : 1 ;
} ;
struct pvcreate_device {
struct dm_list list ;
const char * name ;
struct device * dev ;
char pvid [ ID_LEN + 1 ] ;
const char * vg_name ;
int wiped ;
unsigned is_not_pv : 1 ; /* device is not a PV */
unsigned is_orphan_pv : 1 ; /* device is an orphan PV */
unsigned is_vg_pv : 1 ; /* device is a PV used in a VG */
unsigned is_used_unknown_pv : 1 ; /* device is a PV used in an unknown VG */
} ;
2016-02-17 00:00:50 +03:00
/*
* If a PV is in a VG , and pvcreate or pvremove is run on it :
*
* pvcreate | pvremove - f : fails
* pvcreate | pvremove - y : fails
* pvcreate | pvremove - f - y : fails
* pvcreate | pvremove - ff : get y / n prompt
* pvcreate | pvremove - ff - y : succeeds
*
* FIXME : there are a lot of various phrasings used depending on the
* command and specific case . Find some similar way to phrase these .
*/
2016-02-16 23:15:24 +03:00
static void _check_pvcreate_prompt ( struct cmd_context * cmd ,
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp ,
2016-02-16 23:15:24 +03:00
struct pvcreate_prompt * prompt ,
int ask )
{
2016-02-17 00:00:50 +03:00
const char * vgname = prompt - > vg_name ? prompt - > vg_name : " <unknown> " ;
const char * pvname = prompt - > pv_name ;
2017-04-27 20:13:09 +03:00
int answer_yes = 0 ;
int answer_no = 0 ;
2016-02-17 00:00:50 +03:00
/* The VG name can be unknown when the PV is used but metadata is not available */
2017-04-27 20:13:09 +03:00
if ( prompt - > type & PROMPT_PVCREATE_PV_IN_VG ) {
2016-02-16 23:15:24 +03:00
if ( pp - > force ! = DONT_PROMPT_OVERRIDE ) {
2017-04-27 20:13:09 +03:00
answer_no = 1 ;
2016-02-16 23:15:24 +03:00
if ( prompt - > vg_name_unknown ) {
2016-02-25 23:12:08 +03:00
log_error ( " PV %s is used by a VG but its metadata is missing. " , pvname ) ;
2016-02-17 00:00:50 +03:00
log_error ( " Can't initialize PV '%s' without -ff. " , pvname ) ;
2016-02-16 23:15:24 +03:00
} else if ( ! strcmp ( command_name ( cmd ) , " pvcreate " ) ) {
2016-02-17 00:00:50 +03:00
log_error ( " Can't initialize physical volume \" %s \" of volume group \" %s \" without -ff " , pvname , vgname ) ;
2016-02-16 23:15:24 +03:00
} else {
2016-02-17 00:00:50 +03:00
log_error ( " Physical volume '%s' is already in volume group '%s' " , pvname , vgname ) ;
log_error ( " Unable to add physical volume '%s' to volume group '%s' " , pvname , vgname ) ;
2016-02-16 23:15:24 +03:00
}
} else if ( pp - > yes ) {
2017-04-27 20:13:09 +03:00
answer_yes = 1 ;
2016-02-16 23:15:24 +03:00
} else if ( ask ) {
2016-02-17 00:00:50 +03:00
if ( yes_no_prompt ( " Really INITIALIZE physical volume \" %s \" of volume group \" %s \" [y/n]? " , pvname , vgname ) = = ' n ' ) {
2017-04-27 20:13:09 +03:00
answer_no = 1 ;
2016-02-17 00:00:50 +03:00
} else {
2017-04-27 20:13:09 +03:00
answer_yes = 1 ;
2016-02-17 00:00:50 +03:00
log_warn ( " WARNING: Forcing physical volume creation on %s of volume group \" %s \" " , pvname , vgname ) ;
}
}
2016-02-16 23:15:24 +03:00
2017-04-27 20:13:09 +03:00
}
if ( prompt - > type & PROMPT_PVCREATE_DEV_SIZE ) {
if ( pp - > yes ) {
log_warn ( " WARNING: Faking size of PV %s. Don't write outside real device. " , pvname ) ;
answer_yes = 1 ;
} else if ( ask ) {
if ( prompt - > new_size ! = prompt - > size ) {
if ( yes_no_prompt ( " WARNING: %s: device size %s does not match requested size %s. Proceed? [y/n]: " , pvname ,
2017-07-20 10:57:09 +03:00
display_size ( cmd , prompt - > size ) ,
display_size ( cmd , prompt - > new_size ) ) = = ' n ' ) {
2017-04-27 20:13:09 +03:00
answer_no = 1 ;
} else {
answer_yes = 1 ;
log_warn ( " WARNING: Faking size of PV %s. Don't write outside real device. " , pvname ) ;
}
}
}
}
if ( prompt - > type & PROMPT_PVREMOVE_PV_IN_VG ) {
2016-02-17 00:00:50 +03:00
if ( pp - > force ! = DONT_PROMPT_OVERRIDE ) {
2017-04-27 20:13:09 +03:00
answer_no = 1 ;
2016-02-17 00:00:50 +03:00
if ( prompt - > vg_name_unknown )
2016-02-25 23:12:08 +03:00
log_error ( " PV %s is used by a VG but its metadata is missing. " , pvname ) ;
2016-02-17 00:00:50 +03:00
else
2016-02-25 23:12:08 +03:00
log_error ( " PV %s is used by VG %s so please use vgreduce first. " , pvname , vgname ) ;
2016-02-17 00:00:50 +03:00
log_error ( " (If you are certain you need pvremove, then confirm by using --force twice.) " ) ;
} else if ( pp - > yes ) {
2017-06-23 11:59:12 +03:00
log_warn ( " WARNING: PV %s is used by VG %s. " , pvname , vgname ) ;
2017-04-27 20:13:09 +03:00
answer_yes = 1 ;
2016-02-17 00:00:50 +03:00
} else if ( ask ) {
2017-06-23 11:59:12 +03:00
log_warn ( " WARNING: PV %s is used by VG %s. " , pvname , vgname ) ;
2017-04-27 20:13:09 +03:00
if ( yes_no_prompt ( " Really WIPE LABELS from physical volume \" %s \" of volume group \" %s \" [y/n]? " , pvname , vgname ) = = ' n ' )
answer_no = 1 ;
else
answer_yes = 1 ;
2016-02-16 23:15:24 +03:00
}
2017-04-27 20:13:09 +03:00
}
2016-02-17 00:00:50 +03:00
2017-04-27 20:13:09 +03:00
if ( answer_yes & & answer_no ) {
log_warn ( " WARNING: prompt answer yes is overriden by prompt answer no. " ) ;
answer_yes = 0 ;
2016-02-16 23:15:24 +03:00
}
2017-04-27 20:13:09 +03:00
/*
* no answer is valid when not asking the user .
* the caller uses this to check if all the prompts
* can be answered automatically without prompts .
*/
if ( ! ask & & ! answer_yes & & ! answer_no )
return ;
if ( answer_no )
prompt - > answer = PROMPT_ANSWER_NO ;
else if ( answer_yes )
prompt - > answer = PROMPT_ANSWER_YES ;
/*
* Mostly historical messages . Other messages above could be moved
* here to separate the answer logic from the messages .
*/
if ( ( prompt - > type & ( PROMPT_PVCREATE_DEV_SIZE | PROMPT_PVCREATE_PV_IN_VG ) ) & &
( prompt - > answer = = PROMPT_ANSWER_NO ) )
log_error ( " %s: physical volume not initialized. " , pvname ) ;
if ( ( prompt - > type & PROMPT_PVREMOVE_PV_IN_VG ) & &
( prompt - > answer = = PROMPT_ANSWER_NO ) )
log_error ( " %s: physical volume label not removed. " , pvname ) ;
if ( ( prompt - > type & PROMPT_PVREMOVE_PV_IN_VG ) & &
( prompt - > answer = = PROMPT_ANSWER_YES ) & &
( pp - > force = = DONT_PROMPT_OVERRIDE ) )
log_warn ( " WARNING: Wiping physical volume label from %s of volume group \" %s \" . " , pvname , vgname ) ;
2016-02-16 23:15:24 +03:00
}
static struct pvcreate_device * _pvcreate_list_find_dev ( struct dm_list * devices , struct device * dev )
{
struct pvcreate_device * pd ;
dm_list_iterate_items ( pd , devices ) {
if ( pd - > dev = = dev )
return pd ;
}
return NULL ;
}
static struct pvcreate_device * _pvcreate_list_find_name ( struct dm_list * devices , const char * name )
{
struct pvcreate_device * pd ;
dm_list_iterate_items ( pd , devices ) {
if ( ! strcmp ( pd - > name , name ) )
return pd ;
}
return NULL ;
}
/*
* If this function decides that a arg_devices entry cannot be used , but the
* command might be able to continue without it , then it moves that entry from
* arg_devices to arg_fail .
*
* If this function decides that an arg_devices entry could be used ( possibly
* requiring a prompt ) , then it moves the entry from arg_devices to arg_process .
*
* Any arg_devices entries that are not moved to arg_fail or arg_process were
* not found . The caller will decide if the command can continue if any
* arg_devices entries were not found , or if any were moved to arg_fail .
*
* This check does not need to look at PVs in foreign , shared or clustered VGs .
* If pvcreate / vgcreate / vgextend specifies a device in a
* foreign / shared / clustered VG , that VG will not be processed by this function ,
* and the arg will be reported as not found .
*/
2016-02-17 00:00:50 +03:00
static int _pvcreate_check_single ( struct cmd_context * cmd ,
struct volume_group * vg ,
struct physical_volume * pv ,
struct processing_handle * handle )
2016-02-16 23:15:24 +03:00
{
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp = ( struct pvcreate_params * ) handle - > custom_handle ;
2016-02-16 23:15:24 +03:00
struct pvcreate_device * pd ;
struct pvcreate_prompt * prompt ;
2017-04-27 20:13:09 +03:00
uint64_t size = 0 ;
uint64_t new_size = 0 ;
int need_size_prompt = 0 ;
int need_vg_prompt = 0 ;
2016-02-16 23:15:24 +03:00
int found = 0 ;
if ( ! pv - > dev )
return 1 ;
/*
* Check if one of the command args in arg_devices
* matches this device .
*/
dm_list_iterate_items ( pd , & pp - > arg_devices ) {
2016-05-04 19:28:28 +03:00
if ( pd - > dev ! = pv - > dev )
2016-02-16 23:15:24 +03:00
continue ;
if ( pv - > dev - > pvid [ 0 ] )
strncpy ( pd - > pvid , pv - > dev - > pvid , ID_LEN ) ;
found = 1 ;
break ;
}
/*
* Check if the uuid specified for the new PV is used by another PV .
*/
2016-02-19 00:31:27 +03:00
if ( ! found & & pv - > dev & & pp - > uuid_str & & id_equal ( & pv - > id , & pp - > pva . id ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " UUID %s already in use on \" %s \" . " , pp - > uuid_str , pv_dev_name ( pv ) ) ;
2016-02-16 23:15:24 +03:00
pp - > check_failed = 1 ;
return 0 ;
}
if ( ! found )
return 1 ;
2016-05-04 20:11:13 +03:00
log_debug ( " Checking pvcreate arg %s which has existing PVID: %.32s. " ,
pv_dev_name ( pv ) , pv - > dev - > pvid [ 0 ] ? pv - > dev - > pvid : " <none> " ) ;
2016-02-16 23:15:24 +03:00
/*
* This test will fail if the device belongs to an MD array .
*/
if ( ! dev_test_excl ( pv - > dev ) ) {
/* FIXME Detect whether device-mapper itself is still using it */
log_error ( " Can't open %s exclusively. Mounted filesystem? " ,
pv_dev_name ( pv ) ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
return 1 ;
}
2016-06-06 23:39:51 +03:00
/*
* Don ' t allow using a device with duplicates .
*/
if ( lvmcache_pvid_in_unchosen_duplicates ( pd - > dev - > pvid ) ) {
log_error ( " Cannot use device %s with duplicates. " , pd - > name ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
return 1 ;
}
2016-02-16 23:15:24 +03:00
/*
* What kind of device is this : an orphan PV , an uninitialized / unused
* device , a PV used in a VG .
*/
if ( vg & & ! is_orphan_vg ( vg - > name ) ) {
/* Device is a PV used in a VG. */
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvcreate arg %s: pv is used in %s. " , pd - > name , vg - > name ) ;
2016-02-16 23:15:24 +03:00
pd - > is_vg_pv = 1 ;
pd - > vg_name = dm_pool_strdup ( cmd - > mem , vg - > name ) ;
} else if ( vg & & is_orphan_vg ( vg - > name ) ) {
if ( is_used_pv ( pv ) ) {
/* Device is used in an unknown VG. */
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvcreate arg %s: PV is used in unknown VG. " , pd - > name ) ;
2016-02-16 23:15:24 +03:00
pd - > is_used_unknown_pv = 1 ;
} else {
/* Device is an orphan PV. */
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvcreate arg %s: PV is orphan in %s. " , pd - > name , vg - > name ) ;
2016-02-16 23:15:24 +03:00
pd - > is_orphan_pv = 1 ;
}
if ( ! strcmp ( vg - > name , FMT_LVM1_ORPHAN_VG_NAME ) )
pp - > orphan_vg_name = FMT_LVM1_ORPHAN_VG_NAME ;
else
pp - > orphan_vg_name = FMT_TEXT_ORPHAN_VG_NAME ;
} else {
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvcreate arg %s: device is not a PV. " , pd - > name ) ;
2016-02-16 23:15:24 +03:00
/* Device is not a PV. */
pd - > is_not_pv = 1 ;
}
2017-04-27 20:13:09 +03:00
if ( arg_is_set ( cmd , setphysicalvolumesize_ARG ) ) {
new_size = arg_uint64_value ( cmd , setphysicalvolumesize_ARG , UINT64_C ( 0 ) ) ;
if ( ! dev_get_size ( pv - > dev , & size ) ) {
log_error ( " Can't get device size of %s. " , pv_dev_name ( pv ) ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
return 1 ;
2017-07-19 17:16:12 +03:00
}
if ( new_size ! = size )
2017-04-27 20:13:09 +03:00
need_size_prompt = 1 ;
}
2016-02-16 23:15:24 +03:00
/*
* pvcreate is being run on this device , and it ' s not a PV ,
* or is an orphan PV . Neither case requires a prompt .
2017-04-27 20:13:09 +03:00
* Or , pvcreate is being run on this device , but the device
* is already a PV in a VG . A prompt or force option is required
* to use it .
2016-02-16 23:15:24 +03:00
*/
2017-04-27 20:13:09 +03:00
if ( pd - > is_orphan_pv | | pd - > is_not_pv )
need_vg_prompt = 0 ;
else
need_vg_prompt = 1 ;
if ( ! need_size_prompt & & ! need_vg_prompt ) {
2016-02-16 23:15:24 +03:00
pd - > dev = pv - > dev ;
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
return 1 ;
}
if ( ! ( prompt = dm_pool_zalloc ( cmd - > mem , sizeof ( * prompt ) ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " prompt alloc failed. " ) ;
2016-02-16 23:15:24 +03:00
pp - > check_failed = 1 ;
return 0 ;
}
prompt - > dev = pd - > dev ;
prompt - > pv_name = dm_pool_strdup ( cmd - > mem , pd - > name ) ;
2017-04-27 20:13:09 +03:00
prompt - > size = size ;
prompt - > new_size = new_size ;
2016-03-01 13:41:09 +03:00
2016-02-16 23:15:24 +03:00
if ( pd - > is_used_unknown_pv )
prompt - > vg_name_unknown = 1 ;
2017-04-27 20:13:09 +03:00
else if ( need_vg_prompt )
2016-02-16 23:15:24 +03:00
prompt - > vg_name = dm_pool_strdup ( cmd - > mem , vg - > name ) ;
2017-04-27 20:13:09 +03:00
if ( need_size_prompt )
prompt - > type | = PROMPT_PVCREATE_DEV_SIZE ;
if ( need_vg_prompt )
prompt - > type | = PROMPT_PVCREATE_PV_IN_VG ;
dm_list_add ( & pp - > prompts , & prompt - > list ) ;
2016-02-16 23:15:24 +03:00
pd - > dev = pv - > dev ;
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
2016-03-01 13:41:09 +03:00
2016-02-16 23:15:24 +03:00
return 1 ;
}
/*
* This repeats the first check - - devices should be found , and should not have
* changed since the first check . If they were changed / used while the orphans
* lock was not held ( during prompting ) , then they can ' t be used any more and
* are moved to arg_fail . If they are not found by this loop , that also
* disqualifies them from being used . Each arg_confirm entry that ' s found and
* is ok , is moved to arg_process . Those not found will remain in arg_confirm .
*
* This check does not need to look in foreign / shared / clustered VGs . If a
* device from arg_confirm was used in a foreign / shared / clustered VG during the
* prompts , then it will not be found during this check .
*/
2016-02-17 00:00:50 +03:00
static int _pv_confirm_single ( struct cmd_context * cmd ,
struct volume_group * vg ,
struct physical_volume * pv ,
struct processing_handle * handle )
2016-02-16 23:15:24 +03:00
{
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp = ( struct pvcreate_params * ) handle - > custom_handle ;
2016-02-16 23:15:24 +03:00
struct pvcreate_device * pd ;
int found = 0 ;
dm_list_iterate_items ( pd , & pp - > arg_confirm ) {
if ( pd - > dev ! = pv - > dev )
continue ;
found = 1 ;
break ;
}
if ( ! found )
return 1 ;
2016-02-17 00:00:50 +03:00
/* Repeat the same from check_single. */
2016-02-16 23:15:24 +03:00
if ( ! dev_test_excl ( pv - > dev ) ) {
/* FIXME Detect whether device-mapper itself is still using it */
log_error ( " Can't open %s exclusively. Mounted filesystem? " ,
pv_dev_name ( pv ) ) ;
goto fail ;
}
/*
* What kind of device is this : an orphan PV , an uninitialized / unused
* device , a PV used in a VG .
*/
if ( vg & & ! is_orphan_vg ( vg - > name ) ) {
/* Device is a PV used in a VG. */
if ( pd - > is_orphan_pv | | pd - > is_not_pv | | pd - > is_used_unknown_pv ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was an orphan or unused. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
if ( pd - > is_vg_pv & & pd - > vg_name & & strcmp ( pd - > vg_name , vg - > name ) ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was in a different VG. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
} else if ( is_orphan ( pv ) ) {
/* Device is an orphan PV. */
if ( pd - > is_not_pv ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was not a PV. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
if ( pd - > is_vg_pv ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was in a VG. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
if ( is_used_pv ( pv ) ! = pd - > is_used_unknown_pv ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was different. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
} else {
/* Device is not a PV. */
if ( pd - > is_orphan_pv | | pd - > is_used_unknown_pv ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was an orphan PV. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
if ( pd - > is_vg_pv ) {
2016-02-17 00:00:50 +03:00
/* In check_single it was in a VG. */
2016-02-16 23:15:24 +03:00
goto fail ;
}
}
2016-02-17 00:00:50 +03:00
/* Device is unchanged from check_single. */
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
2016-03-01 13:41:09 +03:00
2016-02-16 23:15:24 +03:00
return 1 ;
fail :
2016-02-17 00:00:50 +03:00
log_error ( " Cannot use device %s: it changed during prompt. " , pd - > name ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
2016-03-01 13:41:09 +03:00
2016-02-16 23:15:24 +03:00
return 1 ;
}
2016-02-17 00:00:50 +03:00
static int _pvremove_check_single ( struct cmd_context * cmd ,
struct volume_group * vg ,
struct physical_volume * pv ,
struct processing_handle * handle )
{
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp = ( struct pvcreate_params * ) handle - > custom_handle ;
2016-02-17 00:00:50 +03:00
struct pvcreate_device * pd ;
struct pvcreate_prompt * prompt ;
struct label * label ;
int found = 0 ;
if ( ! pv - > dev )
return 1 ;
/*
* Check if one of the command args in arg_devices
* matches this device .
*/
dm_list_iterate_items ( pd , & pp - > arg_devices ) {
2016-05-04 19:28:28 +03:00
if ( pd - > dev ! = pv - > dev )
2016-02-17 00:00:50 +03:00
continue ;
if ( pv - > dev - > pvid [ 0 ] )
strncpy ( pd - > pvid , pv - > dev - > pvid , ID_LEN ) ;
found = 1 ;
break ;
}
if ( ! found )
return 1 ;
2016-03-01 13:41:09 +03:00
log_debug ( " Checking device %s for pvremove %.32s. " ,
2016-02-17 00:00:50 +03:00
pv_dev_name ( pv ) , pv - > dev - > pvid [ 0 ] ? pv - > dev - > pvid : " " ) ;
/*
* This test will fail if the device belongs to an MD array .
*/
if ( ! dev_test_excl ( pv - > dev ) ) {
/* FIXME Detect whether device-mapper itself is still using it */
2016-03-01 19:20:47 +03:00
log_error ( " Can't open %s exclusively. Mounted filesystem? " ,
2016-02-17 00:00:50 +03:00
pv_dev_name ( pv ) ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
return 1 ;
}
/*
* Is there a pv here already ?
* If not , this is an error unless you used - f .
*/
if ( ! label_read ( pd - > dev , & label , 0 ) ) {
if ( pp - > force ) {
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
return 1 ;
} else {
log_error ( " No PV label found on %s. " , pd - > name ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
return 1 ;
}
}
/*
* What kind of device is this : an orphan PV , an uninitialized / unused
* device , a PV used in a VG .
*/
if ( vg & & ! is_orphan_vg ( vg - > name ) ) {
/* Device is a PV used in a VG. */
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvremove arg %s: pv is used in %s. " , pd - > name , vg - > name ) ;
2016-02-17 00:00:50 +03:00
pd - > is_vg_pv = 1 ;
pd - > vg_name = dm_pool_strdup ( cmd - > mem , vg - > name ) ;
} else if ( vg & & is_orphan_vg ( vg - > name ) ) {
if ( is_used_pv ( pv ) ) {
/* Device is used in an unknown VG. */
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvremove arg %s: pv is used in unknown VG. " , pd - > name ) ;
2016-02-17 00:00:50 +03:00
pd - > is_used_unknown_pv = 1 ;
} else {
/* Device is an orphan PV. */
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvremove arg %s: pv is orphan in %s. " , pd - > name , vg - > name ) ;
2016-02-17 00:00:50 +03:00
pd - > is_orphan_pv = 1 ;
}
if ( ! strcmp ( vg - > name , FMT_LVM1_ORPHAN_VG_NAME ) )
pp - > orphan_vg_name = FMT_LVM1_ORPHAN_VG_NAME ;
else
pp - > orphan_vg_name = FMT_TEXT_ORPHAN_VG_NAME ;
} else {
2016-03-01 13:41:09 +03:00
log_debug ( " Found pvremove arg %s: device is not a PV. " , pd - > name ) ;
2016-02-17 00:00:50 +03:00
/* Device is not a PV. */
pd - > is_not_pv = 1 ;
}
if ( pd - > is_not_pv ) {
pd - > dev = pv - > dev ;
2016-03-01 13:41:09 +03:00
log_error ( " No PV found on device %s. " , pd - > name ) ;
2016-02-17 00:00:50 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
return 1 ;
}
/*
* pvremove is being run on this device , and it ' s not a PV ,
* or is an orphan PV . Neither case requires a prompt .
*/
if ( pd - > is_orphan_pv ) {
pd - > dev = pv - > dev ;
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
return 1 ;
}
/*
* pvremove is being run on this device , but the device is in a VG .
* A prompt or force option is required to use it .
*/
if ( ! ( prompt = dm_pool_zalloc ( cmd - > mem , sizeof ( * prompt ) ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " prompt alloc failed. " ) ;
2016-02-17 00:00:50 +03:00
pp - > check_failed = 1 ;
return 0 ;
}
prompt - > dev = pd - > dev ;
prompt - > pv_name = dm_pool_strdup ( cmd - > mem , pd - > name ) ;
if ( pd - > is_used_unknown_pv )
prompt - > vg_name_unknown = 1 ;
else
prompt - > vg_name = dm_pool_strdup ( cmd - > mem , vg - > name ) ;
2017-04-27 20:13:09 +03:00
prompt - > type | = PROMPT_PVREMOVE_PV_IN_VG ;
2016-02-17 00:00:50 +03:00
dm_list_add ( & pp - > prompts , & prompt - > list ) ;
pd - > dev = pv - > dev ;
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
2016-03-01 19:20:47 +03:00
2016-02-17 00:00:50 +03:00
return 1 ;
}
2016-02-16 23:15:24 +03:00
/*
* This can be used by pvcreate , vgcreate and vgextend to create PVs . The
* callers need to set up the pvcreate_each_params structure based on command
* line args . This includes the pv_names field which specifies the devices to
* create PVs on .
*
* This uses process_each_pv ( ) and should be called from a high level in the
* command - - the same level at which other instances of process_each are
* called .
*
* This function returns 0 ( failed ) if the caller requires all specified
* devices to be created , and any of those devices are not found , or any of
* them cannot be created .
*
* This function returns 1 ( success ) if the caller requires all specified
* devices to be created , and all are created , or if the caller does not
* require all specified devices to be created and one or more were created .
*
* When this function returns 1 ( success ) , it returns to the caller with the
* VG_ORPHANS write lock held .
*/
int pvcreate_each_device ( struct cmd_context * cmd ,
struct processing_handle * handle ,
2016-02-19 00:38:23 +03:00
struct pvcreate_params * pp )
2016-02-16 23:15:24 +03:00
{
struct pvcreate_device * pd , * pd2 ;
struct pvcreate_prompt * prompt , * prompt2 ;
struct physical_volume * pv ;
struct volume_group * orphan_vg ;
2016-05-13 00:19:57 +03:00
struct dm_list remove_duplicates ;
2016-02-16 23:15:24 +03:00
struct dm_list arg_sort ;
struct pv_list * pvl ;
struct pv_list * vgpvl ;
const char * pv_name ;
int consistent = 0 ;
2017-01-14 00:08:51 +03:00
int must_use_all = ( cmd - > cname - > flags & MUST_USE_ALL_ARGS ) ;
2016-02-16 23:15:24 +03:00
int found ;
2017-02-12 20:18:54 +03:00
unsigned i ;
2016-02-16 23:15:24 +03:00
2016-02-22 18:42:03 +03:00
set_pv_notify ( cmd ) ;
2016-05-13 00:19:57 +03:00
dm_list_init ( & remove_duplicates ) ;
2016-02-16 23:15:24 +03:00
dm_list_init ( & arg_sort ) ;
handle - > custom_handle = pp ;
/*
* Create a list entry for each name arg .
*/
for ( i = 0 ; i < pp - > pv_count ; i + + ) {
dm_unescape_colons_and_at_signs ( pp - > pv_names [ i ] , NULL , NULL ) ;
pv_name = pp - > pv_names [ i ] ;
if ( ! ( pd = dm_pool_zalloc ( cmd - > mem , sizeof ( * pd ) ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " alloc failed. " ) ;
2016-02-16 23:15:24 +03:00
return 0 ;
}
if ( ! ( pd - > name = dm_pool_strdup ( cmd - > mem , pv_name ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " strdup failed. " ) ;
2016-02-16 23:15:24 +03:00
return 0 ;
}
dm_list_add ( & pp - > arg_devices , & pd - > list ) ;
}
/*
* This function holds the orphans lock while reading VGs to look for
* devices . This means the orphans lock is held while VG locks are
* acquired , which is against lvmcache lock ordering rules , so disable
* the lvmcache lock ordering checks .
*/
lvmcache_lock_ordering ( 0 ) ;
/*
* Clear the cache before acquiring the orphan lock . ( Clearing the
* cache with locks held is an error . ) We want the orphan lock
* acquired before process_each_pv . If the orphan lock is not held
* when process_each_pv is called , then process_each_pv clears the
* cache .
*/
lvmcache_destroy ( cmd , 1 , 0 ) ;
/*
* If no prompts require a user response , this orphan lock is held
* throughout , and pvcreate_each_device ( ) returns with it held so that
* vgcreate / vgextend use the PVs created here to add to a VG .
*/
if ( ! lock_vol ( cmd , VG_ORPHANS , LCK_VG_WRITE , NULL ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Can't get lock for orphan PVs. " ) ;
2016-02-16 23:15:24 +03:00
return 0 ;
}
dev_cache_full_scan ( cmd - > full_filter ) ;
2016-05-04 19:28:28 +03:00
/*
* Translate arg names into struct device ' s .
*/
dm_list_iterate_items ( pd , & pp - > arg_devices )
pd - > dev = dev_cache_get ( pd - > name , cmd - > full_filter ) ;
2016-02-16 23:15:24 +03:00
/*
* Use process_each_pv to search all existing PVs and devices .
*
* This is a slightly different way to use process_each_pv , because the
* command args ( arg_devices ) are not being processed directly by
* process_each_pv ( argc and argv are not passed ) . Instead ,
* process_each_pv is processing all existing PVs and devices , and the
* single function is matching each of those against the command args
* ( arg_devices ) .
*
* If an arg_devices entry is found during process_each_pv , it ' s moved
* to arg_process if it can be used , or arg_fail if it cannot be used .
* If it ' s added to arg_process but needs a prompt or force option , then
* a corresponding prompt entry is added to pp - > prompts .
*/
2016-02-17 00:00:50 +03:00
process_each_pv ( cmd , 0 , NULL , NULL , 1 , 0 , handle ,
pp - > is_remove ? _pvremove_check_single : _pvcreate_check_single ) ;
2016-02-16 23:15:24 +03:00
/*
* A fatal error was found while checking .
*/
if ( pp - > check_failed )
goto_bad ;
2016-05-13 00:19:57 +03:00
/*
* Special case : pvremove - ff is allowed to clear a duplicate device in
* the unchosen duplicates list . PVs in the unchosen duplicates list
* won ' t be found by normal process_each searches - - they are not in
* lvmcache and can ' t be processed normally . We save them here and
* erase them below without going through the normal processing code .
*/
if ( pp - > is_remove & & ( pp - > force = = DONT_PROMPT_OVERRIDE ) & &
! dm_list_empty ( & pp - > arg_devices ) & & lvmcache_found_duplicate_pvs ( ) ) {
dm_list_iterate_items_safe ( pd , pd2 , & pp - > arg_devices ) {
if ( lvmcache_dev_is_unchosen_duplicate ( pd - > dev ) ) {
log_debug ( " Found pvremove arg %s: device is a duplicate. " , pd - > name ) ;
dm_list_move ( & remove_duplicates , & pd - > list ) ;
}
}
}
2016-02-16 23:15:24 +03:00
/*
* Check if all arg_devices were found by process_each_pv .
*/
dm_list_iterate_items ( pd , & pp - > arg_devices )
2017-10-17 04:12:41 +03:00
log_error ( " Device %s %s. " , pd - > name , dev_cache_filtered_reason ( pd - > name ) ) ;
2016-02-16 23:15:24 +03:00
/*
* Can the command continue if some specified devices were not found ?
*/
if ( ! dm_list_empty ( & pp - > arg_devices ) & & must_use_all )
goto_bad ;
/*
* Can the command continue if some specified devices cannot be used ?
*/
if ( ! dm_list_empty ( & pp - > arg_fail ) & & must_use_all )
goto_bad ;
/*
2016-05-13 00:19:57 +03:00
* The command cannot continue if there are no devices to process .
2016-02-16 23:15:24 +03:00
*/
2016-05-13 00:19:57 +03:00
if ( dm_list_empty ( & pp - > arg_process ) & & dm_list_empty ( & remove_duplicates ) ) {
2016-02-17 00:00:50 +03:00
log_debug ( " No devices to process. " ) ;
2016-03-01 19:20:47 +03:00
goto bad ;
2016-02-16 23:15:24 +03:00
}
/*
* Clear any prompts that have answers without asking the user .
*/
dm_list_iterate_items_safe ( prompt , prompt2 , & pp - > prompts ) {
_check_pvcreate_prompt ( cmd , pp , prompt , 0 ) ;
switch ( prompt - > answer ) {
case PROMPT_ANSWER_YES :
/* The PV can be used, leave it on arg_process. */
dm_list_del ( & prompt - > list ) ;
break ;
case PROMPT_ANSWER_NO :
/* The PV cannot be used, remove it from arg_process. */
if ( ( pd = _pvcreate_list_find_dev ( & pp - > arg_process , prompt - > dev ) ) )
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
dm_list_del ( & prompt - > list ) ;
break ;
}
}
if ( ! dm_list_empty ( & pp - > arg_fail ) & & must_use_all )
goto_bad ;
/*
* If no remaining prompts need a user response , then keep orphans
* locked and go directly to the create steps .
*/
if ( dm_list_empty ( & pp - > prompts ) )
goto do_command ;
/*
* Prompts require asking the user , so release the orphans lock , ask
* the questions , reacquire the orphans lock , verify that the PVs were
* not used during the questions , then do the create steps .
*/
lvmetad: two phase vg_update
Previously, a command sent lvmetad new VG metadata in vg_commit().
In vg_commit(), devices are suspended, so any memory allocation
done by the command while sending to lvmetad, or by lvmetad while
updating its cache could deadlock if memory reclaim was triggered.
Now lvmetad is updated in unlock_vg(), after devices are resumed.
The new method for updating VG metadata in lvmetad is in two phases:
1. In vg_write(), before devices are suspended, the command sends
lvmetad a short message ("set_vg_info") telling it what the new
VG seqno will be. lvmetad sees that the seqno is newer than
the seqno of its cached VG, so it sets the INVALID flag for the
cached VG. If sending the message to lvmetad fails, the command
fails before the metadata is committed and the change is not made.
If sending the message succeeds, vg_commit() is called.
2. In unlock_vg(), after devices are resumed, the command sends
lvmetad the standard vg_update message with the new metadata.
lvmetad sees that the seqno in the new metadata matches the
seqno it saved from set_vg_info, and knows it has the latest
copy, so it clears the INVALID flag for the cached VG.
If a command fails between 1 and 2 (after committing the VG on disk,
but before sending lvmetad the new metadata), the cached VG retains
the INVALID flag in lvmetad. A subsequent command will read the
cached VG from lvmetad, see the INVALID flag, ignore the cached
copy, read the VG from disk instead, update the lvmetad copy
with the latest copy from disk, (this clears the INVALID flag
in lvmetad), and use the correct VG metadata for the command.
(This INVALID mechanism already existed for use by lvmlockd.)
2016-06-08 22:42:03 +03:00
unlock_vg ( cmd , NULL , VG_ORPHANS ) ;
2016-02-16 23:15:24 +03:00
/*
* Process prompts that require asking the user . The orphans lock is
* not held , so there ' s no harm in waiting for a user to respond .
*/
dm_list_iterate_items_safe ( prompt , prompt2 , & pp - > prompts ) {
_check_pvcreate_prompt ( cmd , pp , prompt , 1 ) ;
switch ( prompt - > answer ) {
case PROMPT_ANSWER_YES :
/* The PV can be used, leave it on arg_process. */
dm_list_del ( & prompt - > list ) ;
break ;
case PROMPT_ANSWER_NO :
/* The PV cannot be used, remove it from arg_process. */
if ( ( pd = _pvcreate_list_find_dev ( & pp - > arg_process , prompt - > dev ) ) )
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
dm_list_del ( & prompt - > list ) ;
break ;
}
if ( ! dm_list_empty ( & pp - > arg_fail ) & & must_use_all )
goto_out ;
if ( sigint_caught ( ) )
goto_out ;
if ( prompt - > abort_command )
goto_out ;
}
/*
* Clear the cache , reacquire the orphans write lock , then check again
* that the devices can still be used . If the second loop finds them
* changed , or can ' t find them any more , then they aren ' t used .
* Clear the cache here before locking orphans , since it won ' t be
* done by process_each_pv with orphans already locked .
*/
lvmcache_destroy ( cmd , 1 , 0 ) ;
if ( ! lock_vol ( cmd , VG_ORPHANS , LCK_VG_WRITE , NULL ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Can't get lock for orphan PVs. " ) ;
2016-11-25 15:46:06 +03:00
goto out ;
2016-02-16 23:15:24 +03:00
}
/*
* The device args began on the arg_devices list , then the first check
* loop moved those entries to arg_process as they were found . Devices
* not found during the first loop are not being used , and remain on
* arg_devices .
*
* Now , the arg_process entries are moved to arg_confirm , and the second
* check loop moves them back to arg_process as they are found and are
* unchanged . Like the first loop , the second loop moves an entry to
* arg_fail if it cannot be used . After the second loop , any devices
* remaining on arg_confirm were not found and are not used .
*/
dm_list_splice ( & pp - > arg_confirm , & pp - > arg_process ) ;
2016-02-17 00:00:50 +03:00
process_each_pv ( cmd , 0 , NULL , NULL , 1 , 0 , handle , _pv_confirm_single ) ;
2016-02-16 23:15:24 +03:00
dm_list_iterate_items ( pd , & pp - > arg_confirm )
2017-10-17 04:12:41 +03:00
log_error ( " Device %s %s. " , pd - > name , dev_cache_filtered_reason ( pd - > name ) ) ;
2016-02-16 23:15:24 +03:00
/* Some devices were not found during the second check. */
if ( ! dm_list_empty ( & pp - > arg_confirm ) & & must_use_all )
goto_bad ;
/* Some devices changed during the second check. */
if ( ! dm_list_empty ( & pp - > arg_fail ) & & must_use_all )
goto_bad ;
if ( dm_list_empty ( & pp - > arg_process ) ) {
2016-02-17 00:00:50 +03:00
log_debug ( " No devices to process. " ) ;
2016-11-25 15:46:06 +03:00
goto bad ;
2016-02-16 23:15:24 +03:00
}
do_command :
/*
* Reorder arg_process entries to match the original order of args .
*/
dm_list_splice ( & arg_sort , & pp - > arg_process ) ;
for ( i = 0 ; i < pp - > pv_count ; i + + ) {
if ( ( pd = _pvcreate_list_find_name ( & arg_sort , pp - > pv_names [ i ] ) ) )
dm_list_move ( & pp - > arg_process , & pd - > list ) ;
}
2016-02-17 00:00:50 +03:00
if ( pp - > is_remove )
dm_list_splice ( & pp - > arg_remove , & pp - > arg_process ) ;
else
dm_list_splice ( & pp - > arg_create , & pp - > arg_process ) ;
2016-02-16 23:15:24 +03:00
/*
* Wipe signatures on devices being created .
*/
dm_list_iterate_items_safe ( pd , pd2 , & pp - > arg_create ) {
2016-03-01 13:41:09 +03:00
log_verbose ( " Wiping signatures on new PV %s. " , pd - > name ) ;
2016-02-16 23:15:24 +03:00
if ( ! wipe_known_signatures ( cmd , pd - > dev , pd - > name , TYPE_LVM1_MEMBER | TYPE_LVM2_MEMBER ,
0 , pp - > yes , pp - > force , & pd - > wiped ) ) {
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
}
if ( sigint_caught ( ) )
goto_bad ;
}
if ( ! dm_list_empty ( & pp - > arg_fail ) & & must_use_all )
goto_bad ;
/*
* Find existing orphan PVs that vgcreate or vgextend want to use .
* " preserve_existing " means that the command wants to use existing PVs
* and not recreate a new PV on top of an existing PV .
*/
if ( pp - > preserve_existing & & pp - > orphan_vg_name ) {
2016-03-01 13:41:09 +03:00
log_debug ( " Using existing orphan PVs in %s. " , pp - > orphan_vg_name ) ;
2016-02-16 23:15:24 +03:00
if ( ! ( orphan_vg = vg_read_internal ( cmd , pp - > orphan_vg_name , NULL , 0 , & consistent ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Cannot read orphans VG %s. " , pp - > orphan_vg_name ) ;
2016-11-25 15:46:06 +03:00
goto bad ;
2016-02-16 23:15:24 +03:00
}
dm_list_iterate_items_safe ( pd , pd2 , & pp - > arg_create ) {
if ( ! pd - > is_orphan_pv )
continue ;
if ( ! ( pvl = dm_pool_alloc ( cmd - > mem , sizeof ( * pvl ) ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " alloc pvl failed. " ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
found = 0 ;
dm_list_iterate_items ( vgpvl , & orphan_vg - > pvs ) {
if ( vgpvl - > pv - > dev = = pd - > dev ) {
found = 1 ;
break ;
}
}
if ( found ) {
2016-03-01 13:41:09 +03:00
log_debug ( " Using existing orphan PV %s. " , pv_dev_name ( vgpvl - > pv ) ) ;
2016-02-16 23:15:24 +03:00
pvl - > pv = vgpvl - > pv ;
dm_list_add ( & pp - > pvs , & pvl - > list ) ;
} else {
log_error ( " Failed to find PV %s " , pd - > name ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
}
}
}
/*
* Create PVs on devices . Either create a new PV on top of an existing
* one ( e . g . for pvcreate ) , or create a new PV on a device that is not
* a PV .
*/
dm_list_iterate_items_safe ( pd , pd2 , & pp - > arg_create ) {
/* Using existing orphan PVs is covered above. */
if ( pp - > preserve_existing & & pd - > is_orphan_pv )
continue ;
if ( ! dm_list_empty ( & pp - > arg_fail ) & & must_use_all )
break ;
if ( ! ( pvl = dm_pool_alloc ( cmd - > mem , sizeof ( * pvl ) ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " alloc pvl failed. " ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
2016-03-01 13:40:53 +03:00
continue ;
2016-02-16 23:15:24 +03:00
}
pv_name = pd - > name ;
2016-03-01 13:41:09 +03:00
log_debug ( " Creating a new PV on %s. " , pv_name ) ;
2016-02-16 23:15:24 +03:00
2016-02-19 00:31:27 +03:00
if ( ! ( pv = pv_create ( cmd , pd - > dev , & pp - > pva ) ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Failed to setup physical volume \" %s \" . " , pv_name ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
log_verbose ( " Set up physical volume for \" %s \" with % " PRIu64
2016-03-01 13:41:09 +03:00
" available sectors. " , pv_name , pv_size ( pv ) ) ;
2016-02-16 23:15:24 +03:00
if ( ! label_remove ( pv - > dev ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Failed to wipe existing label on %s. " , pv_name ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
if ( pp - > zero ) {
2016-03-01 13:41:09 +03:00
log_verbose ( " Zeroing start of device %s. " , pv_name ) ;
2016-02-16 23:15:24 +03:00
if ( ! dev_open_quiet ( pv - > dev ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " %s not opened: device not zeroed. " , pv_name ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
if ( ! dev_set ( pv - > dev , UINT64_C ( 0 ) , ( size_t ) 2048 , 0 ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " %s not wiped: aborting. " , pv_name ) ;
if ( ! dev_close ( pv - > dev ) )
stack ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
2016-03-01 13:41:09 +03:00
}
if ( ! dev_close ( pv - > dev ) )
stack ;
2016-02-16 23:15:24 +03:00
}
2016-03-01 13:41:09 +03:00
log_verbose ( " Writing physical volume data to disk \" %s \" . " , pv_name ) ;
2016-02-16 23:15:24 +03:00
if ( ! pv_write ( cmd , pv , 0 ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Failed to write physical volume \" %s \" . " , pv_name ) ;
2016-02-16 23:15:24 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
2016-02-26 01:38:59 +03:00
continue ;
2016-02-16 23:15:24 +03:00
}
2016-03-01 13:41:09 +03:00
log_print_unless_silent ( " Physical volume \" %s \" successfully created. " ,
pv_name ) ;
2016-02-16 23:15:24 +03:00
pvl - > pv = pv ;
dm_list_add ( & pp - > pvs , & pvl - > list ) ;
}
2016-02-17 00:00:50 +03:00
/*
* Remove PVs from devices for pvremove .
*/
dm_list_iterate_items_safe ( pd , pd2 , & pp - > arg_remove ) {
if ( ! label_remove ( pd - > dev ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Failed to wipe existing label(s) on %s. " , pd - > name ) ;
2016-02-17 00:00:50 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
pvscan: use process_each_vg for autoactivate
This refactors the code for autoactivation. Previously,
as each PV was found, it would be sent to lvmetad, and
the VG would be autoactivated using a non-standard VG
processing function (the "activation_handler") called via
a function pointer from within the lvmetad notification path.
Now, any scanning that the command needs to do (scanning
only the named device args, or scanning all devices when
there are no args), is done first, before any activation
is attempted. During the scans, the VG names are saved.
After scanning is complete, process_each_vg is used to do
autoactivation of the saved VG names. This makes pvscan
activation much more similar to activation done with
vgchange or lvchange.
The separate autoactivate phase also means that if lvmetad
is disabled (either before or during the scan), the command
can continue with the activation step by simply not using
lvmetad and reverting to disk scanning to do the
activation.
2016-04-28 17:37:03 +03:00
if ( ! lvmetad_pv_gone_by_dev ( pd - > dev ) ) {
2016-03-01 13:41:09 +03:00
log_error ( " Failed to remove PV %s from lvmetad. " , pd - > name ) ;
2016-02-17 00:00:50 +03:00
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
2016-03-01 13:41:09 +03:00
log_print_unless_silent ( " Labels on physical volume \" %s \" successfully wiped. " ,
2016-02-17 00:00:50 +03:00
pd - > name ) ;
}
2016-02-16 23:15:24 +03:00
2016-05-13 00:19:57 +03:00
/*
* Special case : pvremove duplicate PVs ( also see above ) .
*/
dm_list_iterate_items_safe ( pd , pd2 , & remove_duplicates ) {
if ( ! label_remove ( pd - > dev ) ) {
log_error ( " Failed to wipe existing label(s) on %s. " , pd - > name ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
pvscan: use process_each_vg for autoactivate
This refactors the code for autoactivation. Previously,
as each PV was found, it would be sent to lvmetad, and
the VG would be autoactivated using a non-standard VG
processing function (the "activation_handler") called via
a function pointer from within the lvmetad notification path.
Now, any scanning that the command needs to do (scanning
only the named device args, or scanning all devices when
there are no args), is done first, before any activation
is attempted. During the scans, the VG names are saved.
After scanning is complete, process_each_vg is used to do
autoactivation of the saved VG names. This makes pvscan
activation much more similar to activation done with
vgchange or lvchange.
The separate autoactivate phase also means that if lvmetad
is disabled (either before or during the scan), the command
can continue with the activation step by simply not using
lvmetad and reverting to disk scanning to do the
activation.
2016-04-28 17:37:03 +03:00
if ( ! lvmetad_pv_gone_by_dev ( pd - > dev ) ) {
2016-05-13 00:19:57 +03:00
log_error ( " Failed to remove PV %s from lvmetad. " , pd - > name ) ;
dm_list_move ( & pp - > arg_fail , & pd - > list ) ;
continue ;
}
lvmcache_remove_unchosen_duplicate ( pd - > dev ) ;
log_print_unless_silent ( " Labels on physical volume \" %s \" successfully wiped. " ,
pd - > name ) ;
}
2016-02-16 23:15:24 +03:00
dm_list_iterate_items ( pd , & pp - > arg_fail )
2016-03-01 13:41:09 +03:00
log_debug ( " %s: command failed for %s. " ,
cmd - > command - > name , pd - > name ) ;
2016-02-16 23:15:24 +03:00
if ( ! dm_list_empty ( & pp - > arg_fail ) )
goto_bad ;
/*
* Returns with VG_ORPHANS write lock held because vgcreate and
* vgextend want to use the newly created PVs .
*/
return 1 ;
bad :
lvmetad: two phase vg_update
Previously, a command sent lvmetad new VG metadata in vg_commit().
In vg_commit(), devices are suspended, so any memory allocation
done by the command while sending to lvmetad, or by lvmetad while
updating its cache could deadlock if memory reclaim was triggered.
Now lvmetad is updated in unlock_vg(), after devices are resumed.
The new method for updating VG metadata in lvmetad is in two phases:
1. In vg_write(), before devices are suspended, the command sends
lvmetad a short message ("set_vg_info") telling it what the new
VG seqno will be. lvmetad sees that the seqno is newer than
the seqno of its cached VG, so it sets the INVALID flag for the
cached VG. If sending the message to lvmetad fails, the command
fails before the metadata is committed and the change is not made.
If sending the message succeeds, vg_commit() is called.
2. In unlock_vg(), after devices are resumed, the command sends
lvmetad the standard vg_update message with the new metadata.
lvmetad sees that the seqno in the new metadata matches the
seqno it saved from set_vg_info, and knows it has the latest
copy, so it clears the INVALID flag for the cached VG.
If a command fails between 1 and 2 (after committing the VG on disk,
but before sending lvmetad the new metadata), the cached VG retains
the INVALID flag in lvmetad. A subsequent command will read the
cached VG from lvmetad, see the INVALID flag, ignore the cached
copy, read the VG from disk instead, update the lvmetad copy
with the latest copy from disk, (this clears the INVALID flag
in lvmetad), and use the correct VG metadata for the command.
(This INVALID mechanism already existed for use by lvmlockd.)
2016-06-08 22:42:03 +03:00
unlock_vg ( cmd , NULL , VG_ORPHANS ) ;
2016-02-16 23:15:24 +03:00
out :
return 0 ;
}