mirror of
git://sourceware.org/git/lvm2.git
synced 2024-12-21 13:34:40 +03:00
Avoid over-quoting in shell scripts.
Do not use "..." around the RHS of VAR= assignment, nor on the argument of "case ... in ...". Author: Jim Meyering <jim@meyering.net>
This commit is contained in:
parent
f18ef24471
commit
0b0c2117af
@ -35,7 +35,7 @@ pvsize=$((200 * 1024 * 2))
|
||||
|
||||
test_expect_success \
|
||||
'set up temp file and loopback device' \
|
||||
'lofile="$(pwd)/lofile" && lodev=$(loop_setup_ "$lofile")'
|
||||
'lofile=$(pwd)/lofile && lodev=$(loop_setup_ "$lofile")'
|
||||
|
||||
offset=0
|
||||
pvs=
|
||||
|
@ -28,8 +28,8 @@ cleanup_()
|
||||
|
||||
test_expect_success \
|
||||
'set up temp files, loopback devices, PVs, and a VG' \
|
||||
'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") &&
|
||||
f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") &&
|
||||
'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
|
||||
f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
|
||||
pvcreate $d1 $d2 &&
|
||||
vg=$(this_test_)-test-vg-$$ &&
|
||||
vgcreate $vg $d1 $d2'
|
||||
@ -71,7 +71,7 @@ test_expect_success \
|
||||
'lvcreate rejects an invalid stripe size' \
|
||||
'lvcreate -L 64M -n $lv -i2 --stripesize 3 $vg 2>err; test $? = 3 &&
|
||||
grep "^ Invalid stripe size 3\.00 KB\$" err &&
|
||||
case "$(lvdisplay $vg)" in "") true ;; *) false ;; esac'
|
||||
case $(lvdisplay $vg) in "") true ;; *) false ;; esac'
|
||||
|
||||
test_done
|
||||
# Local Variables:
|
||||
|
@ -28,8 +28,8 @@ cleanup_()
|
||||
|
||||
test_expect_success \
|
||||
'set up temp files, loopback devices, PVs, and a VG' \
|
||||
'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") &&
|
||||
f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") &&
|
||||
'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
|
||||
f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
|
||||
pvcreate $d1 $d2 &&
|
||||
vg=$(this_test_)-test-vg-$$ &&
|
||||
vgcreate $vg $d1 $d2 &&
|
||||
@ -65,7 +65,7 @@ test_expect_success \
|
||||
check_pv_size_ $d2 "0"'
|
||||
|
||||
# Exercise the range overlap code. Allocate every 2 extents.
|
||||
#
|
||||
#
|
||||
# Physical Extents
|
||||
# 1 2
|
||||
#012345678901234567890123
|
||||
|
@ -28,8 +28,8 @@ cleanup_()
|
||||
|
||||
test_expect_success \
|
||||
'set up temp files, loopback devices, PVs, VG, LV' \
|
||||
'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") &&
|
||||
f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") &&
|
||||
'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
|
||||
f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
|
||||
pvcreate $d1 $d2 &&
|
||||
vg=pvmove-demo-vg-$$ &&
|
||||
vgcreate "$vg" $d1 $d2 &&
|
||||
|
Loading…
Reference in New Issue
Block a user