shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

Avoid over-quoting in shell scripts.

Browse Source 
Do not use "..." around the RHS of VAR= assignment,
nor on the argument of "case ... in ...".


Author: Jim Meyering <jim@meyering.net>
This commit is contained in:
Jim Meyering 2007-09-24 19:19:18 +00:00
parent f18ef24471
commit 0b0c2117af
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/t-lvcreate-pvtags.sh
View File

@ -35,7 +35,7 @@ pvsize=$((200 * 1024 * 2))
test_expect_success \ test_expect_success \
'set up temp file and loopback device' \ 'set up temp file and loopback device' \
'lofile="$(pwd)/lofile" && lodev=$(loop_setup_ "$lofile")' 'lofile=$(pwd)/lofile && lodev=$(loop_setup_ "$lofile")'
offset=0 offset=0
pvs= pvs=

6
test/t-lvcreate-usage.sh
View File

@ -28,8 +28,8 @@ cleanup_()
test_expect_success \ test_expect_success \
'set up temp files, loopback devices, PVs, and a VG' \ 'set up temp files, loopback devices, PVs, and a VG' \
'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") && 'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") && f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
pvcreate $d1 $d2 && pvcreate $d1 $d2 &&
vg=$(this_test_)-test-vg-$$ && vg=$(this_test_)-test-vg-$$ &&
vgcreate $vg $d1 $d2' vgcreate $vg $d1 $d2'
@ -71,7 +71,7 @@ test_expect_success \
'lvcreate rejects an invalid stripe size' \ 'lvcreate rejects an invalid stripe size' \
'lvcreate -L 64M -n $lv -i2 --stripesize 3 $vg 2>err; test $? = 3 && 'lvcreate -L 64M -n $lv -i2 --stripesize 3 $vg 2>err; test $? = 3 &&
grep "^ Invalid stripe size 3\.00 KB\$" err && grep "^ Invalid stripe size 3\.00 KB\$" err &&
case "$(lvdisplay $vg)" in "") true ;; *) false ;; esac' case $(lvdisplay $vg) in "") true ;; *) false ;; esac'
test_done test_done
# Local Variables: # Local Variables:

6
test/t-lvextend-percent-extents.sh
View File

@ -28,8 +28,8 @@ cleanup_()
test_expect_success \ test_expect_success \
'set up temp files, loopback devices, PVs, and a VG' \ 'set up temp files, loopback devices, PVs, and a VG' \
'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") && 'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") && f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
pvcreate $d1 $d2 && pvcreate $d1 $d2 &&
vg=$(this_test_)-test-vg-$$ && vg=$(this_test_)-test-vg-$$ &&
vgcreate $vg $d1 $d2 && vgcreate $vg $d1 $d2 &&
@ -65,7 +65,7 @@ test_expect_success \
check_pv_size_ $d2 "0"' check_pv_size_ $d2 "0"'
# Exercise the range overlap code. Allocate every 2 extents. # Exercise the range overlap code. Allocate every 2 extents.
# #
# Physical Extents # Physical Extents
# 1 2 # 1 2
#012345678901234567890123 #012345678901234567890123

4
test/t-pv-range-overflow.sh
View File

@ -28,8 +28,8 @@ cleanup_()
test_expect_success \ test_expect_success \
'set up temp files, loopback devices, PVs, VG, LV' \ 'set up temp files, loopback devices, PVs, VG, LV' \
'f1="$(pwd)/1" && d1=$(loop_setup_ "$f1") && 'f1=$(pwd)/1 && d1=$(loop_setup_ "$f1") &&
f2="$(pwd)/2" && d2=$(loop_setup_ "$f2") && f2=$(pwd)/2 && d2=$(loop_setup_ "$f2") &&
pvcreate $d1 $d2 && pvcreate $d1 $d2 &&
vg=pvmove-demo-vg-$$ && vg=pvmove-demo-vg-$$ &&
vgcreate "$vg" $d1 $d2 && vgcreate "$vg" $d1 $d2 &&