shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-08-25 13:49:28 +03:00
Code Releases Activity

Add missing checks for function return codes.

Browse Source 
Some functions were being called without having their return values checked.
This commit is contained in:
Jonathan Earl Brassow
2011-08-11 19:38:00 +00:00
parent 4afdf187a1
commit 2100c90dd7
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/activate/dev_manager.c
View File

@ -1233,8 +1233,9 @@ int add_areas_line(struct dev_manager *dm, struct lv_segment *seg,
NULL);
if (!dlid)
return_0;
dm_tree_node_add_target_area(node, NULL, dlid,
extent_size * seg_metale(seg, s));
if (!dm_tree_node_add_target_area(node, NULL, dlid,
extent_size * seg_metale(seg, s)))
return_0;
}
if (!(dlid = build_dm_uuid(dm->mem, seg_lv(seg, s)->lvid.s, NULL)))
return_0;

17
lib/metadata/lv_manip.c
View File

@ -312,13 +312,22 @@ void release_lv_segment_area(struct lv_segment *seg, uint32_t s,
if (area_reduction != seg->area_len) {
log_error("Unable to reduce RAID LV - operation not implemented.");
return;
} else
lv_remove(seg_lv(seg, s));
} else {
if (!lv_remove(seg_lv(seg, s))) {
log_error("Failed to remove RAID image %s",
seg_lv(seg, s)->name);
return;
}
}
/* Remove metadata area if image has been removed */
if (area_reduction == seg->area_len) {
lv_reduce(seg_metalv(seg, s),
seg_metalv(seg, s)->le_count);
if (!lv_reduce(seg_metalv(seg, s),
seg_metalv(seg, s)->le_count)) {
log_error("Failed to remove RAID meta-device %s",
seg_metalv(seg, s)->name);
return;
}
}
return;
}