shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cleanup: avoid allocating memory for hash key

Browse Source 
Hash always allocates its own copy of the key so avoid
this extra uuid copy.
This commit is contained in:
Zdenek Kabelac 2021-03-04 18:17:03 +01:00
parent d3cff64408
commit dac990ae03
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/format_text/export.c
View File

@ -955,7 +955,8 @@ static int _build_pv_names(struct formatter *f, struct volume_group *vg)
int count = 0;
struct pv_list *pvl;
struct physical_volume *pv;
char buffer[32], *uuid, *name;
char buffer[32], *name;
char uuid[64];
if (!(f->mem = dm_pool_create("text pv_names", 512)))
return_0;
@ -973,8 +974,7 @@ static int _build_pv_names(struct formatter *f, struct volume_group *vg)
if (!(name = dm_pool_strdup(f->mem, buffer)))
return_0;
if (!(uuid = dm_pool_zalloc(f->mem, 64)) ||
!id_write_format(&pv->id, uuid, 64))
if (!id_write_format(&pv->id, uuid, sizeof(uuid)))
return_0;
if (!dm_hash_insert(f->pv_names, uuid, name))