shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-08-24 09:49:27 +03:00
Code Releases Activity

The patch fixes some lvconvert issues (WRT mirror <-> mirror).

Browse Source 
The default log option for a mirror is 'disk'.  If the log
type is not explicitly stated on the command line when
converting from an X-way mirror to a Y-way mirror, 'disk'
is chosen.  So, if you have a 'core' log mirror and you
convert, your result will contain a 'disk' log.

This patch remembers what the old log type was.  If the
user is merely trying to switch the number of mirror
images, the log type is now kept the same.

There is one historical behaviour I left in place...
If you have a 2-way, core-log mirror and you use lvconvert to
specify you want a 2-way mirror - without specifying the
log type - you will get a 2-way, disk-log mirror.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Informal-IRC-ACK-by: agk
This commit is contained in:
Jonathan Earl Brassow
2010-01-07 20:42:55 +00:00
parent 94a434e9e7
commit fbe92a13c0
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/lvconvert.c
View File

@ -628,6 +628,17 @@ static int _lvconvert_mirrors(struct cmd_context *cmd, struct logical_volume *lv
return 0;
}
/*
* If we are converting from one type of mirror to another, and
* the type of log wasn't specified, then let's keep the log type
* the same.
*/
if (existing_mirrors && lp->mirrors &&
(lp->mirrors != existing_mirrors) &&
!arg_count(cmd, mirrorlog_ARG) && !arg_count(cmd, corelog_ARG)) {
corelog = first_seg(lv)->log_lv ? 0 : 1;
}
if (repair) {
cmd->handles_missing_pvs = 1;
cmd->partial_activation = 1;