shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity
6,400 Commits 425 Branches 667 Tags 54 MiB
36ddbdbbe2
Commit Graph

6400 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zdenek Kabelac
36ddbdbbe2 Return error for failing allocation 
Fix case, where final strdup would have failed and it would miss to return
failure for this case and return success and NULL pointer.
 2012-02-10 13:56:19 +00:00
Zdenek Kabelac
c046a59e7f Add test for failing allocation 
Avoid memcpy to NULL if realloc fails.
 2012-02-10 13:52:05 +00:00
Zdenek Kabelac
511a5f3ad8 Add test for memory allocation failures 
Replace asserts with test for failing memory allocation.
Add at least stack traces.
Index counter starts from 1 (0 reserved for error), so replacing fingerprint.
 2012-02-10 13:49:29 +00:00
Zdenek Kabelac
5726f4aaac Remove unreachable code 2012-02-10 13:46:23 +00:00
Petr Rockai
872b97a752 What's new. 2012-02-10 02:56:54 +00:00
Petr Rockai
6e41729eb8 Keep a global (per-format) orphan_vg and keep any and all orphan PVs linked to 
it. Avoids the need for FMT_INSTANCE_PV and enables further simplifications. No
functional change, internal refactor only.
 2012-02-10 02:53:03 +00:00
Petr Rockai
0fbbc6ce13 What's new: lvmcache. 2012-02-10 01:29:46 +00:00
Petr Rockai
8e5f7cf3dc Move lvmcache data structures behind an API (making the structures private to 
lvmcache.c). No functional change.
 2012-02-10 01:28:27 +00:00
Peter Rajnoha
5fa417a9c0 Stop processing lvextend if trying to extend a mirror that is being recovered. 
Missing correct return value in lv_extend fn.
 2012-02-09 15:13:42 +00:00
Zdenek Kabelac
b93c1332d1 Move label_init up in code stack 
label_exit() is called destroy_toolcontext() and we are now
using standard dm_list function for destroy, we have to make sure
dm_list gets initialized properly.
 2012-02-08 13:44:49 +00:00
Zdenek Kabelac
a7e2da0585 Thin add pool_below_threshold 
Test both data and metadata percent usage.
 2012-02-08 13:05:38 +00:00
Zdenek Kabelac
cdcf7aaf07 A bit more readable code 
Just a minor readability conversion.
 2012-02-08 13:03:40 +00:00
Zdenek Kabelac
94f88a4f14 Fix test for lv_snapshot_percent 
Do not check for PERCENT_MERGE_FAILED if the lv_snapshot_percent() failed.
(test for snap_percent would be testing uninitialized value).
 2012-02-08 13:02:07 +00:00
Zdenek Kabelac
a13efe5665 Drop unreachable code 2012-02-08 12:59:45 +00:00
Zdenek Kabelac
d707e133d3 Use dm_asprintf to simplify code 2012-02-08 12:59:19 +00:00
Zdenek Kabelac
9278655de1 Some fixmes 
'len' calculation is unused ?
Unreachable code could be removed or moved upward ?
 2012-02-08 12:57:15 +00:00
Zdenek Kabelac
462835faa0 Switch to return void 
List delete cannot fail, so there is no reason to test for error.
 2012-02-08 12:52:58 +00:00
Zdenek Kabelac
33dea28e23 Use dm_snprintf and improve error handling 
Add standard error reporting with error logging.
Use plain alloc instead of zalloc for string buffer.
Use dm_snprintf with valid test for <0.
 2012-02-08 12:50:10 +00:00
Zdenek Kabelac
7ffca95bb6 Add range test for device number 
Check the output of atoi is in valid range.
 2012-02-08 12:48:14 +00:00
Zdenek Kabelac
eae8784ae2 Remove duplicate test 
Tested condition has been already evaluated before
For strlen() code has already excluded <ID_LEN.
For repairing, already tested (!argc && !repairing) before.
 2012-02-08 11:41:18 +00:00
Zdenek Kabelac
d75c5f06f0 Replace snprintf with dm_snprintf 
snprintf testing for negative is replaced with dm_snprintf where this
test really works.
Add missing test for result of dm_snprintf().
 2012-02-08 11:40:02 +00:00
Zdenek Kabelac
a6292f2a6d Remove unneeded assignments 
Variables have (or will have) those values set.
 2012-02-08 11:36:18 +00:00
Zdenek Kabelac
3a8b6a9948 Keep page_size as signed number 
Since it's return value from sysconf and is checked for <0.
 2012-02-08 11:34:46 +00:00
Zdenek Kabelac
84fd8ea4bd Move done jump lower 
Since before 'goto done' is bufused zeroed, it would otherwise write 1
byte in front of buffer.
 2012-02-08 11:31:29 +00:00
Zdenek Kabelac
b63b775143 Add boundary test for number of mirror devs and logs 
As atoi may return negative value - test for both limits.
Test log_args for limits before calling alloca().
Code from dmeventd mirror plugin should probably share same code as
we have in mirrored.c.
 2012-02-08 11:29:13 +00:00
Zdenek Kabelac
ebc9abf6c0 Set all parameters to 0 
Since the function dm_get_next_target() returns NULL as 'next' pointer
so it's not a 'real' error - set 0 to all parameters when NULL is
returned because of missing head.

i.e. one of use case::
do {
	next = dm_get_next_target(dmt, next, &start, &length,
				  &target_type, &params);
	size += length;
} while (next);
 2012-02-08 11:25:09 +00:00
Zdenek Kabelac
0154bcf0a7 Check that whole locking_dir fits _lock_dir buffer 2012-02-08 11:17:34 +00:00
Zdenek Kabelac
1a39fa0073 Move close few lines 
Since the function dev_close() has code path, which really could close
file (for unlocked vg) and destroy dev handler, stay on safe side and move
the close few lines later, even our current use case shouldn't trigger
such scenario.
 2012-02-08 11:15:38 +00:00
Zdenek Kabelac
02aeb23f1f Use dm_list_iterate_items_safe 
And avoid direct access to list member variables.
Inline _free_li().
 2012-02-08 11:12:18 +00:00
Zdenek Kabelac
b6e97cea2c Fix fd resource leak in error path 
Use 'goto bad' to cleanup fd on error path.
 2012-02-08 11:07:17 +00:00
Zdenek Kabelac
5dfd775384 Ensure strncpy() function always ends with '\0' 
Since last character needs to be \0 for string,
pass buffer size smaller by 1 byte.
 2012-02-08 11:05:04 +00:00
Zdenek Kabelac
cd4c26a27f Set status for error path 
Do not leave status unitialized, since in some cases, it's tested,
when the function returns error.
 2012-02-08 10:56:17 +00:00
Zdenek Kabelac
f9bd70878b Add missing deps for lvm2api 
Hmm, wasted some time because of this missing deps....
 2012-02-08 10:52:45 +00:00
Zdenek Kabelac
ee54e43702 Fix resource leaks for failing allocation 
In case, something would fail during format initialization,
return allocated memory.
 2012-02-08 10:49:36 +00:00
Zdenek Kabelac
12ac6f9f11 Release allocated resources in error path 
If composite_filter_create() fails, release filters.
 2012-02-08 10:46:24 +00:00
Zdenek Kabelac
7b408a08ef Check result of lstat 
If lstat returns errno different from ENOENT, do not use the content of
struct stat 'buf'.
 2012-02-08 10:43:42 +00:00
Petr Rockai
3959c60250 What's new. 2012-02-01 20:13:44 +00:00
Petr Rockai
cd466297f4 Remove a dubious log message ("another thread is handling an event") from LVM 
dmeventd plugins. Fixes RHBZ 771419.
 2012-02-01 20:11:58 +00:00
Alasdair Kergon
2a57a934bb post-release 2012-02-01 18:46:57 +00:00
Alasdair Kergon
c8250560cd pre-release 2012-02-01 15:17:04 +00:00
Alasdair Kergon
b167ca28b0 Adjust comments 2012-02-01 15:05:53 +00:00
Zdenek Kabelac
42b5c54092 Add synchornization point in mirror log init. 
Put extra sync point when mirror log is deactivated and before
it's activated for the second time.
 2012-02-01 13:50:36 +00:00
Zdenek Kabelac
ab852ffe66 Disable partial activation for thin LVs and LVs with all missing segments 
Count number of error and existing areas and if there is no existing area
for the LV avoid its activation.

Always disable partial activatio for thin volumes.

For mirrors currently put in hack to let it pass with a special name
since current mirror code needs to activate such LV during some operations.
 2012-02-01 13:47:27 +00:00
Zdenek Kabelac
dfb679e5c7 Avoid warning for small pv_min_size 
Do not print warning for pv_min_size set in range between 512KB and 2MB.
 2012-02-01 13:42:18 +00:00
Peter Rajnoha
b627165a75 Clean up systemd unit ordering and requirements. 2012-02-01 13:08:39 +00:00
Zdenek Kabelac
489bf2fbdf Minor consistency update for debugging messages 
Use mlock/munlock for debugging lines.
 2012-02-01 10:48:22 +00:00
Zdenek Kabelac
8d2d4f2026 User correct base dir for lcov reports 
Fix problem when srcdir != builddir.
 2012-02-01 10:46:45 +00:00
Alasdair Kergon
1368dc905a lost line 2012-02-01 02:11:43 +00:00
Alasdair Kergon
72abf1d880 Track unreserved space for all alloc policies and then permit NORMAL to place 
log and data on same single PV.
 2012-02-01 02:10:45 +00:00
Alasdair Kergon
f2e3d659ea lp.pool may be (null) too 2012-02-01 01:54:20 +00:00