Petr Rockai
8191fe4f4a
Refactor the percent (mirror sync, snapshot usage) handling code to use
...
fixed-point values instead of a combination of a float value and an enum.
2010-11-30 11:53:31 +00:00
Petr Rockai
0669d21847
Fix a failing test (it used a combination of lvconvert parameters that is no
...
longer permitted.)
2010-11-30 11:35:32 +00:00
Petr Rockai
97e8048e05
Avoid the automatic MISSING_PV recovery path in commands with special
...
MISSING_PV handling (cmd->handles_missing_pvs is set).
2010-11-30 11:15:54 +00:00
Alasdair Kergon
1415afcdba
Fix memory leak when VG allocation policy in metadata is invalid.
...
Ignore unrecognised allocation policy found in metadata instead of aborting.
Fix another missing vg_release() in _vg_read_by_vgid.
2010-11-29 18:35:37 +00:00
Zdenek Kabelac
2e3be4f3fd
Optimize lookup table read
...
Reread lookup table only when needed.
2010-11-29 14:25:13 +00:00
Zdenek Kabelac
b20e74d5d6
Remove dead assignment in wait_for_child
...
'pid' is not used anywhere - remove it.
2010-11-29 12:44:52 +00:00
Zdenek Kabelac
4cb0f557d9
Remove dead assignment in _step_matcher
...
'ns' is not used after this assignment and it is reassigned with the following
code, so dropping this assignment.
2010-11-29 12:43:49 +00:00
Zdenek Kabelac
5f3325fcf1
Remove dead assignment in _mirror_emit_segment_line
...
Remove unused 'r' assignment.
2010-11-29 12:42:10 +00:00
Zdenek Kabelac
21ba805499
Fix memory leak in error path
...
Nicely hidden memory leak in outf macro error path.
This macro is using out_text() and does automagical return_0.
That would leak tag_buffer allocated memory.
As there was same code for tags output - create _out_tags() function.
2010-11-29 12:19:58 +00:00
Zdenek Kabelac
693ec4b404
Use one fprintf call for usage print
...
Replace multiple fprintf calls with multiline one.
2010-11-29 12:15:41 +00:00
Zdenek Kabelac
cbecd3cd11
Remove dead assignment in dm_tree_node_add_mirror_target_log
...
'seg' is never used - remove it.
2010-11-29 11:26:00 +00:00
Zdenek Kabelac
2e8d681cf2
Remove dead assignment in 'main'
...
'ret' is never read anywhere - remove it.
2010-11-29 11:23:14 +00:00
Zdenek Kabelac
dce59eb407
Remove unused 'i' in _pv_analyze_mda_raw
...
'i' is unused in the function - remove it.
2010-11-29 11:16:58 +00:00
Zdenek Kabelac
a8cc07b564
Remove dead assignment in lvm2_main
...
'alias' is not read again in this code path.
Also 'alias' is already equal to 0 in this place.
2010-11-29 11:14:33 +00:00
Zdenek Kabelac
73e3226012
Remove dead assignment in _lock_for_cluster
...
'saved_errno' is not read from this initialization and before its
usage is assigned again before _cluster_free_request() call.
2010-11-29 11:13:12 +00:00
Zdenek Kabelac
201222ebad
Reset vg pointer after release
...
Set vg to NULL after releasing it as the following memlock() test may
lead to goto for the second call of vg_release() with the already
released vg pointer.
2010-11-29 11:08:14 +00:00
Zdenek Kabelac
1b88184104
Remove printing of LCK_CACHE
...
LCK_CACHE is defined as 0x100 so it cannot be passed through
unsigned char parameter - remove it from the sprintf code.
If the LCK_CLUSTER should be printed here - lot of code need
to be reworked - so adding FIXME comment.
2010-11-29 11:05:15 +00:00
Zdenek Kabelac
99aacef51c
Fix check for empty system_dir
...
Fixing check for zero length system_dir string.
2010-11-29 10:58:32 +00:00
Zdenek Kabelac
8661190736
Cleanup remove test for NULL
...
dm_free is testing NULL itself
2010-11-29 10:11:50 +00:00
Mike Snitzer
a2f5ce8181
Fix "it's" typo to be "its" in lvconvert error message.
2010-11-28 18:37:33 +00:00
Petr Rockai
964916f8f3
Update WHATS_NEW.
2010-11-25 17:16:41 +00:00
Petr Rockai
a680e90fb0
Disallow certain lvconvert operations that need to both allocate and free
...
extents, while physical volumes are specified. Fixes BZ 640051.
2010-11-25 17:15:46 +00:00
Petr Rockai
0bc382eae4
All 'size' values of lvm2app properties should be in bytes.
...
Fix 'seg_size' to return bytes.
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-25 14:39:02 +00:00
Petr Rockai
f2afa4f21d
Add interactive tests for functions to lookup a pv|lv by name|uuid.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-25 14:35:46 +00:00
Petr Rockai
5219fe3ca8
This patch adds helpers to allow users to lookup a lv or pv handle by
...
uuid (given a vg_t of course).
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-25 14:34:51 +00:00
Petr Rockai
14b0c96bc7
This patch adds helpers to allow users to lookup a lv or pv handle by
...
name (given a vg_t of course).
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-25 14:33:44 +00:00
Zdenek Kabelac
46f84d5cb9
Add missing destrustion of cmd_context
...
Lvm1 fallback code missed to destroy cmd_context in error path.
2010-11-24 09:53:31 +00:00
Zdenek Kabelac
9d6d98c900
Fix memory leak in error path
...
Release allocated path buffer in error path.
2010-11-24 09:43:18 +00:00
Zdenek Kabelac
e8ec0ba2e3
Fix resource leak of dlopened pointer
...
Add missing dlclose in _init_formats() error path.
Use return_0 to print stack trace from the call.
2010-11-24 09:34:34 +00:00
Zdenek Kabelac
2044eacc7e
Add missing fclose
...
Fixing resource leak in _umount().
CHECKME: mountpoints with spaces need to be checked
2010-11-23 21:19:45 +00:00
Zdenek Kabelac
aaa7f4c966
Move arg_vgnames from local scope
...
As gcc puts probably all vars on stack this bug was not noticed in runtime.
Patch fixes referencing local scope list variable.
2010-11-23 20:39:13 +00:00
Zdenek Kabelac
f46de65682
Do not call dm_task_destroy with NULL
2010-11-23 18:29:06 +00:00
Zdenek Kabelac
0a178d853a
Add missing closedir() - fixes resource leak
2010-11-23 15:28:54 +00:00
Zdenek Kabelac
7d11d708d8
Move va_end() so it is also used before error path return
2010-11-23 15:08:57 +00:00
Zdenek Kabelac
b2594b047b
Move va_end(ap) so we do not leave with return -1 without calling it.
...
Remove unneeded ';'
2010-11-23 15:00:52 +00:00
Alasdair Kergon
728074ac83
Suppress 'No PV label' message when removing several PVs without mdas.
2010-11-23 01:55:53 +00:00
Alasdair Kergon
9cd9dab06a
Fix default /etc/lvm permissions to be 0755. (2.02.66)
2010-11-22 21:39:47 +00:00
Alasdair Kergon
663886b954
post-release
2010-11-22 18:37:56 +00:00
Alasdair Kergon
2151f044e8
pre-release
2010-11-22 14:25:22 +00:00
Alasdair Kergon
ef3d8e18d3
Fix _output_field crash from field_id free with DEBUG_MEM. (Phillip Susi)
2010-11-19 13:17:27 +00:00
Petr Rockai
dd5b5fb794
The _free_vg that is created as a placeholder when reporting segments in pvs
...
was lacking the (vgmem) pool. We now create that pool. There is at least one
more such VG (_dummy_vg) which is pool-less. I am not sure what is the right
way to go about this, but this is currently necessary to fix a segfault
introduced by using vgmem in the reporter in Dave's lvseg lvm2app patches.
Signed-off-by: Petr Rockai <prockai@redhat.com>
2010-11-17 22:26:42 +00:00
Petr Rockai
f6531a5f00
Update interactive tests for lvm2app lvseg and pvseg apis.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:13:51 +00:00
Petr Rockai
55429cde3c
Add lvm2app function to query pvseg properties.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:12:39 +00:00
Petr Rockai
4543dac58e
Add the macro and specific 'get' functions for pvsegs.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:11:27 +00:00
Petr Rockai
b2b27cd7f4
Add a new type and function to lvm2app to enumerate pvsegs.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:10:42 +00:00
Petr Rockai
5de70620ef
Add lvm2app function to query lvseg properties.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:09:42 +00:00
Petr Rockai
c1abd569f2
Add the macro and specific 'get' functions for lvsegs.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:08:14 +00:00
Petr Rockai
ecc511167a
Add a new type and function to lvm2app to enumerate lvsegs.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 20:07:01 +00:00
Petr Rockai
cbff112651
Make value.string const char *, in properties.h, to fix a warning introduced by
...
the previous patch set.
2010-11-17 19:50:15 +00:00
Petr Rockai
50814ddb75
Add vg_set_property to the interactive lvm2app test program.
...
Signed-off-by: Dave Wysochanski <wysochanski@pobox.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
2010-11-17 19:17:07 +00:00