shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity
6,379 Commits 425 Branches 667 Tags 54 MiB
a6292f2a6d
Commit Graph

6379 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zdenek Kabelac
a6292f2a6d Remove unneeded assignments 
Variables have (or will have) those values set.
 2012-02-08 11:36:18 +00:00
Zdenek Kabelac
3a8b6a9948 Keep page_size as signed number 
Since it's return value from sysconf and is checked for <0.
 2012-02-08 11:34:46 +00:00
Zdenek Kabelac
84fd8ea4bd Move done jump lower 
Since before 'goto done' is bufused zeroed, it would otherwise write 1
byte in front of buffer.
 2012-02-08 11:31:29 +00:00
Zdenek Kabelac
b63b775143 Add boundary test for number of mirror devs and logs 
As atoi may return negative value - test for both limits.
Test log_args for limits before calling alloca().
Code from dmeventd mirror plugin should probably share same code as
we have in mirrored.c.
 2012-02-08 11:29:13 +00:00
Zdenek Kabelac
ebc9abf6c0 Set all parameters to 0 
Since the function dm_get_next_target() returns NULL as 'next' pointer
so it's not a 'real' error - set 0 to all parameters when NULL is
returned because of missing head.

i.e. one of use case::
do {
	next = dm_get_next_target(dmt, next, &start, &length,
				  &target_type, &params);
	size += length;
} while (next);
 2012-02-08 11:25:09 +00:00
Zdenek Kabelac
0154bcf0a7 Check that whole locking_dir fits _lock_dir buffer 2012-02-08 11:17:34 +00:00
Zdenek Kabelac
1a39fa0073 Move close few lines 
Since the function dev_close() has code path, which really could close
file (for unlocked vg) and destroy dev handler, stay on safe side and move
the close few lines later, even our current use case shouldn't trigger
such scenario.
 2012-02-08 11:15:38 +00:00
Zdenek Kabelac
02aeb23f1f Use dm_list_iterate_items_safe 
And avoid direct access to list member variables.
Inline _free_li().
 2012-02-08 11:12:18 +00:00
Zdenek Kabelac
b6e97cea2c Fix fd resource leak in error path 
Use 'goto bad' to cleanup fd on error path.
 2012-02-08 11:07:17 +00:00
Zdenek Kabelac
5dfd775384 Ensure strncpy() function always ends with '\0' 
Since last character needs to be \0 for string,
pass buffer size smaller by 1 byte.
 2012-02-08 11:05:04 +00:00
Zdenek Kabelac
cd4c26a27f Set status for error path 
Do not leave status unitialized, since in some cases, it's tested,
when the function returns error.
 2012-02-08 10:56:17 +00:00
Zdenek Kabelac
f9bd70878b Add missing deps for lvm2api 
Hmm, wasted some time because of this missing deps....
 2012-02-08 10:52:45 +00:00
Zdenek Kabelac
ee54e43702 Fix resource leaks for failing allocation 
In case, something would fail during format initialization,
return allocated memory.
 2012-02-08 10:49:36 +00:00
Zdenek Kabelac
12ac6f9f11 Release allocated resources in error path 
If composite_filter_create() fails, release filters.
 2012-02-08 10:46:24 +00:00
Zdenek Kabelac
7b408a08ef Check result of lstat 
If lstat returns errno different from ENOENT, do not use the content of
struct stat 'buf'.
 2012-02-08 10:43:42 +00:00
Petr Rockai
3959c60250 What's new. 2012-02-01 20:13:44 +00:00
Petr Rockai
cd466297f4 Remove a dubious log message ("another thread is handling an event") from LVM 
dmeventd plugins. Fixes RHBZ 771419.
 2012-02-01 20:11:58 +00:00
Alasdair Kergon
2a57a934bb post-release 2012-02-01 18:46:57 +00:00
Alasdair Kergon
c8250560cd pre-release 2012-02-01 15:17:04 +00:00
Alasdair Kergon
b167ca28b0 Adjust comments 2012-02-01 15:05:53 +00:00
Zdenek Kabelac
42b5c54092 Add synchornization point in mirror log init. 
Put extra sync point when mirror log is deactivated and before
it's activated for the second time.
 2012-02-01 13:50:36 +00:00
Zdenek Kabelac
ab852ffe66 Disable partial activation for thin LVs and LVs with all missing segments 
Count number of error and existing areas and if there is no existing area
for the LV avoid its activation.

Always disable partial activatio for thin volumes.

For mirrors currently put in hack to let it pass with a special name
since current mirror code needs to activate such LV during some operations.
 2012-02-01 13:47:27 +00:00
Zdenek Kabelac
dfb679e5c7 Avoid warning for small pv_min_size 
Do not print warning for pv_min_size set in range between 512KB and 2MB.
 2012-02-01 13:42:18 +00:00
Peter Rajnoha
b627165a75 Clean up systemd unit ordering and requirements. 2012-02-01 13:08:39 +00:00
Zdenek Kabelac
489bf2fbdf Minor consistency update for debugging messages 
Use mlock/munlock for debugging lines.
 2012-02-01 10:48:22 +00:00
Zdenek Kabelac
8d2d4f2026 User correct base dir for lcov reports 
Fix problem when srcdir != builddir.
 2012-02-01 10:46:45 +00:00
Alasdair Kergon
1368dc905a lost line 2012-02-01 02:11:43 +00:00
Alasdair Kergon
72abf1d880 Track unreserved space for all alloc policies and then permit NORMAL to place 
log and data on same single PV.
 2012-02-01 02:10:45 +00:00
Alasdair Kergon
f2e3d659ea lp.pool may be (null) too 2012-02-01 01:54:20 +00:00
Alasdair Kergon
b6d7a48480 Automatically detect whether corosync clvmd needs to use confdb or cmap. (fabio) 2012-01-31 21:21:53 +00:00
Zdenek Kabelac
15fd61e492 Fix data% reporting 
For reading % of mapped size of thin volume use as origin for
old style snapshot '-real' device needs to be queried.
Fix log_error report given for lvs -a in this case.
 2012-01-28 20:12:26 +00:00
Zdenek Kabelac
400dede7a6 TARGETS macro has to be defined before inclusion of make.tmpl 
Use @TESTING@ check in this case.
 2012-01-27 10:55:02 +00:00
Alasdair Kergon
91c631c558 post-release 2012-01-27 01:23:40 +00:00
Zdenek Kabelac
599771c9b0 Build test run target only for $(TESTING) 
Add libraries properly in LDLIBS.
 2012-01-26 21:40:36 +00:00
Zdenek Kabelac
7012268499 Thin for_each_sub_lv 
Adapt to scan thin dependency LVs
 2012-01-26 21:39:32 +00:00
Zdenek Kabelac
6255e1b5f0 If clvmd is not started, die test instead of skipping it 2012-01-26 18:25:46 +00:00
Zdenek Kabelac
eb2dd721ab Oops missed braces in previous commit 
This has disabled clvmd for being executed.
(FIXME improve testing part to catch this fault)
 2012-01-26 17:55:55 +00:00
Alasdair Kergon
a1991f101d pre-release 2012-01-26 14:02:42 +00:00
Alasdair Kergon
b475be8d77 pre-release 2012-01-26 10:11:30 +00:00
Zdenek Kabelac
b39b36eeb5 Cosmetic change use return macro with implicit stack 2012-01-25 22:38:40 +00:00
Zdenek Kabelac
42beb34826 Set missing header define 2012-01-25 22:37:48 +00:00
Zdenek Kabelac
4125cf5067 Fix leak of hash table 
Minor leak on command initialization.
 2012-01-25 22:36:33 +00:00
Zdenek Kabelac
96bffe6a4a Instrument code that pointer are already released 
Set pointers to NULL since on the function exit they are no longer valid.
 2012-01-25 22:35:36 +00:00
Zdenek Kabelac
254944d890 Set to a defined value vars used after error path 
Static analyzer noticed this vars are used even when error is reported
back thus their state is undefined - set to 0 for this case.
 2012-01-25 22:20:11 +00:00
Zdenek Kabelac
b45035ee14 Test for uname result 
in fail path initialize to 0.
 2012-01-25 22:17:57 +00:00
Zdenek Kabelac
209da6efee Fix missing dmt destructor 
Also always initialize maj,min,patchlevel when success is returned.
 2012-01-25 22:16:04 +00:00
Zdenek Kabelac
a980f56d2a Free allocated segment type in error path 2012-01-25 21:54:00 +00:00
Zdenek Kabelac
1ef10bd81a Limit alignment to 32bit values 
to get the same behavior on 32/64 machines.
 2012-01-25 21:52:53 +00:00
Zdenek Kabelac
fc5c61df97 Ensure whole info is initialised 
Since _create_dm_tree_node is copying whole structure,
make sure all members are initialized.
 2012-01-25 21:50:50 +00:00
Zdenek Kabelac
0e6cacbbb6 Fix resource leak of file handle 
Introduces when added dm_device_get_name.
Close file handle in all error paths.
 2012-01-25 21:47:18 +00:00