Zdenek Kabelac
cc82dc7b23
cleanup: pvdisplay indent
...
Reindent else path, since other branch already exits with return.
2014-03-30 23:44:59 +02:00
Zdenek Kabelac
d7b6334079
cleanup: vgexport drops pv pointer
...
PV pointer is not really needed.
2014-03-30 23:44:59 +02:00
Zdenek Kabelac
31d68b7124
man: sort options
...
Sort order for -C|--columns as with other options,
and use short capital name as the first (as with other options).
Also drop multiple reference for pvs/lvs/vgs, since now
the text for -C is really close to referrence of lvm anyway.
2014-03-30 23:43:31 +02:00
Zdenek Kabelac
7a9c569eb4
pvscan: return error when free parameter is given
...
Just like vgscan, pvscan (without --cache option) is not
accepting and 'free' args (i.e. pvscan /dev/sdx)
2014-03-30 23:42:57 +02:00
Zdenek Kabelac
844afa32a0
pvdisplay: fix option error
...
Properly show error for '-m'.
Also report unsupported '-c & -s' (just like with vg/lvdisplay)
2014-03-30 23:41:52 +02:00
Zdenek Kabelac
cf29de5de0
vgimport/vgexport: return invalid cmd
...
When option parsing fails, return invalid cmd instead of fail.
2014-03-30 23:40:27 +02:00
Zdenek Kabelac
5aa2e5ec8c
tests: update pvs test
...
TODO:
It seems commit 7e685e6c70
has changed the old logic, when 'pvs device_name' used
to work. (regression from 2.02.104)
Currently put in extra pvscan.
2014-03-28 17:06:13 +01:00
Zdenek Kabelac
3181dc72e7
tests: more coverage for pvchange
...
Change metadataignore
Argless pvchange
Alocatability for orphans
2014-03-28 11:38:50 +01:00
Zdenek Kabelac
2a79971004
tests: check pvchange changes uuid
2014-03-28 10:41:59 +01:00
Zdenek Kabelac
09b180cfc2
tests: expect failing pvs when missing PV
2014-03-28 10:41:59 +01:00
Zdenek Kabelac
88a9705222
pvchange: populate lvmcache for --all
...
When running pvchange --all learn about available VGs from lvmetad.
2014-03-28 10:41:58 +01:00
Marian Csontos
3d0ba79f86
lvconvert: fix help message cache_pool -> cache-pool
2014-03-28 09:10:30 +01:00
Zdenek Kabelac
a512ea6a6a
tests: updates
2014-03-28 00:41:19 +01:00
Zdenek Kabelac
bd805ff048
tests: move some tests to better places
...
Some tests already have separate test scripts - so move
those tests to listing and vgcfgbackup files.
2014-03-28 00:41:19 +01:00
Zdenek Kabelac
5b44a036b1
tests: support invalid and fail results
...
Allow more detailed check for failing exit code:
invalid - expects 3
fail - expects 5
2014-03-28 00:41:19 +01:00
Zdenek Kabelac
0e02551f04
spec: add dumpconfig man
2014-03-28 00:41:19 +01:00
Peter Rajnoha
6d314466f3
man: better formatting for lvm dumpconfig man page
2014-03-27 14:18:41 +01:00
Peter Rajnoha
801d43445d
man: add man page for lvm dumpconfig
2014-03-27 14:03:28 +01:00
Zdenek Kabelac
c7a89323f5
fix spurios char
...
Mistyped char left in code.
2014-03-27 13:49:24 +01:00
Zdenek Kabelac
4ebdfcfb59
tests: more pvchange options examined
2014-03-27 13:13:22 +01:00
Zdenek Kabelac
04a6918518
tests: cover more commands
...
Visit more code lines.
2014-03-27 13:13:09 +01:00
Zdenek Kabelac
fc8185601d
cleanup: indent change
2014-03-27 13:13:09 +01:00
Zdenek Kabelac
5076456a73
debug: avoid warning when compiled with valgrind
...
Declare 'c' only when compiling without valgrind.
This cleans compiler warning about unused var when
compiled with valgrind pool support.
2014-03-27 13:13:08 +01:00
Zdenek Kabelac
356fdda46d
lv_manip: drop cmd pointer from for_each_sub_lv
...
Drop unused passed cmd pointer from function.
TODO:
We have two similar functions (though not identical)
lv_manip.c: for_each_sub_lv()
metadata.c: _lv_each_dependency()
They seem to not always match - we should probably convert
to use only a single function.
2014-03-27 13:10:13 +01:00
Zdenek Kabelac
22579b4451
lv_rename: validate renamed sublv
...
Use proper vgmem memory pool for allocation of LV name in the vg
and check if new renamed LV is a valid name.
TODO: validation should really use also VG name, othewise we are not
able to tell "vgname-lvname" will be valid.
2014-03-27 13:06:23 +01:00
Zdenek Kabelac
28e4bf0b6d
lvrename: fix exit code
...
Return invalid cmd line (3) when error is detect on cmd line input.
Cmd failed (5) is used when command processing fails.
2014-03-27 13:04:55 +01:00
Zdenek Kabelac
80fe100afa
pvchange: fix exit code regression
...
Commit 1a832398a7
moved
some code from _pvchange_single() to main pvchange() and
introduced exit code regression as return codes have not
been properly changed, thus pvchange command exited
with '0' exit code, even though it has reported error.
Also there is a missing vg unlock in error path.
Fix it by counting the total number of expected calls before
checking for pvname and also unlock and relase vg when
pv is not found.
2014-03-27 13:01:51 +01:00
Zdenek Kabelac
2a93eba68e
cleanup: easier casting
...
Use 32bit for extent calcs.
Drop uneeded implicit case.
2014-03-26 14:11:37 +01:00
Zdenek Kabelac
0499e87ace
cleanup: simplify pv name size estimation
...
Reuse buffer with size of 2 * PATH_MAX to handle worst case escape
and avoid extra calculation of espaced len.
2014-03-26 14:11:37 +01:00
Zdenek Kabelac
3fda296da6
cleanup: lvmetad use dm_hash_iterator
...
Simplify code with the use of dm_hash_iterator
2014-03-26 14:11:37 +01:00
Zdenek Kabelac
dae455f806
man: colorization fixes
...
Fix style
2014-03-26 14:11:37 +01:00
Zdenek Kabelac
bda0fe95ad
man: add repair info for thin pools
...
Document lvconvert --repair for thin pools.
2014-03-26 14:11:36 +01:00
Petr Rockai
a3615f3149
lvmetad: Fix an endless wait loop introduced in c13f5dbb
.
2014-03-26 11:45:28 +01:00
Zdenek Kabelac
a2614c6866
tests: missed exclusive activation
2014-03-26 00:22:23 +01:00
Zdenek Kabelac
5b900dbef5
tests: pass list devs to allocate from
2014-03-26 00:05:46 +01:00
Zdenek Kabelac
1259ae5954
tests: cover code from more commands
2014-03-26 00:05:46 +01:00
Zdenek Kabelac
4b30863e85
tests: check forced backup
2014-03-26 00:05:46 +01:00
Zdenek Kabelac
4adbb85c37
tests: disable test for broken kernel raid targe
...
Since using raid5 - validate it's usable on the system
2014-03-26 00:04:59 +01:00
Zdenek Kabelac
fb471a372d
tests: remove also 3.14 fc21 kernels
2014-03-26 00:04:59 +01:00
Petr Rockai
c13f5dbb25
lvmetad: Wait at least 80s for the initial scan.
2014-03-25 16:38:35 +01:00
Zdenek Kabelac
65bbfdf74d
lvmetad: add missing dev_close in error path
...
Fixes missing dev_close() in dev_read error path
introduced in commit
a368698672
3e5bec37e9
(in-release fix)
2014-03-25 14:55:58 +01:00
Peter Rajnoha
ce78cb58eb
lvmdump: add lvm dumpconfig --type diff/missing
...
For a quick overview of config when debugging and to quickly check
which values are different from defaults and which are not defined
in the config and for which defaults are used.
2014-03-25 13:06:59 +01:00
Zdenek Kabelac
0738f0ad72
pvresize: fail exit code for negative size
...
Pvresize with negative value retuns invalid cmd line exit code.
2014-03-25 11:52:03 +01:00
Zdenek Kabelac
8471fb01d8
tests: wipe signature
...
Check for usable blkid.
2014-03-25 11:23:00 +01:00
Zdenek Kabelac
3c9204a75a
tests: update
2014-03-25 11:23:00 +01:00
Zdenek Kabelac
36d87eddcf
tests: use exclusive activation
...
pvmove in cluster needs exlusive activation or cmirrord running.
2014-03-25 11:23:00 +01:00
Zdenek Kabelac
db1d4ba4ac
tests: argless pvremove
2014-03-25 11:23:00 +01:00
Zdenek Kabelac
04861b9bed
tests: more pvresize tests
...
Maybe move to separate pvresize test,
remove vgck size this is already executed elsewhere.
2014-03-25 11:22:59 +01:00
Zdenek Kabelac
db04d3e6d2
tests: relocate vgimport test
...
It seem like a better-fit here.
2014-03-25 11:22:59 +01:00
Zdenek Kabelac
13258d6e96
debug: add proper backtrace debug
...
When failure happens inside refresh, print proper debug backtrace.
2014-03-25 11:22:59 +01:00