Christine Caulfield
e7bdd69af0
If lvm.conf was touched, clvmd attempted to update the toolcontext
...
but only did half of the job. It now shares the do_refresh_cache()
function that vgscan invokes.
2008-04-04 08:53:47 +00:00
Alasdair Kergon
fefc655969
Add some basic internal VG lock validation.
2008-04-03 18:56:40 +00:00
Alasdair Kergon
4dceaef60e
.
2008-04-03 14:40:34 +00:00
Alasdair Kergon
6fc10dd3ae
.
2008-04-03 14:32:31 +00:00
Alasdair Kergon
1ecd05a584
fix vd->virtblk
2008-04-03 10:29:00 +00:00
Alasdair Kergon
976acaca31
enable vg metadata cache by default
2008-04-02 21:31:14 +00:00
Alasdair Kergon
b4e5131d59
Add per-command flags to control which commands use the VG metadata cache.
2008-04-02 21:23:39 +00:00
Dave Wysochanski
49f7cfefd7
Fix vgsplit locking and remove unneeded error messages when split into new VG.
...
When vg_lock_and_read() calls were added, they were done so incorrectly for
the destination VG (vg_to). This resulted in the VG lock not obtained when
a new VG was the destination (vg_lock_and_read() would fail in the vg_read()
clause, which would then release the lock before returning NULL), and could
result in corrupted destination VG.
The fix was to put back the original lock_vol() and vg_read() calls for 'vg_to'.
The failure of vg_read() indicates "vg does not exist", and we key off that
to determine whether we are dealing with a new or existing VG as the
destination.
The first two error messages were also the result of the incorrect
vg_lock_and_read() calls:
Volume group "new" not found
cluster request failed: Invalid argument
New volume group "new" successfully split from "vg"
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=438249
2008-04-02 19:30:12 +00:00
Dave Wysochanski
fc365092f6
Suppress "Volume group not found" message when vgsplit of new VG.
2008-04-02 13:08:49 +00:00
Dave Wysochanski
7f26240442
Fix lvresize to dump stack if vg_lock_and_read() fails.
...
Necessary because vg_lock_and_read() may fail silently if the vg_check_status() call fails.
Also add lvresize tests.
2008-04-02 12:17:30 +00:00
Alasdair Kergon
db559bb20a
Cache VG metadata internally while VG lock is held.
2008-04-01 22:40:13 +00:00
Dave Wysochanski
52850faa15
Fix redundant lvresize message if vg doesn't exist.
...
BEFORE:
tools/lvm lvresize -l +4 vg22/lv1linear
Volume group "vg22" not found
Volume group vg22 doesn't exist
AFTER:
tools/lvm lvresize -l +4 vg22/lv1linear
Volume group "vg22" not found
2008-04-01 22:15:16 +00:00
Christine Caulfield
57d9a6c836
Fix another allocation bug with clvmd and large node IDs.`
2008-04-01 15:01:30 +00:00
Dave Wysochanski
752c880bfc
Add find_lv_in_lv_list() and find_pv_in_pv_list().
...
Update _add_pvs() to call find_pv_in_pv_list().
2008-03-28 19:08:23 +00:00
Dave Wysochanski
d83a354781
Enhance test debugging by updating verbose mode of check_*_field_ functions.
...
Author: Dave Wysochanski <dwysocha@redhat.com>
2008-03-28 18:02:22 +00:00
Christine Caulfield
17dd81336d
Fix a couple of uninitialised variables. The newfd one could cause
...
some obscure hangs.
2008-03-28 12:58:09 +00:00
Dave Wysochanski
eaa46a2575
Add vgmerge tests.
2008-03-26 18:03:35 +00:00
Dave Wysochanski
fc0ec1e71e
Use list_move() in applicable places.
2008-03-26 17:26:32 +00:00
Dave Wysochanski
fb2f92df1d
Add pvseg_is_allocated() for identifying a PV segment allocated to a LV.
2008-03-26 16:48:10 +00:00
Dave Wysochanski
74adbb77b7
Add list_move() support function for list manipulation.
2008-03-26 16:20:54 +00:00
Dave Wysochanski
788e544e1d
Add 'is_reserved_lvname()' helper function.
...
Very similar to apply_lvname_restrictions but without the error messages.
2008-03-25 15:24:59 +00:00
Alasdair Kergon
368a0d4d2d
Correct command name in lvmdiskscan man page.
2008-03-25 12:37:48 +00:00
Christine Caulfield
962b7222d0
When reallocating the node IDs array, make it bigger rather than smaller!
2008-03-25 10:41:59 +00:00
Dave Wysochanski
17c1f54369
Add vgsplit tests to verfy attributes of new VG match source VG.
...
Author: Dave Wysochanski <dwysocha@redhat.com>
2008-03-23 15:40:35 +00:00
Dave Wysochanski
33ae38e71b
Fixup vgsplit tests in preparation for vgsplit changes.
2008-03-21 22:00:29 +00:00
Dave Wysochanski
ef58af4bf1
Update vgsplit tests to execute twice (existing and new VG as destination).
2008-03-21 21:14:38 +00:00
Dave Wysochanski
3fad2db2f8
Add LV and VG name restrictions to the lvm man page.
...
Original patch by: Gerrard Geldenhuis <Gerrard.Geldenhuis@datacash.com>
2008-03-20 18:34:29 +00:00
Alasdair Kergon
9feaeb28ca
preparation for vg cache
2008-03-17 16:51:31 +00:00
Christine Caulfield
0075364715
Fix potential thread deadlock.
...
Also make local sockets non-blocking.
2008-03-17 09:37:47 +00:00
Dave Wysochanski
99c5da5da5
Const cleanups in find_* functions.
2008-03-13 22:51:24 +00:00
Alasdair Kergon
22c957bc20
Refactor text format initialisation into _init_text_import.
2008-03-13 12:33:22 +00:00
Milan Broz
3316d59910
Add metadata test for escaping double quotes in device names (bz431474).
2008-03-12 17:34:58 +00:00
Alasdair Kergon
a109ce1eca
Escape double quotes and backslashes in external metadata and config data.
...
Add functions for escaping double quotes in strings.
Rename count_chars_len to count_chars.
2008-03-12 16:03:22 +00:00
Alasdair Kergon
e581a78d65
Use return_0 in a couple more places.
...
Correct a function name typo in _line_append error message.
2008-03-10 18:51:27 +00:00
Christine Caulfield
3c78f9900c
Include limits.h so it compiles with newer headers.
2008-03-06 08:41:05 +00:00
Alasdair Kergon
bd606943e6
add vd to filters
2008-03-05 18:15:04 +00:00
Dave Wysochanski
6381666df4
Update vgsplit tests.
...
- Add validation on pv_count, lv_count, and snap_count after split
NOTE: Some of these counts are misleading. If you compare "lvs" output
with these counts you will be left scratching your head what a "logical volume"
really is. ;-)
2008-03-04 22:49:00 +00:00
Dave Wysochanski
736f1aa301
Update vgsplit tests.
...
- Divide into 'usage' and 'operation' tests.
- Add operation tests for specific LV types.
2008-03-04 19:48:32 +00:00
Dave Wysochanski
b1a4eac7a8
Refactor _move_pv() in vgsplit.
...
Should be no functional change.
2008-02-29 00:13:48 +00:00
Dave Wysochanski
8226a5276b
Add vgsplit test to check failure when PV not in source volume group.
2008-02-29 00:09:21 +00:00
Dave Wysochanski
77ad0bb12e
Fix t-vgsplit-operation.sh lv2-3 definitions to include test signature.
2008-02-28 17:39:47 +00:00
Dave Wysochanski
9412b42206
Fix t-vgsplit-operation.sh lv1 definition to include test signature.
2008-02-28 16:48:09 +00:00
Alasdair Kergon
2a91d87074
Fix resetting of MIRROR_IMAGE and VISIBLE_LV after removal of LV.
2008-02-22 13:28:29 +00:00
Alasdair Kergon
4a23617d79
Fix remove_layer_from_lv to empty the LV before removing it. (2.02.30)
2008-02-22 13:22:44 +00:00
Alasdair Kergon
0e2ceed74d
Add missing no-longer-used segs_using_this_lv test to check_lv_segments.
2008-02-22 13:22:21 +00:00
Jim Meyering
ed56aed8eb
Remove redundant if-before-free tests.
2008-02-15 14:14:58 +00:00
Jim Meyering
8d909cbdc0
Remove redundant if-before-free tests in clvmd.c.
2008-02-15 14:12:32 +00:00
Jim Meyering
bf98943cbb
is_orphan: make parameter "const" to avoid compiler warning
2008-02-13 20:01:48 +00:00
Alasdair Kergon
6ff4552be2
Fix lvconvert detection of mirror conversion in progress.
2008-02-12 13:29:08 +00:00
Alasdair Kergon
1c7eb79370
Avoid automatic lvconvert polldaemon invocation when -R specified.
2008-02-12 13:26:53 +00:00