Zdenek Kabelac
eb91c54467
Add sys_debug loging for unlink
...
This unlink intentionally silently ignores any errors.
It's still worth to trace its error status in debug mode.
2011-01-05 15:06:10 +00:00
Zdenek Kabelac
56b6c12e8a
Fix gcc warnings for missing headers and prototypes
...
Add missing header string.h (strcmp, strndup).
Add 'static' to fix missing prototypes gcc warning.
Remove unused variables verbose_off, TESTDIR, PREFIX.
2011-01-05 15:03:43 +00:00
Petr Rockai
6507ce98df
Remove obsolete bits of support code from test/.
2011-01-05 14:15:26 +00:00
Petr Rockai
2fbadde558
Re-enable t-lvconvert-repair-transient, avoiding the deadlock by running mkfs
...
asynchronously.
2011-01-05 14:15:01 +00:00
Zdenek Kabelac
5a363d74f2
Add missing error path tests
2011-01-05 14:03:36 +00:00
Zdenek Kabelac
b2817688ac
Fail deamonization if lvmcache_init fail
...
FIXME Add proper cleanup
2011-01-05 12:59:46 +00:00
Zdenek Kabelac
659b348a44
Return PERCENT_INVALID for error case
...
If the percent value could not be determined return PERCENT_INVALID.
Indent function with tabs.
2011-01-05 12:33:51 +00:00
Zdenek Kabelac
6990a8c942
Remove unused variable mirr_state and its assignment
2011-01-05 12:27:56 +00:00
Zdenek Kabelac
98b4ee635d
Remove dead assignment to thisfd
...
Value of 'thisfd' is not read again after its assigment
2011-01-05 12:17:19 +00:00
Petr Rockai
7d048d52f6
Fix another bug in t-pvcreate-operation-md (should pass now).
2011-01-05 01:04:47 +00:00
Petr Rockai
41fb54489f
Add a test for RHBZ 640621 (metadata/dirs + no PV MDAs broken).
2011-01-05 01:00:34 +00:00
Petr Rockai
3be9ec308a
Fix typo in t-pvcreate-operation-md.sh.
2011-01-05 00:38:41 +00:00
Petr Rockai
f120a17b1d
Move the mkdtemp functionality into test/lib/utils.sh.
2011-01-05 00:26:19 +00:00
Petr Rockai
fc7054c150
Fix a couple of bugs in the new (test/lib/)aux.sh.
2011-01-05 00:25:07 +00:00
Petr Rockai
cde70f94db
Substantial rework of the functional test support code. Some new features:
...
- somewhat neater, more consistent and more readable output
- possible to set any lvm.conf value: aux lvmconf "section/key = value"
- LVM_TEST_NODEBUG to suppress the (lengthy) "## DEBUG" output
- back-substitution on test output ($TESTDIR/$PREFIX -> @TESTDIR@/@PREFIX@)
- support code moved from test/ to test/lib/ --> less clutter
2011-01-05 00:16:18 +00:00
Jonathan Earl Brassow
8f0f328dbf
Fix bug 635949: lvconvert man page clarification
2011-01-04 21:41:35 +00:00
Jonathan Earl Brassow
10e3bdcce3
Change to correct cmirrord return code is user visible - update WHATS_NEW
...
file.
2011-01-04 21:33:06 +00:00
Jonathan Earl Brassow
bc036c01cb
Fix bug 632681: cmirrord shouldn't fail 'start' if already started
...
Return 0 from the cmirrord init script if the daemon is already
running.
http://refspecs.freestandards.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
2011-01-04 21:16:54 +00:00
Peter Rajnoha
c14f565d18
Export DM_CONTROL_NODE_UMASK and use it while creating /dev/mapper/control.
2011-01-04 14:43:53 +00:00
Petr Rockai
f56007d95f
Use system assert in test/api/percent.c, for now.
2011-01-03 15:07:39 +00:00
Milan Broz
65599cfb58
Fix wrongly paired unlocking of global lock in pvchange. (2.02.66)
2010-12-23 14:23:30 +00:00
Zdenek Kabelac
39b2b95477
Remove check for existance of vg pointer
...
Checking for vg being != NULL in this place is not needed.
Pointer vg is already dereferced in this function above this code line.
Also this internal function _read_pv is always called with valid 'vg' pointer.
2010-12-22 15:44:09 +00:00
Zdenek Kabelac
e65561feae
Add backtraces for backup and backup_remove fail paths
2010-12-22 15:36:41 +00:00
Zdenek Kabelac
2a2170efc0
Hide unused code into if 0
...
Make it obvious for lcov coverage and static analyzis we
are not interested in this piece of code.
2010-12-22 15:32:15 +00:00
Zdenek Kabelac
adb5fb90b1
Detect errors from dm_task_set calls
...
Check for errors in dm_task_set calls.
Use goto_bad macro with stack trace.
Replace label failed: with bad:.
2010-12-22 15:28:44 +00:00
Zdenek Kabelac
ad9e16c198
Fix last pthread_join fix commit
...
Call for pthread_join() does not set errno value even though return values
looks like that. For now assign errno from return value and still use
strerror() to print some error message as this seems to be commonly used.
Add also log_sys_error() message for error close of local pipe.
2010-12-22 14:00:28 +00:00
Zdenek Kabelac
96a20ae9d4
Add backtraces for archive and backup_locally
...
If archive or back_locally fails - add stack trace.
2010-12-22 13:45:33 +00:00
Zdenek Kabelac
0cadf7ba66
Fix memory leak in debug mode of restart_clvmd() error path
2010-12-22 12:14:11 +00:00
Zdenek Kabelac
bb5ccf8869
Log error state from pthread_join operation
...
Value jstat is unused - so replace it with logging via log_sys_error().
2010-12-22 12:10:56 +00:00
Zdenek Kabelac
57d19b3f1b
Remove dead assignment of lv_total and lv_capasity_total
...
Variables 'lv_total' and 'lv_capasity_total' are unused.
2010-12-22 12:06:54 +00:00
Alasdair Kergon
e45d947322
post-release
2010-12-21 21:08:51 +00:00
Alasdair Kergon
b44cdfc143
Copyright notices for new files.
2010-12-21 01:14:34 +00:00
Alasdair Kergon
385933819e
pre-release
2010-12-21 01:08:29 +00:00
Zdenek Kabelac
58e3ba19a2
Add missing test for reallocation error.
2010-12-20 14:38:22 +00:00
Zdenek Kabelac
0f3ab63a24
Remove dead assignment
...
Variable 'r' is never read so remove it and just cast result from
_error_device function to (void).
2010-12-20 14:36:12 +00:00
Zdenek Kabelac
2697eddcba
Verbose log old_umask value
...
Use old_umask value and print its content through verbose log.
2010-12-20 14:34:49 +00:00
Zdenek Kabelac
90ba925a19
Add internal error if pointer is uninitialized
...
Add simple check for existance of 'pl' and printer internal error message
if device is missing instead of plain crash.
2010-12-20 14:20:52 +00:00
Zdenek Kabelac
b5d23f1591
Add check for unlink errors
2010-12-20 14:08:46 +00:00
Zdenek Kabelac
e6f0290d9f
Remove unused variable label
...
Variable 'label' is unused in _format1_pv_write().
2010-12-20 14:06:33 +00:00
Zdenek Kabelac
23a3de988f
Remove unused variable dev_dir_provided
2010-12-20 14:05:31 +00:00
Zdenek Kabelac
c4fc6c2381
Remove dead assignment of segh
...
Variable 'segh' is never read again after this assignment.
2010-12-20 14:04:43 +00:00
Zdenek Kabelac
9bc24aea56
Remove dead store in lvm_run_command
...
Variable 'ret' is not read before its next assignment.
2010-12-20 13:59:52 +00:00
Zdenek Kabelac
8392d2853e
Removed unused pointer
...
Pointer 'duplicate' is unused.
2010-12-20 13:58:38 +00:00
Zdenek Kabelac
28708849a9
Use dm_free for dm_malloc-ed areas in _clog_ctr/_clog_dtr (cmirrord).
...
Use dm_zalloc to obtain zeroed memory block.
Use dm_free for dm_ allocated memory blocks.
Test close() for error.
2010-12-20 13:57:19 +00:00
Zdenek Kabelac
9f1538687a
Add checks for allocation errors in config node clonning.
...
Add checks for clonning allocation a fail-out when something is
not allocated correctly.
Also move var declaration to the begining of the function
and fix log_error messages.
2010-12-20 13:53:10 +00:00
Zdenek Kabelac
0ae26564ce
Replace multiple fprintf calls with one large string parameter
2010-12-20 13:48:28 +00:00
Zdenek Kabelac
9c146b8a6f
Fix error path if regex engine cannot be created in _build_matcher().
...
Fix only 'stack' printing with full function error exit.
2010-12-20 13:45:39 +00:00
Zdenek Kabelac
2913ac8b4e
Use const char * for name and old_name in vg
...
Switch to use const char pointers to avoid changes of these structure
members and having better control over, were these members could
be modified.
2010-12-20 13:40:46 +00:00
Zdenek Kabelac
6556fcc3fc
Use const char* for offset calculation
...
As 'const' types are also passed to macro dm_list_struct_base -
keep offset calculation with const char pointers.
Fixes several gcc constness warnings.
2010-12-20 13:39:12 +00:00
Zdenek Kabelac
1c6b3062bf
Switch void* to char* arithmetic
2010-12-20 13:37:26 +00:00
