Comparing 298719b02f..5ffedbcec1 - lvm2 - Gitea: Git with a cup of tea

shaba/lvm2

mirror of git://sourceware.org/git/lvm2.git synced 2025-11-03 08:23:48 +03:00

Author	SHA1	Message	Date
David Teigland	5ffedbcec1	generate man pages	2017-02-10 11:08:32 -06:00
David Teigland	417c3dece8	args: use arg parsing function for region size Consolidate the validation of the region size arg in a new arg parsing function.	2017-02-10 11:07:41 -06:00
David Teigland	311d3c7e8f	lvconvert: remove code for changing region size from the generic raid type conversion code.	2017-02-10 11:07:41 -06:00
David Teigland	c025c8b46f	lvconvert: add command to change region size of a raid LV	2017-02-10 11:07:41 -06:00
David Teigland	2baabc823f	vgchange: fix uint32 parsing of logicalvolume arg	2017-02-10 11:07:41 -06:00
David Teigland	d48dd64e35	commands: recognize raid variations	2017-02-10 11:07:41 -06:00
David Teigland	eee727883b	lvconvert: remove unused code For "split" which is not an alias for splitmirrors.	2017-02-10 11:07:20 -06:00
David Teigland	fa3a14df14	args: split is a synonym for splitcache also tidy the other synonyms	2017-02-10 11:06:43 -06:00
David Teigland	43480f222f	man: lvmthin updates Some minor changes to some of the command syntaxes to use more standard forms.	2017-02-10 11:06:43 -06:00
David Teigland	d7651132a7	ccmd: split into multiple files	2017-02-10 11:06:43 -06:00
David Teigland	61e4fbca11	command struct: remove command name refs Change run time access to the command_name struct cmd->cname instead of indirectly through cmd->command->cname. This removes the two run time fields from struct command.	2017-02-10 11:06:43 -06:00
David Teigland	13818a4630	command.h comment tidying	2017-02-10 11:06:43 -06:00
David Teigland	003437673d	lvm shell: clear argv for each command	2017-02-10 11:06:43 -06:00
David Teigland	d4784802de	help: accept positional args lvm help <commandname> ...	2017-02-10 11:06:42 -06:00
David Teigland	24b93c6e35	fix lvmcmdline warning declaration of ‘usage’ shadows a globa	2017-02-10 11:06:42 -06:00
David Teigland	98f007034e	man lvm: remove options all options are now included in commands	2017-02-10 11:06:42 -06:00
David Teigland	d5ac07f818	args: add man page descriptions	2017-02-10 11:06:42 -06:00
David Teigland	bd8965194f	args: use uint32 arg for maxphysicalvolumes	2017-02-10 11:06:42 -06:00
David Teigland	1eaad64ded	lvconvert: remove unused code	2017-02-10 11:06:42 -06:00
David Teigland	f16abdce55	lvconvert: use command defs for raid/mirror types All lvconvert functionality has been moved out of the previous monolithic lvconvert code, except conversions related to raid/mirror/striped/linear. This switches that remaining code to be based on command defs, and standard process_each_lv arg processing. This final switch results in quite a bit of dead code that is also removed.	2017-02-10 11:06:42 -06:00
David Teigland	44058693d5	tests: use swapmetadata and some other pool/cache/thin related changes	2017-02-10 11:06:41 -06:00
David Teigland	715c959983	lvconvert: use command defs for mergemirrors and route the generic --merge to one of the specific merge functions	2017-02-10 11:06:41 -06:00
David Teigland	7a6a99a488	toollib: find VG name in option values when needed	2017-02-10 11:06:41 -06:00
David Teigland	7ef774e2c2	lvconvert: use command defs for thin/cache/pool creation Everything related to thin and cache.	2017-02-10 11:06:41 -06:00
David Teigland	88db11bece	lvconvert: add startpoll command using command def This is a new explicit version of 'lvconvert LV' which has been an obscure way of triggering polling to be restarted on an LV that was previously converted.	2017-02-10 11:06:41 -06:00
David Teigland	1c5014eda9	lvconvert: snapshot: use command definitions Lift all the snapshot utilities (merge, split, combine) out of the monolithic lvconvert implementation, using the command definitions. The old code associated with these commands is now unused and will be removed separately.	2017-02-10 11:06:41 -06:00
David Teigland	0c5cd2ae9f	lvconvert: remove unused calls for repair and replace repair and replace are no longer called from the monolithic lvconvert code, so remove the unused code.	2017-02-10 11:06:40 -06:00
David Teigland	96227b575d	lvconvert: repair and replace: use command definitions This lifts the lvconvert --repair and --replace commands out of the monolithic lvconvert implementation. The previous calls into repair/replace can no longer be reached and will be removed in a separate commit.	2017-02-10 11:06:40 -06:00
David Teigland	29da4255b2	lvchange: make use of command definitions Reorganize the lvchange code to take advantage of the command definition, and remove the validation that is done by the command definintion rules.	2017-02-10 11:06:40 -06:00
David Teigland	106ef06c2c	process_each_lv: add check_single_lv function The new check_single_lv() function is called prior to the existing process_single_lv(). If the check function returns 0, the LV will not be processed. The check_single_lv function is meant to be a standard method to validate the combination of specific command + specific LV, and decide if the combination is allowed. The check_single function can be used by anything that calls process_each_lv. As commands are migrated to take advantage of command definitions, each command definition gets its own entry point which calls process_each for itself, passing a pair of check_single/process_single functions which can be specific to the narrowly defined command def.	2017-02-10 11:06:40 -06:00
David Teigland	6467dea0db	commands: new method for defining commands . Define a prototype for every lvm command. . Match every user command with one definition. . Generate help text and man pages from them. The new file command-lines.in defines a prototype for every unique lvm command. A unique lvm command is a unique combination of: command name + required option args + required positional args. Each of these prototypes also includes the optional option args and optional positional args that the command will accept, a description, and a unique string ID for the definition. Any valid command will match one of the prototypes. Here's an example of the lvresize command definitions from command-lines.in, there are three unique lvresize commands: lvresize --size SizeMB LV OO: --alloc Alloc, --autobackup Bool, --force, --nofsck, --nosync, --noudevsync, --reportformat String, --resizefs, --stripes Number, --stripesize SizeKB, --poolmetadatasize SizeMB OP: PV ... ID: lvresize_by_size DESC: Resize an LV by a specified size. lvresize LV PV ... OO: --alloc Alloc, --autobackup Bool, --force, --nofsck, --nosync, --noudevsync, --reportformat String, --resizefs, --stripes Number, --stripesize SizeKB ID: lvresize_by_pv DESC: Resize an LV by specified PV extents. FLAGS: SECONDARY_SYNTAX lvresize --poolmetadatasize SizeMB LV_thinpool OO: --alloc Alloc, --autobackup Bool, --force, --nofsck, --nosync, --noudevsync, --reportformat String, --stripes Number, --stripesize SizeKB OP: PV ... ID: lvresize_pool_metadata_by_size DESC: Resize a pool metadata SubLV by a specified size. The three commands have separate definitions because they have different required parameters. Required parameters are specified on the first line of the definition. Optional options are listed after OO, and optional positional args are listed after OP. This data is used to generate corresponding command definition structures for lvm in command-lines.h. usage/help output is also auto generated, so it is always in sync with the definitions. Every user-entered command is compared against the set of command structures, and matched with one. An error is reported if an entered command does not have the required parameters for any definition. The closest match is printed as a suggestion, and running lvresize --help will display the usage for each possible lvresize command. The prototype syntax used for help/man output includes required --option and positional args on the first line, and optional --option and positional args enclosed in [ ] on subsequent lines. command_name <required_opt_args> <required_pos_args> [ <optional_opt_args> ] [ <optional_pos_args> ] Command definitions that are not to be advertised/suggested have the flag SECONDARY_SYNTAX. These commands will not be printed in the normal help output. Man page prototypes are also generated from the same original command definitions, and are always in sync with the code and help text. Very early in command execution, a matching command definition is found. lvm then knows the operation being done, and that the provided args conform to the definition. This will allow lots of ad hoc checking/validation to be removed throughout the code. Each command definition can also be routed to a specific function to implement it. The function is associated with an enum value for the command definition (generated from the ID string.) These per-command-definition implementation functions have not yet been created, so all commands currently fall back to the existing per-command-name implementation functions. Using per-command-definition functions will allow lots of code to be removed which tries to figure out what the command is meant to do. This is currently based on ad hoc and complicated option analysis. When using the new functions, what the command is doing is already known from the associated command definition.	2017-02-10 11:06:32 -06:00

Compare commits

31 Commits

dev-dct-cm ... dev-dct-cm

Diff Content Not Available

Compare commits

31 Commits dev-dct-cm ... dev-dct-cm

Diff Content Not Available

31 Commits

dev-dct-cm ... dev-dct-cm