Dave Wysochanski 10a27bdfb6 Change vg_create() to take only minimal parameters and obtain a lock. ... vg_t *vg_create(struct cmd_context *cmd, const char *vg_name); This is the first step towards the API called to create a VG. Call vg_lock_newname() inside this function. Use _vg_make_handle() where possible. Now we have 2 ways to construct a volume group: 1) vg_read: Used when constructing an existing VG from disks 2) vg_create: Used when constructing a new VG Both of these interfaces obtain a lock, and return a vg_t *. The usage of _vg_make_handle() inside vg_create() doesn't fit perfectly but it's ok for now. Needs some cleanup though and I've noted "FIXME" in the code. Add the new vg_create() plus vg 'set' functions for non-default VG parameters in the following tools: - vgcreate: Fairly straightforward refactoring. We just moved vg_lock_newname inside vg_create so we check the return via vg_read_error. - vgsplit: The refactoring here is a bit more tricky. Originally we called vg_lock_newname and depending on the error code, we either read the existing vg or created the new one. Now vg_create() calls vg_lock_newname, so we first try to create the VG. If this fails with FAILED_EXIST, we can then do the vg_read. If the create succeeds, we check the input parameters and set any new values on the VG. TODO in future patches: 1. The VG_ORPHAN lock needs some thought. We may want to treat this as any other VG, and require the application to obtain a handle and pass it to other API calls (for example, vg_extend). Or, we may find that hiding the VG_ORPHAN lock inside other APIs is the way to go. I thought of placing the VG_ORPHAN lock inside vg_create() and tying it to the vg handle, but was not certain this was the right approach. 2. Cleanup error paths. Integrate vg_read_error() with vg_create and vg_read* error codes and/or the new error APIs. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>		2009-07-09 10:09:33 +00:00
..
lv_alloc.h	Calculate mirror log size instead of hardcoding 1 extent size.	2008-12-19 15:24:52 +00:00
lv_manip.c	Suspend virtual origin before real snapshot.	2009-06-06 16:37:15 +00:00
merge.c	Right, a simple build (without options) is working again.	2008-11-03 22:14:30 +00:00
metadata-exported.h	Change vg_create() to take only minimal parameters and obtain a lock.	2009-07-09 10:09:33 +00:00
metadata.c	Change vg_create() to take only minimal parameters and obtain a lock.	2009-07-09 10:09:33 +00:00
metadata.h	Fix readahead calculation problems.	2009-06-01 12:43:31 +00:00
mirror.c	Fix convert polling to ignore LV with different UUID.	2009-06-01 14:43:27 +00:00
pv_alloc.h	Right, a simple build (without options) is working again.	2008-11-03 22:14:30 +00:00
pv_manip.c	Right, a simple build (without options) is working again.	2008-11-03 22:14:30 +00:00
pv_map.c	Do not include MISSING_PVs in allocation maps.	2009-04-23 16:41:27 +00:00
pv_map.h	Right, a simple build (without options) is working again.	2008-11-03 22:14:30 +00:00
segtype.c	Right, a simple build (without options) is working again.	2008-11-03 22:14:30 +00:00
segtype.h	Permit several segment types to be registered by a single shared object.	2009-07-08 12:36:01 +00:00
snapshot_manip.c	Pre-release cleanups.	2009-05-21 03:04:52 +00:00