shaba/one
1
0
Fork 0
mirror of https://github.com/OpenNebula/one.git synced 2025-04-02 10:50:07 +03:00
Code Releases Wiki Activity

L #3683: code linting

Browse Source
This commit is contained in:
Alejandro Huertas 2019-09-12 12:50:08 +02:00 committed by Ruben S. Montero
parent 1b348cc011
commit 1061d4a02d
2 changed files with 97 additions and 90 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
share/linters/.rubocop.yml
View File

@ -369,7 +369,6 @@ AllCops:
- src/cli/one_helper/onemarketapp_helper.rb
- src/cli/one_helper/onegroup_helper.rb
- src/cli/one_helper/onevnet_helper.rb
- src/cli/one_helper/oneacl_helper.rb
- src/cli/one_helper/onevcenter_helper.rb
- src/cli/one_helper/onecluster_helper.rb
- src/cli/one_helper/onevntemplate_helper.rb

186
src/cli/one_helper/oneacl_helper.rb
View File

@ -16,16 +16,88 @@
require 'one_helper'
# Helper for oneacl command
class OneAclHelper < OpenNebulaHelper::OneHelper
def self.rname
"ACL"
'ACL'
end
def self.conf_file
"oneacl.yaml"
'oneacl.yaml'
end
private
# rubocop:disable Lint/IneffectiveAccessModifier
private
# TODO: check that @content[:resources_str] is valid
def self.resource_mask(str)
resource_type=str.split('/')[0]
mask = '------------------'
resource_type.split('+').each do |type|
case type
when 'VM'
mask[0] = 'V'
when 'HOST'
mask[1] = 'H'
when 'NET'
mask[2] = 'N'
when 'IMAGE'
mask[3] = 'I'
when 'USER'
mask[4] = 'U'
when 'TEMPLATE'
mask[5] = 'T'
when 'GROUP'
mask[6] = 'G'
when 'DATASTORE'
mask[7] = 'D'
when 'CLUSTER'
mask[8] = 'C'
when 'DOCUMENT'
mask[9] = 'O'
when 'ZONE'
mask[10] = 'Z'
when 'SECGROUP'
mask[11] = 'S'
when 'VDC'
mask[12] = 'v'
when 'VROUTER'
mask[13] = 'R'
when 'MARKETPLACE'
mask[14] = 'M'
when 'MARKETPLACEAPP'
mask[15] = 'A'
when 'VMGROUP'
mask[16] = 'P'
when 'VNTEMPLATE'
mask[17] = 't'
end
end
mask
end
# TODO: check that @content[:resources_str] is valid
def self.right_mask(str)
mask = '----'
str.split('+').each do |type|
case type
when 'USE'
mask[0] = 'u'
when 'MANAGE'
mask[1] = 'm'
when 'ADMIN'
mask[2] = 'a'
when 'CREATE'
mask[3] = 'c'
end
end
mask
end
def factory(id = nil)
if id
@ -36,113 +108,48 @@ private
end
end
def factory_pool(filter)
def factory_pool(_filter)
OpenNebula::AclPool.new(@client)
end
# TODO check that @content[:resources_str] is valid
def self.resource_mask(str)
resource_type=str.split("/")[0]
mask = "------------------"
resource_type.split("+").each{|type|
case type
when "VM"
mask[0] = "V"
when "HOST"
mask[1] = "H"
when "NET"
mask[2] = "N"
when "IMAGE"
mask[3] = "I"
when "USER"
mask[4] = "U"
when "TEMPLATE"
mask[5] = "T"
when "GROUP"
mask[6] = "G"
when "DATASTORE"
mask[7] = "D"
when "CLUSTER"
mask[8] = "C"
when "DOCUMENT"
mask[9] = "O"
when "ZONE"
mask[10] = "Z"
when "SECGROUP"
mask[11] = "S"
when "VDC"
mask[12] = "v"
when "VROUTER"
mask[13] = "R"
when "MARKETPLACE"
mask[14] = "M"
when "MARKETPLACEAPP"
mask[15] = "A"
when "VMGROUP"
mask[16] = "P"
when "VNTEMPLATE"
mask[17] = "t"
end
}
mask
end
# TODO check that @content[:resources_str] is valid
def self.right_mask(str)
mask = "----"
str.split("+").each{|type|
case type
when "USE"
mask[0] = "u"
when "MANAGE"
mask[1] = "m"
when "ADMIN"
mask[2] = "a"
when "CREATE"
mask[3] = "c"
end
}
mask
end
def format_pool(options)
def format_pool(_options)
config_file = self.class.table_conf
table = CLIHelper::ShowTable.new(config_file, self) do
column :ID, "Rule Identifier",
:size=>5 do |d|
column :ID,
'Rule Identifier',
:size => 5 do |d|
d['ID']
end
column :USER, "To which resource owner the rule applies to",
:size=>8 do |d|
d['STRING'].split(" ")[0]
column :USER,
'To which resource owner the rule applies to',
:size => 8 do |d|
d['STRING'].split(' ')[0]
end
column :RES_VHNIUTGDCOZSvRMAPt, "Resource to which the rule applies",
:size => 22 do |d|
OneAclHelper::resource_mask d['STRING'].split(" ")[1]
column :RES_VHNIUTGDCOZSvRMAPt,
'Resource to which the rule applies',
:size => 22 do |d|
OneAclHelper.resource_mask d['STRING'].split(' ')[1]
end
column :RID, "Resource ID", :right, :size=>5 do |d|
d['STRING'].split(" ")[1].split("/")[1]
column :RID, 'Resource ID', :right, :size => 5 do |d|
d['STRING'].split(' ')[1].split('/')[1]
end
column :ZONE, "Zone ID", :right, :size=>5 do |d|
d['STRING'].split(" ")[3]
column :ZONE, 'Zone ID', :right, :size => 5 do |d|
d['STRING'].split(' ')[3]
end
column :OPE_UMAC,
"Operation to which the rule applies", :size =>8 do |d|
OneAclHelper::right_mask d['STRING'].split(" ")[2]
'Operation to which the rule applies',
:size => 8 do |d|
OneAclHelper.right_mask d['STRING'].split(' ')[2]
end
column :STRING,
"ACL rule in string format",
'ACL rule in string format',
:adjust => true,
:left => true do |d|
d['STRING']
@ -153,5 +160,6 @@ private
table
end
# rubocop:enable Lint/IneffectiveAccessModifier
end