Commit Graph

6150 Commits

Author SHA1 Message Date
Luca BRUNO
9163665a29
ci/rust: bump linting toolchain to latest stable (1.64)
This bumps the Rust toolchain for clippy/rustfmt to 1.64.
2022-10-26 09:27:50 +00:00
Luca Bruno
9801689c74
Merge pull request #2744 from lucab/ups/ci-memory-bump
ci: bump cosaPod memory requirement to 5Gi
2022-10-26 09:23:29 +00:00
Jonathan Lebon
52810a41b9
ci: bump cosaPod memory requirement to 5Gi
We're hitting memory limits when running the reprovisioning tests. We
should investigate why we need 1Gi of overhead, but for now to get
unblocked let's just bump it.
2022-10-26 06:42:06 +00:00
Colin Walters
a19cc34883
Merge pull request #2663 from mstuehn/test-static-delta-file
lib/static-delta: document and check parameters format
2022-10-19 17:04:40 -04:00
Luca BRUNO
ed6678ce5f
rust/tests: fix static delta generation testcase 2022-10-13 16:30:00 +00:00
Luca BRUNO
763d2d2863
lib/static-delta: document and check parameters format
This enhances the logic handling GVariant parameters within
`ostree_repo_static_delta_generate()`.
Several of those entries are expected to be zero-terminated values,
and this implicit assumption has been observed to be an hidden trap
in languages where strings and arrays may not carry a terminator value
(e.g. Rust).
In order to improve the situation, this makes the documentation more
explicit and actively tries to catch invalid input parameters.
2022-10-13 16:29:59 +00:00
Manuel Stühn
14f513cf02
Add test for generating static delta to file 2022-10-13 16:29:58 +00:00
Luca Bruno
a335a780a9
Merge pull request #2733 from ostreedev/dependabot/submodules/libglnx-e701578
build(deps): bump libglnx from `26375b5` to `e701578`
2022-10-13 15:36:28 +00:00
Jonathan Lebon
4a83cf4a36
Merge pull request #2738 from lucab/ups/lib-zipl-check-open-errors 2022-10-13 11:22:38 -04:00
Jonathan Lebon
c874d4f3f3 ci: Use new names for custom kola steps
The old `fcos*` versions are deprecated now:
https://github.com/coreos/coreos-ci-lib/pull/111
2022-10-13 09:18:08 -04:00
Jonathan Lebon
139759dd7e ci: Drop unnecessary outer stage
We define stages inside of this stage, so get rid of the outer `FCOS`
stage. This should help rendering the pipeline in BlueOcean more
clearly.
2022-10-13 09:16:19 -04:00
Jonathan Lebon
d5129e3766 ci: Bump memory request, use fcosKolaTestIso
More fallout from https://github.com/coreos/coreos-ci-lib/pull/116. We
need to be more honest about how much memory we need.

While we're here, switch the `kola testiso` invocation to use
`fcosKolaTestIso` instead. This will add coverage for UEFI and UEFI
SecureBoot testing.
2022-10-13 09:14:08 -04:00
Dan Nicholson
1075e58c16
Merge pull request #2737 from lucab/ups/repo-checkout-fix-uid-typo
lib/repo-checkout: fix typo in error message
2022-10-13 06:41:55 -06:00
Luca BRUNO
39ef6253e9
lib/bootloader-zipl: check for errors when opening initrd
This adds a missing error check when opening an initrd in s390x
Secure Execution (SE) logic.
It was detected by RH internal static checks.
2022-10-13 10:48:38 +00:00
Luca BRUNO
1ea5e8e7d2
lib/repo-checkout: fix typo in error message
This fixes a typo in an error message, resulting in a GID vs UID
mixup. It was detected by RH internal static checks.
2022-10-13 10:38:11 +00:00
dependabot[bot]
3bb3546fff
build(deps): bump libglnx from 26375b5 to e701578
Bumps libglnx from `26375b5` to `e701578`.

---
updated-dependencies:
- dependency-name: libglnx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-11 12:29:06 +00:00
Luca Bruno
e0cc8069c9
Merge pull request #2730 from ostreedev/release-2022.6
Release 2022.6
2022-10-07 16:40:10 +00:00
Luca BRUNO
b147166d06
configure: post-release version bump 2022-10-07 07:56:24 +00:00
Luca BRUNO
eee649d902
Release 2022.6 2022-10-07 07:54:09 +00:00
Luca Bruno
017ea3edc1
Merge pull request #2721 from cgwalters/link-otto
README.md: Link otto
2022-09-28 21:54:53 +00:00
Colin Walters
b04dde8882
Merge pull request #2717 from mangelajo/support-whiteouts
Support overlayfs whiteouts on checkout
2022-09-28 08:35:24 -04:00
Colin Walters
b83032d0d3 README.md: Link otto
Another project in the ostree/container space.
2022-09-28 08:30:18 -04:00
Miguel Angel Ajo
e234b630f8 Support overlayfs whiteouts on checkout
Introduces an intermediate format for overlayfs storage, where
.wh-ostree. prefixed files will be converted into char 0:0
whiteout devices used by overlayfs to mark deletions across layers.

The CI scripts now uses a volume for the scratch directories
previously in /var/tmp otherwise we cannot create whiteout
devices into an overlayfs mounted filesystem.

Related-Issue: #2712
2022-09-28 12:26:31 +02:00
Luca Bruno
4e51f22145
Merge pull request #2720 from lucab/ups/lib-deploy-ignore-result
lib/sysroot-deploy: explicitly handle `g_variant_lookup` results
2022-09-26 12:40:04 +00:00
Luca BRUNO
a1018840f4
lib/sysroot-deploy: explicitly handle g_variant_lookup results
This explicitly ignores the results of two optional variant lookups,
in order to pacify a RHT internal static analyzer.
2022-09-26 07:42:12 +00:00
Colin Walters
f442f02c15
Merge pull request #2718 from lucab/ups/repo-initialize-valid-bootloader
lib/repo: properly initialize boolean variable
2022-09-23 11:09:13 -04:00
Luca BRUNO
5412dc49ae
lib/repo: properly initialize boolean variable
This initializes a boolean variable that was previously left
uninitialized. It was detected by a RHT internal static analyzer.
2022-09-23 13:02:00 +00:00
Colin Walters
404fcc0206
Merge pull request #2716 from dbnicholson/max-metadata-size-doc
lib/pull: Fix max-metadata-size documentation
2022-09-18 15:04:54 -04:00
Dan Nicholson
631e014bd6 lib/pull: Fix max-metadata-size documentation
The documented option is incorrect and has been since it's introduction
in 2c55bc6997.
2022-09-18 12:15:18 -06:00
Dan Nicholson
f2d8b583e0
Merge pull request #2714 from andreamtp/patch-1
Fix recursive git archive reference
2022-09-17 12:12:09 -06:00
Andrea Perotti
565ad4a1b4
Fix recursive git archive reference
Broken link for "recursive git archive" example
2022-09-17 11:00:46 +02:00
Colin Walters
c6c3c5ae9f
Merge pull request #2711 from lucab/ups/sign-assertions
lib/sign: convert invariant checks to assertions
2022-09-09 10:05:27 -04:00
Luca BRUNO
ace973186c
lib/sign: convert invariant checks to assertions
This converts several invariant checks to asserts. Most of the
functions in this file were already using assertions, so this aligns
the remaining few outliers to the rest.
2022-09-09 13:20:43 +00:00
Luca Bruno
c2dc6d3893
Merge pull request #2709 from lucab/ups/otutils-variant-builder-error
otutil: add error handling to variant builders
2022-09-08 14:41:53 +00:00
Luca BRUNO
542b79cfeb
otutil: add error handling to variant builders
This enhances a bunch of helpers related to GVariant building, in
order to properly handle errors and avoid some potential cases of
unexpected NULL results.
2022-09-08 13:53:05 +00:00
Colin Walters
6873a2511b
Merge pull request #2708 from nikita-dubrovskii/sh_to_c
s390x: drop shell code for `initrd` modification in SE case
2022-09-08 07:45:04 -04:00
Nikita Dubrovskii
c6a53ef6e8 s390x: use 'libarchive' to modify initrd in SE case 2022-09-08 11:41:34 +02:00
Luca Bruno
dc0a5152c7
Merge pull request #2710 from lucab/ups/lib-mtree-redundant-validation
lib/mtree: drop redundant name checks
2022-09-07 13:24:36 +00:00
Luca BRUNO
642efe924f
lib/mtree: drop redundant name checks
This drops several NULL checks against filename input argument.
Those checks are both redundant (as filename validation already
checks for that) and dangerous (as they return early without
setting an error value).
2022-09-07 12:33:37 +00:00
Luca Bruno
73eda79662
Merge pull request #2707 from lucab/ups/libostree-bootloader-asserts
lib/bootloader: assert invariants
2022-09-06 00:36:11 +00:00
Nikita Dubrovskii
769ac686f1 s390x: simplify 's390x-se-luks-gencpio' script 2022-09-05 12:08:35 +02:00
Luca Bruno
fdbc05dab0
Merge pull request #2706 from git-bruh/main
ostree-fetcher-curl: check for HTTP2 support before trying to use it
2022-09-05 09:29:29 +00:00
Luca BRUNO
273089d9e4
lib/bootloader: assert invariants
This tweaks some invariants checks into full assertions, in order
to avoid returning to the caller in case of known invalid states.
2022-09-05 09:27:38 +00:00
Nikita Dubrovskii
49ce9b0289 s390x: ensure both 'root' and 'boot' luks keys exist 2022-09-05 10:46:13 +02:00
git-bruh
35d6ea88f6
ostree-fetcher-curl: check for HTTP2 support before trying to use it 2022-09-03 12:50:00 +05:30
Dan Nicholson
eed9e9f335
Merge pull request #2704 from cgwalters/finalize-no-sigterm
finalize-staged: Don't listen to `SIGTERM`, just let kernel exit us
2022-08-30 16:32:46 -06:00
Colin Walters
683e4eff08 finalize-staged: Don't listen to SIGTERM, just let kernel exit us
Followup from discussion in
https://github.com/ostreedev/ostree/pull/2544#discussion_r958840936

This is more efficient; no need to have the kernel context switch
us in at shutdown time just so we can turn around and call
`exit()`.
2022-08-30 17:50:03 -04:00
Colin Walters
6651b72a7a
Merge pull request #2544 from dbnicholson/finalize-block
finalize-staged: Ensure /boot and /sysroot automounts don't expire
2022-08-30 15:12:32 -04:00
Dan Nicholson
f3db79e7fa finalize-staged: Ensure /boot automount doesn't expire
If `/boot` is an automount, then the unit will be stopped as soon as the
automount expires. That's would defeat the purpose of using systemd to
delay finalizing the deployment until shutdown. This is not uncommon as
`systemd-gpt-auto-generator` will create an automount unit for `/boot`
when it's the EFI System Partition and there's no fstab entry.

To ensure that systemd doesn't stop the service early when the `/boot`
automount expires, introduce a new unit that holds `/boot` open until
it's sent `SIGTERM`. This uses a new `--hold` option for
`finalize-staged` that loads but doesn't lock the sysroot. A separate
unit is used since we want the process to remain active throughout the
finalization run in `ExecStop`. That wouldn't work if it was specified
in `ExecStart` in the same unit since it would be killed before the
`ExecStop` action was run.

Fixes: #2543
2022-08-30 09:16:39 -06:00
Dan Nicholson
e30a3b6b17 main: Factor out sysroot loading
It can be useful to parse the options and initialize the sysroot without
actually loading it until later. Factor out the sysroot loading to a new
`ostree_admin_sysroot_load` and add a new
`OSTREE_ADMIN_BUILTIN_FLAG_NO_LOAD` flag to accommodate this.
2022-08-30 08:46:26 -06:00