Luca Boccassi
1f066ce255
Update TODO
2022-05-11 14:51:37 +01:00
Zbigniew Jędrzejewski-Szmek
71e2fa54fd
Merge pull request #23331 from kmoriwak/tmpfiles-quickref
...
man: add missing cleanup-age to tmpfiles.d quickref
2022-05-11 09:08:39 +02:00
Kazuo Moriwaka
4da5e566e7
man: mention to Age parameter in C Type
2022-05-11 15:08:34 +09:00
Yu Watanabe
6bb8928205
meson: sort files
2022-05-11 02:13:15 +09:00
Yu Watanabe
97cda6e10f
Merge pull request #23335 from keszybz/fuzz-json-more-coverage
...
More coverage in fuzz-json
2022-05-11 02:12:57 +09:00
Zbigniew Jędrzejewski-Szmek
82544241ba
fuzz-bootspec: limit input size
...
https://oss-fuzz.com/testcase-detail/5680508182331392 has the
first timeout with 811kb of input. As in the other cases, the code
is known to be slow with lots of repeated entries and we're fine with
that.
2022-05-11 02:12:35 +09:00
Yu Watanabe
01c99b29e9
Merge pull request #23336 from keszybz/fuzz-calendarspec-more-coverage
...
More coverage in fuzz-calendarspec
2022-05-11 02:12:11 +09:00
Zbigniew Jędrzejewski-Szmek
99b1145aae
shared/json: fix memleak in sort
2022-05-10 17:08:37 +02:00
Zbigniew Jędrzejewski-Szmek
3b6ce05537
shared/json: fix another memleak in normalization
2022-05-10 17:08:37 +02:00
Zbigniew Jędrzejewski-Szmek
dbd27c6d28
fuzz-json: also try self-merge operations
...
This might even work ;)
2022-05-10 17:08:37 +02:00
Zbigniew Jędrzejewski-Szmek
96d651a22b
basic/alloc-util: remove unnecessary parens
...
Those symbols are not macros anymore, so we can drop parens.
2022-05-10 17:08:37 +02:00
Zbigniew Jędrzejewski-Szmek
ce913e0ec4
shared/json: add helper to ref first, unref second
...
This normally wouldn't happen, but if some of those places were called
with lhs and rhs being the same object, we could unref the last ref first,
and then try to take the ref again. It's easier to be safe, and with the
helper we save some lines too.
2022-05-10 17:08:34 +02:00
Zbigniew Jędrzejewski-Szmek
8e1e59b9ad
shared/calendarspec: fix formatting of entries which collapse to a star
...
We canonicalize repeats that cover the whole range: "0:0:0/1" → "0:0:*". But
we'd also do "0:0:0/1,0" → "0:0:*,0", which we then refuse to parse. Thus,
first go throug the whole chain, and print a '*' and nothing else if any of the
components covers the whole range.
2022-05-10 14:35:57 +02:00
Zbigniew Jędrzejewski-Szmek
07b420a3b9
Merge pull request #23329 from superm1/mlimonci/lg850-gl
...
Set auto-suspend delay on LG850-GL
2022-05-10 13:52:36 +02:00
Yu Watanabe
756491af39
core/timer: fix potential use-after-free
2022-05-10 13:50:50 +02:00
Yu Watanabe
d3ab7b8078
core/timer: fix memleak
...
Fixes #23326 .
2022-05-10 13:50:50 +02:00
Zbigniew Jędrzejewski-Szmek
3aff2ae9d5
shared/calendarspec: fix printing of second ranges which start with 0
...
0..3 is not the same as 0..infinity, we need to check both ends of the range.
This logic was added in 3215e35c40
, and back then
the field was called .value. .stop was added later and apparently wasn't taken
into account here.
2022-05-10 13:06:32 +02:00
Zbigniew Jędrzejewski-Szmek
4f23345592
test-calendarspec: tighten tests and add more logging
2022-05-10 13:06:32 +02:00
Zbigniew Jędrzejewski-Szmek
8b105ec831
shared/calendarspec: wrap long comments and reduce scope of one var
2022-05-10 13:06:32 +02:00
Zbigniew Jędrzejewski-Szmek
8e6e3ac7d1
fuzz-calendarspec: increase coverage by calculating occurences
...
Coverage data shows that we didn't test calendar_spec_next_usec() and
associated functions at all.
The input samples so far were only used until the first NUL. We take advantage
of that by using the part until the second NUL as the starting timestamp,
retaining backwards compatibility for how the first part is used.
2022-05-10 13:06:32 +02:00
Zbigniew Jędrzejewski-Szmek
262037f0b1
fuzz-calendarspec: add input sample with a list of weekdays and all syntax characters
...
This should make the fuzzer searches start off a bit better.
2022-05-10 13:06:32 +02:00
Zbigniew Jędrzejewski-Szmek
b456b09b25
shared/calendarspec: make function static void
...
calendar_spec_from_string() already calls calendar_spec_normalize(), so
there is no point in calling it from the fuzzer. Once that's removed, there's
just one internal caller and it can be made static.
2022-05-10 13:06:32 +02:00
Zbigniew Jędrzejewski-Szmek
7e4be6a584
shared/json: fix memory leak on failed normalization
...
We need to increase the counter immediately after taking the ref,
otherwise we may not unref it properly if we fail before incrementing.
2022-05-10 12:58:49 +02:00
Zbigniew Jędrzejewski-Szmek
bac06497fe
shared/json: wrap long comments
2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek
a2c5735dd8
fuzz-json: also do sorting and normalizing and other easy calls
2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek
a4669764f7
shared/json: reduce scope of variables
2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek
9ad955ce40
fuzz-json: optionally allow logging and output
...
Similarly to other fuzzers… this makes development easier.
2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek
9674b089cf
json: align table
2022-05-10 12:58:48 +02:00
Kazuo Moriwaka
6f310287db
add missing cleanup-age to quickref
2022-05-10 17:41:21 +09:00
Yu Watanabe
16f74783d8
resolve: reallocate DNS scope when DNSSEC and/or DNS-over-TLS settings are changed
...
Fixes #23227 .
2022-05-10 09:44:45 +02:00
Yu Watanabe
81391854ec
Merge pull request #23300 from DaanDeMeyer/device-debug
...
core/device: Add more logging
2022-05-10 14:29:35 +09:00
Frantisek Sumsal
624f685fe8
core: annotate Reexecute() as NoReply
...
So we're able to tell from the introspection data that the method
doesn't reply.
2022-05-10 14:16:11 +09:00
Yutsuten
ffa3da1dc2
Add HUION Inspiroy H420X to hwdb
2022-05-10 14:14:17 +09:00
Mario Limonciello
f32049eda3
Set autosuspend delay for Fibocom LG850-GL
...
It has been shown that the autosuspend delay for this device enacted
by modem manager will race with suspend and cause system suspend
failures.
This occurred in ChromiumOS on a chromebook, but there is no reason
it won't happen in regular notebooks with the same WWAN. To avoid
the failure delay autosuspend to a frequency longer than the polling
rate used by modem manager.
Link: https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/3635003
Link: 43e76bf1bb/src/mm-iface-modem.c (L1633)
2022-05-09 21:14:12 -05:00
Mario Limonciello
fa9a43a690
Add support to set autosuspend delay via hwdb
2022-05-09 21:14:12 -05:00
Yu Watanabe
31090c17f4
Merge pull request #23321 from poettering/sockaddr-no-cast
...
tests: avoid sockaddr casts
2022-05-09 23:44:01 +09:00
Yu Watanabe
d171e72e7a
core/slice: make slice_freezer_action() return 0 if freezing state is unchanged
...
Fixes #23278 .
2022-05-09 23:43:32 +09:00
Luca Boccassi
37b7eef35d
mkosi: add shadow package to SUSE Tumbleweed
...
[1958/1958] Generating export-dbus-interfaces with a custom command
/root/mkosi.build: line 70: groupadd: command not found
2022-05-09 14:58:06 +01:00
Lennart Poettering
f9a1fd2a3b
test: JSON_BUILD_REAL nowadays expects 'double', not 'long double'
...
Follow-up for 337712e777
, aka "the great
un-long-double-ification of 2021".
2022-05-09 14:32:31 +02:00
Lennart Poettering
3bf175f076
tests: avoid (struct sockaddr*) casts
...
We prefer using using union sockaddr_union instead of casting sockaddr
to the correct types.
Coding style, nothing else.
Follow-up for 0dd5ec58fa
.
2022-05-09 13:56:39 +02:00
Lennart Poettering
b501e42e71
socket-util: don't reference field by macro parameter name
...
Let's avoid ambigituies here. (Interesting that the current users
compiled at all, in fact)
2022-05-09 13:55:28 +02:00
Lennart Poettering
3a466defd4
update TODO
2022-05-09 12:17:08 +02:00
Yu Watanabe
a6b084234c
network: set/unset enumerating flag before/after loop
2022-05-09 18:59:24 +09:00
Daan De Meyer
2aaf6d407e
shared: Fix memory leak in bus_append_execute_property()
...
Fixes #23317
2022-05-09 18:58:55 +09:00
Yu Watanabe
df423851fc
Merge pull request #23310 from keszybz/suppress-fuzzer-timeouts-and-errors
...
Suppress fuzzer timeouts and errors
2022-05-09 15:50:29 +09:00
Yu Watanabe
b5be9dbebf
Merge pull request #23311 from keszybz/bootspec-fuzzer
...
Fuzzer for bootspec.c and associated fixes
2022-05-09 15:46:49 +09:00
Zbigniew Jędrzejewski-Szmek
3947432eb0
shared/calendarspec: reduce scope of variables
2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek
68ac5118e7
shared/dissect-image: apply standard indentation
2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek
a9d178d28b
basic/virt: use STRV_FOREACH instead of iteration with ELEMENTSOF
...
I think it's a bit simpler, we don't have two indexes.
2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek
c9c3b81f12
libsystemd-network: constify casts
...
It is better to not drop the const-ness from the argument.
2022-05-08 22:47:50 +02:00