Lennart Poettering
6e9efa5920
man: document "machinectl export-tar" and "export-raw"
2015-03-10 15:48:14 +01:00
Shawn Landden
3b1c524154
add REMOTE_ADDR and REMOTE_PORT for Accept=yes
2015-03-10 09:00:27 -04:00
Didier Roche
54bcf1557c
fsckd: clean up log messages
...
Avoid double logs printing. Not that we don't return
manager_update_global_progress() to the handler callback as if the console or
plymouth isn't available momentarily, we still desire to handle future
fd progress events if those are available again (like cancellation, reports…)
2015-03-10 11:45:54 +01:00
Didier Roche
867ce6a516
fsckd: Reduce the SAK window when writing to console
...
We don't want to keep /dev/console open all the time, but only open it when
needed, to avoid interfering with SAK.
2015-03-10 11:43:09 +01:00
Thomas Hindoe Paaboel Andersen
0c900704e7
Add type specifier for int
2015-03-10 05:37:01 +01:00
Thomas Hindoe Paaboel Andersen
6c767d1e1a
logs-show: fix check of loop_read_exact
...
just a typo fix
2015-03-10 05:37:01 +01:00
Zbigniew Jędrzejewski-Szmek
a6dcc7e592
Introduce loop_read_exact helper
...
Usually when using loop_read(), we want to read the full buffer.
Add a helper that mirrors loop_write(), and returns 0 when full buffer
was read, and an error otherwise.
Use -ENODATA for the short read, to distinguish it from a read error.
2015-03-09 22:10:54 -04:00
Zbigniew Jędrzejewski-Szmek
ad7bcf526d
efivars: itialize variable
...
Introduced a few commits ago.
2015-03-09 22:10:54 -04:00
Zbigniew Jędrzejewski-Szmek
d92f98b4f6
bootchart: use _cleanup_
2015-03-09 22:10:54 -04:00
Zbigniew Jędrzejewski-Szmek
6410074b4f
Add missing includes
...
audit.h uses uint32_t and bool.
log.h uses abs.
2015-03-09 22:10:54 -04:00
Zbigniew Jędrzejewski-Szmek
faf9da01ad
journalctl: unlink without checking with access first
...
It is more elegant to do this in one step.
Coverity complains about the TOCTOU difference, but it is not an
actual problem (CID #1237777 ).
2015-03-09 22:06:46 -04:00
Zbigniew Jędrzejewski-Szmek
977eaa1eae
journal: fix return code
...
Introduced in fa6ac76083b8ff.
Might be related to CID #1261724 , but I don't know if coverity can
recurse this deep.
2015-03-09 22:02:25 -04:00
Zbigniew Jędrzejewski-Szmek
d587eca510
journal-file: update format string to remove cast
2015-03-09 22:02:25 -04:00
Zbigniew Jędrzejewski-Szmek
288359dba1
journal: align comments to make them more legible
2015-03-09 22:02:25 -04:00
Tom Gundersen
b94da8cf72
libudev: add missing hunks
...
This should have been committed with
udev_device_add_property - implicitly mark properties for saving to db
2015-03-09 23:36:27 +01:00
Tom Gundersen
570b83cc62
libudev: udev_device_read_db - drop unused argument
2015-03-09 23:27:12 +01:00
Tom Gundersen
df546eb56a
libudev: udev_device_add_property - implicitly mark properties for saving to db
...
Properties should only be saved to the db when added to the udev_device by udevd, and only if
the property does not start with a '.'. Make this implicit rather than expose the marking of
properties.
2015-03-09 22:50:44 +01:00
Tom Gundersen
3738cc858d
udev/libudev: event - move {OLD_,}INTERFACE handling from udevd to libudev
...
This should be internal to the library as it is only about reflecting the sysfs state in the udev_device.
2015-03-09 22:50:44 +01:00
Tom Gundersen
bd57b6de74
libudev: private - make property_from_string_parse* static
2015-03-09 22:50:44 +01:00
Lennart Poettering
af40e5d3ac
man: document machinectl import-tar and import-raw
2015-03-09 22:46:26 +01:00
Lennart Poettering
124f2f9b6f
update TODO
2015-03-09 22:46:26 +01:00
Tom Gundersen
dfc4b6acf0
udev: simplify event_queue_update() and add debug logging
...
This essentially replaces
open("/run/udev/queue", O_WRONLY|O_CREAT|O_CLOEXEC|O_TRUNC|O_NOFOLLOW, 0444)
with
open("/run/udev/queue", O_WRONLY|O_CREAT|O_CLOEXEC|O_NOCTTY, 0644),
which is ok for our purposes.
2015-03-09 22:38:51 +01:00
Zbigniew Jędrzejewski-Szmek
7432b24b83
efivars: use greedy_realloc
2015-03-09 16:45:28 -04:00
Zbigniew Jędrzejewski-Szmek
0797f2329c
efivars: use more _cleanup_
...
Also rename r to buf, since r is customarily reserved for the return value.
2015-03-09 16:45:27 -04:00
Zbigniew Jędrzejewski-Szmek
0aa3b7830f
efivars: do binary and before converting to bool
...
I'm pretty sure that this is what was meant here.
2015-03-09 16:45:27 -04:00
Zbigniew Jędrzejewski-Szmek
a8436474fa
efivars: rename last remaining err to r
2015-03-09 16:45:27 -04:00
Zbigniew Jędrzejewski-Szmek
b7749eb517
efivars: modernization
...
Fix return value if unlink fails.
2015-03-09 16:45:27 -04:00
Zbigniew Jędrzejewski-Szmek
56c70b32af
boot/efi: do not assign variable twice
...
If the highlighted line did not move outside of the visible
region, it should not be necessary to update idx_last.
CID #1287137 , #1287138 .
2015-03-09 16:45:27 -04:00
Thomas Hindoe Paaboel Andersen
061a237dd2
machinectl: remove unused variables
2015-03-09 21:09:18 +01:00
Lennart Poettering
566690fdb0
fsck: modernize error handling
2015-03-09 19:57:39 +01:00
Lennart Poettering
1952708abb
fsck: use _cleanup_close_pair_ where appropriate
2015-03-09 19:50:37 +01:00
Lennart Poettering
57b394b505
fsckd: make sure we free the connection event source before we close the connection fd
2015-03-09 19:41:01 +01:00
Lennart Poettering
e78e0674f3
fsckd: don't allow unbounded numbers of clients
2015-03-09 19:38:23 +01:00
Lennart Poettering
35682f425f
fsckd: make sure unprivileged clients cannot play games with fsckd
2015-03-09 19:38:23 +01:00
Lennart Poettering
d42688ef21
fsckd: free client event source before we close its fd
2015-03-09 19:38:23 +01:00
Sylvain Plantefève
f699ebe130
po: update French translation
...
Add strings for importd, following 587fec427c80b6c34dcf1d7570f891fcb652a7c5
2015-03-09 19:27:35 +01:00
Lennart Poettering
88b28381ef
fsck: rename functions to reflect some object orientation
...
Let's clean up the function naming scheme and put the object they
operate on first in the name, the way OO programming usually does it.
Also, let's make sure can properly destroy half-initialized Manager
objects.
2015-03-09 19:23:36 +01:00
Lennart Poettering
df4573e851
fsck: don't read invalid data
2015-03-09 18:58:05 +01:00
Lennart Poettering
0b02c7c36d
fsckd: internaly check if a client already was cancelled
2015-03-09 18:57:58 +01:00
Lennart Poettering
f8824a5129
fsck: simplify client destruction logic
2015-03-09 18:57:11 +01:00
Lennart Poettering
7046313698
fsckd: rework plymouth connection management
...
- the even source should not be freed before the fd for it is closed
- read() returns an ssize_t and we need to handle it as such
- properly handle errors from read()
- reuse on_plymouth_disconnect() whenever we disconnect from plymouth,
and rename it plymouth_disconnect hence()
2015-03-09 18:45:50 +01:00
Lennart Poettering
e9d2527ff4
fscd: fix error handling
2015-03-09 18:30:37 +01:00
Lennart Poettering
3963cea3b0
fsck: no need for a temporary variable
2015-03-09 18:30:18 +01:00
Lennart Poettering
d2268a20a0
fsckd: fix error handling when sending cancel request to fsck client
2015-03-09 18:29:08 +01:00
Lennart Poettering
705778ad6a
fsck: unify exit path for connect_plymouth()
2015-03-09 18:21:34 +01:00
Lennart Poettering
a922c18bce
fsck: use only a single exit code ternary operator
2015-03-09 18:19:56 +01:00
Lennart Poettering
76bb3afd81
fsck: simplification
2015-03-09 18:19:23 +01:00
Lennart Poettering
adfe5671ef
fsckd: the error code is actually returned in 'fd'
...
Also, we don't use {} for single-line if-blocks.
2015-03-09 18:16:56 +01:00
Lennart Poettering
2de68ed95d
fsckd: simplify code a bit
2015-03-09 18:16:36 +01:00
Lennart Poettering
c011cc2669
fsckd: make use of safe_close()'s return value
2015-03-09 18:16:20 +01:00