Yu Watanabe
97f9df9e30
network: rename Protocol= in [RoutingPolicyRule] to IPProtocol=
2018-12-02 06:13:47 +01:00
Yu Watanabe
dca2309108
test: add tests for ip_protocol_{from,to}_name()
2018-12-02 06:13:47 +01:00
Yu Watanabe
0667a0c497
util: introduce parse_ip_protocol()
...
Not only protocol name in lower case, but it optionally accepts
IP protocol name in upper case and IP protocol number.
2018-12-02 06:13:41 +01:00
Yu Watanabe
cedfe0b02b
util: cast smaller type to large type
2018-12-02 05:58:18 +01:00
Yu Watanabe
da96ad5ae2
util: rename socket_protocol_{from,to}_name() to ip_protocol_{from,to}_name()
2018-12-02 05:48:27 +01:00
Lennart Poettering
5dd9527883
tree-wide: remove various unused functions
...
All found with "cppcheck --enable=unusedFunction".
2018-12-02 13:35:34 +09:00
Evgeny Vereshchagin
c26ae3013d
Merge pull request #11013 from evverx/travis-clang
...
travis: also build systemd with clang
2018-12-02 03:54:21 +03:00
Susant Sahani
58a02e4c97
ip rule: fix clang warning.
...
```
[2/1209] Compiling C object 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o'.
FAILED: src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o
clang -Isrc/network/src@network@@networkd-core@sta -Isrc/network -I../src/network -Isrc/basic -I../src/basic -Isrc/shared -I../src/shared -Isrc/systemd -I../src/systemd -Isrc/journal -I../src/journal -Isrc/journal-remote -I../src/journal-remote -Isrc/nspawn -I../src/nspawn -Isrc/resolve -I../src/resolve -Isrc/timesync -I../src/timesync -I../src/time-wait-sync -Isrc/login -I../src/login -Isrc/udev -I../src/udev -Isrc/libudev -I../src/libudev -Isrc/core -I../src/core -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -Isrc/libsystemd-network -I../src/libsystemd-network -I. -I../ -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -g -Wextra -Werror=undef -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wfloat-equal -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=missing-declarations -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wmissing-noreturn -Wshadow -Wendif-labels -Wstrict-aliasing=2 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Wdate-time -Wnested-externs -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Wno-error=nonnull -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -fPIE -Wno-typedef-redefinition -Wno-gnu-variable-sized-type-not-at-end -Werror=shadow -include config.h -fPIC -MD -MQ 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o' -MF 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o.d' -o 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o' -c ../src/network/networkd-routing-policy-rule.c
../src/network/networkd-routing-policy-rule.c:1071:33: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->sport.start, rule->sport.end);
^~~~~~~~~~~~~~~~~
../src/network/networkd-routing-policy-rule.c:1071:52: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->sport.start, rule->sport.end);
^~~~~~~~~~~~~~~
../src/network/networkd-routing-policy-rule.c:1078:33: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->dport.start, rule->dport.end);
^~~~~~~~~~~~~~~~~
../src/network/networkd-routing-policy-rule.c:1078:52: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->dport.start, rule->dport.end);
^~~~~~~~~~~~~~~
4 errors generated.
```
2018-12-01 15:45:12 +01:00
Aleksei Timofeyev
09e5c07fbd
resolved: add missed io-util.h header to resolved-dnstls-openssl.c
...
Regression after commit 5cfa2c3dc09ffed1
2018-12-01 12:49:01 +01:00
Evgeny Vereshchagin
37cbcd4642
travis: also build systemd with clang
2018-12-01 04:53:11 +01:00
Evgeny Vereshchagin
f5e75e08b0
travis: use latest instead of rawhide
2018-12-01 06:45:45 +03:00
Lennart Poettering
2c8f15aeca
Merge pull request #11006 from poettering/conf-file-fix
...
minor fixes for conf-files.c
2018-12-01 00:47:22 +01:00
Lennart Poettering
ac20048fc0
Merge pull request #11002 from keszybz/path_join-merging
...
Path join merging
2018-12-01 00:44:58 +01:00
Lennart Poettering
f8ee4eaa48
Merge pull request #11004 from keszybz/remove-fixme-comment
...
socket-util: drop obsolete FIXME comment and add test
2018-12-01 00:01:11 +01:00
Zbigniew Jędrzejewski-Szmek
652ef29887
path-util: allow NULLs in arguments to path_join()
...
This removes the need to remember to put strempty() in places, thus reducing
the likelihood of a stupid mistake.
2018-11-30 22:21:17 +01:00
Lennart Poettering
59ea6e57a5
networkd: refuse IPv6 RADV prefixes that lack Prefix= setting
...
Fixes : #9589
2018-11-30 22:19:28 +01:00
Zbigniew Jędrzejewski-Szmek
15dca3711d
basic/socket-util: use c-escaping to print unprintable socket paths
...
We are pretty careful to reject abstract sockets that are too long to fit in
the address structure as a NUL-terminated string. And since we parse sockets as
strings, it is not possible to embed a NUL in the the address either. But we
might receive an external socket (abstract or not), and we want to be able to
print its address in all cases. We would call socket_address_verify() and
refuse to print various sockets that the kernel considers legit.
Let's do the strict verification only in case of socket addresses we parse and
open ourselves, and do less strict verification when printing addresses of
existing sockets, and use c-escaping to print embedded NULs and such.
More tests are added.
This should make LGTM happier because on FIXME comment is removed.
2018-11-30 21:58:47 +01:00
Zbigniew Jędrzejewski-Szmek
3a48499153
shared/socket-util: do not print empty CID
...
That's just ugly.
2018-11-30 21:40:04 +01:00
Zbigniew Jędrzejewski-Szmek
39e73acb9b
test-socket-util: add test for socket_address_print
2018-11-30 21:40:02 +01:00
Zbigniew Jędrzejewski-Szmek
041103a688
test-socket-util: the usual modernization
2018-11-30 21:37:44 +01:00
Lennart Poettering
b806f0b0aa
Merge pull request #10701 from poettering/analyze-security
...
systemd-analyze: add a new "security" verb for analyzing unit sandboxing options
2018-11-30 19:41:59 +01:00
Lennart Poettering
380b82d678
conf-files: remove unused function
2018-11-30 16:56:35 +01:00
Lennart Poettering
a7181c671a
conf-files: remove misplaced log_oom()
...
The caller should log in this case (and all callers in fact already do),
hence let's remove the duplicate logging here.
2018-11-30 16:55:57 +01:00
Lennart Poettering
243dd6ae1d
conf-files: improve algorithm O(n²) → O(n)
2018-11-30 16:55:33 +01:00
Lennart Poettering
d96c081aa5
update TODO
2018-11-30 16:48:09 +01:00
Lennart Poettering
ee93c1e664
man: document systemd-analyze security
2018-11-30 16:48:09 +01:00
Lennart Poettering
ec16f3b6dd
analyze: add new security verb
2018-11-30 16:48:09 +01:00
Lennart Poettering
88db94fa57
format-table: make sure we never call memcmp() with NULL parameters
2018-11-30 16:46:10 +01:00
Lennart Poettering
62d99b3970
format-table: add calls to query the data in a specific cell
2018-11-30 16:46:10 +01:00
Lennart Poettering
30d98de00c
format-table: always underline header line
2018-11-30 16:46:10 +01:00
Lennart Poettering
9314ead785
format-table: add an API for getting the cell at a specific row/column
2018-11-30 16:46:10 +01:00
Lennart Poettering
27e730e6d0
format-table: add table_update() to update existing entries
2018-11-30 16:46:10 +01:00
Lennart Poettering
a2c73e2d38
format-table: optionally allow reversing the sort order for a column
2018-11-30 16:46:10 +01:00
Lennart Poettering
a4661181fa
format-table: add option to store/format percent and uint64_t values in cells
2018-11-30 16:46:10 +01:00
Lennart Poettering
a22318e554
format-table: before outputting a color, check if colors are available
...
This is in many cases redundant, as a similar check is done by various
callers already, but in other cases (where we read the color from a
static table for example), it's nice to let the color check be done by
the table code itself, and since it doesn't hurt in the other cases just
do it again.
2018-11-30 16:46:10 +01:00
Lennart Poettering
165ca5663e
format-table: optionally make specific cells clickable links
2018-11-30 16:46:10 +01:00
Lennart Poettering
13b0d4d7bd
format-table: when duplicating a cell, also copy the color
2018-11-30 16:46:10 +01:00
Lennart Poettering
62d6a1cc9f
terminal-util: split out file:// generation from terminal_urlify_path()
...
This way we can use it at other places, for example when preparing URLs
for format_table_set_url()
2018-11-30 16:46:10 +01:00
Lennart Poettering
8a453c9dfc
macro: update DIV_ROUND_UP() so that it can be called nested
2018-11-30 16:46:10 +01:00
Lennart Poettering
b06f0cc625
parse-util: allow parse_boolean() to take a NULL argument
...
It's pretty useful to allow parse_boolean() to take a NULL argument and
return an error in that case, rather than abort. i.e. making this a
runtime rather than programming error allows us to shorten code
elsewhere.
2018-11-30 16:46:09 +01:00
Lennart Poettering
2987225ce6
analyze: use strv_skip() where appropriate
2018-11-30 16:46:09 +01:00
Lennart Poettering
0ed3da7c8c
analyze: remove unnecessary negation of bus_error_message() error number parameter
2018-11-30 16:46:09 +01:00
Lennart Poettering
90bea7448d
analyze: fix include order
2018-11-30 16:46:09 +01:00
Lennart Poettering
ad5ffe3716
seccomp-util: drop process_vm_readv from @debug group
...
it's already part of @ipc, no need to have it in both. Given that @ipc
is much more popular (as it is part of @system-service for example),
let's not define it a second time.
2018-11-30 16:46:09 +01:00
Lennart Poettering
5f1b0cc6d0
locale-util: add logic to output smiley emojis at various happiness levels
2018-11-30 16:19:29 +01:00
Zbigniew Jędrzejewski-Szmek
62a85ee0a9
tree-wide: rename path_join_many() to path_join()
...
$ git grep -e path_join_many -l|xargs sed -r -i 's/path_join_many/path_join/g'
The two test functions are merged into one.
2018-11-30 10:59:47 +01:00
Zbigniew Jędrzejewski-Szmek
30016f21b3
tree-wide: replace path_join with path_join_many
2018-11-30 10:40:38 +01:00
Zbigniew Jędrzejewski-Szmek
b2ac2b01c8
Merge pull request #10996 from poettering/oci-prep
...
Preparation for the nspawn-OCI work
2018-11-30 10:09:00 +01:00
Filipe Brandenburger
00195abcbe
docs: turn LGTM URL into a markdown link
2018-11-30 12:02:13 +03:00
Claudius Ellsel
d03a00e2de
hwdb: Put Lenovo mouse under the correct category in 70-mouse.hwdb ( #10995 )
...
[zj: the entry for a Thinkpad mouse is moved to the end of Lenovo section, and a
Lenovo mouse is moved from Logitech section to Lenovo section.]
2018-11-30 09:14:30 +01:00