1
1
mirror of https://github.com/systemd/systemd-stable.git synced 2025-03-08 20:58:20 +03:00

58066 Commits

Author SHA1 Message Date
Luca Boccassi
a27b694453 integritysetup: do not use crypt_init_data_device after crypt_init
crypt_init_data_device() replaces the crypt_device struct with a
new allocation, losing the old one, which we get from crypt_init().
Use crypt_set_data_device() instead.

Enhance the test to cover this option too.

(cherry picked from commit 872f9da4d8b67b012f1b1b227416d0c99bcdf43c)
2022-08-08 10:59:36 +02:00
Daan De Meyer
3814bd0e71 man: Clarify that tools should prefer mount units over editing fstab
(cherry picked from commit 29e804dffd52496aaad2d0fc6a50d18a9940010d)
2022-08-08 10:59:25 +02:00
Lennart Poettering
6b58b06c7d man: fix docbook
(cherry picked from commit 1374f5a03aec469ad2f0ce56650f26da285d8660)
2022-08-08 10:59:24 +02:00
James Hilliard
cdd3f180b0 bpf: fix is_allow_list section
The llvm bpf compiler appears to place const volatile variables in
a non-standard section which creates an incompatibility with the gcc
bpf compiler.

To fix this force GCC to also use the rodata section.

Note this does emit an assembler warning:
Generating src/core/bpf/restrict_ifaces/restrict-ifaces.bpf.unstripped.o with a custom command
/tmp/ccM2b7jP.s: Assembler messages:
/tmp/ccM2b7jP.s:87: Warning: setting incorrect section attributes for .rodata

See:
https://github.com/llvm/llvm-project/issues/56468

Fixes:
../src/core/restrict-ifaces.c:45:14: error: ‘struct
restrict_ifaces_bpf’ has no member named ‘rodata’; did you mean
‘data’?
   45 |         obj->rodata->is_allow_list = is_allow_list;
      |              ^~~~~~
      |              data

(cherry picked from commit e8b1e9cf1095f9d6d0f1e2dce2503e25fec2e6c5)
2022-08-08 10:58:29 +02:00
Loïc Collignon
45faf77d4d Fix 24172: __STDC_VERSION__ may be defined in C++
According to the C++ ISO standard, a conformant compiler is allowed to
define this macro to any value for any reason as it is implementation
defined: https://timsong-cpp.github.io/cppwp/cpp.predefined#2.3

This mean that it cannot be assumed that it is not defined in a C++.
Change the condition to reflect that.

(cherry picked from commit 00852912edc69e652f4932fa536da60528f08ed3)
2022-08-08 10:58:18 +02:00
Lennart Poettering
0cfe2d7e88 systemctl: clarify that "status" is about the most recent invocation of a service
And point people to "journalctl --unit=" for information of prior runs.

Inspired by: #24159

(cherry picked from commit 157cb4337b83359267050bff43c1ad39b0303f10)
2022-08-08 10:56:45 +02:00
Lennart Poettering
d3e84e4703 repart: when keeping ref to backing inode/devnode, use fd_reopen() rathern than F_DUPFD
Via the "backing_fd" variable we intend to pin the backing inode through
our entire code. So far we typically created the fd via F_DUPFD_CLOEXEC,
and thus any BSD lock taken one the original fd is shared with our
backing_fd reference. And if the origina fd is closed but our backing_fd
is not, we'll keep the BSD lock open, even if we then reopen the block
device through the backing_fd. If hit, this results in a deadlock.

Let's fix that by creating the backing_fd via fd_reopen(), so that the
locks are no longer shared, and if the original fd is closed all BSD
locks on it that are in effect are auto-released.

(Note the deadlock is only triggered if multiple operations on the same
backing inode are executed, i.e. factory reset, resize and applying of
partitions.)

Replaces: #24181
(cherry picked from commit 38f81e937426993cfc899aa09298f69f00935852)
2022-08-08 10:56:33 +02:00
Jacek Migacz
7384d152c8 resolved: fix single-label resolution over DNS
Fixes: #23494 (when ResolveUnicastSingleLabel=yes)
(cherry picked from commit ff0a5070d45f20df7744b1090892be797bf18365)
2022-08-08 10:55:56 +02:00
Cristian Rodríguez
695eb67322 gcrypt: switch to system rng before gcry_check_version (#24162)
Current docs claim this must be done before gcry_check_version.

(cherry picked from commit 91375fb9cf38aca397a6d50e3f22dfb7a4aa1b98)
2022-08-08 10:53:20 +02:00
Max Gautier
79de67e2df docs: Correct StandartOutput documentation
fix #2114

(cherry picked from commit e0a12b96344b1d7ee499df1d0447b14ced62c1b4)
2022-08-08 10:53:02 +02:00
Eli Schwartz
3a382bf86b meson: fix broken boolean kwarg
Everywhere else that `conf.get('ENABLE_*')` is used as a boolean key for
something (for example in if statements) it always checks if == 1, but
in this one case it neglects to do so. This is important because
conf.get yields the same int that was stored, but if statements require
booleans.

So does executable's "install" kwarg, at least according to the
documentation. In actuality, it accepts all types without sanity
checking, then uses python "if bool(var)", so you can actually do
`install: 'do not'` and that's treated identical to `true`. This is a
type-checking bug which Meson will eventually fix.

muon fails on the same code, today.

(cherry picked from commit 9e4a50bcdf7a275766e4f5c7af012c32bc22128d)
2022-08-08 10:52:49 +02:00
Cristian Rodríguez
ca0ed3a78c gcrypt: prefer the OS RNG
by default, gcrypt defaults to an userspace RNG, this is
the wrong thing (tm) to do on linux.

Switch to the SYSTEM rng instead.

(cherry picked from commit 80f967311ac53ae43b5a26332f32cc6665661338)
2022-08-08 10:49:52 +02:00
Fei Li
e7d635f0b9 virt: detect KubeVirt instance
Kubevirt is currently technically based on KVM (but not xen yet[1]).
The systemd-detect-virt command, used to differentiate the current
virtualization environment, works fine on x86 relying on CPUID, while
fails to get the correct value (none instead of kvm) on aarch64.

Let's fix this by adding a new 'vendor[KubeVirt] = kvm' classification
considering the sys_vendor is always KubeVirt.

[1] https://groups.google.com/g/kubevirt-dev/c/C6cUgzTOsVg

Signed-off-by: Fei Li <lifei.shirley@bytedance.com>
(cherry picked from commit c15d1ac2c4e8ce46c6d07621f7d5531cbc2160a8)
2022-08-08 10:49:39 +02:00
Yu Watanabe
2391c031a6 resolve: mdns: calculate required packet size to store questions and authorities
Otherwise, if we have many cached entries or pending transactions with
TYPE_ANY, then dns_transaction_make_packet_mdns() fails with -EMSGSIZE.

This also fixes use-after-free.

Fixes #23894.

(cherry picked from commit 325513bc776c739a814996cc5c483235ca92be86)
2022-08-08 10:44:15 +02:00
Vishal Chillara Srinivas
ef6c379089 RFC 6762 section 7.1: a Multicast DNS querier SHOULD NOT include records in the
Known-Answer list whose remaining TTL is less than half of their original TTL

(cherry picked from commit f941c124273ac1b3bce0029f69f9664ba6f01f7f)
2022-08-08 10:44:09 +02:00
Yu Watanabe
b61a61ec53 resolve: do not trigger assertions on invalid query
(cherry picked from commit 055acd4d8b385fd9ff29e49e0c46856a9e705433)
2022-08-08 10:43:05 +02:00
Yu Watanabe
0070302b3c resolve: mdns_packet_extract_matching_rrs() may return 0
Fixes the following assertion:
---
Assertion 'r > 0' failed at src/resolve/resolved-mdns.c:180, function mdns_do_tiebreak(). Aborting.
---

(cherry picked from commit f2605af1f2e770818bbc6bad2561acdbd25a38ad)
2022-08-08 10:43:00 +02:00
Yu Watanabe
d6a637fbe6 resolve: shorten code a bit
(cherry picked from commit d3887b2b484004f6d5b393f57b01fe2eb917981f)
2022-08-08 10:42:53 +02:00
Yu Watanabe
45c5fec1c0 resolve: introduce dns_transaction_setup_timeout()
This also fixes timeout in dns_transaction_make_packet_mdns(), which was
incremented multiple times.

(cherry picked from commit 87b91644dbc14d9cdf4c614a3ac2dd8c15733cf6)
2022-08-08 10:42:50 +02:00
Yu Watanabe
41810cb166 resolve: fix misuse of accuracy parameter in sd_event_add_time()
Also, this makes mDNS regular queries sent without delay (except for
one caused by the default accuracy of sd-event).

Note, RFC 6762 Section 5.2 is about continuous mDNS query, which is not
implemented yet.

(cherry picked from commit 765647ba805727e93ac8607e38c7b60da2aab2dd)
2022-08-08 10:42:41 +02:00
Yu Watanabe
a1edebfde0 resolve: drop unnecessary else, and add short comment
(cherry picked from commit 4b2ceb8a48c3aeef4147e335b5f31bc2ed4aa6fb)
2022-08-08 10:42:29 +02:00
Yu Watanabe
e832a277ea resolve: mdns: fix use-after-free
Fixes #23843 and #23873.

(cherry picked from commit d50a58e7252b763043485aa79a61094bfae9d7ff)
2022-08-08 10:42:07 +02:00
Luca Boccassi
6e111d2811 portable: set PrivateTmp=yes in trusted profile too
When running on images you don't want to modify the /tmp
directory even if it's writable, and often it will just
be read-only. Set PrivateTmp=yes.

Fixes https://github.com/systemd/systemd/issues/23592

(cherry picked from commit f2d26cd89b195e53f184387f1a5b97a98512c82a)
2022-08-08 10:41:31 +02:00
Yu Watanabe
9f8b7ee55a core/mount: downgrade log level about several mkdir failures
(cherry picked from commit 574febda6b0e00aae164b18b70aa80744d950500)
2022-08-08 10:38:02 +02:00
Yu Watanabe
b1e494d64d Revert "core/mount: fail early if directory cannot be created"
This reverts commit e4de58c8231e47509ffeb3aa47620ca42f22d7f6.

If mkdir() fails and the path does exist, then the later mount
command fails anyway. Hence, it is not necessary to fail here.

Fixes #24120.

(cherry picked from commit e5e6b7c225987551ebda14d2d7feadb66a64fb3c)
2022-08-08 10:37:55 +02:00
Yu Watanabe
739d7130cb home: drop conflicted headers
Fixes #24117.

(cherry picked from commit 0a58cd00454cc7b57b04f3a4a334584d743d7f7a)
2022-08-08 10:32:20 +02:00
Yu Watanabe
834632a477 homed: fix dbus node enumerator
Fixes #24114.

(cherry picked from commit 52023622d2f8312887fcf72ca29bab4ad42c8eb7)
2022-08-08 10:32:08 +02:00
Lennart Poettering
200cbc299b localed: don't fail if we cannot copy an xattr
We ignore xattr copy failures on all other cases, and we should do so
here too.

Fixes: #24106
(cherry picked from commit d3efe29452aeddc395865469b776fe7a1eb45eae)
2022-08-08 10:27:45 +02:00
Yu Watanabe
a9dd0f6fc9 udev: downgrade error level and mention that the error is ignored
(cherry picked from commit 6e40ed53257604f81b14ddefadf5a782dc8ad279)
2022-08-08 10:27:45 +02:00
Rudi Heitbaum
8fe0c12178 glibc: Remove #include <linux/fs.h> to resolve fsconfig_command/mount_attr conflict with glibc 2.36
(cherry picked from commit 3657d3a01c7e25ff86d7a4642065b367c4ff7484)
2022-08-08 10:27:45 +02:00
Yu Watanabe
9ac0ad80fe unit-file: avoid (null) in debugging logs
The variable `inst` was set to NULL by TAKE_PTR().

This fixes the following log message:
```
systemd[1]: Unit getty@tty2.service has alias (null).
```

(cherry picked from commit 7c35b78a0b96085e3d634542212c5521bc2a2f21)
2022-08-08 10:27:45 +02:00
Zbigniew Jędrzejewski-Szmek
dc3333bcc9 manager: limit access to private dbus socket
For the system manager, /run/systemd/private is publicly accessible, because
/run/systemd is 0755, and /run/systemd/private is 0777. For the user manager,
/run/user/<uid> is 0700, and /run/user/<uid>/systemd/private is 0777. This
does not directly cause any security issue because we check the sender in
bus_check_peercred (ucred.uid != 0 && ucred.uid != geteuid()).

But it makes sense to limit access to the socket to avoid wasting time in PID1.
Somebody could send messages there that'd we'd reject anyway. It also makes
things more explicit.

(cherry picked from commit df1cbd1adf26071aab41d96e054452a3d66103a4)
2022-08-08 10:27:45 +02:00
Kai Lueke
fbf4050e2c man: Use correct target type for sysupdate entry
While Type=file works because it seems to be the default, the line gets
ignored as printed on the stderr output.
Use the correct value "regular-file" for the target type.

(cherry picked from commit 0ad7b7b8092e85f85be155dc3264b9f7607e9d24)
2022-08-08 10:27:45 +02:00
Ulrich Ölmann
a4a04055f8 man: document udevadm lock's exit code
(cherry picked from commit aa386add6772a41b3fcc2220d1c7f6d2d3b16c0a)
2022-08-08 10:27:45 +02:00
Jan Janssen
8d688da26d man: Miscellaneous fixes
Fixes: #24056
(cherry picked from commit 6a1d8f116161a1f439e7da50fdfb4706fdf3f146)
2022-08-08 10:27:45 +02:00
Ansgar Burchardt
bf9e8207df man/system-or-user-ns.xml: explicitly refer to PrivateUsers= option
It is not clear what "unprivileged user namespaces are available" means.
It could mean either that they are only usable, that is, enabled in the kernel,
or they have been enabled for the specific service. Referring to the
`PrivateUsers=` options makes it clear that the latter is meant.

(cherry picked from commit 34aee208b5d745fd6c90c09e3e6e91f2c2949514)
2022-08-08 10:27:45 +02:00
Richard Huang
9f3ed4f5cc Update sleep.conf HibernateDelaySec default to match implementation
(cherry picked from commit 5f2b4f9cb9555f3beb582e95624418a8277128e9)
2022-08-08 10:27:45 +02:00
David Tardon
8e466d902d systemctl: include upheld units in dependencies
Fixes: #22706
(cherry picked from commit cbc2593eeaf35a42881319d7fa50b12fc5584bf9)
2022-08-08 10:27:45 +02:00
Vito Caputo
110d49d151 man: fix grammatical error in --cursor-file description
Just a minor cleanup to fix unparseable wording

(cherry picked from commit 729d2df8065ac90ac606e1fff91dc2d588b2795d)
2022-08-08 10:27:45 +02:00
Frantisek Sumsal
5c822e33c9 core: drop a stray %m specifier from a warning message
since in this specific case (r == 0) `errno` is irrelevant and most likely
set to zero, leading up to a confusing message:

```
[  120.595085] H systemd[1]: session-5.scope: No PIDs left to attach to the scope's control group, refusing: Success
[  120.595144] H systemd[1]: session-5.scope: Failed with result 'resources'.
```

(cherry picked from commit e99b9285cb289115a64d775c768e6e831e39f12e)
2022-08-08 10:27:44 +02:00
Zbigniew Jędrzejewski-Szmek
b7c5530a1f man: fix formatting of "BARRIER=1"
Whitespace inside of the <varname> field was propagated to the displayed form,
causing strange indentation.

(cherry picked from commit 9cfc294fe0e2637d96f8e5c29143c10e2173daa3)
2022-08-08 10:27:44 +02:00
lastkrick
7632ff4ccc man: fix typo in systemd.network documentation in IPv6RoutePrefix section (#24030)
(cherry picked from commit 69a7d108327fa5d4b4e8e913441e924b2187cd78)
2022-08-08 10:27:44 +02:00
Łukasz Stelmach
c88309d5cd core: drop ambient capabilities in user manager
Ambient capabilities should not be passed implicitly to user
services. Dropping them does not affect the permitted and effective sets
which are important for the manager itself to operate.

(cherry picked from commit 963b6b906e5666876f5c90b47600b13ae94d5e4c)
2022-08-08 10:27:44 +02:00
Lennart Poettering
689487785f cgroups-agent: connect stdin/stdout/stderr to /dev/null
Inspired by https://github.com/systemd/systemd/pull/24024 this is
another user mode helper, where this might be an issue. hence let's
rather be safe than sorry, and also connect stdin/stdout/stderr
explicitly with /dev/null.

(cherry picked from commit 50492ce81589773df2d82b4fc8047778e86c6edf)
2022-08-08 10:27:44 +02:00
Daan De Meyer
fba50bc0fc coredump: Connect stdout/stderr to /dev/null before doing anything
When invoked as the coredump handler by the kernel, systemd-coredump's
stdout and stderr streams are closed. This is dangerous as this means
the fd's can get reallocated, leading to hard to debug errors such as
log messages ending up being appended to a compressed coredump file.

To avoid such issues in the future, let's bind stdout/stderr to
/dev/null so the file descriptors can't get used for anything else.

(cherry picked from commit 1f9d2a8199c261593aa6a11df9cce5d31e23c714)
2022-08-08 10:27:44 +02:00
Lennart Poettering
724d52146a man: explain why various resource limits don't make sense and should not be used.
(cherry picked from commit 8c8889577238749007c9bc129635af7c608723df)
2022-08-08 10:27:44 +02:00
Lennart Poettering
83203873ee man: drop misplaced ','
(cherry picked from commit 3840b147818882a0d8e3ad5427c464796bb713f5)
2022-08-08 10:27:44 +02:00
Andre Kalb
098d70f438 man/network: ServerAddress= drop "literal" from IP address ranges
(cherry picked from commit 1df6201882607666daec13d7f7c056e8366ef5aa)
2022-08-08 10:27:44 +02:00
Lennart Poettering
64be8d8a34 base-filesystem: pick more conservative access mode for /root/
Let's not allow anyone to look into /root/ if we create it via the
base-filesystem logic. i.e. change 0755 → 0750 as default access mode
for /root/, in case we create it if it happens to be missing.

(cherry picked from commit 93cbc9ca12043a13a2a80087a00012e009216f13)
2022-08-08 10:27:44 +02:00
Lennart Poettering
625472b219 tmpfiles: check the directory we were supposed to create, not its parent
This current code checks the wrong directory. This was broken in
4c39d899ff00e90b7290e4985696f321d7f2726f which converted the previous
code incorrectly.

(cherry picked from commit 92631578fff1568fa8e99f96de05baae5b258ffe)
2022-08-08 10:27:41 +02:00